January 2024 - Linux-stable-mirror

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 5.15.147 release. There are 59 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Mon, 15 Jan 2024 09:41:55 +0000. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.147-r… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 5.15.147-rc1 Justin Chen <justinpopo6(a)gmail.com> net: usb: ax88179_178a: move priv to driver_priv Justin Chen <justinpopo6(a)gmail.com> net: usb: ax88179_178a: remove redundant init code Andrii Nakryiko <andrii(a)kernel.org> tracing/kprobes: Fix symbol counting logic by looking at modules as well Jiri Olsa <jolsa(a)kernel.org> kallsyms: Make module_kallsyms_on_each_symbol generally available Phil Sutter <phil(a)nwl.cc> netfilter: nf_tables: Reject tables of unsupported family Adrian Hunter <adrian.hunter(a)intel.com> perf inject: Fix GEN_ELF_TEXT_OFFSET for jit Jon Maxwell <jmaxwell37(a)gmail.com> ipv6: remove max_size check inline with ipv4 John Fastabend <john.fastabend(a)gmail.com> net: tls, update curr on splice as well Wenchao Chen <wenchao.chen(a)unisoc.com> mmc: sdhci-sprd: Fix eMMC init failure after hw reset Geert Uytterhoeven <geert+renesas(a)glider.be> mmc: core: Cancel delayed work before releasing host Jorge Ramirez-Ortiz <jorge(a)foundries.io> mmc: rpmb: fixes pause retune on all RPMB partitions. Ziyang Huang <hzyitc(a)outlook.com> mmc: meson-mx-sdhc: Fix initialization frozen issue Jiajun Xie <jiajun.xie.sh(a)gmail.com> mm: fix unmap_mapping_range high bits shift bug Benjamin Bara <benjamin.bara(a)skidata.com> i2c: core: Fix atomic xfer check for non-preempt config Jinghao Jia <jinghao7(a)illinois.edu> x86/kprobes: fix incorrect return address calculation in kprobe_emulate_call_indirect Takashi Sakamoto <o-takashi(a)sakamocchi.jp> firewire: ohci: suppress unexpected system reboot in AMD Ryzen machines and ASM108x/VT630x PCIe cards Matthew Wilcox (Oracle) <willy(a)infradead.org> mm/memory-failure: check the mapcount of the precise page Muhammad Usama Anjum <usama.anjum(a)collabora.com> selftests: secretmem: floor the memory size to the multiple of page_size Thomas Lange <thomas(a)corelatus.se> net: Implement missing SO_TIMESTAMPING_NEW cmsg support Michael Chan <michael.chan(a)broadcom.com> bnxt_en: Remove mis-applied code from bnxt_cfg_ntp_filters() Chen Ni <nichen(a)iscas.ac.cn> asix: Add check for usbnet_get_endpoints Naveen Mamindlapalli <naveenm(a)marvell.com> octeontx2-af: Re-enable MAC TX in otx2_stop processing Naveen Mamindlapalli <naveenm(a)marvell.com> octeontx2-af: Always configure NIX TX link credits based on max frame size Sunil Goutham <sgoutham(a)marvell.com> octeontx2-af: Set NIX link credits based on max LMAC Hariprasad Kelam <hkelam(a)marvell.com> octeontx2-af: Don't enable Pause frames by default Dinghao Liu <dinghao.liu(a)zju.edu.cn> net/qla3xxx: fix potential memleak in ql_alloc_buffer_queues Rodrigo Cataldo <rodrigo.cadore(a)l-acoustics.com> igc: Fix hicredit calculation Andrii Staikov <andrii.staikov(a)intel.com> i40e: Restore VF MSI-X state during PCI reset Mark Brown <broonie(a)kernel.org> ASoC: meson: g12a-tohdmitx: Fix event generation for S/PDIF mux Mark Brown <broonie(a)kernel.org> ASoC: meson: g12a-toacodec: Fix event generation Mark Brown <broonie(a)kernel.org> ASoC: meson: g12a-tohdmitx: Validate written enum values Mark Brown <broonie(a)kernel.org> ASoC: meson: g12a-toacodec: Validate written enum values Ke Xiao <xiaoke(a)sangfor.com.cn> i40e: fix use-after-free in i40e_aqc_add_filters() Marc Dionne <marc.dionne(a)auristor.com> net: Save and restore msg_namelen in sock_sendmsg Pablo Neira Ayuso <pablo(a)netfilter.org> netfilter: nft_immediate: drop chain reference counter on error Adrian Cinal <adriancinal(a)gmail.com> net: bcmgenet: Fix FCS generation for fragmented skbuffs Zhipeng Lu <alexious(a)zju.edu.cn> sfc: fix a double-free bug in efx_probe_filters Stefan Wahren <wahrenst(a)gmx.net> ARM: sun9i: smp: Fix array-index-out-of-bounds read in sunxi_mc_smp_init Vadim Fedorenko <vadfed(a)meta.com> net-timestamp: extend SOF_TIMESTAMPING_OPT_ID to HW timestamps Marc Kleine-Budde <mkl(a)pengutronix.de> can: raw: add support for SO_MARK Marc Kleine-Budde <mkl(a)pengutronix.de> can: raw: add support for SO_TXTIME/SCM_TXTIME Jörn-Thorben Hinz <jthinz(a)mailbox.tu-berlin.de> net: Implement missing getsockopt(SO_TIMESTAMPING_NEW) Kai-Heng Feng <kai.heng.feng(a)canonical.com> r8169: Fix PCI error on system resume Hangyu Hua <hbh25y(a)gmail.com> net: sched: em_text: fix possible memory leak in em_text_destroy() David Thompson <davthompson(a)nvidia.com> mlxbf_gige: fix receive packet race condition Chancel Liu <chancel.liu(a)nxp.com> ASoC: fsl_rpmsg: Fix error handler with pm_runtime_enable Kurt Kanzenbach <kurt(a)linutronix.de> igc: Check VLAN EtherType mask Kurt Kanzenbach <kurt(a)linutronix.de> igc: Check VLAN TCI mask Kurt Kanzenbach <kurt(a)linutronix.de> igc: Report VLAN EtherType matching back to user Sudheer Mogilappagari <sudheer.mogilappagari(a)intel.com> i40e: Fix filter input checks to prevent config with invalid values Khaled Almahallawy <khaled.almahallawy(a)intel.com> drm/i915/dp: Fix passing the correct DPCD_REV for drm_dp_set_phy_test_pattern Suman Ghosh <sumang(a)marvell.com> octeontx2-af: Fix marking couple of structure as __packed Siddh Raman Pant <code(a)siddh.me> nfc: llcp_core: Hold a ref to llcp_local->dev when holding a ref to llcp_local Douglas Anderson <dianders(a)chromium.org> drm/bridge: ti-sn65dsi86: Never store more than msg->size bytes in AUX xfer Johannes Berg <johannes.berg(a)intel.com> wifi: iwlwifi: pcie: don't synchronize IRQs from IRQ Bjorn Helgaas <bhelgaas(a)google.com> Revert "PCI/ASPM: Remove pcie_aspm_pm_state_change()" Siddhesh Dharme <siddheshdharme18(a)gmail.com> ALSA: hda/realtek: Fix mute and mic-mute LEDs for HP ProBook 440 G6 Sarthak Kukreti <sarthakkukreti(a)chromium.org> block: Don't invalidate pagecache for invalid falloc modes Edward Adam Davis <eadavis(a)qq.com> keys, dns: Fix missing size check of V1 server-list header ------------- Diffstat: Makefile | 4 +- arch/arm/mach-sunxi/mc_smp.c | 4 +- arch/x86/kernel/kprobes/core.c | 3 +- block/fops.c | 21 ++- drivers/firewire/ohci.c | 51 +++++++ drivers/gpu/drm/bridge/ti-sn65dsi86.c | 4 +- drivers/gpu/drm/i915/display/intel_dp.c | 2 +- drivers/i2c/i2c-core.h | 4 +- drivers/mmc/core/block.c | 7 +- drivers/mmc/core/host.c | 1 + drivers/mmc/host/meson-mx-sdhc-mmc.c | 26 +--- drivers/mmc/host/sdhci-sprd.c | 10 +- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 4 +- drivers/net/ethernet/broadcom/genet/bcmgenet.c | 4 +- drivers/net/ethernet/intel/i40e/i40e_main.c | 11 +- drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 34 ++++- drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.h | 3 + drivers/net/ethernet/intel/igc/igc.h | 1 + drivers/net/ethernet/intel/igc/igc_ethtool.c | 42 +++++- drivers/net/ethernet/intel/igc/igc_tsn.c | 2 +- drivers/net/ethernet/marvell/octeontx2/af/cgx.c | 68 ++++++---- .../ethernet/marvell/octeontx2/af/lmac_common.h | 1 + drivers/net/ethernet/marvell/octeontx2/af/npc.h | 4 +- drivers/net/ethernet/marvell/octeontx2/af/rpm.c | 77 ++++++----- drivers/net/ethernet/marvell/octeontx2/af/rpm.h | 1 + drivers/net/ethernet/marvell/octeontx2/af/rvu.h | 3 +- .../net/ethernet/marvell/octeontx2/af/rvu_cgx.c | 33 +++++ .../net/ethernet/marvell/octeontx2/af/rvu_nix.c | 146 ++++----------------- .../ethernet/marvell/octeontx2/nic/otx2_common.c | 1 + .../net/ethernet/marvell/octeontx2/nic/otx2_pf.c | 15 ++- .../net/ethernet/marvell/octeontx2/nic/otx2_vf.c | 12 +- .../ethernet/mellanox/mlxbf_gige/mlxbf_gige_rx.c | 9 +- drivers/net/ethernet/qlogic/qla3xxx.c | 2 + drivers/net/ethernet/realtek/r8169_main.c | 2 +- drivers/net/ethernet/sfc/rx_common.c | 4 +- drivers/net/usb/ax88172a.c | 4 +- drivers/net/usb/ax88179_178a.c | 115 ++++------------ drivers/net/wireless/intel/iwlwifi/pcie/internal.h | 4 +- drivers/net/wireless/intel/iwlwifi/pcie/rx.c | 8 +- drivers/net/wireless/intel/iwlwifi/pcie/trans.c | 17 +-- drivers/pci/pci.c | 6 + drivers/pci/pci.h | 2 + drivers/pci/pcie/aspm.c | 19 +++ include/linux/module.h | 9 ++ include/net/dst_ops.h | 2 +- kernel/module.c | 2 - kernel/trace/trace_kprobe.c | 2 + mm/memory-failure.c | 6 +- mm/memory.c | 4 +- net/can/raw.c | 12 +- net/core/dst.c | 8 +- net/core/sock.c | 12 +- net/dns_resolver/dns_key.c | 19 ++- net/ipv4/ip_output.c | 2 +- net/ipv6/ip6_output.c | 2 +- net/ipv6/route.c | 13 +- net/netfilter/nf_tables_api.c | 27 ++++ net/netfilter/nft_immediate.c | 2 +- net/nfc/llcp_core.c | 39 +++++- net/sched/em_text.c | 4 +- net/socket.c | 2 + net/tls/tls_sw.c | 2 + sound/pci/hda/patch_realtek.c | 1 + sound/soc/fsl/fsl_rpmsg.c | 10 +- sound/soc/meson/g12a-toacodec.c | 5 +- sound/soc/meson/g12a-tohdmitx.c | 8 +- tools/perf/util/genelf.h | 4 +- tools/testing/selftests/vm/memfd_secret.c | 3 + 68 files changed, 588 insertions(+), 403 deletions(-)

1 year, 1 month

9
67
0 0

[PATCH 6.1 0/4] 6.1.73-rc1 review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 6.1.73 release. There are 4 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Mon, 15 Jan 2024 09:41:55 +0000. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.73-rc1… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.1.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 6.1.73-rc1 Jon Maxwell <jmaxwell37(a)gmail.com> ipv6: remove max_size check inline with ipv4 Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Revert "nfsd: separate nfsd_last_thread() from nfsd_put()" Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Revert "nfsd: call nfsd_last_thread() before final nfsd_put()" Steve French <stfrench(a)microsoft.com> cifs: fix flushing folio regression for 6.1 backport ------------- Diffstat: Makefile | 4 ++-- fs/nfsd/nfsctl.c | 9 ++------- fs/nfsd/nfsd.h | 8 +------- fs/nfsd/nfssvc.c | 52 ++++++++++++++++++++++++++++++++------------------ fs/smb/client/cifsfs.c | 2 +- include/net/dst_ops.h | 2 +- net/core/dst.c | 8 ++------ net/ipv6/route.c | 13 +++++-------- 8 files changed, 47 insertions(+), 51 deletions(-)

1 year, 1 month

12
18
0 0

[PATCH 6.6 0/1] 6.6.12-rc1 review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 6.6.12 release. There are 1 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Mon, 15 Jan 2024 09:41:55 +0000. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.6.12-rc1… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.6.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 6.6.12-rc1 Jeff Layton <jlayton(a)kernel.org> nfsd: drop the nfsd_put helper ------------- Diffstat: Makefile | 4 ++-- fs/nfsd/nfsctl.c | 31 +++++++++++++++++-------------- fs/nfsd/nfsd.h | 7 ------- 3 files changed, 19 insertions(+), 23 deletions(-)

1 year, 1 month

14
14
0 0

[PATCH 5.4 00/38] 5.4.267-rc1 review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 5.4.267 release. There are 38 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Mon, 15 Jan 2024 09:41:55 +0000. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.267-rc… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 5.4.267-rc1 Jon Maxwell <jmaxwell37(a)gmail.com> ipv6: remove max_size check inline with ipv4 Eric Dumazet <edumazet(a)google.com> ipv6: make ip6_rt_gc_expire an atomic_t Eric Dumazet <edumazet(a)google.com> net/dst: use a smaller percpu_counter batch for dst entries accounting Bartosz Pawlowski <bartosz.pawlowski(a)intel.com> PCI: Disable ATS for specific Intel IPU E2000 devices Bartosz Pawlowski <bartosz.pawlowski(a)intel.com> PCI: Extract ATS disabling to a helper function Phil Sutter <phil(a)nwl.cc> netfilter: nf_tables: Reject tables of unsupported family John Fastabend <john.fastabend(a)gmail.com> net: tls, update curr on splice as well Douglas Anderson <dianders(a)chromium.org> ath10k: Get rid of "per_ce_irq" hw param Douglas Anderson <dianders(a)chromium.org> ath10k: Keep track of which interrupts fired, don't poll them Rakesh Pillai <pillair(a)codeaurora.org> ath10k: Add interrupt summary based CE processing Douglas Anderson <dianders(a)chromium.org> ath10k: Wait until copy complete is actually done before completing Wenchao Chen <wenchao.chen(a)unisoc.com> mmc: sdhci-sprd: Fix eMMC init failure after hw reset Geert Uytterhoeven <geert+renesas(a)glider.be> mmc: core: Cancel delayed work before releasing host Jorge Ramirez-Ortiz <jorge(a)foundries.io> mmc: rpmb: fixes pause retune on all RPMB partitions. Jiajun Xie <jiajun.xie.sh(a)gmail.com> mm: fix unmap_mapping_range high bits shift bug Benjamin Bara <benjamin.bara(a)skidata.com> i2c: core: Fix atomic xfer check for non-preempt config Takashi Sakamoto <o-takashi(a)sakamocchi.jp> firewire: ohci: suppress unexpected system reboot in AMD Ryzen machines and ASM108x/VT630x PCIe cards Matthew Wilcox (Oracle) <willy(a)infradead.org> mm/memory-failure: check the mapcount of the precise page Thomas Lange <thomas(a)corelatus.se> net: Implement missing SO_TIMESTAMPING_NEW cmsg support Michael Chan <michael.chan(a)broadcom.com> bnxt_en: Remove mis-applied code from bnxt_cfg_ntp_filters() Chen Ni <nichen(a)iscas.ac.cn> asix: Add check for usbnet_get_endpoints Dinghao Liu <dinghao.liu(a)zju.edu.cn> net/qla3xxx: fix potential memleak in ql_alloc_buffer_queues Christophe JAILLET <christophe.jaillet(a)wanadoo.fr> net/qla3xxx: switch from 'pci_' to 'dma_' API Andrii Staikov <andrii.staikov(a)intel.com> i40e: Restore VF MSI-X state during PCI reset Mark Brown <broonie(a)kernel.org> ASoC: meson: g12a-tohdmitx: Fix event generation for S/PDIF mux Mark Brown <broonie(a)kernel.org> ASoC: meson: g12a-tohdmitx: Validate written enum values Jerome Brunet <jbrunet(a)baylibre.com> ASoC: meson: g12a: extract codec-to-codec utils Ke Xiao <xiaoke(a)sangfor.com.cn> i40e: fix use-after-free in i40e_aqc_add_filters() Marc Dionne <marc.dionne(a)auristor.com> net: Save and restore msg_namelen in sock_sendmsg Adrian Cinal <adriancinal(a)gmail.com> net: bcmgenet: Fix FCS generation for fragmented skbuffs Stefan Wahren <wahrenst(a)gmx.net> ARM: sun9i: smp: Fix array-index-out-of-bounds read in sunxi_mc_smp_init Vadim Fedorenko <vadfed(a)meta.com> net-timestamp: extend SOF_TIMESTAMPING_OPT_ID to HW timestamps Marc Kleine-Budde <mkl(a)pengutronix.de> can: raw: add support for SO_MARK Marc Kleine-Budde <mkl(a)pengutronix.de> can: raw: add support for SO_TXTIME/SCM_TXTIME Jörn-Thorben Hinz <jthinz(a)mailbox.tu-berlin.de> net: Implement missing getsockopt(SO_TIMESTAMPING_NEW) Hangyu Hua <hbh25y(a)gmail.com> net: sched: em_text: fix possible memory leak in em_text_destroy() Sudheer Mogilappagari <sudheer.mogilappagari(a)intel.com> i40e: Fix filter input checks to prevent config with invalid values Siddh Raman Pant <code(a)siddh.me> nfc: llcp_core: Hold a ref to llcp_local->dev when holding a ref to llcp_local ------------- Diffstat: Makefile | 4 +- arch/arm/mach-sunxi/mc_smp.c | 4 +- drivers/firewire/ohci.c | 51 +++++ drivers/i2c/i2c-core.h | 4 +- drivers/mmc/core/block.c | 7 +- drivers/mmc/core/host.c | 1 + drivers/mmc/host/sdhci-sprd.c | 10 +- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 4 +- drivers/net/ethernet/broadcom/genet/bcmgenet.c | 4 +- drivers/net/ethernet/intel/i40e/i40e_main.c | 11 +- drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 34 ++- drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.h | 3 + drivers/net/ethernet/qlogic/qla3xxx.c | 198 ++++++++---------- drivers/net/usb/ax88172a.c | 4 +- drivers/net/wireless/ath/ath10k/ce.c | 79 +++---- drivers/net/wireless/ath/ath10k/ce.h | 15 +- drivers/net/wireless/ath/ath10k/core.c | 13 -- drivers/net/wireless/ath/ath10k/hw.h | 3 - drivers/net/wireless/ath/ath10k/snoc.c | 19 +- drivers/net/wireless/ath/ath10k/snoc.h | 1 + drivers/pci/quirks.c | 28 ++- include/net/dst_ops.h | 6 +- include/net/netns/ipv6.h | 4 +- mm/memory-failure.c | 6 +- mm/memory.c | 4 +- net/can/raw.c | 12 +- net/core/dst.c | 12 +- net/core/sock.c | 12 +- net/ipv4/ip_output.c | 2 +- net/ipv6/ip6_output.c | 2 +- net/ipv6/route.c | 25 +-- net/netfilter/nf_tables_api.c | 27 +++ net/nfc/llcp_core.c | 39 +++- net/sched/em_text.c | 4 +- net/socket.c | 2 + net/tls/tls_sw.c | 2 + sound/soc/meson/Kconfig | 4 + sound/soc/meson/Makefile | 2 + sound/soc/meson/g12a-tohdmitx.c | 227 +++++---------------- sound/soc/meson/meson-codec-glue.c | 149 ++++++++++++++ sound/soc/meson/meson-codec-glue.h | 32 +++ 41 files changed, 658 insertions(+), 412 deletions(-)

1 year, 1 month

6
43
0 0

[PATCH v4 6/6] s390/vfio-ap: do not reset queue removed from host config

by Tony Krowiak

From: Tony Krowiak <akrowiak(a)linux.ibm.com> When a queue is unbound from the vfio_ap device driver, it is reset to ensure its crypto data is not leaked when it is bound to another device driver. If the queue is unbound due to the fact that the adapter or domain was removed from the host's AP configuration, then attempting to reset it will fail with response code 01 (APID not valid) getting returned from the reset command. Let's ensure that the queue is assigned to the host's configuration before resetting it. Signed-off-by: Tony Krowiak <akrowiak(a)linux.ibm.com> Reviewed-by: Jason J. Herne <jjherne(a)linux.ibm.com> Reviewed-by: Halil Pasic <pasic(a)linux.ibm.com> Fixes: eeb386aeb5b7 ("s390/vfio-ap: handle config changed and scan complete notification") Cc: <stable(a)vger.kernel.org> --- drivers/s390/crypto/vfio_ap_ops.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/drivers/s390/crypto/vfio_ap_ops.c b/drivers/s390/crypto/vfio_ap_ops.c index 550c936c413d..983b3b16196c 100644 --- a/drivers/s390/crypto/vfio_ap_ops.c +++ b/drivers/s390/crypto/vfio_ap_ops.c @@ -2215,10 +2215,10 @@ void vfio_ap_mdev_remove_queue(struct ap_device *apdev) q = dev_get_drvdata(&apdev->device); get_update_locks_for_queue(q); matrix_mdev = q->matrix_mdev; + apid = AP_QID_CARD(q->apqn); + apqi = AP_QID_QUEUE(q->apqn); if (matrix_mdev) { - apid = AP_QID_CARD(q->apqn); - apqi = AP_QID_QUEUE(q->apqn); /* If the queue is assigned to the guest's AP configuration */ if (test_bit_inv(apid, matrix_mdev->shadow_apcb.apm) && test_bit_inv(apqi, matrix_mdev->shadow_apcb.aqm)) { @@ -2234,8 +2234,16 @@ void vfio_ap_mdev_remove_queue(struct ap_device *apdev) } } - vfio_ap_mdev_reset_queue(q); - flush_work(&q->reset_work); + /* + * If the queue is not in the host's AP configuration, then resetting + * it will fail with response code 01, (APQN not valid); so, let's make + * sure it is in the host's config. + */ + if (test_bit_inv(apid, (unsigned long *)matrix_dev->info.apm) && + test_bit_inv(apqi, (unsigned long *)matrix_dev->info.aqm)) { + vfio_ap_mdev_reset_queue(q); + flush_work(&q->reset_work); + } done: if (matrix_mdev) -- 2.43.0

1 year, 1 month

1
0
0 0

[PATCH v4 5/6] s390/vfio-ap: reset queues associated with adapter for queue unbound from driver

by Tony Krowiak

From: Tony Krowiak <akrowiak(a)linux.ibm.com> When a queue is unbound from the vfio_ap device driver, if that queue is assigned to a guest's AP configuration, its associated adapter is removed because queues are defined to a guest via a matrix of adapters and domains; so, it is not possible to remove a single queue. If an adapter is removed from the guest's AP configuration, all associated queues must be reset to prevent leaking crypto data should any of them be assigned to a different guest or device driver. The one caveat is that if the queue is being removed because the adapter or domain has been removed from the host's AP configuration, then an attempt to reset the queue will fail with response code 01, AP-queue number not valid; so resetting these queues should be skipped. Acked-by: Halil Pasic <pasic(a)linux.ibm.com> Signed-off-by: Tony Krowiak <akrowiak(a)linux.ibm.com> Fixes: 09d31ff78793 ("s390/vfio-ap: hot plug/unplug of AP devices when probed/removed") Cc: <stable(a)vger.kernel.org> --- drivers/s390/crypto/vfio_ap_ops.c | 76 +++++++++++++++++-------------- 1 file changed, 41 insertions(+), 35 deletions(-) diff --git a/drivers/s390/crypto/vfio_ap_ops.c b/drivers/s390/crypto/vfio_ap_ops.c index 44cd29aace8e..550c936c413d 100644 --- a/drivers/s390/crypto/vfio_ap_ops.c +++ b/drivers/s390/crypto/vfio_ap_ops.c @@ -939,45 +939,45 @@ static void vfio_ap_mdev_link_adapter(struct ap_matrix_mdev *matrix_mdev, AP_MKQID(apid, apqi)); } +static void collect_queues_to_reset(struct ap_matrix_mdev *matrix_mdev, + unsigned long apid, + struct list_head *qlist) +{ + struct vfio_ap_queue *q; + unsigned long apqi; + + for_each_set_bit_inv(apqi, matrix_mdev->shadow_apcb.aqm, AP_DOMAINS) { + q = vfio_ap_mdev_get_queue(matrix_mdev, AP_MKQID(apid, apqi)); + if (q) + list_add_tail(&q->reset_qnode, qlist); + } +} + +static void reset_queues_for_apid(struct ap_matrix_mdev *matrix_mdev, + unsigned long apid) +{ + struct list_head qlist; + + INIT_LIST_HEAD(&qlist); + collect_queues_to_reset(matrix_mdev, apid, &qlist); + vfio_ap_mdev_reset_qlist(&qlist); +} + static int reset_queues_for_apids(struct ap_matrix_mdev *matrix_mdev, unsigned long *apm_reset) { - struct vfio_ap_queue *q, *tmpq; struct list_head qlist; - unsigned long apid, apqi; - int apqn, ret = 0; + unsigned long apid; if (bitmap_empty(apm_reset, AP_DEVICES)) return 0; INIT_LIST_HEAD(&qlist); - for_each_set_bit_inv(apid, apm_reset, AP_DEVICES) { - for_each_set_bit_inv(apqi, matrix_mdev->shadow_apcb.aqm, - AP_DOMAINS) { - /* - * If the domain is not in the host's AP configuration, - * then resetting it will fail with response code 01 - * (APQN not valid). - */ - if (!test_bit_inv(apqi, - (unsigned long *)matrix_dev->info.aqm)) - continue; - - apqn = AP_MKQID(apid, apqi); - q = vfio_ap_mdev_get_queue(matrix_mdev, apqn); - - if (q) - list_add_tail(&q->reset_qnode, &qlist); - } - } + for_each_set_bit_inv(apid, apm_reset, AP_DEVICES) + collect_queues_to_reset(matrix_mdev, apid, &qlist); - ret = vfio_ap_mdev_reset_qlist(&qlist); - - list_for_each_entry_safe(q, tmpq, &qlist, reset_qnode) - list_del(&q->reset_qnode); - - return ret; + return vfio_ap_mdev_reset_qlist(&qlist); } /** @@ -2217,24 +2217,30 @@ void vfio_ap_mdev_remove_queue(struct ap_device *apdev) matrix_mdev = q->matrix_mdev; if (matrix_mdev) { - vfio_ap_unlink_queue_fr_mdev(q); - apid = AP_QID_CARD(q->apqn); apqi = AP_QID_QUEUE(q->apqn); - - /* - * If the queue is assigned to the guest's APCB, then remove - * the adapter's APID from the APCB and hot it into the guest. - */ + /* If the queue is assigned to the guest's AP configuration */ if (test_bit_inv(apid, matrix_mdev->shadow_apcb.apm) && test_bit_inv(apqi, matrix_mdev->shadow_apcb.aqm)) { + /* + * Since the queues are defined via a matrix of adapters + * and domains, it is not possible to hot unplug a + * single queue; so, let's unplug the adapter. + */ clear_bit_inv(apid, matrix_mdev->shadow_apcb.apm); vfio_ap_mdev_update_guest_apcb(matrix_mdev); + reset_queues_for_apid(matrix_mdev, apid); + goto done; } } vfio_ap_mdev_reset_queue(q); flush_work(&q->reset_work); + +done: + if (matrix_mdev) + vfio_ap_unlink_queue_fr_mdev(q); + dev_set_drvdata(&apdev->device, NULL); kfree(q); release_update_locks_for_mdev(matrix_mdev); -- 2.43.0

1 year, 1 month

1
0
0 0

[PATCH v4 2/6] s390/vfio-ap: loop over the shadow APCB when filtering guest's AP configuration

by Tony Krowiak

From: Tony Krowiak <akrowiak(a)linux.ibm.com> While filtering the mdev matrix, it doesn't make sense - and will have unexpected results - to filter an APID from the matrix if the APID or one of the associated APQIs is not in the host's AP configuration. There are two reasons for this: 1. An adapter or domain that is not in the host's AP configuration can be assigned to the matrix; this is known as over-provisioning. Queue devices, however, are only created for adapters and domains in the host's AP configuration, so there will be no queues associated with an over-provisioned adapter or domain to filter. 2. The adapter or domain may have been externally removed from the host's configuration via an SE or HMC attached to a DPM enabled LPAR. In this case, the vfio_ap device driver would have been notified by the AP bus via the on_config_changed callback and the adapter or domain would have already been filtered. Since the matrix_mdev->shadow_apcb.apm and matrix_mdev->shadow_apcb.aqm are copied from the mdev matrix sans the APIDs and APQIs not in the host's AP configuration, let's loop over those bitmaps instead of those assigned to the matrix. Signed-off-by: Tony Krowiak <akrowiak(a)linux.ibm.com> Reviewed-by: Halil Pasic <pasic(a)linux.ibm.com> Fixes: 48cae940c31d ("s390/vfio-ap: refresh guest's APCB by filtering AP resources assigned to mdev") Cc: <stable(a)vger.kernel.org> --- drivers/s390/crypto/vfio_ap_ops.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/s390/crypto/vfio_ap_ops.c b/drivers/s390/crypto/vfio_ap_ops.c index 1f7a6c106786..e825e13847fe 100644 --- a/drivers/s390/crypto/vfio_ap_ops.c +++ b/drivers/s390/crypto/vfio_ap_ops.c @@ -695,8 +695,9 @@ static bool vfio_ap_mdev_filter_matrix(struct ap_matrix_mdev *matrix_mdev) bitmap_and(matrix_mdev->shadow_apcb.aqm, matrix_mdev->matrix.aqm, (unsigned long *)matrix_dev->info.aqm, AP_DOMAINS); - for_each_set_bit_inv(apid, matrix_mdev->matrix.apm, AP_DEVICES) { - for_each_set_bit_inv(apqi, matrix_mdev->matrix.aqm, AP_DOMAINS) { + for_each_set_bit_inv(apid, matrix_mdev->shadow_apcb.apm, AP_DEVICES) { + for_each_set_bit_inv(apqi, matrix_mdev->shadow_apcb.aqm, + AP_DOMAINS) { /* * If the APQN is not bound to the vfio_ap device * driver, then we can't assign it to the guest's -- 2.43.0

1 year, 1 month

1
0
0 0

[PATCH v4 1/6] s390/vfio-ap: always filter entire AP matrix

by Tony Krowiak

From: Tony Krowiak <akrowiak(a)linux.ibm.com> The vfio_ap_mdev_filter_matrix function is called whenever a new adapter or domain is assigned to the mdev. The purpose of the function is to update the guest's AP configuration by filtering the matrix of adapters and domains assigned to the mdev. When an adapter or domain is assigned, only the APQNs associated with the APID of the new adapter or APQI of the new domain are inspected. If an APQN does not reference a queue device bound to the vfio_ap device driver, then it's APID will be filtered from the mdev's matrix when updating the guest's AP configuration. Inspecting only the APID of the new adapter or APQI of the new domain will result in passing AP queues through to a guest that are not bound to the vfio_ap device driver under certain circumstances. Consider the following: guest's AP configuration (all also assigned to the mdev's matrix): 14.0004 14.0005 14.0006 16.0004 16.0005 16.0006 unassign domain 4 unbind queue 16.0005 assign domain 4 When domain 4 is re-assigned, since only domain 4 will be inspected, the APQNs that will be examined will be: 14.0004 16.0004 Since both of those APQNs reference queue devices that are bound to the vfio_ap device driver, nothing will get filtered from the mdev's matrix when updating the guest's AP configuration. Consequently, queue 16.0005 will get passed through despite not being bound to the driver. This violates the linux device model requirement that a guest shall only be given access to devices bound to the device driver facilitating their pass-through. To resolve this problem, every adapter and domain assigned to the mdev will be inspected when filtering the mdev's matrix. Signed-off-by: Tony Krowiak <akrowiak(a)linux.ibm.com> Acked-by: Halil Pasic <pasic(a)linux.ibm.com> Fixes: 48cae940c31d ("s390/vfio-ap: refresh guest's APCB by filtering AP resources assigned to mdev") Cc: <stable(a)vger.kernel.org> --- drivers/s390/crypto/vfio_ap_ops.c | 57 +++++++++---------------------- 1 file changed, 17 insertions(+), 40 deletions(-) diff --git a/drivers/s390/crypto/vfio_ap_ops.c b/drivers/s390/crypto/vfio_ap_ops.c index acb710d3d7bc..1f7a6c106786 100644 --- a/drivers/s390/crypto/vfio_ap_ops.c +++ b/drivers/s390/crypto/vfio_ap_ops.c @@ -674,8 +674,7 @@ static bool vfio_ap_mdev_filter_cdoms(struct ap_matrix_mdev *matrix_mdev) * Return: a boolean value indicating whether the KVM guest's APCB was changed * by the filtering or not. */ -static bool vfio_ap_mdev_filter_matrix(unsigned long *apm, unsigned long *aqm, - struct ap_matrix_mdev *matrix_mdev) +static bool vfio_ap_mdev_filter_matrix(struct ap_matrix_mdev *matrix_mdev) { unsigned long apid, apqi, apqn; DECLARE_BITMAP(prev_shadow_apm, AP_DEVICES); @@ -696,8 +695,8 @@ static bool vfio_ap_mdev_filter_matrix(unsigned long *apm, unsigned long *aqm, bitmap_and(matrix_mdev->shadow_apcb.aqm, matrix_mdev->matrix.aqm, (unsigned long *)matrix_dev->info.aqm, AP_DOMAINS); - for_each_set_bit_inv(apid, apm, AP_DEVICES) { - for_each_set_bit_inv(apqi, aqm, AP_DOMAINS) { + for_each_set_bit_inv(apid, matrix_mdev->matrix.apm, AP_DEVICES) { + for_each_set_bit_inv(apqi, matrix_mdev->matrix.aqm, AP_DOMAINS) { /* * If the APQN is not bound to the vfio_ap device * driver, then we can't assign it to the guest's @@ -962,7 +961,6 @@ static ssize_t assign_adapter_store(struct device *dev, { int ret; unsigned long apid; - DECLARE_BITMAP(apm_delta, AP_DEVICES); struct ap_matrix_mdev *matrix_mdev = dev_get_drvdata(dev); mutex_lock(&ap_perms_mutex); @@ -991,11 +989,8 @@ static ssize_t assign_adapter_store(struct device *dev, } vfio_ap_mdev_link_adapter(matrix_mdev, apid); - memset(apm_delta, 0, sizeof(apm_delta)); - set_bit_inv(apid, apm_delta); - if (vfio_ap_mdev_filter_matrix(apm_delta, - matrix_mdev->matrix.aqm, matrix_mdev)) + if (vfio_ap_mdev_filter_matrix(matrix_mdev)) vfio_ap_mdev_update_guest_apcb(matrix_mdev); ret = count; @@ -1171,7 +1166,6 @@ static ssize_t assign_domain_store(struct device *dev, { int ret; unsigned long apqi; - DECLARE_BITMAP(aqm_delta, AP_DOMAINS); struct ap_matrix_mdev *matrix_mdev = dev_get_drvdata(dev); mutex_lock(&ap_perms_mutex); @@ -1200,11 +1194,8 @@ static ssize_t assign_domain_store(struct device *dev, } vfio_ap_mdev_link_domain(matrix_mdev, apqi); - memset(aqm_delta, 0, sizeof(aqm_delta)); - set_bit_inv(apqi, aqm_delta); - if (vfio_ap_mdev_filter_matrix(matrix_mdev->matrix.apm, aqm_delta, - matrix_mdev)) + if (vfio_ap_mdev_filter_matrix(matrix_mdev)) vfio_ap_mdev_update_guest_apcb(matrix_mdev); ret = count; @@ -2109,9 +2100,7 @@ int vfio_ap_mdev_probe_queue(struct ap_device *apdev) if (matrix_mdev) { vfio_ap_mdev_link_queue(matrix_mdev, q); - if (vfio_ap_mdev_filter_matrix(matrix_mdev->matrix.apm, - matrix_mdev->matrix.aqm, - matrix_mdev)) + if (vfio_ap_mdev_filter_matrix(matrix_mdev)) vfio_ap_mdev_update_guest_apcb(matrix_mdev); } dev_set_drvdata(&apdev->device, q); @@ -2461,34 +2450,22 @@ void vfio_ap_on_cfg_changed(struct ap_config_info *cur_cfg_info, static void vfio_ap_mdev_hot_plug_cfg(struct ap_matrix_mdev *matrix_mdev) { - bool do_hotplug = false; - int filter_domains = 0; - int filter_adapters = 0; - DECLARE_BITMAP(apm, AP_DEVICES); - DECLARE_BITMAP(aqm, AP_DOMAINS); + bool filter_domains, filter_adapters, filter_cdoms, do_hotplug = false; mutex_lock(&matrix_mdev->kvm->lock); mutex_lock(&matrix_dev->mdevs_lock); - filter_adapters = bitmap_and(apm, matrix_mdev->matrix.apm, - matrix_mdev->apm_add, AP_DEVICES); - filter_domains = bitmap_and(aqm, matrix_mdev->matrix.aqm, - matrix_mdev->aqm_add, AP_DOMAINS); - - if (filter_adapters && filter_domains) - do_hotplug |= vfio_ap_mdev_filter_matrix(apm, aqm, matrix_mdev); - else if (filter_adapters) - do_hotplug |= - vfio_ap_mdev_filter_matrix(apm, - matrix_mdev->shadow_apcb.aqm, - matrix_mdev); - else - do_hotplug |= - vfio_ap_mdev_filter_matrix(matrix_mdev->shadow_apcb.apm, - aqm, matrix_mdev); + filter_adapters = bitmap_intersects(matrix_mdev->matrix.apm, + matrix_mdev->apm_add, AP_DEVICES); + filter_domains = bitmap_intersects(matrix_mdev->matrix.aqm, + matrix_mdev->aqm_add, AP_DOMAINS); + filter_cdoms = bitmap_intersects(matrix_mdev->matrix.adm, + matrix_mdev->adm_add, AP_DOMAINS); + + if (filter_adapters || filter_domains) + do_hotplug = vfio_ap_mdev_filter_matrix(matrix_mdev); - if (bitmap_intersects(matrix_mdev->matrix.adm, matrix_mdev->adm_add, - AP_DOMAINS)) + if (filter_cdoms) do_hotplug |= vfio_ap_mdev_filter_cdoms(matrix_mdev); if (do_hotplug) -- 2.43.0

1 year, 1 month

1
0
0 0

[PATCH] interconnect: qcom: sm8450: Revert "interconnect: qcom: sm8450: Enable sync_state"

by Krzysztof Kozlowski

Revert commit 16862f1b2110 ("interconnect: qcom: sm8450: Enable sync_state"), because it causes serial console to corrupt, later freeze and become either entirely corrupted or only print without accepting any input. Cc: <stable(a)vger.kernel.org> Fixes: 16862f1b2110 ("interconnect: qcom: sm8450: Enable sync_state") Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski(a)linaro.org> --- drivers/interconnect/qcom/sm8450.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/interconnect/qcom/sm8450.c b/drivers/interconnect/qcom/sm8450.c index b3cd0087377c..952017940b02 100644 --- a/drivers/interconnect/qcom/sm8450.c +++ b/drivers/interconnect/qcom/sm8450.c @@ -1888,7 +1888,6 @@ static struct platform_driver qnoc_driver = { .driver = { .name = "qnoc-sm8450", .of_match_table = qnoc_of_match, - .sync_state = icc_sync_state, }, }; -- 2.34.1

1 year, 1 month

3
8
0 0

Linux 6.6.12

by Greg Kroah-Hartman

I'm announcing the release of the 6.6.12 kernel. All users of the 6.6 kernel series must upgrade. The updated 6.6.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-6.6.y and can be browsed at the normal kernel.org git web browser: https://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary thanks, greg k-h ------------ Makefile | 2 +- fs/nfsd/nfsctl.c | 31 +++++++++++++++++-------------- fs/nfsd/nfsd.h | 7 ------- 3 files changed, 18 insertions(+), 22 deletions(-) Greg Kroah-Hartman (1): Linux 6.6.12 Jeff Layton (1): nfsd: drop the nfsd_put helper

1 year, 1 month

1
1
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror January 2024