April 2025 - Linux-stable-mirror

possible deadlock in blk_mq_freeze_queue in Linux6.1.25(longterm maintenance, last updated on April 25, 2025)

by Jianzhou Zhao

Hello, I found a potential bug titled " possible deadlock in blk_mq_freeze_queue" with modified syzkaller in the Linux6.12.25(longterm maintenance, last updated on April 25, 2025) If you fix this issue, please add the following tag to the commit: Reported-by: Jianzhou Zhao <luckd0g(a)163.com>, xingwei lee <xrivendell7(a)gmail.com> The commit of the kernel is : ef4999852d307d38cfdecd91ed6892cc03beb9b8 kernel config: https://syzkaller.appspot.com/text?tag=KernelConfig&x=55f8591b98dd132 compiler: gcc version 11.4.0 Unfortunately, although my fuzz testing tool can trigger this bug relatively frequently, it still cannot generate a reproduction program. ------------[ cut here ]----------------------------------------- TITLE: possible deadlock in blk_mq_freeze_queue ------------[ cut here ]------------ loop6: detected capacity change from 1024 to 1023 ====================================================== WARNING: possible circular locking dependency detected 6.12.25 #1 Not tainted ------------------------------------------------------ syz.8.1968/32422 is trying to acquire lock: ffffffff8e34acc0 (fs_reclaim){+.+.}-{0:0}, at: might_alloc include/linux/sched/mm.h:318 [inline] ffffffff8e34acc0 (fs_reclaim){+.+.}-{0:0}, at: slab_pre_alloc_hook mm/slub.c:4068 [inline] ffffffff8e34acc0 (fs_reclaim){+.+.}-{0:0}, at: slab_alloc_node mm/slub.c:4146 [inline] ffffffff8e34acc0 (fs_reclaim){+.+.}-{0:0}, at: __kmalloc_cache_noprof+0x56/0x3e0 mm/slub.c:4322 but task is already holding lock: ffff8880435f1468 (&q->q_usage_counter(io)#23){++++}-{0:0}, at: blk_freeze_queue block/blk-mq.c:224 [inline] ffff8880435f1468 (&q->q_usage_counter(io)#23){++++}-{0:0}, at: blk_mq_freeze_queue+0x15/0x20 block/blk-mq.c:234 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&q->q_usage_counter(io)#23){++++}-{0:0}: bio_queue_enter block/blk.h:76 [inline] blk_mq_submit_bio+0x22fd/0x2dd0 block/blk-mq.c:3088 __submit_bio+0x63b/0x10b0 block/blk-core.c:629 __submit_bio_noacct_mq block/blk-core.c:716 [inline] submit_bio_noacct_nocheck block/blk-core.c:745 [inline] submit_bio_noacct_nocheck+0x6cc/0xd30 block/blk-core.c:722 submit_bio_noacct+0x6c9/0x1fc0 block/blk-core.c:868 xfs_buf_ioapply_map fs/xfs/xfs_buf.c:1585 [inline] _xfs_buf_ioapply+0xa65/0xed0 fs/xfs/xfs_buf.c:1673 __xfs_buf_submit+0x26c/0x700 fs/xfs/xfs_buf.c:1757 xfs_buf_submit fs/xfs/xfs_buf.c:61 [inline] _xfs_buf_read fs/xfs/xfs_buf.c:808 [inline] xfs_buf_read_map+0x672/0xde0 fs/xfs/xfs_buf.c:872 xfs_trans_read_buf_map+0x356/0xcf0 fs/xfs/xfs_trans_buf.c:289 xfs_trans_read_buf fs/xfs/xfs_trans.h:212 [inline] xfs_imap_to_bp+0x110/0x2a0 fs/xfs/libxfs/xfs_inode_buf.c:138 xfs_inode_item_precommit+0x5d9/0x980 fs/xfs/xfs_inode_item.c:174 xfs_trans_run_precommits fs/xfs/xfs_trans.c:802 [inline] __xfs_trans_commit+0x303/0xda0 fs/xfs/xfs_trans.c:845 xfs_trans_commit+0x117/0x1b0 fs/xfs/xfs_trans.c:930 xfs_qm_qino_alloc+0x4da/0x700 fs/xfs/xfs_qm.c:861 xfs_qm_init_quotainos+0x526/0x6e0 fs/xfs/xfs_qm.c:1664 xfs_qm_init_quotainfo+0xf8/0xb00 fs/xfs/xfs_qm.c:667 xfs_qm_mount_quotas+0x59/0x650 fs/xfs/xfs_qm.c:1514 xfs_mountfs+0x1c0e/0x20e0 fs/xfs/xfs_mount.c:984 xfs_fs_fill_super+0x148f/0x1f30 fs/xfs/xfs_super.c:1764 get_tree_bdev_flags+0x389/0x620 fs/super.c:1636 vfs_get_tree+0x90/0x340 fs/super.c:1814 do_new_mount fs/namespace.c:3512 [inline] path_mount+0x1290/0x1bc0 fs/namespace.c:3839 do_mount+0xf8/0x110 fs/namespace.c:3852 __do_sys_mount fs/namespace.c:4062 [inline] __se_sys_mount fs/namespace.c:4039 [inline] __x64_sys_mount+0x193/0x230 fs/namespace.c:4039 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xcf/0x250 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #1 (&xfs_nondir_ilock_class#3){++++}-{3:3}: down_write_nested+0x96/0x210 kernel/locking/rwsem.c:1693 xfs_ilock+0x35c/0x420 fs/xfs/xfs_inode.c:164 xfs_reclaim_inode fs/xfs/xfs_icache.c:981 [inline] xfs_icwalk_process_inode fs/xfs/xfs_icache.c:1675 [inline] xfs_icwalk_ag+0xa64/0x17c0 fs/xfs/xfs_icache.c:1757 xfs_icwalk+0x4b/0xa0 fs/xfs/xfs_icache.c:1805 xfs_reclaim_inodes_nr+0x1ad/0x2b0 fs/xfs/xfs_icache.c:1047 super_cache_scan+0x364/0x490 fs/super.c:227 do_shrink_slab+0x464/0x11d0 mm/shrinker.c:437 shrink_slab+0x336/0x12c0 mm/shrinker.c:664 shrink_one+0x4a8/0x7d0 mm/vmscan.c:4835 shrink_many mm/vmscan.c:4896 [inline] lru_gen_shrink_node mm/vmscan.c:4974 [inline] shrink_node+0x24da/0x3b50 mm/vmscan.c:5954 kswapd_shrink_node mm/vmscan.c:6782 [inline] balance_pgdat+0x9d0/0x1670 mm/vmscan.c:6974 kswapd+0x538/0xc70 mm/vmscan.c:7243 kthread+0x342/0x450 kernel/kthread.c:389 ret_from_fork+0x45/0x80 arch/x86/kernel/process.c:152 ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244 -> #0 (fs_reclaim){+.+.}-{0:0}: check_prev_add kernel/locking/lockdep.c:3161 [inline] check_prevs_add kernel/locking/lockdep.c:3280 [inline] validate_chain kernel/locking/lockdep.c:3904 [inline] __lock_acquire+0x2940/0x4810 kernel/locking/lockdep.c:5202 lock_acquire kernel/locking/lockdep.c:5825 [inline] lock_acquire+0x1b4/0x590 kernel/locking/lockdep.c:5790 __fs_reclaim_acquire mm/page_alloc.c:3853 [inline] fs_reclaim_acquire+0x102/0x150 mm/page_alloc.c:3867 might_alloc include/linux/sched/mm.h:318 [inline] slab_pre_alloc_hook mm/slub.c:4068 [inline] slab_alloc_node mm/slub.c:4146 [inline] __kmalloc_cache_noprof+0x56/0x3e0 mm/slub.c:4322 kmalloc_noprof include/linux/slab.h:878 [inline] kzalloc_noprof include/linux/slab.h:1014 [inline] kobject_uevent_env+0x23a/0x16b0 lib/kobject_uevent.c:540 set_capacity_and_notify+0x1cb/0x250 block/genhd.c:95 loop_set_size.isra.0+0x2f/0xc0 drivers/block/loop.c:232 loop_set_status+0x486/0x740 drivers/block/loop.c:1210 loop_set_status_old+0x148/0x1c0 drivers/block/loop.c:1313 lo_ioctl+0xc5e/0x1830 drivers/block/loop.c:1466 blkdev_ioctl+0x27b/0x6d0 block/ioctl.c:693 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:907 [inline] __se_sys_ioctl fs/ioctl.c:893 [inline] __x64_sys_ioctl+0x19d/0x210 fs/ioctl.c:893 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xcf/0x250 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f other info that might help us debug this: Chain exists of: fs_reclaim --> &xfs_nondir_ilock_class#3 --> &q->q_usage_counter(io)#23 Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&q->q_usage_counter(io)#23); lock(&xfs_nondir_ilock_class#3); lock(&q->q_usage_counter(io)#23); lock(fs_reclaim); *** DEADLOCK *** 3 locks held by syz.8.1968/32422: #0: ffff888020454b70 (&lo->lo_mutex){+.+.}-{3:3}, at: loop_set_status+0x2a/0x740 drivers/block/loop.c:1176 #1: ffff8880435f1468 (&q->q_usage_counter(io)#23){++++}-{0:0}, at: blk_freeze_queue block/blk-mq.c:224 [inline] #1: ffff8880435f1468 (&q->q_usage_counter(io)#23){++++}-{0:0}, at: blk_mq_freeze_queue+0x15/0x20 block/blk-mq.c:234 #2: ffff8880435f14a0 (&q->q_usage_counter(queue)#7){+.+.}-{0:0}, at: blk_freeze_queue block/blk-mq.c:224 [inline] #2: ffff8880435f14a0 (&q->q_usage_counter(queue)#7){+.+.}-{0:0}, at: blk_mq_freeze_queue+0x15/0x20 block/blk-mq.c:234 stack backtrace: CPU: 0 UID: 0 PID: 32422 Comm: syz.8.1968 Not tainted 6.12.25 #1 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.15.0-1 04/01/2014 Call Trace: <TASK> __dump_stack lib/dump_stack.c:94 [inline] dump_stack_lvl+0x116/0x1b0 lib/dump_stack.c:120 print_circular_bug.isra.0+0x5e5/0x9f0 kernel/locking/lockdep.c:2074 check_noncircular+0x2f1/0x3d0 kernel/locking/lockdep.c:2206 check_prev_add kernel/locking/lockdep.c:3161 [inline] check_prevs_add kernel/locking/lockdep.c:3280 [inline] validate_chain kernel/locking/lockdep.c:3904 [inline] __lock_acquire+0x2940/0x4810 kernel/locking/lockdep.c:5202 lock_acquire kernel/locking/lockdep.c:5825 [inline] lock_acquire+0x1b4/0x590 kernel/locking/lockdep.c:5790 __fs_reclaim_acquire mm/page_alloc.c:3853 [inline] fs_reclaim_acquire+0x102/0x150 mm/page_alloc.c:3867 might_alloc include/linux/sched/mm.h:318 [inline] slab_pre_alloc_hook mm/slub.c:4068 [inline] slab_alloc_node mm/slub.c:4146 [inline] __kmalloc_cache_noprof+0x56/0x3e0 mm/slub.c:4322 kmalloc_noprof include/linux/slab.h:878 [inline] kzalloc_noprof include/linux/slab.h:1014 [inline] kobject_uevent_env+0x23a/0x16b0 lib/kobject_uevent.c:540 set_capacity_and_notify+0x1cb/0x250 block/genhd.c:95 loop_set_size.isra.0+0x2f/0xc0 drivers/block/loop.c:232 loop_set_status+0x486/0x740 drivers/block/loop.c:1210 loop_set_status_old+0x148/0x1c0 drivers/block/loop.c:1313 lo_ioctl+0xc5e/0x1830 drivers/block/loop.c:1466 blkdev_ioctl+0x27b/0x6d0 block/ioctl.c:693 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:907 [inline] __se_sys_ioctl fs/ioctl.c:893 [inline] __x64_sys_ioctl+0x19d/0x210 fs/ioctl.c:893 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xcf/0x250 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7f22897ac5ad Code: 02 b8 ff ff ff ff c3 66 0f 1f 44 00 00 f3 0f 1e fa 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f228a5f2f98 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 RAX: ffffffffffffffda RBX: 00007f22899e5fa0 RCX: 00007f22897ac5ad RDX: 0000200000000080 RSI: 0000000000004c02 RDI: 0000000000000006 RBP: 00007f228984458e R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 0000000000000000 R14: 00007f22899e5fa0 R15: 00007f228a5d3000 </TASK> =================================================================== I hope it helps. Best regards Jianzhou Zhao

2 months

1
0
0 0

KASAN: slab-use-after-free Read in perf_uprobe_destroy in linux6.12.25(longterm maintenance)

by Jianzhou Zhao

Hello, I found a potential bug titled " KASAN: slab-use-after-free Read in perf_uprobe_destroy " with modified syzkaller in the Linux6.12.25(longterm maintenance, last updated on April 25, 2025) If you fix this issue, please add the following tag to the commit: Reported-by: Jianzhou Zhao <luckd0g(a)163.com>, xingwei lee <xrivendell7(a)gmail.com>, Penglei Jiang <superman.xpt(a)gmail.com> The commit of the kernel is : ef4999852d307d38cfdecd91ed6892cc03beb9b8 kernel config: https://syzkaller.appspot.com/text?tag=KernelConfig&x=55f8591b98dd132 compiler: gcc version 11.4.0 I put the reproduction program of this bug at the end of the email. ------------[ cut here ]----------------------------------------- TITLE: KASAN: slab-use-after-free Read in perf_uprobe_destroy ------------[ cut here ]------------ ================================================================== BUG: KASAN: slab-use-after-free in perf_trace_event_close kernel/trace/trace_event_perf.c:190 [inline] BUG: KASAN: slab-use-after-free in perf_uprobe_destroy+0x1d6/0x200 kernel/trace/trace_event_perf.c:344 Read of size 8 at addr ffff888028f59060 by task syz.0.14/12239 CPU: 0 UID: 0 PID: 12239 Comm: syz.0.14 Not tainted 6.12.25 #1 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.15.0-1 04/01/2014 Call Trace: <TASK> __dump_stack lib/dump_stack.c:94 [inline] dump_stack_lvl+0x116/0x1b0 lib/dump_stack.c:120 print_address_description mm/kasan/report.c:377 [inline] print_report+0xc0/0x5e0 mm/kasan/report.c:488 kasan_report+0x93/0xc0 mm/kasan/report.c:601 perf_trace_event_close kernel/trace/trace_event_perf.c:190 [inline] perf_uprobe_destroy+0x1d6/0x200 kernel/trace/trace_event_perf.c:344 __free_event+0x1d9/0x870 kernel/events/core.c:5330 perf_event_alloc kernel/events/core.c:12437 [inline] perf_event_alloc+0x1246/0x37d0 kernel/events/core.c:12210 __do_sys_perf_event_open+0x44c/0x2aa0 kernel/events/core.c:12847 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xcf/0x250 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7fb0d09ac5ad Code: 02 b8 ff ff ff ff c3 66 0f 1f 44 00 00 f3 0f 1e fa 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007fb0d18f5f98 EFLAGS: 00000246 ORIG_RAX: 000000000000012a RAX: ffffffffffffffda RBX: 00007fb0d0be5fa0 RCX: 00007fb0d09ac5ad RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000200000000040 RBP: 00007fb0d0a4458e R08: 000000000000000a R09: 0000000000000000 R10: ffffffffffffffff R11: 0000000000000246 R12: 0000000000000000 R13: 0000000000000000 R14: 00007fb0d0be5fa0 R15: 00007fb0d18d6000 </TASK> Allocated by task 12239: kasan_save_stack+0x24/0x50 mm/kasan/common.c:47 kasan_save_track+0x14/0x30 mm/kasan/common.c:68 poison_kmalloc_redzone mm/kasan/common.c:377 [inline] __kasan_kmalloc+0xaa/0xb0 mm/kasan/common.c:394 kasan_kmalloc include/linux/kasan.h:260 [inline] __kmalloc_cache_noprof+0x1a5/0x3e0 mm/slub.c:4327 kmalloc_noprof include/linux/slab.h:878 [inline] kzalloc_noprof include/linux/slab.h:1014 [inline] trace_probe_init+0xbc/0x5f0 kernel/trace/trace_probe.c:2050 alloc_trace_uprobe+0xa5/0x310 kernel/trace/trace_uprobe.c:347 create_local_trace_uprobe+0x10d/0x4c0 kernel/trace/trace_uprobe.c:1643 perf_uprobe_init+0x13a/0x220 kernel/trace/trace_event_perf.c:319 perf_uprobe_event_init+0x103/0x1d0 kernel/events/core.c:10715 perf_try_init_event+0x137/0xd70 kernel/events/core.c:11976 perf_init_event kernel/events/core.c:12064 [inline] perf_event_alloc kernel/events/core.c:12345 [inline] perf_event_alloc+0x101a/0x37d0 kernel/events/core.c:12210 __do_sys_perf_event_open+0x44c/0x2aa0 kernel/events/core.c:12847 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xcf/0x250 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f Freed by task 12239: kasan_save_stack+0x24/0x50 mm/kasan/common.c:47 kasan_save_track+0x14/0x30 mm/kasan/common.c:68 kasan_save_free_info+0x3a/0x60 mm/kasan/generic.c:579 poison_slab_object mm/kasan/common.c:247 [inline] __kasan_slab_free+0x54/0x70 mm/kasan/common.c:264 kasan_slab_free include/linux/kasan.h:233 [inline] slab_free_hook mm/slub.c:2372 [inline] slab_free mm/slub.c:4611 [inline] kfree+0x14e/0x4a0 mm/slub.c:4759 trace_probe_unlink+0x185/0x200 kernel/trace/trace_probe.c:2016 trace_probe_cleanup+0x168/0x1d0 kernel/trace/trace_probe.c:2034 free_trace_uprobe.part.0+0x1b/0x80 kernel/trace/trace_uprobe.c:371 free_trace_uprobe kernel/trace/trace_uprobe.c:367 [inline] destroy_local_trace_uprobe+0x5d/0x80 kernel/trace/trace_uprobe.c:1682 perf_try_init_event+0x44b/0xd70 kernel/events/core.c:12007 perf_init_event kernel/events/core.c:12064 [inline] perf_event_alloc kernel/events/core.c:12345 [inline] perf_event_alloc+0x101a/0x37d0 kernel/events/core.c:12210 __do_sys_perf_event_open+0x44c/0x2aa0 kernel/events/core.c:12847 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xcf/0x250 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f The buggy address belongs to the object at ffff888028f59000 which belongs to the cache kmalloc-512 of size 512 The buggy address is located 96 bytes inside of freed 512-byte region [ffff888028f59000, ffff888028f59200) The buggy address belongs to the physical page: page: refcount:1 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x28f58 head: order:2 mapcount:0 entire_mapcount:0 nr_pages_mapped:0 pincount:0 flags: 0xfff00000000040(head|node=0|zone=1|lastcpupid=0x7ff) page_type: f5(slab) raw: 00fff00000000040 ffff88801b041c80 ffffea0000a70200 dead000000000002 raw: 0000000000000000 0000000000100010 00000001f5000000 0000000000000000 head: 00fff00000000040 ffff88801b041c80 ffffea0000a70200 dead000000000002 head: 0000000000000000 0000000000100010 00000001f5000000 0000000000000000 head: 00fff00000000002 ffffea0000a3d601 ffffffffffffffff 0000000000000000 head: 0000000000000004 0000000000000000 00000000ffffffff 0000000000000000 page dumped because: kasan: bad access detected page_owner tracks the page as allocated page last allocated via order 2, migratetype Unmovable, gfp_mask 0xd20c0(__GFP_IO|__GFP_FS|__GFP_NOWARN|__GFP_NORETRY|__GFP_COMP|__GFP_NOMEMALLOC), pid 9461, tgid 9461 (syz-executor), ts 105252344888, free_ts 105090780548 set_page_owner include/linux/page_owner.h:32 [inline] post_alloc_hook mm/page_alloc.c:1558 [inline] prep_new_page+0x31b/0x3a0 mm/page_alloc.c:1566 get_page_from_freelist+0x19fb/0x33b0 mm/page_alloc.c:3476 __alloc_pages_noprof+0x324/0x6b0 mm/page_alloc.c:4754 alloc_pages_mpol_noprof+0x2ce/0x610 mm/mempolicy.c:2269 alloc_slab_page mm/slub.c:2442 [inline] allocate_slab mm/slub.c:2608 [inline] new_slab+0x253/0x430 mm/slub.c:2662 ___slab_alloc+0xe1c/0x1720 mm/slub.c:3850 __slab_alloc.isra.0+0x56/0xb0 mm/slub.c:3940 __slab_alloc_node mm/slub.c:3993 [inline] slab_alloc_node mm/slub.c:4154 [inline] __kmalloc_cache_noprof+0x37f/0x3e0 mm/slub.c:4322 kmalloc_noprof include/linux/slab.h:878 [inline] kzalloc_noprof include/linux/slab.h:1014 [inline] fib6_info_alloc+0xc9/0x290 net/ipv6/ip6_fib.c:155 ip6_route_info_create+0x341/0x1610 net/ipv6/route.c:3802 ip6_route_add+0x26/0x160 net/ipv6/route.c:3896 addrconf_prefix_route.isra.0+0x302/0x510 net/ipv6/addrconf.c:2486 inet6_addr_add+0x73a/0xc10 net/ipv6/addrconf.c:3083 inet6_rtm_newaddr+0x116a/0x18b0 net/ipv6/addrconf.c:5068 rtnetlink_rcv_msg+0x3c9/0xfc0 net/core/rtnetlink.c:6678 netlink_rcv_skb+0x165/0x450 net/netlink/af_netlink.c:2537 page last free pid 9499 tgid 9499 stack trace: reset_page_owner include/linux/page_owner.h:25 [inline] free_pages_prepare mm/page_alloc.c:1127 [inline] free_unref_page+0x799/0x1320 mm/page_alloc.c:2659 __put_partials+0x151/0x170 mm/slub.c:3177 qlink_free mm/kasan/quarantine.c:163 [inline] qlist_free_all+0x50/0x130 mm/kasan/quarantine.c:179 kasan_quarantine_reduce+0x165/0x1c0 mm/kasan/quarantine.c:286 __kasan_slab_alloc+0x67/0x90 mm/kasan/common.c:329 kasan_slab_alloc include/linux/kasan.h:250 [inline] slab_post_alloc_hook mm/slub.c:4117 [inline] slab_alloc_node mm/slub.c:4166 [inline] __kmalloc_cache_noprof+0x12a/0x3e0 mm/slub.c:4322 kmalloc_noprof include/linux/slab.h:878 [inline] call_modprobe kernel/module/kmod.c:84 [inline] __request_module+0x2a2/0x6b0 kernel/module/kmod.c:173 dev_load+0x1ff/0x240 net/core/dev_ioctl.c:645 dev_ioctl+0x518/0x10b0 net/core/dev_ioctl.c:709 sock_do_ioctl+0x1ca/0x260 net/socket.c:1241 sock_ioctl+0x23a/0x6c0 net/socket.c:1346 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:907 [inline] __se_sys_ioctl fs/ioctl.c:893 [inline] __x64_sys_ioctl+0x19d/0x210 fs/ioctl.c:893 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xcf/0x250 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f Memory state around the buggy address: ffff888028f58f00: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc ffff888028f58f80: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc >ffff888028f59000: fa fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb ^ ffff888028f59080: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb ffff888028f59100: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb ================================================================== // autogenerated by syzkaller (https://github.com/google/syzkaller) #define _GNU_SOURCE #include <dirent.h> #include <endian.h> #include <errno.h> #include <fcntl.h> #include <signal.h> #include <stdarg.h> #include <stdbool.h> #include <stdint.h> #include <stdio.h> #include <stdlib.h> #include <string.h> #include <sys/prctl.h> #include <sys/stat.h> #include <sys/syscall.h> #include <sys/types.h> #include <sys/wait.h> #include <time.h> #include <unistd.h> static void sleep_ms(uint64_t ms) { usleep(ms * 1000); } static uint64_t current_time_ms(void) { struct timespec ts; if (clock_gettime(CLOCK_MONOTONIC, &ts)) exit(1); return (uint64_t)ts.tv_sec * 1000 + (uint64_t)ts.tv_nsec / 1000000; } #define BITMASK(bf_off, bf_len) (((1ull << (bf_len)) - 1) << (bf_off)) #define STORE_BY_BITMASK(type, htobe, addr, val, bf_off, bf_len) \ *(type*)(addr) = \ htobe((htobe(*(type*)(addr)) & ~BITMASK((bf_off), (bf_len))) | \ (((type)(val) << (bf_off)) & BITMASK((bf_off), (bf_len)))) static bool write_file(const char* file, const char* what, ...) { char buf[1024]; va_list args; va_start(args, what); vsnprintf(buf, sizeof(buf), what, args); va_end(args); buf[sizeof(buf) - 1] = 0; int len = strlen(buf); int fd = open(file, O_WRONLY | O_CLOEXEC); if (fd == -1) return false; if (write(fd, buf, len) != len) { int err = errno; close(fd); errno = err; return false; } close(fd); return true; } static void kill_and_wait(int pid, int* status) { kill(-pid, SIGKILL); kill(pid, SIGKILL); for (int i = 0; i < 100; i++) { if (waitpid(-1, status, WNOHANG | __WALL) == pid) return; usleep(1000); } DIR* dir = opendir("/sys/fs/fuse/connections"); if (dir) { for (;;) { struct dirent* ent = readdir(dir); if (!ent) break; if (strcmp(ent->d_name, ".") == 0 || strcmp(ent->d_name, "..") == 0) continue; char abort[300]; snprintf(abort, sizeof(abort), "/sys/fs/fuse/connections/%s/abort", ent->d_name); int fd = open(abort, O_WRONLY); if (fd == -1) { continue; } if (write(fd, abort, 1) < 0) { } close(fd); } closedir(dir); } else { } while (waitpid(-1, status, __WALL) != pid) { } } static void setup_test() { prctl(PR_SET_PDEATHSIG, SIGKILL, 0, 0, 0); setpgrp(); write_file("/proc/self/oom_score_adj", "1000"); } static void execute_one(void); #define WAIT_FLAGS __WALL static void loop(void) { int iter = 0; for (;; iter++) { int pid = fork(); if (pid < 0) exit(1); if (pid == 0) { setup_test(); execute_one(); exit(0); } int status = 0; uint64_t start = current_time_ms(); for (;;) { sleep_ms(10); if (waitpid(-1, &status, WNOHANG | WAIT_FLAGS) == pid) break; if (current_time_ms() - start < 5000) continue; kill_and_wait(pid, &status); break; } } } void execute_one(void) { if (write(1, "executing program\n", sizeof("executing program\n") - 1)) { } memcpy((void*)0x200000000000, ".pending_reads\000", 15); syscall(__NR_openat, /*fd=*/0xffffff9c, /*file=*/0x200000000000ul, /*flags=O_SYNC|O_NOATIME|O_LARGEFILE|O_CREAT|O_APPEND*/ 0x149440, /*mode=*/0); *(uint32_t*)0x200000000040 = 8; *(uint32_t*)0x200000000044 = 0x80; *(uint8_t*)0x200000000048 = 2; *(uint8_t*)0x200000000049 = 0; *(uint8_t*)0x20000000004a = 0; *(uint8_t*)0x20000000004b = 0; *(uint32_t*)0x20000000004c = 0; *(uint64_t*)0x200000000050 = 0; *(uint64_t*)0x200000000058 = 0x6a484; *(uint64_t*)0x200000000060 = 4; STORE_BY_BITMASK(uint64_t, , 0x200000000068, 0, 0, 1); STORE_BY_BITMASK(uint64_t, , 0x200000000068, 0, 1, 1); STORE_BY_BITMASK(uint64_t, , 0x200000000068, 0, 2, 1); STORE_BY_BITMASK(uint64_t, , 0x200000000068, 0, 3, 1); STORE_BY_BITMASK(uint64_t, , 0x200000000068, 0, 4, 1); STORE_BY_BITMASK(uint64_t, , 0x200000000068, 0, 5, 1); STORE_BY_BITMASK(uint64_t, , 0x200000000068, 0, 6, 1); STORE_BY_BITMASK(uint64_t, , 0x200000000068, 0, 7, 1); STORE_BY_BITMASK(uint64_t, , 0x200000000068, 0, 8, 1); STORE_BY_BITMASK(uint64_t, , 0x200000000068, 0, 9, 1); STORE_BY_BITMASK(uint64_t, , 0x200000000068, 0, 10, 1); STORE_BY_BITMASK(uint64_t, , 0x200000000068, 0, 11, 1); STORE_BY_BITMASK(uint64_t, , 0x200000000068, 0, 12, 1); STORE_BY_BITMASK(uint64_t, , 0x200000000068, 0, 13, 1); STORE_BY_BITMASK(uint64_t, , 0x200000000068, 0, 14, 1); STORE_BY_BITMASK(uint64_t, , 0x200000000068, 0, 15, 2); STORE_BY_BITMASK(uint64_t, , 0x200000000068, 0, 17, 1); STORE_BY_BITMASK(uint64_t, , 0x200000000068, 0, 18, 1); STORE_BY_BITMASK(uint64_t, , 0x200000000068, 1, 19, 1); STORE_BY_BITMASK(uint64_t, , 0x200000000068, 0, 20, 1); STORE_BY_BITMASK(uint64_t, , 0x200000000068, 0, 21, 1); STORE_BY_BITMASK(uint64_t, , 0x200000000068, 0, 22, 1); STORE_BY_BITMASK(uint64_t, , 0x200000000068, 0, 23, 1); STORE_BY_BITMASK(uint64_t, , 0x200000000068, 0, 24, 1); STORE_BY_BITMASK(uint64_t, , 0x200000000068, 0, 25, 1); STORE_BY_BITMASK(uint64_t, , 0x200000000068, 0, 26, 1); STORE_BY_BITMASK(uint64_t, , 0x200000000068, 0, 27, 1); STORE_BY_BITMASK(uint64_t, , 0x200000000068, 0, 28, 1); STORE_BY_BITMASK(uint64_t, , 0x200000000068, 0, 29, 1); STORE_BY_BITMASK(uint64_t, , 0x200000000068, 0, 30, 1); STORE_BY_BITMASK(uint64_t, , 0x200000000068, 0, 31, 1); STORE_BY_BITMASK(uint64_t, , 0x200000000068, 0, 32, 1); STORE_BY_BITMASK(uint64_t, , 0x200000000068, 0, 33, 1); STORE_BY_BITMASK(uint64_t, , 0x200000000068, 0, 34, 1); STORE_BY_BITMASK(uint64_t, , 0x200000000068, 0, 35, 1); STORE_BY_BITMASK(uint64_t, , 0x200000000068, 0, 36, 1); STORE_BY_BITMASK(uint64_t, , 0x200000000068, 0, 37, 1); STORE_BY_BITMASK(uint64_t, , 0x200000000068, 0, 38, 26); *(uint32_t*)0x200000000070 = 7; *(uint32_t*)0x200000000074 = 0; *(uint64_t*)0x200000000078 = 0x200000000000; *(uint64_t*)0x200000000080 = 0; *(uint64_t*)0x200000000088 = 0; *(uint64_t*)0x200000000090 = 0; *(uint32_t*)0x200000000098 = 0; *(uint32_t*)0x20000000009c = 0; *(uint64_t*)0x2000000000a0 = 0x40000000000000; *(uint32_t*)0x2000000000a8 = 0; *(uint16_t*)0x2000000000ac = 0; *(uint16_t*)0x2000000000ae = 0; *(uint32_t*)0x2000000000b0 = 9; *(uint32_t*)0x2000000000b4 = 0; *(uint64_t*)0x2000000000b8 = 0; syscall(__NR_perf_event_open, /*attr=*/0x200000000040ul, /*pid=*/0, /*cpu=*/0ul, /*group=*/-1, /*flags=PERF_FLAG_FD_CLOEXEC|PERF_FLAG_FD_OUTPUT*/ 0xaul); } int main(void) { syscall(__NR_mmap, /*addr=*/0x1ffffffff000ul, /*len=*/0x1000ul, /*prot=*/0ul, /*flags=MAP_FIXED|MAP_ANONYMOUS|MAP_PRIVATE*/ 0x32ul, /*fd=*/-1, /*offset=*/0ul); syscall(__NR_mmap, /*addr=*/0x200000000000ul, /*len=*/0x1000000ul, /*prot=PROT_WRITE|PROT_READ|PROT_EXEC*/ 7ul, /*flags=MAP_FIXED|MAP_ANONYMOUS|MAP_PRIVATE*/ 0x32ul, /*fd=*/-1, /*offset=*/0ul); syscall(__NR_mmap, /*addr=*/0x200001000000ul, /*len=*/0x1000ul, /*prot=*/0ul, /*flags=MAP_FIXED|MAP_ANONYMOUS|MAP_PRIVATE*/ 0x32ul, /*fd=*/-1, /*offset=*/0ul); const char* reason; (void)reason; loop(); return 0; } =================================================================== I hope it helps. Best regards Jianzhou Zhao

2 months

1
0
0 0

sound/pci/hda: add quirk for HP Spectre x360 15-eb0xxx

by Ezra Khuzadi

sound/pci/hda: add quirk for HP Spectre x360 15-eb0xxx Add subsystem ID 0x86e5 for HP Spectre x360 15-eb0xxx so that ALC285_FIXUP_HP_SPECTRE_X360_EB1 (GPIO amp-enable, mic-mute LED and pinconfigs) is applied. Tested on HP Spectre x360 15-eb0043dx (Vendor 0x10ec0285, Subsys 0x103c86e5) with legacy HDA driver and hda-verb toggles: $ cat /proc/asound/card0/codec#0 \ | sed -n -e '1,5p;/Vendor Id:/p;/Subsystem Id:/p' Codec: Realtek ALC285 Vendor Id: 0x10ec0285 Subsystem Id: 0x103c86e5 $ dmesg | grep -i realtek [ 5.828728] snd_hda_codec_realtek ehdaudio0D0: ALC285: picked fixup for PCI SSID 103c:86e5 Signed-off-by: Ezra Khuzadi <ekhuzadi(a)uci.edu> --- sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 877137cb09ac..82ad105e7fa9 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -10563,6 +10563,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x103c, 0x86c7, "HP Envy AiO 32", ALC274_FIXUP_HP_ENVY_GPIO), + SND_PCI_QUIRK(0x103c, 0x86e5, "HP Spectre x360 15-eb0xxx", ALC285_FIXUP_HP_SPECTRE_X360_EB1), SND_PCI_QUIRK(0x103c, 0x86e7, "HP Spectre x360 15-eb0xxx", ALC285_FIXUP_HP_SPECTRE_X360_EB1), SND_PCI_QUIRK(0x103c, 0x86e8, "HP Spectre x360 15-eb0xxx", ALC285_FIXUP_HP_SPECTRE_X360_EB1), SND_PCI_QUIRK(0x103c, 0x86f9, "HP Spectre x360 13-aw0xxx", ALC285_FIXUP_HP_SPECTRE_X360_MUTE_LED),

2 months

2
2
0 0

[to-be-updated] kasan-avoid-sleepable-page-allocation-from-atomic-context.patch removed from -mm tree

by Andrew Morton

The quilt patch titled Subject: kasan: avoid sleepable page allocation from atomic context has been removed from the -mm tree. Its filename was kasan-avoid-sleepable-page-allocation-from-atomic-context.patch This patch was dropped because an updated version will be issued ------------------------------------------------------ From: Alexander Gordeev <agordeev(a)linux.ibm.com> Subject: kasan: avoid sleepable page allocation from atomic context Date: Tue, 29 Apr 2025 18:08:41 +0200 apply_to_pte_range() enters the lazy MMU mode and then invokes kasan_populate_vmalloc_pte() callback on each page table walk iteration. However, the callback can go into sleep when trying to allocate a single page, e.g. if an architecutre disables preemption on lazy MMU mode enter. On s390 with the call sequences arch_enter_lazy_mmu_mode() -> preempt_enable() and arch_leave_lazy_mmu_mode() -> preempt_disable(), such a crash occurs: [ 553.332108] preempt_count: 1, expected: 0 [ 553.332117] no locks held by multipathd/2116. [ 553.332128] CPU: 24 PID: 2116 Comm: multipathd Kdump: loaded Tainted: [ 553.332139] Hardware name: IBM 3931 A01 701 (LPAR) [ 553.332146] Call Trace: [ 553.332152] [<00000000158de23a>] dump_stack_lvl+0xfa/0x150 [ 553.332167] [<0000000013e10d12>] __might_resched+0x57a/0x5e8 [ 553.332178] [<00000000144eb6c2>] __alloc_pages+0x2ba/0x7c0 [ 553.332189] [<00000000144d5cdc>] __get_free_pages+0x2c/0x88 [ 553.332198] [<00000000145663f6>] kasan_populate_vmalloc_pte+0x4e/0x110 [ 553.332207] [<000000001447625c>] apply_to_pte_range+0x164/0x3c8 [ 553.332218] [<000000001448125a>] apply_to_pmd_range+0xda/0x318 [ 553.332226] [<000000001448181c>] __apply_to_page_range+0x384/0x768 [ 553.332233] [<0000000014481c28>] apply_to_page_range+0x28/0x38 [ 553.332241] [<00000000145665da>] kasan_populate_vmalloc+0x82/0x98 [ 553.332249] [<00000000144c88d0>] alloc_vmap_area+0x590/0x1c90 [ 553.332257] [<00000000144ca108>] __get_vm_area_node.constprop.0+0x138/0x260 [ 553.332265] [<00000000144d17fc>] __vmalloc_node_range+0x134/0x360 [ 553.332274] [<0000000013d5dbf2>] alloc_thread_stack_node+0x112/0x378 [ 553.332284] [<0000000013d62726>] dup_task_struct+0x66/0x430 [ 553.332293] [<0000000013d63962>] copy_process+0x432/0x4b80 [ 553.332302] [<0000000013d68300>] kernel_clone+0xf0/0x7d0 [ 553.332311] [<0000000013d68bd6>] __do_sys_clone+0xae/0xc8 [ 553.332400] [<0000000013d68dee>] __s390x_sys_clone+0xd6/0x118 [ 553.332410] [<0000000013c9d34c>] do_syscall+0x22c/0x328 [ 553.332419] [<00000000158e7366>] __do_syscall+0xce/0xf0 [ 553.332428] [<0000000015913260>] system_call+0x70/0x98 Instead of allocating single pages per-PTE, bulk-allocate the shadow memory prior to applying kasan_populate_vmalloc_pte() callback on a page range. Link: https://lkml.kernel.org/r/573a823565734e1eac3aa128fb9d3506ec918a72.17459408… Fixes: 3c5c3cfb9ef4 ("kasan: support backing vmalloc space with real shadow memory") Signed-off-by: Alexander Gordeev <agordeev(a)linux.ibm.com> Suggested-by: Andrey Ryabinin <ryabinin.a.a(a)gmail.com> Cc: Alexander Gordeev <agordeev(a)linux.ibm.com> Cc: Daniel Axtens <dja(a)axtens.net> Cc: Alexander Potapenko <glider(a)google.com> Cc: Andrey Konovalov <andreyknvl(a)gmail.com> Cc: Dmitry Vyukov <dvyukov(a)google.com> Cc: Vincenzo Frascino <vincenzo.frascino(a)arm.com> Cc: <stable(a)vger.kernel.org> Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> --- mm/kasan/shadow.c | 65 +++++++++++++++++++++++++++++++++----------- 1 file changed, 49 insertions(+), 16 deletions(-) --- a/mm/kasan/shadow.c~kasan-avoid-sleepable-page-allocation-from-atomic-context +++ a/mm/kasan/shadow.c @@ -292,30 +292,65 @@ void __init __weak kasan_populate_early_ { } +struct vmalloc_populate_data { + unsigned long start; + struct page **pages; +}; + static int kasan_populate_vmalloc_pte(pte_t *ptep, unsigned long addr, - void *unused) + void *_data) { - unsigned long page; + struct vmalloc_populate_data *data = _data; + struct page *page; + unsigned long pfn; pte_t pte; if (likely(!pte_none(ptep_get(ptep)))) return 0; - page = __get_free_page(GFP_KERNEL); - if (!page) - return -ENOMEM; - - __memset((void *)page, KASAN_VMALLOC_INVALID, PAGE_SIZE); - pte = pfn_pte(PFN_DOWN(__pa(page)), PAGE_KERNEL); + page = data->pages[PFN_DOWN(addr - data->start)]; + pfn = page_to_pfn(page); + __memset(pfn_to_virt(pfn), KASAN_VMALLOC_INVALID, PAGE_SIZE); + pte = pfn_pte(pfn, PAGE_KERNEL); spin_lock(&init_mm.page_table_lock); - if (likely(pte_none(ptep_get(ptep)))) { + if (likely(pte_none(ptep_get(ptep)))) set_pte_at(&init_mm, addr, ptep, pte); - page = 0; - } spin_unlock(&init_mm.page_table_lock); - if (page) - free_page(page); + + return 0; +} + +static int __kasan_populate_vmalloc(unsigned long start, unsigned long end) +{ + unsigned long nr_pages, nr_total = PFN_UP(end - start); + struct vmalloc_populate_data data; + int ret; + + data.pages = (struct page **)__get_free_page(GFP_KERNEL); + if (!data.pages) + return -ENOMEM; + + while (nr_total) { + nr_pages = min(nr_total, PAGE_SIZE / sizeof(data.pages[0])); + __memset(data.pages, 0, nr_pages * sizeof(data.pages[0])); + if (nr_pages != alloc_pages_bulk(GFP_KERNEL, nr_pages, data.pages)) { + free_page((unsigned long)data.pages); + return -ENOMEM; + } + + data.start = start; + ret = apply_to_page_range(&init_mm, start, nr_pages * PAGE_SIZE, + kasan_populate_vmalloc_pte, &data); + if (ret) + return ret; + + start += nr_pages * PAGE_SIZE; + nr_total -= nr_pages; + } + + free_page((unsigned long)data.pages); + return 0; } @@ -348,9 +383,7 @@ int kasan_populate_vmalloc(unsigned long shadow_start = PAGE_ALIGN_DOWN(shadow_start); shadow_end = PAGE_ALIGN(shadow_end); - ret = apply_to_page_range(&init_mm, shadow_start, - shadow_end - shadow_start, - kasan_populate_vmalloc_pte, NULL); + ret = __kasan_populate_vmalloc(shadow_start, shadow_end); if (ret) return ret; _ Patches currently in -mm which might be from agordeev(a)linux.ibm.com are

2 months

1
0
0 0

[PATCH AUTOSEL 5.4 1/3] scsi: target: iscsi: Fix timeout on deleted connection

by Sasha Levin

From: Dmitry Bogdanov <d.bogdanov(a)yadro.com> [ Upstream commit 7f533cc5ee4c4436cee51dc58e81dfd9c3384418 ] NOPIN response timer may expire on a deleted connection and crash with such logs: Did not receive response to NOPIN on CID: 0, failing connection for I_T Nexus (null),i,0x00023d000125,iqn.2017-01.com.iscsi.target,t,0x3d BUG: Kernel NULL pointer dereference on read at 0x00000000 NIP strlcpy+0x8/0xb0 LR iscsit_fill_cxn_timeout_err_stats+0x5c/0xc0 [iscsi_target_mod] Call Trace: iscsit_handle_nopin_response_timeout+0xfc/0x120 [iscsi_target_mod] call_timer_fn+0x58/0x1f0 run_timer_softirq+0x740/0x860 __do_softirq+0x16c/0x420 irq_exit+0x188/0x1c0 timer_interrupt+0x184/0x410 That is because nopin response timer may be re-started on nopin timer expiration. Stop nopin timer before stopping the nopin response timer to be sure that no one of them will be re-started. Signed-off-by: Dmitry Bogdanov <d.bogdanov(a)yadro.com> Link: https://lore.kernel.org/r/20241224101757.32300-1-d.bogdanov@yadro.com Reviewed-by: Maurizio Lombardi <mlombard(a)redhat.com> Signed-off-by: Martin K. Petersen <martin.petersen(a)oracle.com> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- drivers/target/iscsi/iscsi_target.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/target/iscsi/iscsi_target.c b/drivers/target/iscsi/iscsi_target.c index ab2f0ceb1e23b..b610c99c9c2dc 100644 --- a/drivers/target/iscsi/iscsi_target.c +++ b/drivers/target/iscsi/iscsi_target.c @@ -4168,8 +4168,8 @@ int iscsit_close_connection( spin_unlock(&iscsit_global->ts_bitmap_lock); iscsit_stop_timers_for_cmds(conn); - iscsit_stop_nopin_response_timer(conn); iscsit_stop_nopin_timer(conn); + iscsit_stop_nopin_response_timer(conn); if (conn->conn_transport->iscsit_wait_conn) conn->conn_transport->iscsit_wait_conn(conn); -- 2.39.5

2 months

1
2
0 0

[PATCH AUTOSEL 5.10 1/3] scsi: target: iscsi: Fix timeout on deleted connection

by Sasha Levin

From: Dmitry Bogdanov <d.bogdanov(a)yadro.com> [ Upstream commit 7f533cc5ee4c4436cee51dc58e81dfd9c3384418 ] NOPIN response timer may expire on a deleted connection and crash with such logs: Did not receive response to NOPIN on CID: 0, failing connection for I_T Nexus (null),i,0x00023d000125,iqn.2017-01.com.iscsi.target,t,0x3d BUG: Kernel NULL pointer dereference on read at 0x00000000 NIP strlcpy+0x8/0xb0 LR iscsit_fill_cxn_timeout_err_stats+0x5c/0xc0 [iscsi_target_mod] Call Trace: iscsit_handle_nopin_response_timeout+0xfc/0x120 [iscsi_target_mod] call_timer_fn+0x58/0x1f0 run_timer_softirq+0x740/0x860 __do_softirq+0x16c/0x420 irq_exit+0x188/0x1c0 timer_interrupt+0x184/0x410 That is because nopin response timer may be re-started on nopin timer expiration. Stop nopin timer before stopping the nopin response timer to be sure that no one of them will be re-started. Signed-off-by: Dmitry Bogdanov <d.bogdanov(a)yadro.com> Link: https://lore.kernel.org/r/20241224101757.32300-1-d.bogdanov@yadro.com Reviewed-by: Maurizio Lombardi <mlombard(a)redhat.com> Signed-off-by: Martin K. Petersen <martin.petersen(a)oracle.com> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- drivers/target/iscsi/iscsi_target.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/target/iscsi/iscsi_target.c b/drivers/target/iscsi/iscsi_target.c index 075e2a6fb474f..48fe53323f84c 100644 --- a/drivers/target/iscsi/iscsi_target.c +++ b/drivers/target/iscsi/iscsi_target.c @@ -4168,8 +4168,8 @@ int iscsit_close_connection( spin_unlock(&iscsit_global->ts_bitmap_lock); iscsit_stop_timers_for_cmds(conn); - iscsit_stop_nopin_response_timer(conn); iscsit_stop_nopin_timer(conn); + iscsit_stop_nopin_response_timer(conn); if (conn->conn_transport->iscsit_wait_conn) conn->conn_transport->iscsit_wait_conn(conn); -- 2.39.5

2 months

1
2
0 0

[PATCH AUTOSEL 5.15 1/7] scsi: target: iscsi: Fix timeout on deleted connection

by Sasha Levin

From: Dmitry Bogdanov <d.bogdanov(a)yadro.com> [ Upstream commit 7f533cc5ee4c4436cee51dc58e81dfd9c3384418 ] NOPIN response timer may expire on a deleted connection and crash with such logs: Did not receive response to NOPIN on CID: 0, failing connection for I_T Nexus (null),i,0x00023d000125,iqn.2017-01.com.iscsi.target,t,0x3d BUG: Kernel NULL pointer dereference on read at 0x00000000 NIP strlcpy+0x8/0xb0 LR iscsit_fill_cxn_timeout_err_stats+0x5c/0xc0 [iscsi_target_mod] Call Trace: iscsit_handle_nopin_response_timeout+0xfc/0x120 [iscsi_target_mod] call_timer_fn+0x58/0x1f0 run_timer_softirq+0x740/0x860 __do_softirq+0x16c/0x420 irq_exit+0x188/0x1c0 timer_interrupt+0x184/0x410 That is because nopin response timer may be re-started on nopin timer expiration. Stop nopin timer before stopping the nopin response timer to be sure that no one of them will be re-started. Signed-off-by: Dmitry Bogdanov <d.bogdanov(a)yadro.com> Link: https://lore.kernel.org/r/20241224101757.32300-1-d.bogdanov@yadro.com Reviewed-by: Maurizio Lombardi <mlombard(a)redhat.com> Signed-off-by: Martin K. Petersen <martin.petersen(a)oracle.com> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- drivers/target/iscsi/iscsi_target.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/target/iscsi/iscsi_target.c b/drivers/target/iscsi/iscsi_target.c index 686a9e5918e21..b072718701329 100644 --- a/drivers/target/iscsi/iscsi_target.c +++ b/drivers/target/iscsi/iscsi_target.c @@ -4170,8 +4170,8 @@ int iscsit_close_connection( spin_unlock(&iscsit_global->ts_bitmap_lock); iscsit_stop_timers_for_cmds(conn); - iscsit_stop_nopin_response_timer(conn); iscsit_stop_nopin_timer(conn); + iscsit_stop_nopin_response_timer(conn); if (conn->conn_transport->iscsit_wait_conn) conn->conn_transport->iscsit_wait_conn(conn); -- 2.39.5

2 months

1
6
0 0

+ kasan-avoid-sleepable-page-allocation-from-atomic-context.patch added to mm-hotfixes-unstable branch

by Andrew Morton

The patch titled Subject: kasan: avoid sleepable page allocation from atomic context has been added to the -mm mm-hotfixes-unstable branch. Its filename is kasan-avoid-sleepable-page-allocation-from-atomic-context.patch This patch will shortly appear at https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patche… This patch will later appear in the mm-hotfixes-unstable branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next via the mm-everything branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm and is updated there every 2-3 working days ------------------------------------------------------ From: Alexander Gordeev <agordeev(a)linux.ibm.com> Subject: kasan: avoid sleepable page allocation from atomic context Date: Tue, 29 Apr 2025 18:08:41 +0200 apply_to_pte_range() enters the lazy MMU mode and then invokes kasan_populate_vmalloc_pte() callback on each page table walk iteration. However, the callback can go into sleep when trying to allocate a single page, e.g. if an architecutre disables preemption on lazy MMU mode enter. On s390 with the call sequences arch_enter_lazy_mmu_mode() -> preempt_enable() and arch_leave_lazy_mmu_mode() -> preempt_disable(), such a crash occurs: [ 553.332108] preempt_count: 1, expected: 0 [ 553.332117] no locks held by multipathd/2116. [ 553.332128] CPU: 24 PID: 2116 Comm: multipathd Kdump: loaded Tainted: [ 553.332139] Hardware name: IBM 3931 A01 701 (LPAR) [ 553.332146] Call Trace: [ 553.332152] [<00000000158de23a>] dump_stack_lvl+0xfa/0x150 [ 553.332167] [<0000000013e10d12>] __might_resched+0x57a/0x5e8 [ 553.332178] [<00000000144eb6c2>] __alloc_pages+0x2ba/0x7c0 [ 553.332189] [<00000000144d5cdc>] __get_free_pages+0x2c/0x88 [ 553.332198] [<00000000145663f6>] kasan_populate_vmalloc_pte+0x4e/0x110 [ 553.332207] [<000000001447625c>] apply_to_pte_range+0x164/0x3c8 [ 553.332218] [<000000001448125a>] apply_to_pmd_range+0xda/0x318 [ 553.332226] [<000000001448181c>] __apply_to_page_range+0x384/0x768 [ 553.332233] [<0000000014481c28>] apply_to_page_range+0x28/0x38 [ 553.332241] [<00000000145665da>] kasan_populate_vmalloc+0x82/0x98 [ 553.332249] [<00000000144c88d0>] alloc_vmap_area+0x590/0x1c90 [ 553.332257] [<00000000144ca108>] __get_vm_area_node.constprop.0+0x138/0x260 [ 553.332265] [<00000000144d17fc>] __vmalloc_node_range+0x134/0x360 [ 553.332274] [<0000000013d5dbf2>] alloc_thread_stack_node+0x112/0x378 [ 553.332284] [<0000000013d62726>] dup_task_struct+0x66/0x430 [ 553.332293] [<0000000013d63962>] copy_process+0x432/0x4b80 [ 553.332302] [<0000000013d68300>] kernel_clone+0xf0/0x7d0 [ 553.332311] [<0000000013d68bd6>] __do_sys_clone+0xae/0xc8 [ 553.332400] [<0000000013d68dee>] __s390x_sys_clone+0xd6/0x118 [ 553.332410] [<0000000013c9d34c>] do_syscall+0x22c/0x328 [ 553.332419] [<00000000158e7366>] __do_syscall+0xce/0xf0 [ 553.332428] [<0000000015913260>] system_call+0x70/0x98 Instead of allocating single pages per-PTE, bulk-allocate the shadow memory prior to applying kasan_populate_vmalloc_pte() callback on a page range. Link: https://lkml.kernel.org/r/573a823565734e1eac3aa128fb9d3506ec918a72.17459408… Fixes: 3c5c3cfb9ef4 ("kasan: support backing vmalloc space with real shadow memory") Signed-off-by: Alexander Gordeev <agordeev(a)linux.ibm.com> Suggested-by: Andrey Ryabinin <ryabinin.a.a(a)gmail.com> Cc: Alexander Gordeev <agordeev(a)linux.ibm.com> Cc: Daniel Axtens <dja(a)axtens.net> Cc: Alexander Potapenko <glider(a)google.com> Cc: Andrey Konovalov <andreyknvl(a)gmail.com> Cc: Dmitry Vyukov <dvyukov(a)google.com> Cc: Vincenzo Frascino <vincenzo.frascino(a)arm.com> Cc: <stable(a)vger.kernel.org> Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> --- mm/kasan/shadow.c | 65 +++++++++++++++++++++++++++++++++----------- 1 file changed, 49 insertions(+), 16 deletions(-) --- a/mm/kasan/shadow.c~kasan-avoid-sleepable-page-allocation-from-atomic-context +++ a/mm/kasan/shadow.c @@ -292,30 +292,65 @@ void __init __weak kasan_populate_early_ { } +struct vmalloc_populate_data { + unsigned long start; + struct page **pages; +}; + static int kasan_populate_vmalloc_pte(pte_t *ptep, unsigned long addr, - void *unused) + void *_data) { - unsigned long page; + struct vmalloc_populate_data *data = _data; + struct page *page; + unsigned long pfn; pte_t pte; if (likely(!pte_none(ptep_get(ptep)))) return 0; - page = __get_free_page(GFP_KERNEL); - if (!page) - return -ENOMEM; - - __memset((void *)page, KASAN_VMALLOC_INVALID, PAGE_SIZE); - pte = pfn_pte(PFN_DOWN(__pa(page)), PAGE_KERNEL); + page = data->pages[PFN_DOWN(addr - data->start)]; + pfn = page_to_pfn(page); + __memset(pfn_to_virt(pfn), KASAN_VMALLOC_INVALID, PAGE_SIZE); + pte = pfn_pte(pfn, PAGE_KERNEL); spin_lock(&init_mm.page_table_lock); - if (likely(pte_none(ptep_get(ptep)))) { + if (likely(pte_none(ptep_get(ptep)))) set_pte_at(&init_mm, addr, ptep, pte); - page = 0; - } spin_unlock(&init_mm.page_table_lock); - if (page) - free_page(page); + + return 0; +} + +static int __kasan_populate_vmalloc(unsigned long start, unsigned long end) +{ + unsigned long nr_pages, nr_total = PFN_UP(end - start); + struct vmalloc_populate_data data; + int ret; + + data.pages = (struct page **)__get_free_page(GFP_KERNEL); + if (!data.pages) + return -ENOMEM; + + while (nr_total) { + nr_pages = min(nr_total, PAGE_SIZE / sizeof(data.pages[0])); + __memset(data.pages, 0, nr_pages * sizeof(data.pages[0])); + if (nr_pages != alloc_pages_bulk(GFP_KERNEL, nr_pages, data.pages)) { + free_page((unsigned long)data.pages); + return -ENOMEM; + } + + data.start = start; + ret = apply_to_page_range(&init_mm, start, nr_pages * PAGE_SIZE, + kasan_populate_vmalloc_pte, &data); + if (ret) + return ret; + + start += nr_pages * PAGE_SIZE; + nr_total -= nr_pages; + } + + free_page((unsigned long)data.pages); + return 0; } @@ -348,9 +383,7 @@ int kasan_populate_vmalloc(unsigned long shadow_start = PAGE_ALIGN_DOWN(shadow_start); shadow_end = PAGE_ALIGN(shadow_end); - ret = apply_to_page_range(&init_mm, shadow_start, - shadow_end - shadow_start, - kasan_populate_vmalloc_pte, NULL); + ret = __kasan_populate_vmalloc(shadow_start, shadow_end); if (ret) return ret; _ Patches currently in -mm which might be from agordeev(a)linux.ibm.com are kasan-avoid-sleepable-page-allocation-from-atomic-context.patch

2 months

1
0
0 0

[PATCH v2] nvmem: zynqmp_nvmem: unbreak driver after cleanup

by Peter Korsgaard

Commit 29be47fcd6a0 ("nvmem: zynqmp_nvmem: zynqmp_nvmem_probe cleanup") changed the driver to expect the device pointer to be passed as the "context", but in nvmem the context parameter comes from nvmem_config.priv which is never set - Leading to null pointer exceptions when the device is accessed. Fixes: 29be47fcd6a0 ("nvmem: zynqmp_nvmem: zynqmp_nvmem_probe cleanup") Cc: stable(a)vger.kernel.org Signed-off-by: Peter Korsgaard <peter(a)korsgaard.com> --- Changes since v1: - Cc stable drivers/nvmem/zynqmp_nvmem.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/nvmem/zynqmp_nvmem.c b/drivers/nvmem/zynqmp_nvmem.c index 8682adaacd692..7da717d6c7faf 100644 --- a/drivers/nvmem/zynqmp_nvmem.c +++ b/drivers/nvmem/zynqmp_nvmem.c @@ -213,6 +213,7 @@ static int zynqmp_nvmem_probe(struct platform_device *pdev) econfig.word_size = 1; econfig.size = ZYNQMP_NVMEM_SIZE; econfig.dev = dev; + econfig.priv = dev; econfig.add_legacy_fixed_of_cells = true; econfig.reg_read = zynqmp_nvmem_read; econfig.reg_write = zynqmp_nvmem_write; -- 2.39.5

2 months

3
2
0 0

[PATCH v3] net: mdio: mux-meson-gxl: set reversed bit when using internal phy

by Da Xue

This bit is necessary to receive packets from the internal PHY. Without this bit set, no activity occurs on the interface. Normally u-boot sets this bit, but if u-boot is compiled without net support, the interface will be up but without any activity. The vendor SDK sets this bit along with the PHY_ID bits. Fixes: 9a24e1ff4326 ("net: mdio: add amlogic gxl mdio mux support"); Signed-off-by: Da Xue <da(a)libre.computer> --- Changes since v2: * Rename REG2_RESERVED_28 to REG2_REVERSED Link to v2: https://patchwork.kernel.org/project/linux-amlogic/patch/20250331074420.344… --- drivers/net/mdio/mdio-mux-meson-gxl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/mdio/mdio-mux-meson-gxl.c b/drivers/net/mdio/mdio-mux-meson-gxl.c index 00c66240136b..3dd12a8c8b03 100644 --- a/drivers/net/mdio/mdio-mux-meson-gxl.c +++ b/drivers/net/mdio/mdio-mux-meson-gxl.c @@ -17,6 +17,7 @@ #define REG2_LEDACT GENMASK(23, 22) #define REG2_LEDLINK GENMASK(25, 24) #define REG2_DIV4SEL BIT(27) +#define REG2_REVERSED BIT(28) #define REG2_ADCBYPASS BIT(30) #define REG2_CLKINSEL BIT(31) #define ETH_REG3 0x4 @@ -65,7 +66,7 @@ static void gxl_enable_internal_mdio(struct gxl_mdio_mux *priv) * The only constraint is that it must match the one in * drivers/net/phy/meson-gxl.c to properly match the PHY. */ - writel(FIELD_PREP(REG2_PHYID, EPHY_GXL_ID), + writel(REG2_REVERSED | FIELD_PREP(REG2_PHYID, EPHY_GXL_ID), priv->regs + ETH_REG2); /* Enable the internal phy */ -- 2.39.5

2 months

6
5
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror April 2025