- Linux-stable-mirror - lists.linaro.org

[PATCH] x86/speculation: Revert turning on STIBP all the time

by Tim Chen

Commit 53c613fe "x86/speculation: Enable cross-hyperthread spectre v2 STIBP mitigation" turns on STIBP all the time. This causes large performance regression in many workloads. One case is perlbench in the SpecInt Rate 2006 test suite which shows a 21% reduction in throughput. There're also other reports of drop in performance on Python and PHP benchmarks: https://www.phoronix.com/scan.php?page=article&item=linux-420-bisect&num=2 STIBP on all the time should not be the default option. Turn off STIBP all the time for now till STIBP can be applied on a per task basis. Signed-off-by: Tim Chen <tim.c.chen(a)linux.intel.com> --- arch/x86/kernel/cpu/bugs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kernel/cpu/bugs.c b/arch/x86/kernel/cpu/bugs.c index c37e66e..21a8f39 100644 --- a/arch/x86/kernel/cpu/bugs.c +++ b/arch/x86/kernel/cpu/bugs.c @@ -332,7 +332,7 @@ static bool stibp_needed(void) if (!boot_cpu_has(X86_FEATURE_STIBP)) return false; - return true; + return false; } static void update_stibp_msr(void *info) -- 2.9.4

6 years, 11 months

4
3
0 0

[PATCH 3.18 00/90] 3.18.126-stable review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 3.18.126 release. There are 90 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Wed Nov 21 16:25:28 UTC 2018. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v3.x/stable-review/patch-3.18.126-r… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-3.18.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 3.18.126-rc1 Mike Kravetz <mike.kravetz(a)oracle.com> hugetlbfs: fix kernel BUG at fs/hugetlbfs/inode.c:444! Guenter Roeck <linux(a)roeck-us.net> configfs: replace strncpy with memcpy Miklos Szeredi <mszeredi(a)redhat.com> fuse: fix leaked notify reply Frank Sorenson <sorenson(a)redhat.com> sunrpc: correct the computation for page_ptr when truncating Eric W. Biederman <ebiederm(a)xmission.com> mount: Prevent MNT_DETACH from disconnecting locked mounts Eric W. Biederman <ebiederm(a)xmission.com> mount: Don't allow copying MNT_UNBINDABLE|MNT_LOCKED mounts Eric W. Biederman <ebiederm(a)xmission.com> mount: Retest MNT_LOCKED in do_umount Vasily Averin <vvs(a)virtuozzo.com> ext4: fix buffer leak in __ext4_read_dirblock() on error path Vasily Averin <vvs(a)virtuozzo.com> ext4: fix buffer leak in ext4_xattr_move_to_block() on error path Vasily Averin <vvs(a)virtuozzo.com> ext4: release bs.bh before re-using in ext4_xattr_block_find() Theodore Ts'o <tytso(a)mit.edu> ext4: fix possible leak of sbi->s_group_desc_leak in error path Theodore Ts'o <tytso(a)mit.edu> ext4: avoid possible double brelse() in add_new_gdb() on error path Vasily Averin <vvs(a)virtuozzo.com> ext4: fix missing cleanup if ext4_alloc_flex_bg_array() fails while resizing Vasily Averin <vvs(a)virtuozzo.com> ext4: avoid buffer leak in ext4_orphan_add() after prior errors Vasily Averin <vvs(a)virtuozzo.com> ext4: fix possible inode leak in the retry loop of ext4_resize_fs() Vasily Averin <vvs(a)virtuozzo.com> ext4: avoid potential extra brelse in setup_new_flex_group_blocks() Vasily Averin <vvs(a)virtuozzo.com> ext4: add missing brelse() add_new_gdb_meta_bg()'s error path Vasily Averin <vvs(a)virtuozzo.com> ext4: add missing brelse() in set_flexbg_block_bitmap()'s error path Vasily Averin <vvs(a)virtuozzo.com> ext4: add missing brelse() update_backups()'s error path H. Peter Anvin (Intel) <hpa(a)zytor.com> arch/alpha, termios: implement BOTHER, IBSHIFT and termios2 H. Peter Anvin <hpa(a)zytor.com> termios, tty/tty_baudrate.c: fix buffer overrun Arnd Bergmann <arnd(a)arndb.de> mtd: docg3: don't set conflicting BCH_CONST_PARAMS option Changwei Ge <ge.changwei(a)h3c.com> ocfs2: fix a misuse a of brelse after failing ocfs2_check_dir_entry Mikulas Patocka <mpatocka(a)redhat.com> mach64: fix image corruption due to reading accelerator registers Mikulas Patocka <mpatocka(a)redhat.com> mach64: fix display corruption on big endian machines Ilya Dryomov <idryomov(a)gmail.com> libceph: bump CEPH_MSG_MAX_DATA_LEN Krzysztof Kozlowski <krzk(a)kernel.org> clk: s2mps11: Fix matching when built as module and DT node contains compatible Max Filippov <jcmvbkbc(a)gmail.com> xtensa: fix boot parameters address translation Young_X <YangX92(a)hotmail.com> cdrom: fix improper type cast, which can leat to information leak. Dominique Martinet <dominique.martinet(a)cea.fr> 9p: clear dangling pointers in p9stat_free Marco Felsch <m.felsch(a)pengutronix.de> media: tvp5150: fix width alignment during set_selection() Joel Stanley <joel(a)jms.id.au> powerpc/boot: Ensure _zimage_start is a weak symbol Dengcheng Zhu <dzhu(a)wavecomp.com> MIPS: kexec: Mark CPU offline before disabling local IRQ Nicholas Mc Guire <hofrat(a)osadl.org> media: pci: cx23885: handle adding to list failure Tomi Valkeinen <tomi.valkeinen(a)ti.com> drm/omap: fix memory barrier bug in DMM driver Daniel Axtens <dja(a)axtens.net> powerpc/nohash: fix undefined behaviour when testing page size support Miles Chen <miles.chen(a)mediatek.com> tty: check name length in tty_find_polling_driver() Corey Wright <undefined(a)pobox.com> dm: remove duplicate dm_get_live_table() in __dm_destroy() Nicolas Pitre <nicolas.pitre(a)linaro.org> Cramfs: fix abad comparison when wrap-arounds occur Mauro Carvalho Chehab <mchehab+samsung(a)kernel.org> media: em28xx: make v4l2-compliance happier by starting sequence on zero Mauro Carvalho Chehab <mchehab+samsung(a)kernel.org> media: em28xx: fix input name for Terratec AV 350 Mauro Carvalho Chehab <mchehab+samsung(a)kernel.org> media: em28xx: use a default format if TRY_FMT fails He Zhe <zhe.he(a)windriver.com> kgdboc: Passing ekgdboc to command line causes panic Maciej W. Rozycki <macro(a)linux-mips.org> TC: Set DMA masks for devices Wenwen Wang <wang6495(a)umn.edu> dm ioctl: harden copy_params()'s copy_from_user() from malicious users Amir Goldstein <amir73il(a)gmail.com> lockd: fix access beyond unterminated strings in prints Trond Myklebust <trondmy(a)gmail.com> nfsd: Fix an Oops in free_session() Trond Myklebust <trond.myklebust(a)hammerspace.com> NFSv4.1: Fix the r/wsize checking He Zhe <zhe.he(a)windriver.com> printk: Fix panic caused by passing log_buf_len to command line Steve French <stfrench(a)microsoft.com> smb3: on kerberos mount if server doesn't specify auth type use krb5 Steve French <stfrench(a)microsoft.com> smb3: do not attempt cifs operation in smb3 query info error path Steve French <stfrench(a)microsoft.com> smb3: allow stats which track session and share reconnects to be reset Andreas Kemnade <andreas(a)kemnade.info> w1: omap-hdq: fix missing bus unregister at removal Eugen Hristev <eugen.hristev(a)microchip.com> iio: adc: at91: fix wrong channel number in triggered buffer mode Eugen Hristev <eugen.hristev(a)microchip.com> iio: adc: at91: fix acking DRDY irq on simple conversions Arnd Bergmann <arnd(a)arndb.de> kbuild: fix kernel/bounds.c 'W=1' warning Eric Biggers <ebiggers(a)google.com> ima: fix showing large 'violations' or 'runtime_measurements_count' Ondrej Mosnacek <omosnace(a)redhat.com> crypto: lrw - Fix out-of bounds access on counter overflow Eric W. Biederman <ebiederm(a)xmission.com> signal/GenWQE: Fix sending of SIGKILL Lukas Czerner <lczerner(a)redhat.com> ext4: initialize retries variable in ext4_da_write_inline_data_begin() Al Viro <viro(a)zeniv.linux.org.uk> gfs2_meta: ->mount() can get NULL dev_name Jan Kara <jack(a)suse.cz> jbd2: fix use after free in jbd2_log_do_checkpoint() Stefan Nuernberger <snu(a)amazon.com> net/ipv4: defensive cipso option parsing Eric W. Biederman <ebiederm(a)xmission.com> signal: Always deliver the kernel's SIGKILL and SIGSTOP to a pid namespace init James Smart <jsmart2021(a)gmail.com> scsi: lpfc: Correct soft lockup when running mds diagnostics Alexandre Belloni <alexandre.belloni(a)bootlin.com> uio: ensure class is registered before devices Loic Poulain <loic.poulain(a)linaro.org> usb: chipidea: Prevent unbalanced IRQ disable Theodore Ts'o <tytso(a)mit.edu> ext4: fix argument checking in EXT4_IOC_MOVE_EXT Finn Thain <fthain(a)telegraphics.com.au> scsi: esp_scsi: Track residual for PIO transfers Martin Willi <martin(a)strongswan.org> ath10k: schedule hardware restart if WMI command times out Masami Hiramatsu <mhiramat(a)kernel.org> kprobes: Return error if we fail to reuse kprobe instead of BUG_ON() Ben Hutchings <ben(a)decadent.org.uk> x86: boot: Fix EFI stub alignment Lubomir Rintel <lkundrak(a)v3.sk> x86/olpc: Indicate that legacy PC XO-1 platform should not register RTC Yu Zhao <yuzhao(a)google.com> mmc: sdhci-pci-o2micro: Add quirk for O2 Micro dev 0x8620 rev 0x01 Prarit Bhargava <prarit(a)redhat.com> cpupower: Fix coredump on VMWare Sanskriti Sharma <sansharm(a)redhat.com> perf tools: Cleanup trace-event-info 'tdata' leak Sanskriti Sharma <sansharm(a)redhat.com> perf tools: Free temporary 'sys' string in read_event_files() Serhey Popovych <serhe.popovych(a)gmail.com> tun: Consistently configure generic netdev params via rtnetlink Omar Sandoval <osandov(a)fb.com> swim: fix cleanup on setup error Omar Sandoval <osandov(a)fb.com> ataflop: fix error handling during setup Waiman Long <longman(a)redhat.com> locking/lockdep: Fix debug_locks off performance problem Masami Hiramatsu <mhiramat(a)kernel.org> selftests: ftrace: Add synthetic event syntax testcase Nathan Chancellor <natechancellor(a)gmail.com> net: qla3xxx: Remove overflowing shift statement David S. Miller <davem(a)davemloft.net> sparc: Throttle perf events properly. David S. Miller <davem(a)davemloft.net> sparc: Fix single-pcr perf event counter management. He Zhe <zhe.he(a)windriver.com> x86/corruption-check: Fix panic in memory_corruption_check() when boot option without value is provided Alex Stanoev <alex(a)astanoev.com> ALSA: ca0106: Disable IZD on SB0570 DAC to fix audio pops Maciej S. Szmigiero <mail(a)maciej.szmigiero.name> pcmcia: Implement CLKRUN protocol disabling for Ricoh bridges Hou Tao <houtao1(a)huawei.com> jffs2: free jffs2_sb_info through jffs2_kill_sb() Tang Junhui <tang.junhui.linux(a)gmail.com> bcache: fix miss key refill->end in writeback ------------- Diffstat: Makefile | 4 +- arch/alpha/include/asm/termios.h | 8 ++- arch/alpha/include/uapi/asm/ioctls.h | 5 ++ arch/alpha/include/uapi/asm/termbits.h | 17 +++++ arch/mips/kernel/crash.c | 3 + arch/mips/kernel/machine_kexec.c | 3 + arch/powerpc/boot/crt0.S | 4 +- arch/powerpc/mm/tlb_nohash.c | 3 + arch/sparc/kernel/perf_event.c | 26 +++++-- arch/x86/boot/tools/build.c | 7 ++ arch/x86/kernel/check.c | 15 ++++ arch/x86/platform/olpc/olpc-xo1-rtc.c | 3 + arch/xtensa/kernel/head.S | 7 +- crypto/lrw.c | 7 +- drivers/block/ataflop.c | 25 ++++--- drivers/block/swim.c | 13 +++- drivers/cdrom/cdrom.c | 2 +- drivers/clk/clk-s2mps11.c | 30 ++++++++ drivers/gpu/drm/omapdrm/omap_dmm_tiler.c | 11 +++ drivers/iio/adc/at91_adc.c | 6 +- drivers/md/bcache/btree.c | 2 +- drivers/md/dm-ioctl.c | 18 ++--- drivers/md/dm.c | 1 - drivers/media/i2c/tvp5150.c | 14 ++-- drivers/media/pci/cx23885/altera-ci.c | 10 +++ drivers/media/usb/em28xx/em28xx-cards.c | 4 +- drivers/media/usb/em28xx/em28xx-video.c | 8 ++- drivers/misc/genwqe/card_base.h | 2 +- drivers/misc/genwqe/card_dev.c | 9 +-- drivers/mmc/host/sdhci-pci-o2micro.c | 3 + drivers/mtd/devices/Kconfig | 2 +- drivers/net/ethernet/qlogic/qla3xxx.c | 2 - drivers/net/tun.c | 2 + drivers/net/wireless/ath/ath10k/wmi.c | 6 ++ drivers/pcmcia/ricoh.h | 35 ++++++++++ drivers/pcmcia/yenta_socket.c | 3 +- drivers/scsi/esp_scsi.c | 1 + drivers/scsi/esp_scsi.h | 2 + drivers/scsi/lpfc/lpfc_sli.c | 7 ++ drivers/scsi/mac_esp.c | 2 + drivers/tc/tc.c | 8 ++- drivers/tty/serial/kgdboc.c | 5 ++ drivers/tty/tty_io.c | 2 +- drivers/tty/tty_ioctl.c | 4 +- drivers/uio/uio.c | 9 +++ drivers/usb/chipidea/otg.h | 3 +- drivers/video/fbdev/aty/mach64_accel.c | 28 ++++---- drivers/w1/masters/omap_hdq.c | 2 + fs/cifs/cifs_debug.c | 3 + fs/cifs/cifs_spnego.c | 6 +- fs/cifs/inode.c | 10 ++- fs/configfs/symlink.c | 2 +- fs/cramfs/inode.c | 3 +- fs/ext4/inline.c | 2 +- fs/ext4/move_extent.c | 8 ++- fs/ext4/namei.c | 5 +- fs/ext4/resize.c | 28 ++++---- fs/ext4/super.c | 16 ++--- fs/ext4/xattr.c | 4 ++ fs/fuse/dev.c | 4 +- fs/gfs2/ops_fstype.c | 3 + fs/jbd2/checkpoint.c | 4 +- fs/jffs2/super.c | 4 +- fs/lockd/host.c | 2 +- fs/namespace.c | 22 ++++-- fs/nfs/nfs4client.c | 16 +++-- fs/ocfs2/dir.c | 3 +- include/linux/ceph/libceph.h | 8 ++- include/linux/tc.h | 1 + kernel/bounds.c | 4 +- kernel/kprobes.c | 27 ++++++-- kernel/locking/lockdep.c | 4 +- kernel/printk/printk.c | 7 +- kernel/signal.c | 2 +- lib/debug_locks.c | 2 +- mm/hugetlb.c | 23 +++++-- net/9p/protocol.c | 5 ++ net/ipv4/cipso_ipv4.c | 11 +-- net/sunrpc/svc_xprt.c | 2 +- net/sunrpc/xdr.c | 5 +- security/integrity/ima/ima_fs.c | 6 +- sound/pci/ca0106/ca0106.h | 2 +- tools/perf/util/trace-event-info.c | 2 + tools/perf/util/trace-event-read.c | 5 +- tools/power/cpupower/utils/cpufreq-info.c | 2 + tools/power/cpupower/utils/helpers/amd.c | 5 ++ .../inter-event/trigger-synthetic-event-syntax.tc | 80 ++++++++++++++++++++++ 87 files changed, 581 insertions(+), 160 deletions(-)

6 years, 11 months

5
101
0 0

stable-rc/linux-4.14.y boot: 92 boots: 0 failed, 89 passed with 3 offline (v4.14.82-22-gaa2838d50dfb)

by kernelci.org bot

stable-rc/linux-4.14.y boot: 92 boots: 0 failed, 89 passed with 3 offline (v4.14.82-22-gaa2838d50dfb) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-4.14.y/kernel/v4.1… Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-4.14.y/kernel/v4.14.82-22… Tree: stable-rc Branch: linux-4.14.y Git Describe: v4.14.82-22-gaa2838d50dfb Git Commit: aa2838d50dfbecf82e5ba9e1013d3057c54590b2 Git URL: http://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Tested: 53 unique boards, 21 SoC families, 15 builds out of 197 Offline Platforms: arm: multi_v7_defconfig: stih410-b2120: 1 offline lab arm64: defconfig: meson-gxl-s905d-p230: 1 offline lab meson-gxl-s905x-p212: 1 offline lab --- For more info write to <info(a)kernelci.org>

6 years, 11 months

1
0
0 0

stable-rc/linux-4.19.y boot: 96 boots: 0 failed, 93 passed with 3 offline (v4.19.3-43-g2b8db8734888)

by kernelci.org bot

stable-rc/linux-4.19.y boot: 96 boots: 0 failed, 93 passed with 3 offline (v4.19.3-43-g2b8db8734888) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-4.19.y/kernel/v4.1… Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-4.19.y/kernel/v4.19.3-43-… Tree: stable-rc Branch: linux-4.19.y Git Describe: v4.19.3-43-g2b8db8734888 Git Commit: 2b8db8734888b00156c6afb235eda91aa71da503 Git URL: http://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Tested: 55 unique boards, 21 SoC families, 15 builds out of 198 Offline Platforms: arm: multi_v7_defconfig: stih410-b2120: 1 offline lab arm64: defconfig: meson-gxl-s905d-p230: 1 offline lab meson-gxl-s905x-p212: 1 offline lab --- For more info write to <info(a)kernelci.org>

6 years, 11 months

1
0
0 0

+ mm-use-swp_offset-as-key-in-shmem_replace_page.patch added to -mm tree

by akpm＠linux-foundation.org

The patch titled Subject: mm: use swp_offset as key in shmem_replace_page() has been added to the -mm tree. Its filename is mm-use-swp_offset-as-key-in-shmem_replace_page.patch This patch should soon appear at http://ozlabs.org/~akpm/mmots/broken-out/mm-use-swp_offset-as-key-in-shmem_… and later at http://ozlabs.org/~akpm/mmotm/broken-out/mm-use-swp_offset-as-key-in-shmem_… Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Yu Zhao <yuzhao(a)google.com> Subject: mm: use swp_offset as key in shmem_replace_page() We changed the key of swap cache tree from swp_entry_t.val to swp_offset. We need to do so in shmem_replace_page() as well. Link: http://lkml.kernel.org/r/20181121215442.138545-1-yuzhao@google.com Fixes: f6ab1f7f6b2d ("mm, swap: use offset of swap entry as key of swap cache") Signed-off-by: Yu Zhao <yuzhao(a)google.com> Reviewed-by: Matthew Wilcox <willy(a)infradead.org> Acked-by: Hugh Dickins <hughd(a)google.com> Cc: <stable(a)vger.kernel.org> [4.9+] Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> --- --- a/mm/shmem.c~mm-use-swp_offset-as-key-in-shmem_replace_page +++ a/mm/shmem.c @@ -1509,11 +1509,13 @@ static int shmem_replace_page(struct pag { struct page *oldpage, *newpage; struct address_space *swap_mapping; + swp_entry_t entry; pgoff_t swap_index; int error; oldpage = *pagep; - swap_index = page_private(oldpage); + entry.val = page_private(oldpage); + swap_index = swp_offset(entry); swap_mapping = page_mapping(oldpage); /* @@ -1532,7 +1534,7 @@ static int shmem_replace_page(struct pag __SetPageLocked(newpage); __SetPageSwapBacked(newpage); SetPageUptodate(newpage); - set_page_private(newpage, swap_index); + set_page_private(newpage, entry.val); SetPageSwapCache(newpage); /* _ Patches currently in -mm which might be from yuzhao(a)google.com are mm-use-swp_offset-as-key-in-shmem_replace_page.patch mm-dont-expose-page-to-fast-gup-before-its-ready.patch

6 years, 11 months

1
0
0 0

stable-rc/linux-4.9.y boot: 79 boots: 0 failed, 78 passed with 1 offline (v4.9.138-60-g70b13958eeae)

by kernelci.org bot

stable-rc/linux-4.9.y boot: 79 boots: 0 failed, 78 passed with 1 offline (v4.9.138-60-g70b13958eeae) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-4.9.y/kernel/v4.9.… Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-4.9.y/kernel/v4.9.138-60-… Tree: stable-rc Branch: linux-4.9.y Git Describe: v4.9.138-60-g70b13958eeae Git Commit: 70b13958eeae24843ed944e4f3d4a25a0cdec0dc Git URL: http://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Tested: 42 unique boards, 20 SoC families, 16 builds out of 192 Offline Platforms: arm: multi_v7_defconfig: stih410-b2120: 1 offline lab --- For more info write to <info(a)kernelci.org>

6 years, 11 months

1
0
0 0

[PATCH] drm/ast: fixed reading monitor EDID not stable issue

by Y.C. Chen

From: "Y.C. Chen" <yc_chen(a)aspeedtech.com> over-sample data to increase the stability with some specific monitors Signed-off-by: Y.C. Chen <yc_chen(a)aspeedtech.com> --- drivers/gpu/drm/ast/ast_mode.c | 32 ++++++++++++++++++++++++++------ 1 file changed, 26 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c index 5e77d45..22e80c0 100644 --- a/drivers/gpu/drm/ast/ast_mode.c +++ b/drivers/gpu/drm/ast/ast_mode.c @@ -972,9 +972,19 @@ static int get_clock(void *i2c_priv) { struct ast_i2c_chan *i2c = i2c_priv; struct ast_private *ast = i2c->dev->dev_private; - uint32_t val; + volatile uint32_t val, val2, count; + + count = 0; + val = (ast_get_index_reg_mask(ast, AST_IO_CRTC_PORT, 0xb7, 0x10) >> 4) & 0x01; + do { + val2 = (ast_get_index_reg_mask(ast, AST_IO_CRTC_PORT, 0xb7, 0x10) >> 4) & 0x01; + if (val == val2) count++; + else { + count = 0; + val = (ast_get_index_reg_mask(ast, AST_IO_CRTC_PORT, 0xb7, 0x10) >> 4) & 0x01; + } + } while (count < 5); - val = ast_get_index_reg_mask(ast, AST_IO_CRTC_PORT, 0xb7, 0x10) >> 4; return val & 1 ? 1 : 0; } @@ -982,9 +992,19 @@ static int get_data(void *i2c_priv) { struct ast_i2c_chan *i2c = i2c_priv; struct ast_private *ast = i2c->dev->dev_private; - uint32_t val; + volatile uint32_t val, val2, count; + + count = 0; + val = (ast_get_index_reg_mask(ast, AST_IO_CRTC_PORT, 0xb7, 0x20) >> 5) & 0x01; + do { + val2 = (ast_get_index_reg_mask(ast, AST_IO_CRTC_PORT, 0xb7, 0x20) >> 5) & 0x01; + if (val == val2) count++; + else { + count = 0; + val = (ast_get_index_reg_mask(ast, AST_IO_CRTC_PORT, 0xb7, 0x20) >> 5) & 0x01; + } + } while (count < 5); - val = ast_get_index_reg_mask(ast, AST_IO_CRTC_PORT, 0xb7, 0x20) >> 5; return val & 1 ? 1 : 0; } @@ -997,7 +1017,7 @@ static void set_clock(void *i2c_priv, int clock) for (i = 0; i < 0x10000; i++) { ujcrb7 = ((clock & 0x01) ? 0 : 1); - ast_set_index_reg_mask(ast, AST_IO_CRTC_PORT, 0xb7, 0xfe, ujcrb7); + ast_set_index_reg_mask(ast, AST_IO_CRTC_PORT, 0xb7, 0xf4, ujcrb7); jtemp = ast_get_index_reg_mask(ast, AST_IO_CRTC_PORT, 0xb7, 0x01); if (ujcrb7 == jtemp) break; @@ -1013,7 +1033,7 @@ static void set_data(void *i2c_priv, int data) for (i = 0; i < 0x10000; i++) { ujcrb7 = ((data & 0x01) ? 0 : 1) << 2; - ast_set_index_reg_mask(ast, AST_IO_CRTC_PORT, 0xb7, 0xfb, ujcrb7); + ast_set_index_reg_mask(ast, AST_IO_CRTC_PORT, 0xb7, 0xf1, ujcrb7); jtemp = ast_get_index_reg_mask(ast, AST_IO_CRTC_PORT, 0xb7, 0x04); if (ujcrb7 == jtemp) break; -- 1.8.3.1

6 years, 11 months

3
4
0 0

[PATCH 22/28] perf pmu: Suppress potential format-truncation warning

by Arnaldo Carvalho de Melo

From: Ben Hutchings <ben(a)decadent.org.uk> Depending on which functions are inlined in util/pmu.c, the snprintf() calls in perf_pmu__parse_{scale,unit,per_pkg,snapshot}() might trigger a warning: util/pmu.c: In function 'pmu_aliases': util/pmu.c:178:31: error: '%s' directive output may be truncated writing up to 255 bytes into a region of size between 0 and 4095 [-Werror=format-truncation=] snprintf(path, PATH_MAX, "%s/%s.unit", dir, name); ^~ I found this when trying to build perf from Linux 3.16 with gcc 8. However I can reproduce the problem in mainline if I force __perf_pmu__new_alias() to be inlined. Suppress this by using scnprintf() as has been done elsewhere in perf. Signed-off-by: Ben Hutchings <ben(a)decadent.org.uk> Cc: Alexander Shishkin <alexander.shishkin(a)linux.intel.com> Cc: Jiri Olsa <jolsa(a)redhat.com> Cc: Namhyung Kim <namhyung(a)kernel.org> Cc: Peter Zijlstra <peterz(a)infradead.org> Cc: stable(a)vger.kernel.org Link: http://lkml.kernel.org/r/20181111184524.fux4taownc6ndbx6@decadent.org.uk Signed-off-by: Arnaldo Carvalho de Melo <acme(a)redhat.com> --- tools/perf/util/pmu.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c index 7e49baad304d..7348eea0248f 100644 --- a/tools/perf/util/pmu.c +++ b/tools/perf/util/pmu.c @@ -145,7 +145,7 @@ static int perf_pmu__parse_scale(struct perf_pmu_alias *alias, char *dir, char * int fd, ret = -1; char path[PATH_MAX]; - snprintf(path, PATH_MAX, "%s/%s.scale", dir, name); + scnprintf(path, PATH_MAX, "%s/%s.scale", dir, name); fd = open(path, O_RDONLY); if (fd == -1) @@ -175,7 +175,7 @@ static int perf_pmu__parse_unit(struct perf_pmu_alias *alias, char *dir, char *n ssize_t sret; int fd; - snprintf(path, PATH_MAX, "%s/%s.unit", dir, name); + scnprintf(path, PATH_MAX, "%s/%s.unit", dir, name); fd = open(path, O_RDONLY); if (fd == -1) @@ -205,7 +205,7 @@ perf_pmu__parse_per_pkg(struct perf_pmu_alias *alias, char *dir, char *name) char path[PATH_MAX]; int fd; - snprintf(path, PATH_MAX, "%s/%s.per-pkg", dir, name); + scnprintf(path, PATH_MAX, "%s/%s.per-pkg", dir, name); fd = open(path, O_RDONLY); if (fd == -1) @@ -223,7 +223,7 @@ static int perf_pmu__parse_snapshot(struct perf_pmu_alias *alias, char path[PATH_MAX]; int fd; - snprintf(path, PATH_MAX, "%s/%s.snapshot", dir, name); + scnprintf(path, PATH_MAX, "%s/%s.snapshot", dir, name); fd = open(path, O_RDONLY); if (fd == -1) -- 2.14.5

6 years, 11 months

1
0
0 0

Re: [[PATCH v2]] drm/ast: fixed reading monitor EDID not stable issue

by Dave Airlie

On Thu, 22 Nov 2018 at 11:42, 陳雅正 <yacheng600221(a)gmail.com> wrote: > > Hi Dave, > Thanks for your feedback. No issue found actually if I remove "volatile" on my platform. In my experience, if the value is volatile, adding "volatile" will be safer and no harm, that is why I add it by default. If you think it is not necessary, it's ok for me to remove it. > Don't add it unless you've got proof you need it, we don't want it confusing people later. Dave.

6 years, 11 months

1
0
0 0

v4.14.82 build: 0 failures 0 warnings (v4.14.82)

by Build bot for Mark Brown

Tree/Branch: v4.14.82 Git describe: v4.14.82 Commit: a21f3c11b4 Linux 4.14.82 Build Time: 112 min 22 sec Passed: 11 / 11 (100.00 %) Failed: 0 / 11 ( 0.00 %) Errors: 0 Warnings: 0 Section Mismatches: 0 ------------------------------------------------------------------------------- defconfigs with issues (other than build errors): ------------------------------------------------------------------------------- =============================================================================== Detailed per-defconfig build reports below: ------------------------------------------------------------------------------- Passed with no errors, warnings or mismatches: arm64-allnoconfig arm64-allmodconfig arm-multi_v5_defconfig arm-multi_v7_defconfig x86_64-defconfig arm-allmodconfig arm-allnoconfig x86_64-allnoconfig arm-multi_v4t_defconfig x86_64-allmodconfig arm64-defconfig close failed in file object destructor: sys.excepthook is missing lost sys.stderr

6 years, 11 months

1
0
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror