- Linux-stable-mirror - lists.linaro.org

[REGRESSION] stable-rc/linux-6.6.y: (build) incompatible function pointer types initializing 'int (*)(struct i...

by KernelCI bot

Hello, New build issue found on stable-rc/linux-6.6.y: --- incompatible function pointer types initializing 'int (*)(struct iommu_domain *, unsigned long, size_t)' (aka 'int (*)(struct iommu_domain *, unsigned long, unsigned int)') with an expression of type 'void (struct iommu_domain *, unsigned long, size_t)' (aka 'void (struct iommu_domain *, unsigned long, unsigned int)') [-Wincompatible-function-pointer-types] in drivers/iommu/tegra-gart.o (drivers/iommu/tegra-gart.c) [logspec:kbuild,kbuild.compiler.error] --- - dashboard: https://d.kernelci.org/i/maestro:387fac999fdadaaca0ca80ad07047ef2d702c09a - giturl: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git - commit HEAD: b5872ed076bddad62df34a0ff4cbe4bbdfe45a67 Log excerpt: ===================================================== drivers/iommu/tegra-gart.c:281:21: error: incompatible function pointer types initializing 'int (*)(struct iommu_domain *, unsigned long, size_t)' (aka 'int (*)(struct iommu_domain *, unsigned long, unsigned int)') with an expression of type 'void (struct iommu_domain *, unsigned long, size_t)' (aka 'void (struct iommu_domain *, unsigned long, unsigned int)') [-Wincompatible-function-pointer-types] 281 | .iotlb_sync_map = gart_iommu_sync_map, | ^~~~~~~~~~~~~~~~~~~ 1 error generated. ===================================================== # Builds where the incident occurred: ## defconfig+allmodconfig+CONFIG_FRAME_WARN=2048 on (arm): - compiler: clang-17 - dashboard: https://d.kernelci.org/build/maestro:686d4a9e34612746bbb52198 #kernelci issue maestro:387fac999fdadaaca0ca80ad07047ef2d702c09a Reported-by: kernelci.org bot <bot(a)kernelci.org> -- This is an experimental report format. Please send feedback in! Talk to us at kernelci(a)lists.linux.dev Made with love by the KernelCI team - https://kernelci.org

3 days, 20 hours

1
0
0 0

[REGRESSION] stable-rc/linux-6.1.y: (build) undefined reference to `cpu_show_tsa' in drivers/base/cpu (drivers...

by KernelCI bot

Hello, New build issue found on stable-rc/linux-6.1.y: --- undefined reference to `cpu_show_tsa' in drivers/base/cpu (drivers/base/cpu.c) [logspec:kbuild,kbuild.compiler.linker_error] --- - dashboard: https://d.kernelci.org/i/maestro:634dca9c0041633c75d4d5ce3cb61da4d05029f1 - giturl: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git - commit HEAD: 16a0c0f862e842e4269c2142fabfece05c2380b1 Log excerpt: ===================================================== arm-linux-gnueabihf-ld: drivers/base/cpu.o: in function `.LANCHOR2': cpu.c:(.data+0xc0): undefined reference to `cpu_show_tsa' ===================================================== # Builds where the incident occurred: ## multi_v7_defconfig on (arm): - compiler: gcc-12 - dashboard: https://d.kernelci.org/build/maestro:686d53f934612746bbb53f15 ## multi_v7_defconfig+kselftest on (arm): - compiler: gcc-12 - dashboard: https://d.kernelci.org/build/maestro:686d49fc34612746bbb51ff1 #kernelci issue maestro:634dca9c0041633c75d4d5ce3cb61da4d05029f1 Reported-by: kernelci.org bot <bot(a)kernelci.org> -- This is an experimental report format. Please send feedback in! Talk to us at kernelci(a)lists.linux.dev Made with love by the KernelCI team - https://kernelci.org

3 days, 20 hours

1
0
0 0

[REGRESSION] stable-rc/linux-6.1.y: (build) undefined reference to `cpu_show_tsa' in drivers/base/cpu (drivers...

by KernelCI bot

Hello, New build issue found on stable-rc/linux-6.1.y: --- undefined reference to `cpu_show_tsa' in drivers/base/cpu (drivers/base/cpu.c) [logspec:kbuild,kbuild.compiler.linker_error] --- - dashboard: https://d.kernelci.org/i/maestro:320f186cf70d8d6a8155682d995d1860d2ef3445 - giturl: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git - commit HEAD: 16a0c0f862e842e4269c2142fabfece05c2380b1 Log excerpt: ===================================================== arm-linux-gnueabihf-ld: drivers/base/cpu.o: in function `.LANCHOR2': cpu.c:(.data+0xb0): undefined reference to `cpu_show_tsa' ===================================================== # Builds where the incident occurred: ## vexpress_defconfig on (arm): - compiler: gcc-12 - dashboard: https://d.kernelci.org/build/maestro:686d4a0d34612746bbb52003 #kernelci issue maestro:320f186cf70d8d6a8155682d995d1860d2ef3445 Reported-by: kernelci.org bot <bot(a)kernelci.org> -- This is an experimental report format. Please send feedback in! Talk to us at kernelci(a)lists.linux.dev Made with love by the KernelCI team - https://kernelci.org

3 days, 20 hours

1
0
0 0

[REGRESSION] stable-rc/linux-6.1.y: (build) ld.lld: error: undefined symbol: cpu_show_tsa in vmlinux (scripts/...

by KernelCI bot

Hello, New build issue found on stable-rc/linux-6.1.y: --- ld.lld: error: undefined symbol: cpu_show_tsa in vmlinux (scripts/Makefile.vmlinux:34) [logspec:kbuild,kbuild.other] --- - dashboard: https://d.kernelci.org/i/maestro:6b1157158f4d95650fb3e4447503581fbc3320c8 - giturl: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git - commit HEAD: 16a0c0f862e842e4269c2142fabfece05c2380b1 Log excerpt: ===================================================== .lds ....+...+..+. HDRTEST usr/include/linux/if_x25.h .............. CC arch/arm64/kernel/debug-monitors.o +......... HDRTEST usr/include/linux/msg.h ....+.....+.......+.. HDRTEST usr/include/linux/sonypi.h .+........+...+ CC mm/kasan/generic.o .+.. HDRTEST usr/include/linux/const.h ...+...+.............. HDRTEST usr/include/linux/affs_hardblocks.h ..+...........+...+.... HDRTEST usr/include/linux/loadpin.h ........+.+............ HDRTEST usr/include/linux/route.h +.....+.+..+............ HDRTEST usr/include/linux/v4l2-subdev.h +.+..+....+...+.. HDRTEST usr/include/linux/if_eql.h .........+....+..+.... HDRTEST usr/include/linux/netfilter_ipv4.h .....+.......+........+... HDRTEST usr/include/linux/smiapp.h ......+......+.......+ HDRTEST usr/include/linux/bsg.h ...+..+............+. HDRTEST usr/include/linux/agpgart.h .........+..+............ HDRTEST usr/include/linux/aspeed-p2a-ctrl.h .........+.............+..... CC init/do_mounts_initrd.o + HDRTEST usr/include/linux/media-bus-format.h ..........+..+...+.... HDRTEST usr/include/linux/fiemap.h ..+...+............+.... HDRTEST usr/include/linux/vfio_zdev.h ..+.........+......+..................+.+ HDRTEST usr/include/linux/socket.h ........+.......+...+.. HDRTEST usr/include/linux/lp.h .+..............+.+..... HDRTEST usr/include/linux/serio.h ...............+...+....+ HDRTEST usr/include/linux/vbox_vmmdev_types.h ..+.+...+.....+..... HDRTEST usr/include/linux/seg6_genl.h ..............+......+.. HDRTEST usr/include/linux/netfilter_ipv4/ipt_CLUSTERIP.h ........................+... HDRTEST usr/include/linux/netfilter_ipv4/ipt_ah.h +.+.....+.+...........+ HDRTEST usr/include/linux/netfilter_ipv4/ipt_TTL.h .......+..+......+... HDRTEST usr/include/linux/netfilter_ipv4/ipt_ecn.h .+...+..+.............. HDRTEST usr/include/linux/netfilter_ipv4/ipt_LOG.h .....+..+....+.....+ HDRTEST usr/include/linux/netfilter_ipv4/ipt_ECN.h ............................+ HDRTEST usr/include/linux/netfilter_ipv4/ipt_REJECT.h ..+...+......+....... HDRTEST usr/include/linux/netfilter_ipv4/ipt_ttl.h ........................+......+........... HDRTEST usr/include/linux/netfilter_ipv4/ip_tables.h ....+...+..+ AR fs/notify/fanotify/built-in.a ....+...+. CC fs/notify/fsnotify.o ....+ HDRTEST usr/include/linux/serial.h ......+.+........+..... HDRTEST usr/include/linux/btf.h .+.......+.........+... HDRTEST usr/include/linux/batadv_packet.h ...+..+...+...+......... HDRTEST usr/include/linux/filter.h ...........................+ HDRTEST usr/include/linux/fsi.h ...............+....+.. HDRTEST usr/include/linux/sysctl.h ...+++++++++++ HDRTEST usr/include/linux/smc.h +++ AS arch/arm64/kernel/entry.o ++++++ HDRTEST usr/include/linux/dqblk_xfs.h ++++++++++++++++++++++ HDRTEST usr/include/linux/apm_bios.h ++++++++++ HDRTEST usr/include/linux/virtio_bt.h ++++++++++ HDRTEST usr/include/linux/major.h +++ ......+....+.....+.+........+.+......+........+....+.....+.......+...+......+.....+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++*............+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++*.+......... HDRTEST usr/include/linux/loop.h ...... CC arch/arm64/kernel/irq.o ..........+..+ CC init/initramfs.o ...... HDRTEST usr/include/linux/if_macsec.h ....+...+......+..+... HDRTEST usr/include/linux/misc/bcm_vk.h .......+.....+...............+...+....+. HDRTEST usr/include/linux/kcmp.h ..+.........+.... CC ipc/shm.o ..+.........+..............+.+. HDRTEST usr/include/linux/fsverity.h .....+............+......+.........+ HDRTEST usr/include/linux/fsmap.h .....+.+..+.........+....+..............+.......+ HDRTEST usr/include/linux/ip_vs.h .....+..........+.....+ HDRTEST usr/include/linux/fdreg.h ......+.......+........+ HDRTEST usr/include/linux/virtio_input.h .............+......... HDRTEST usr/include/linux/rseq.h ...+...+..+.......+... CC kernel/sched/fair.o .. HDRTEST usr/include/linux/veth.h .....................+... HDRTEST usr/include/linux/reboot.h ............+......+.. HDRTEST usr/include/linux/nsfs.h ..+..+....+.......... HDRTEST usr/include/linux/nfc.h ........+..+ CC mm/kasan/report_generic.o .+........ HDRTEST usr/include/linux/nfs4_mount.h ....+..+...............+... HDRTEST usr/include/linux/nfsd/debug.h .+.....+....+............+. HDRTEST usr/include/linux/nfsd/cld.h ..+...+....................+ HDRTEST usr/include/linux/nfsd/stats.h ...............+...............+. HDRTEST usr/include/linux/nfsd/export.h ......+............+.........+ HDRTEST usr/include/linux/utime.h ..+...+..........+..+ HDRTEST usr/include/linux/bt-bmc.h .......+...+........+ HDRTEST usr/include/linux/oom.h .+........+........ HDRTEST usr/include/linux/ioam6.h .....+..+............+. HDRTEST usr/include/linux/wmi.h ...............+........ HDRTEST usr/include/linux/gameport.h ....+......+++++++++++++ HDRTEST usr/include/linux/rxrpc.h ++++++++++++ HDRTEST usr/include/linux/surface_aggregator/dtx.h +++++++++ HDRTEST usr/include/linux/surface_aggregator/cdev.h +++++++++ HDRTEST usr/include/linux/if_link.h ++++++ CC arch/arm64/kernel/fpsimd.o ++++ HDRTEST usr/include/linux/fib_rules.h ++++++++++ HDRTEST usr/include/linux/zorro.h ++ ----- ld.lld: error: undefined symbol: cpu_show_tsa >>> referenced by cpu.c >>> drivers/base/cpu.o:(dev_attr_tsa) in archive vmlinux.a ===================================================== # Builds where the incident occurred: ## defconfig+allmodconfig on (arm64): - compiler: clang-17 - dashboard: https://d.kernelci.org/build/maestro:686d49d034612746bbb51fb8 ## defconfig+allmodconfig+CONFIG_FRAME_WARN=2048 on (arm): - compiler: clang-17 - dashboard: https://d.kernelci.org/build/maestro:686d49cb34612746bbb51fb2 #kernelci issue maestro:6b1157158f4d95650fb3e4447503581fbc3320c8 Reported-by: kernelci.org bot <bot(a)kernelci.org> -- This is an experimental report format. Please send feedback in! Talk to us at kernelci(a)lists.linux.dev Made with love by the KernelCI team - https://kernelci.org

3 days, 20 hours

1
0
0 0

[REGRESSION] stable-rc/linux-5.15.y: (build) ld.lld: error: undefined symbol: cpu_show_tsa in vmlinux (Makefile...

by KernelCI bot

Hello, New build issue found on stable-rc/linux-5.15.y: --- ld.lld: error: undefined symbol: cpu_show_tsa in vmlinux (Makefile:1246) [logspec:kbuild,kbuild.other] --- - dashboard: https://d.kernelci.org/i/maestro:37759c63a97e01566b3769ef90482ca5ec2daa9f - giturl: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git - commit HEAD: 57a10c76a9922f216165558513b1e0f5a2eae559 Log excerpt: ===================================================== .lds ld.lld: error: undefined symbol: cpu_show_tsa >>> referenced by cpu.c >>> base/cpu.o:(dev_attr_tsa) in archive drivers/built-in.a ===================================================== # Builds where the incident occurred: ## defconfig+arm64-chromebook+kselftest on (arm64): - compiler: clang-17 - dashboard: https://d.kernelci.org/build/maestro:686d490a34612746bbb51e76 #kernelci issue maestro:37759c63a97e01566b3769ef90482ca5ec2daa9f Reported-by: kernelci.org bot <bot(a)kernelci.org> -- This is an experimental report format. Please send feedback in! Talk to us at kernelci(a)lists.linux.dev Made with love by the KernelCI team - https://kernelci.org

3 days, 20 hours

1
0
0 0

[PATCH v5 1/4] scsi: fnic: Fix crash in fnic_wq_cmpl_handler when FDMI times out

by Karan Tilak Kumar

When both the RHBA and RPA FDMI requests time out, fnic reuses a frame to send ABTS for each of them. On send completion, this causes an attempt to free the same frame twice that leads to a crash. Fix crash by allocating separate frames for RHBA and RPA, and modify ABTS logic accordingly. Tested by checking MDS for FDMI information. Tested by using instrumented driver to: Drop PLOGI response Drop RHBA response Drop RPA response Drop RHBA and RPA response Drop PLOGI response + ABTS response Drop RHBA response + ABTS response Drop RPA response + ABTS response Drop RHBA and RPA response + ABTS response for both of them Fixes: 09c1e6ab4ab2 ("scsi: fnic: Add and integrate support for FDMI") Reviewed-by: Sesidhar Baddela <sebaddel(a)cisco.com> Reviewed-by: Arulprabhu Ponnusamy <arulponn(a)cisco.com> Reviewed-by: Gian Carlo Boffa <gcboffa(a)cisco.com> Tested-by: Arun Easi <aeasi(a)cisco.com> Co-developed-by: Arun Easi <aeasi(a)cisco.com> Signed-off-by: Arun Easi <aeasi(a)cisco.com> Tested-by: Karan Tilak Kumar <kartilak(a)cisco.com> Cc: <stable(a)vger.kernel.org> Signed-off-by: Karan Tilak Kumar <kartilak(a)cisco.com> --- Changes between v4 and v5: - Incorporate review comments from John: - Refactor patches Changes between v3 and v4: - Incorporate review comments from Dan: - Remove comments from Cc tag Changes between v2 and v3: - Incorporate review comments from Dan: - Add Cc to stable Changes between v1 and v2: - Incorporate review comments from Dan: - Add Fixes tag --- drivers/scsi/fnic/fdls_disc.c | 113 +++++++++++++++++++++++++--------- drivers/scsi/fnic/fnic.h | 2 +- drivers/scsi/fnic/fnic_fdls.h | 1 + 3 files changed, 87 insertions(+), 29 deletions(-) diff --git a/drivers/scsi/fnic/fdls_disc.c b/drivers/scsi/fnic/fdls_disc.c index c2b6f4eb338e..0ee1b74967b9 100644 --- a/drivers/scsi/fnic/fdls_disc.c +++ b/drivers/scsi/fnic/fdls_disc.c @@ -763,47 +763,69 @@ static void fdls_send_fabric_abts(struct fnic_iport_s *iport) iport->fabric.timer_pending = 1; } -static void fdls_send_fdmi_abts(struct fnic_iport_s *iport) +static uint8_t *fdls_alloc_init_fdmi_abts_frame(struct fnic_iport_s *iport, + uint16_t oxid) { - uint8_t *frame; + struct fc_frame_header *pfdmi_abts; uint8_t d_id[3]; + uint8_t *frame; struct fnic *fnic = iport->fnic; - struct fc_frame_header *pfabric_abts; - unsigned long fdmi_tov; - uint16_t oxid; - uint16_t frame_size = FNIC_ETH_FCOE_HDRS_OFFSET + - sizeof(struct fc_frame_header); frame = fdls_alloc_frame(iport); if (frame == NULL) { FNIC_FCS_DBG(KERN_ERR, fnic->host, fnic->fnic_num, "Failed to allocate frame to send FDMI ABTS"); - return; + return NULL; } - pfabric_abts = (struct fc_frame_header *) (frame + FNIC_ETH_FCOE_HDRS_OFFSET); + pfdmi_abts = (struct fc_frame_header *) (frame + FNIC_ETH_FCOE_HDRS_OFFSET); fdls_init_fabric_abts_frame(frame, iport); hton24(d_id, FC_FID_MGMT_SERV); - FNIC_STD_SET_D_ID(*pfabric_abts, d_id); + FNIC_STD_SET_D_ID(*pfdmi_abts, d_id); + FNIC_STD_SET_OX_ID(*pfdmi_abts, oxid); + + return frame; +} + +static void fdls_send_fdmi_abts(struct fnic_iport_s *iport) +{ + uint8_t *frame; + unsigned long fdmi_tov; + uint16_t frame_size = FNIC_ETH_FCOE_HDRS_OFFSET + + sizeof(struct fc_frame_header); if (iport->fabric.fdmi_pending & FDLS_FDMI_PLOGI_PENDING) { - oxid = iport->active_oxid_fdmi_plogi; - FNIC_STD_SET_OX_ID(*pfabric_abts, oxid); + frame = fdls_alloc_init_fdmi_abts_frame(iport, + iport->active_oxid_fdmi_plogi); + if (frame == NULL) + return; + fnic_send_fcoe_frame(iport, frame, frame_size); } else { if (iport->fabric.fdmi_pending & FDLS_FDMI_REG_HBA_PENDING) { - oxid = iport->active_oxid_fdmi_rhba; - FNIC_STD_SET_OX_ID(*pfabric_abts, oxid); + frame = fdls_alloc_init_fdmi_abts_frame(iport, + iport->active_oxid_fdmi_rhba); + if (frame == NULL) + return; + fnic_send_fcoe_frame(iport, frame, frame_size); } if (iport->fabric.fdmi_pending & FDLS_FDMI_RPA_PENDING) { - oxid = iport->active_oxid_fdmi_rpa; - FNIC_STD_SET_OX_ID(*pfabric_abts, oxid); + frame = fdls_alloc_init_fdmi_abts_frame(iport, + iport->active_oxid_fdmi_rpa); + if (frame == NULL) { + if (iport->fabric.fdmi_pending & FDLS_FDMI_REG_HBA_PENDING) + goto arm_timer; + else + return; + } + fnic_send_fcoe_frame(iport, frame, frame_size); } } +arm_timer: fdmi_tov = jiffies + msecs_to_jiffies(2 * iport->e_d_tov); mod_timer(&iport->fabric.fdmi_timer, round_jiffies(fdmi_tov)); iport->fabric.fdmi_pending |= FDLS_FDMI_ABORT_PENDING; @@ -2244,6 +2266,21 @@ void fdls_fabric_timer_callback(struct timer_list *t) spin_unlock_irqrestore(&fnic->fnic_lock, flags); } +void fdls_fdmi_retry_plogi(struct fnic_iport_s *iport) +{ + struct fnic *fnic = iport->fnic; + + iport->fabric.fdmi_pending = 0; + /* If max retries not exhausted, start over from fdmi plogi */ + if (iport->fabric.fdmi_retry < FDLS_FDMI_MAX_RETRY) { + iport->fabric.fdmi_retry++; + FNIC_FCS_DBG(KERN_INFO, fnic->host, fnic->fnic_num, + "Retry FDMI PLOGI. FDMI retry: %d", + iport->fabric.fdmi_retry); + fdls_send_fdmi_plogi(iport); + } +} + void fdls_fdmi_timer_callback(struct timer_list *t) { struct fnic_fdls_fabric_s *fabric = from_timer(fabric, t, fdmi_timer); @@ -2289,14 +2326,7 @@ void fdls_fdmi_timer_callback(struct timer_list *t) FNIC_FCS_DBG(KERN_INFO, fnic->host, fnic->fnic_num, "fdmi timer callback : 0x%x\n", iport->fabric.fdmi_pending); - iport->fabric.fdmi_pending = 0; - /* If max retries not exhaused, start over from fdmi plogi */ - if (iport->fabric.fdmi_retry < FDLS_FDMI_MAX_RETRY) { - iport->fabric.fdmi_retry++; - FNIC_FCS_DBG(KERN_INFO, fnic->host, fnic->fnic_num, - "retry fdmi timer %d", iport->fabric.fdmi_retry); - fdls_send_fdmi_plogi(iport); - } + fdls_fdmi_retry_plogi(iport); FNIC_FCS_DBG(KERN_INFO, fnic->host, fnic->fnic_num, "fdmi timer callback : 0x%x\n", iport->fabric.fdmi_pending); spin_unlock_irqrestore(&fnic->fnic_lock, flags); @@ -3714,11 +3744,32 @@ static void fdls_process_fdmi_abts_rsp(struct fnic_iport_s *iport, switch (FNIC_FRAME_TYPE(oxid)) { case FNIC_FRAME_TYPE_FDMI_PLOGI: fdls_free_oxid(iport, oxid, &iport->active_oxid_fdmi_plogi); + + iport->fabric.fdmi_pending &= ~FDLS_FDMI_PLOGI_PENDING; + iport->fabric.fdmi_pending &= ~FDLS_FDMI_ABORT_PENDING; break; case FNIC_FRAME_TYPE_FDMI_RHBA: + iport->fabric.fdmi_pending &= ~FDLS_FDMI_REG_HBA_PENDING; + + /* If RPA is still pending, don't turn off ABORT PENDING. + * We count on the timer to detect the ABTS timeout and take + * corrective action. + */ + if (!(iport->fabric.fdmi_pending & FDLS_FDMI_RPA_PENDING)) + iport->fabric.fdmi_pending &= ~FDLS_FDMI_ABORT_PENDING; + fdls_free_oxid(iport, oxid, &iport->active_oxid_fdmi_rhba); break; case FNIC_FRAME_TYPE_FDMI_RPA: + iport->fabric.fdmi_pending &= ~FDLS_FDMI_RPA_PENDING; + + /* If RHBA is still pending, don't turn off ABORT PENDING. + * We count on the timer to detect the ABTS timeout and take + * corrective action. + */ + if (!(iport->fabric.fdmi_pending & FDLS_FDMI_REG_HBA_PENDING)) + iport->fabric.fdmi_pending &= ~FDLS_FDMI_ABORT_PENDING; + fdls_free_oxid(iport, oxid, &iport->active_oxid_fdmi_rpa); break; default: @@ -3728,10 +3779,16 @@ static void fdls_process_fdmi_abts_rsp(struct fnic_iport_s *iport, break; } - timer_delete_sync(&iport->fabric.fdmi_timer); - iport->fabric.fdmi_pending &= ~FDLS_FDMI_ABORT_PENDING; - - fdls_send_fdmi_plogi(iport); + /* + * Only if ABORT PENDING is off, delete the timer, and if no other + * operations are pending, retry FDMI. + * Otherwise, let the timer pop and take the appropriate action. + */ + if (!(iport->fabric.fdmi_pending & FDLS_FDMI_ABORT_PENDING)) { + timer_delete_sync(&iport->fabric.fdmi_timer); + if (!iport->fabric.fdmi_pending) + fdls_fdmi_retry_plogi(iport); + } } static void diff --git a/drivers/scsi/fnic/fnic.h b/drivers/scsi/fnic/fnic.h index 6c5f6046b1f5..86e293ce530d 100644 --- a/drivers/scsi/fnic/fnic.h +++ b/drivers/scsi/fnic/fnic.h @@ -30,7 +30,7 @@ #define DRV_NAME "fnic" #define DRV_DESCRIPTION "Cisco FCoE HBA Driver" -#define DRV_VERSION "1.8.0.0" +#define DRV_VERSION "1.8.0.1" #define PFX DRV_NAME ": " #define DFX DRV_NAME "%d: " diff --git a/drivers/scsi/fnic/fnic_fdls.h b/drivers/scsi/fnic/fnic_fdls.h index 8e610b65ad57..531d0b37e450 100644 --- a/drivers/scsi/fnic/fnic_fdls.h +++ b/drivers/scsi/fnic/fnic_fdls.h @@ -394,6 +394,7 @@ void fdls_send_tport_abts(struct fnic_iport_s *iport, bool fdls_delete_tport(struct fnic_iport_s *iport, struct fnic_tport_s *tport); void fdls_fdmi_timer_callback(struct timer_list *t); +void fdls_fdmi_retry_plogi(struct fnic_iport_s *iport); /* fnic_fcs.c */ void fnic_fdls_init(struct fnic *fnic, int usefip); -- 2.47.1

3 days, 21 hours

3
3
0 0

[PATCH] mm/userfaultfd: fix missing PTE unmap for non-migration entries

by Sasha Levin

When handling non-swap entries in move_pages_pte(), the error handling for entries that are NOT migration entries fails to unmap the page table entries before jumping to the error handling label. This results in a kmap/kunmap imbalance which on CONFIG_HIGHPTE systems triggers a WARNING in kunmap_local_indexed() because the kmap stack is corrupted. Example call trace on ARM32 (CONFIG_HIGHPTE enabled): WARNING: CPU: 1 PID: 633 at mm/highmem.c:622 kunmap_local_indexed+0x178/0x17c Call trace: kunmap_local_indexed from move_pages+0x964/0x19f4 move_pages from userfaultfd_ioctl+0x129c/0x2144 userfaultfd_ioctl from sys_ioctl+0x558/0xd24 The issue was introduced with the UFFDIO_MOVE feature but became more frequent with the addition of guard pages (commit 7c53dfbdb024 ("mm: add PTE_MARKER_GUARD PTE marker")) which made the non-migration entry code path more commonly executed during userfaultfd operations. Fix this by ensuring PTEs are properly unmapped in all non-swap entry paths before jumping to the error handling label, not just for migration entries. Fixes: adef440691ba ("userfaultfd: UFFDIO_MOVE uABI") Cc: stable(a)vger.kernel.org Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- mm/userfaultfd.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/mm/userfaultfd.c b/mm/userfaultfd.c index 8253978ee0fb1..7c298e9cbc18f 100644 --- a/mm/userfaultfd.c +++ b/mm/userfaultfd.c @@ -1384,14 +1384,15 @@ static int move_pages_pte(struct mm_struct *mm, pmd_t *dst_pmd, pmd_t *src_pmd, entry = pte_to_swp_entry(orig_src_pte); if (non_swap_entry(entry)) { + pte_unmap(src_pte); + pte_unmap(dst_pte); + src_pte = dst_pte = NULL; if (is_migration_entry(entry)) { - pte_unmap(src_pte); - pte_unmap(dst_pte); - src_pte = dst_pte = NULL; migration_entry_wait(mm, src_pmd, src_addr); err = -EAGAIN; - } else + } else { err = -EFAULT; + } goto out; } -- 2.39.5

3 days, 22 hours

5
9
0 0

[PATCH v2] net: ethernet: rtsn: Fix a null pointer dereference in rtsn_probe()

by Haoxiang Li

Add check for the return value of rcar_gen4_ptp_alloc() to prevent potential null pointer dereference. Fixes: b0d3969d2b4d ("net: ethernet: rtsn: Add support for Renesas Ethernet-TSN") Cc: stable(a)vger.kernel.org Signed-off-by: Haoxiang Li <haoxiang_li2024(a)163.com> --- Changes in v2: - Add a blank line to make the grouping similar to the style of other error checks in probe. Thanks, Niklas! --- drivers/net/ethernet/renesas/rtsn.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/ethernet/renesas/rtsn.c b/drivers/net/ethernet/renesas/rtsn.c index 6b3f7fca8d15..05c4b6c8c9c3 100644 --- a/drivers/net/ethernet/renesas/rtsn.c +++ b/drivers/net/ethernet/renesas/rtsn.c @@ -1259,7 +1259,12 @@ static int rtsn_probe(struct platform_device *pdev) priv = netdev_priv(ndev); priv->pdev = pdev; priv->ndev = ndev; + priv->ptp_priv = rcar_gen4_ptp_alloc(pdev); + if (!priv->ptp_priv) { + ret = -ENOMEM; + goto error_free; + } spin_lock_init(&priv->lock); platform_set_drvdata(pdev, priv); -- 2.25.1

3 days, 23 hours

3
2
0 0

Re: Patch "crypto: powerpc/poly1305 - add depends on BROKEN for now" has been added to the 6.12-stable tree

by Eric Biggers

On Mon, Jul 07, 2025 at 12:34:45AM -0400, Sasha Levin wrote: > This is a note to let you know that I've just added the patch titled > > crypto: powerpc/poly1305 - add depends on BROKEN for now > > to the 6.12-stable tree which can be found at: > http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=sum… You forgot to Cc the relevant mailing lists. > diff --git a/arch/powerpc/lib/crypto/Kconfig b/arch/powerpc/lib/crypto/Kconfig > new file mode 100644 > index 0000000000000..3f9e1bbd9905b > --- /dev/null > +++ b/arch/powerpc/lib/crypto/Kconfig > @@ -0,0 +1,22 @@ > +# SPDX-License-Identifier: GPL-2.0-only > + > +config CRYPTO_CHACHA20_P10 > + tristate > + depends on PPC64 && CPU_LITTLE_ENDIAN && VSX > + default CRYPTO_LIB_CHACHA > + select CRYPTO_LIB_CHACHA_GENERIC > + select CRYPTO_ARCH_HAVE_LIB_CHACHA > + > +config CRYPTO_POLY1305_P10 > + tristate > + depends on PPC64 && CPU_LITTLE_ENDIAN && VSX > + depends on BROKEN # Needs to be fixed to work in softirq context > + default CRYPTO_LIB_POLY1305 > + select CRYPTO_ARCH_HAVE_LIB_POLY1305 > + select CRYPTO_LIB_POLY1305_GENERIC > + > +config CRYPTO_SHA256_PPC_SPE > + tristate > + depends on SPE > + default CRYPTO_LIB_SHA256 > + select CRYPTO_ARCH_HAVE_LIB_SHA256 Really? - Eric

3 days, 23 hours

2
2
0 0

Please apply commit 93bd4a80efeb to v6.6.y and v6.12.y

by Guenter Roeck

Hi Greg, v6.6.y and v6.12.y fail to build corenet64_smp_defconfig. powerpc64-linux-ld: arch/powerpc/kernel/irq_64.o: in function `__replay_soft_interrupts': /opt/buildbot/slave/qemu-ppc64/build/arch/powerpc/kernel/irq_64.c:119:(.text+0x50): undefined reference to `ppc_save_regs' This is caused by the backport of upstream commit 497b7794aef0 ("powerpc: do not build ppc_save_regs.o always"). That commit made some wrong assumptions and causes the build failure. Please apply commit 93bd4a80efeb ("powerpc/kernel: Fix ppc_save_regs inclusion in build") to both branches to fix the problem. Thanks, Guenter --- bisect: # bad: [a5df3a702b2cba82bcfb066fa9f5e4a349c33924] Linux 6.6.96 # good: [c2603c511feb427b2b09f74b57816a81272932a1] Linux 6.6.93 git bisect start 'HEAD' 'c2603c511feb' # bad: [36318ff3d6bf94ea01b2caa0967f2b366c7daea6] media: venus: Fix probe error handling git bisect bad 36318ff3d6bf94ea01b2caa0967f2b366c7daea6 # bad: [c64a16344c5258dcaaa6caf2bbe2298e6e3e469c] randstruct: gcc-plugin: Remove bogus void member git bisect bad c64a16344c5258dcaaa6caf2bbe2298e6e3e469c # bad: [cb4b9369463eb6f6d0f4bdeaf35d183a935c2573] Use thread-safe function pointer in libbpf_print git bisect bad cb4b9369463eb6f6d0f4bdeaf35d183a935c2573 # bad: [aa7b90057bc3f8d9ddf50e7397facdd613de5610] x86/mtrr: Check if fixed-range MTRRs exist in mtrr_save_fixed_ranges() git bisect bad aa7b90057bc3f8d9ddf50e7397facdd613de5610 # good: [cb1e26f53e598a3946dd9b3014d6bcddd8609a47] crypto: sun8i-ss - do not use sg_dma_len before calling DMA functions git bisect good cb1e26f53e598a3946dd9b3014d6bcddd8609a47 # bad: [5810e9d402c43a63c16ce949f9d9ff59fe6832e7] crypto: sun8i-ce - move fallback ahash_request to the end of the struct git bisect bad 5810e9d402c43a63c16ce949f9d9ff59fe6832e7 # bad: [3cf4d9cae4356c2a0610d82c13c957e4a88d6d94] crypto: marvell/cesa - Avoid empty transfer descriptor git bisect bad 3cf4d9cae4356c2a0610d82c13c957e4a88d6d94 # bad: [ce167ff4cd172bb85b834d671f37151b0f7f734a] x86/microcode/AMD: Do not return error when microcode update is not necessary git bisect bad ce167ff4cd172bb85b834d671f37151b0f7f734a # bad: [4fb22310892c9bba3a170d0873e95886fbadf064] powerpc/crash: Fix non-smp kexec preparation git bisect bad 4fb22310892c9bba3a170d0873e95886fbadf064 # bad: [fdc39b3ad8a7791792408212507683bfae9f2dc5] powerpc: do not build ppc_save_regs.o always git bisect bad fdc39b3ad8a7791792408212507683bfae9f2dc5 # first bad commit: [fdc39b3ad8a7791792408212507683bfae9f2dc5] powerpc: do not build ppc_save_regs.o always

3 days, 23 hours

2
1
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror