On 04/20, Oleg Nesterov wrote:
>On 04/20, Zhenliang Wei wrote:
>>
>> --- a/kernel/signal.c
>> +++ b/kernel/signal.c
>> @@ -2441,6 +2441,8 @@ bool get_signal(struct ksignal *ksig)
>> if (signal_group_exit(signal)) {
>> ksig->info.si_signo = signr = SIGKILL;
>> sigdelset(¤t->pending.signal, SIGKILL);
>> + trace_signal_deliver(signr, &ksig->info,
>> + &sighand->action[signr - 1]);
>
>Well, in this case ksig->info is not fully initialized for TP_STORE_SIGINFO() which reads si_errno/si_code...
>
>How about
>
> trace_signal_deliver(SIGKILL, SEND_SIG_NOINFO, SIG_DFL)
>
>?
>
>We know that action[SIGKILL] must be SIG_DFL.
>
>And SEND_SIG_NOINFO matches the fact that SIGKILL doesn't have any info,
>collect_signal() sets SI_USER and clears si_errno in this case.
>
>Oleg.
Thank you for your review, I agree with your suggestion, and I will recommit the patch later.
Zhenliang Wei.
On 2019/4/20 7:16 上午, Sasha Levin wrote:
> Hi,
>
> [This is an automated email]
>
> This commit has been processed because it contains a -stable tag.
> The stable tag indicates that it's relevant for the following trees: all
>
> The bot has tested the following trees: v5.0.8, v4.19.35, v4.14.112, v4.9.169, v4.4.178, v3.18.138.
>
> v5.0.8: Build OK!
> v4.19.35: Build OK!
> v4.14.112: Failed to apply! Possible dependencies:
> a728eacbbdd2 ("bcache: add journal statistic")
> c4dc2497d50d ("bcache: fix high CPU occupancy during journal")
>
> v4.9.169: Failed to apply! Possible dependencies:
> a728eacbbdd2 ("bcache: add journal statistic")
> c4dc2497d50d ("bcache: fix high CPU occupancy during journal")
>
> v4.4.178: Failed to apply! Possible dependencies:
> a728eacbbdd2 ("bcache: add journal statistic")
> c4dc2497d50d ("bcache: fix high CPU occupancy during journal")
>
> v3.18.138: Failed to apply! Possible dependencies:
> a728eacbbdd2 ("bcache: add journal statistic")
> c4dc2497d50d ("bcache: fix high CPU occupancy during journal")
>
>
> How should we proceed with this patch?
This patch will go into Linux v5.2. We can have them in stable after
they being upstream.
Thanks.
--
Coly Li