tl;dr automatic bisection reports are enabled for mainline and stable
In case you're not already familiar with it, the kernelci.org project
is a community effort to build and test upstream kernel trees on a
variety of hardware platforms. Reports are mostly sent to the
kernel-build-reports mailing list[1] and all the results can be seen
on https://kernelci.org.
When a boot test regression is detected on mainline or stable
branches, a bisection is automatically run. Starting from today, an
email report will be automatically sent to a list of recipients based
on the commit the bisection has found (author, trailers, maintainers
and lists associated with the code changed by the commit). Until
now, the results were manually curated and only reported more widely
when they seemed valid. Some automated checks are now used, they
have been showing good results for a while with no false positives.
There shouldn't be many bisection reports yet, typically one or two
every month. As we'll start bisecting other trees such as linux-next
and other test results than just plain boots, the volume may start
increasing gradually over the coming months.
Please let us know if you would like the report format to be changed
when you get one, or if you have any suggestions at all.
Hope this helps!
Guillaume
[1] https://lists.linaro.org/mailman/listinfo/kernel-build-reports
This is the start of the stable review cycle for the 4.14.83 release.
There are 21 patches in this series, all will be posted as a response
to this one. If anyone has any issues with these being applied, please
let me know.
Responses should be made by Fri Nov 23 18:34:13 UTC 2018.
Anything received after that time might be too late.
The whole patch series can be found in one patch at:
https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.83-rc…
or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.14.y
and the diffstat can be found below.
thanks,
greg k-h
-------------
Pseudo-Shortlog of commits:
Greg Kroah-Hartman <gregkh(a)linuxfoundation.org>
Linux 4.14.83-rc1
Chris Paterson <chris.paterson2(a)renesas.com>
ARM: dts: r8a7793: Correct critical CPU temperature
Chris Paterson <chris.paterson2(a)renesas.com>
ARM: dts: r8a7791: Correct critical CPU temperature
Greg Kroah-Hartman <gregkh(a)linuxfoundation.org>
Revert "x86/speculation: Enable cross-hyperthread spectre v2 STIBP mitigation"
Eric Dumazet <edumazet(a)google.com>
inet: frags: better deal with smp races
Frieder Schrempf <frieder.schrempf(a)kontron.de>
usbnet: smsc95xx: disable carrier check while suspending
Stefan Wahren <stefan.wahren(a)i2se.com>
net: smsc95xx: Fix MTU range
Shalom Toledo <shalomt(a)mellanox.com>
mlxsw: spectrum: Fix IP2ME CPU policer configuration
Xin Long <lucien.xin(a)gmail.com>
sctp: not increase stream's incnt before sending addstrm_in request
Martin Schiller <ms(a)dev.tdt.de>
net: phy: mdio-gpio: Fix working over slow can_sleep GPIOs
Xin Long <lucien.xin(a)gmail.com>
sctp: fix strchange_flags name for Stream Change Event
Tristram Ha <Tristram.Ha(a)microchip.com>
net: dsa: microchip: initialize mutex before use
Subash Abhinov Kasiviswanathan <subashab(a)codeaurora.org>
net: qualcomm: rmnet: Fix incorrect assignment of real_dev
Florian Fainelli <f.fainelli(a)gmail.com>
net: systemport: Protect stop from timeout
Matthew Cover <werekraken(a)gmail.com>
tuntap: fix multiqueue rx
Siva Reddy Kallam <siva.kallam(a)broadcom.com>
tg3: Add PHY reset for 5717/5719/5720 in change ring and flow control paths
Xin Long <lucien.xin(a)gmail.com>
sctp: not allow to set asoc prsctp_enable by sockopt
Eric Dumazet <edumazet(a)google.com>
net-gro: reset skb->pkt_type in napi_reuse_skb()
David Ahern <dsahern(a)gmail.com>
ipv6: Fix PMTU updates for UDP/raw sockets in presence of VRF
Sabrina Dubroca <sd(a)queasysnail.net>
ip_tunnel: don't force DF when MTU is locked
Michał Mirosław <mirq-linux(a)rere.qmqm.pl>
ibmvnic: fix accelerated VLAN handling
배석진 <soukjin.bae(a)samsung.com>
flow_dissector: do not dissect l4 ports for fragments
-------------
Diffstat:
Makefile | 4 +-
arch/arm/boot/dts/r8a7791.dtsi | 2 +-
arch/arm/boot/dts/r8a7793.dtsi | 2 +-
arch/x86/kernel/cpu/bugs.c | 57 +++----------------------
drivers/net/dsa/microchip/ksz_common.c | 10 ++---
drivers/net/ethernet/broadcom/bcmsysport.c | 15 +++----
drivers/net/ethernet/broadcom/tg3.c | 18 +++++++-
drivers/net/ethernet/ibm/ibmvnic.c | 2 +-
drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 1 -
drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c | 6 +--
drivers/net/phy/mdio-gpio.c | 10 ++---
drivers/net/tun.c | 6 ++-
drivers/net/usb/smsc95xx.c | 9 ++++
include/uapi/linux/sctp.h | 2 +
kernel/cpu.c | 11 +----
net/core/dev.c | 4 ++
net/core/flow_dissector.c | 4 +-
net/ipv4/inet_fragment.c | 28 ++++++------
net/ipv4/ip_tunnel_core.c | 2 +-
net/ipv6/route.c | 7 ++-
net/sctp/socket.c | 26 +++--------
net/sctp/stream.c | 1 -
22 files changed, 96 insertions(+), 131 deletions(-)
This is the start of the stable review cycle for the 4.9.139 release.
There are 59 patches in this series, all will be posted as a response
to this one. If anyone has any issues with these being applied, please
let me know.
Responses should be made by Fri Nov 23 18:34:55 UTC 2018.
Anything received after that time might be too late.
The whole patch series can be found in one patch at:
https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.9.139-rc…
or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.9.y
and the diffstat can be found below.
thanks,
greg k-h
-------------
Pseudo-Shortlog of commits:
Greg Kroah-Hartman <gregkh(a)linuxfoundation.org>
Linux 4.9.139-rc1
Russell King <rmk+kernel(a)armlinux.org.uk>
ARM: spectre-v1: mitigate user accesses
Russell King <rmk+kernel(a)armlinux.org.uk>
ARM: spectre-v1: use get_user() for __get_user()
Russell King <rmk+kernel(a)armlinux.org.uk>
ARM: use __inttype() in get_user()
Russell King <rmk+kernel(a)armlinux.org.uk>
ARM: oabi-compat: copy semops using __copy_from_user()
Russell King <rmk+kernel(a)armlinux.org.uk>
ARM: vfp: use __copy_from_user() when restoring VFP state
Russell King <rmk+kernel(a)armlinux.org.uk>
ARM: signal: copy registers using __copy_from_user()
Russell King <rmk+kernel(a)armlinux.org.uk>
ARM: spectre-v1: fix syscall entry
Russell King <rmk+kernel(a)armlinux.org.uk>
ARM: spectre-v1: add array_index_mask_nospec() implementation
Russell King <rmk+kernel(a)armlinux.org.uk>
ARM: spectre-v1: add speculation barrier (csdb) macros
Russell King <rmk+kernel(a)armlinux.org.uk>
ARM: KVM: report support for SMCCC_ARCH_WORKAROUND_1
Russell King <rmk+kernel(a)armlinux.org.uk>
ARM: KVM: Add SMCCC_ARCH_WORKAROUND_1 fast handling
Russell King <rmk+kernel(a)armlinux.org.uk>
ARM: spectre-v2: KVM: invalidate icache on guest exit for Brahma B15
Marc Zyngier <marc.zyngier(a)arm.com>
ARM: KVM: invalidate icache on guest exit for Cortex-A15
Marc Zyngier <marc.zyngier(a)arm.com>
ARM: KVM: invalidate BTB on guest exit for Cortex-A12/A17
Russell King <rmk+kernel(a)armlinux.org.uk>
ARM: spectre-v2: warn about incorrect context switching functions
Russell King <rmk+kernel(a)armlinux.org.uk>
ARM: spectre-v2: add firmware based hardening
Russell King <rmk+kernel(a)armlinux.org.uk>
ARM: spectre-v2: harden user aborts in kernel space
Russell King <rmk+kernel(a)armlinux.org.uk>
ARM: spectre-v2: add Cortex A8 and A15 validation of the IBE bit
Russell King <rmk+kernel(a)armlinux.org.uk>
ARM: spectre-v2: harden branch predictor on context switches
Russell King <rmk+kernel(a)armlinux.org.uk>
ARM: spectre: add Kconfig symbol for CPUs vulnerable to Spectre
Russell King <rmk+kernel(a)armlinux.org.uk>
ARM: bugs: add support for per-processor bug checking
Russell King <rmk+kernel(a)armlinux.org.uk>
ARM: bugs: hook processor bug checking into SMP and suspend paths
Russell King <rmk+kernel(a)armlinux.org.uk>
ARM: bugs: prepare processor bug infrastructure
Russell King <rmk+kernel(a)armlinux.org.uk>
ARM: add more CPU part numbers for Cortex and Brahma B15 CPUs
Mark Rutland <mark.rutland(a)arm.com>
arm64: uaccess: suppress spurious clang warning
Arnd Bergmann <arnd(a)arndb.de>
Kbuild: use -fshort-wchar globally
Matthias Kaehlcke <mka(a)chromium.org>
x86/build: Use cc-option to validate stack alignment parameter
Matthias Kaehlcke <mka(a)chromium.org>
x86/build: Fix stack alignment for CLang
Ard Biesheuvel <ard.biesheuvel(a)linaro.org>
efi/libstub/arm64: Set -fpie when building the EFI stub
Ard Biesheuvel <ard.biesheuvel(a)linaro.org>
efi/libstub: Preserve .debug sections after absolute relocation check
Ard Biesheuvel <ard.biesheuvel(a)linaro.org>
efi/libstub/arm64: Force 'hidden' visibility for section markers
Ard Biesheuvel <ard.biesheuvel(a)linaro.org>
efi/libstub/arm64: Use hidden attribute for struct screen_info reference
Michael Davidson <md(a)google.com>
x86/boot: #undef memcpy() et al in string.c
Ard Biesheuvel <ard.biesheuvel(a)linaro.org>
crypto: arm64/sha - avoid non-standard inline asm tricks
Matthias Kaehlcke <mka(a)chromium.org>
kbuild: clang: Disable 'address-of-packed-member' warning
Matthias Kaehlcke <mka(a)chromium.org>
x86/build: Specify stack alignment for clang
Matthias Kaehlcke <mka(a)chromium.org>
x86/build: Use __cc-option for boot code compiler options
Matthias Kaehlcke <mka(a)chromium.org>
kbuild: Add __cc-option macro
Michael Davidson <md(a)google.com>
crypto, x86: aesni - fix token pasting for clang
Matthias Kaehlcke <mka(a)chromium.org>
x86/kbuild: Use cc-option to enable -falign-{jumps/loops}
Arnd Bergmann <arnd(a)arndb.de>
modules: mark __inittest/__exittest as __maybe_unused
Vinícius Tinti <viniciustinti(a)gmail.com>
kbuild: Add support to generate LLVM assembly files
Behan Webster <behanw(a)converseincode.com>
kbuild: use -Oz instead of -Os when using clang
Mark Charlebois <charlebm(a)gmail.com>
kbuild, LLVMLinux: Add -Werror to cc-option to support clang
Masahiro Yamada <yamada.masahiro(a)socionext.com>
kbuild: drop -Wno-unknown-warning-option from clang options
Jeroen Hofstee <jeroen(a)myspectrum.nl>
kbuild: fix asm-offset generation to work with clang
Masahiro Yamada <yamada.masahiro(a)socionext.com>
kbuild: consolidate redundant sed script ASM offset generation
Matthias Kaehlcke <mka(a)chromium.org>
kbuild: Consolidate header generation from ASM offset information
Michael Davidson <md(a)google.com>
kbuild: clang: add -no-integrated-as to KBUILD_[AC]FLAGS
Behan Webster <behanw(a)converseincode.com>
kbuild: Add better clang cross build support
David Ahern <dsahern(a)gmail.com>
ipv6: Fix PMTU updates for UDP/raw sockets in presence of VRF
Eric Dumazet <edumazet(a)google.com>
inet: frags: better deal with smp races
Frieder Schrempf <frieder.schrempf(a)kontron.de>
usbnet: smsc95xx: disable carrier check while suspending
Siva Reddy Kallam <siva.kallam(a)broadcom.com>
tg3: Add PHY reset for 5717/5719/5720 in change ring and flow control paths
Xin Long <lucien.xin(a)gmail.com>
sctp: not allow to set asoc prsctp_enable by sockopt
Eric Dumazet <edumazet(a)google.com>
net-gro: reset skb->pkt_type in napi_reuse_skb()
Sabrina Dubroca <sd(a)queasysnail.net>
ip_tunnel: don't force DF when MTU is locked
Michał Mirosław <mirq-linux(a)rere.qmqm.pl>
ibmvnic: fix accelerated VLAN handling
배석진 <soukjin.bae(a)samsung.com>
flow_dissector: do not dissect l4 ports for fragments
-------------
Diffstat:
.gitignore | 1 +
Kbuild | 25 -----
Makefile | 29 +++--
arch/arm/include/asm/assembler.h | 12 +++
arch/arm/include/asm/barrier.h | 32 ++++++
arch/arm/include/asm/bugs.h | 6 +-
arch/arm/include/asm/cp15.h | 3 +
arch/arm/include/asm/cputype.h | 8 ++
arch/arm/include/asm/kvm_asm.h | 2 -
arch/arm/include/asm/kvm_host.h | 14 ++-
arch/arm/include/asm/kvm_mmu.h | 23 +++-
arch/arm/include/asm/proc-fns.h | 4 +
arch/arm/include/asm/system_misc.h | 15 +++
arch/arm/include/asm/thread_info.h | 4 +-
arch/arm/include/asm/uaccess.h | 26 +++--
arch/arm/kernel/Makefile | 1 +
arch/arm/kernel/bugs.c | 18 ++++
arch/arm/kernel/entry-common.S | 18 ++--
arch/arm/kernel/entry-header.S | 25 +++++
arch/arm/kernel/signal.c | 55 +++++-----
arch/arm/kernel/smp.c | 4 +
arch/arm/kernel/suspend.c | 2 +
arch/arm/kernel/sys_oabi-compat.c | 8 +-
arch/arm/kvm/hyp/hyp-entry.S | 112 ++++++++++++++++++-
arch/arm/lib/copy_from_user.S | 9 ++
arch/arm/mm/Kconfig | 23 ++++
arch/arm/mm/Makefile | 2 +-
arch/arm/mm/fault.c | 3 +
arch/arm/mm/proc-macros.S | 3 +-
arch/arm/mm/proc-v7-2level.S | 6 --
arch/arm/mm/proc-v7-bugs.c | 174 ++++++++++++++++++++++++++++++
arch/arm/mm/proc-v7.S | 154 ++++++++++++++++++++------
arch/arm/vfp/vfpmodule.c | 17 ++-
arch/arm64/crypto/sha1-ce-core.S | 6 +-
arch/arm64/crypto/sha1-ce-glue.c | 11 +-
arch/arm64/crypto/sha2-ce-core.S | 6 +-
arch/arm64/crypto/sha2-ce-glue.c | 13 +--
arch/arm64/include/asm/efi.h | 3 +
arch/arm64/include/asm/uaccess.h | 4 +-
arch/ia64/kernel/Makefile | 26 +----
arch/x86/Makefile | 39 +++++--
arch/x86/boot/string.c | 9 ++
arch/x86/crypto/aes_ctrby8_avx-x86_64.S | 7 +-
drivers/firmware/efi/libstub/Makefile | 26 +++--
drivers/firmware/efi/libstub/arm64-stub.c | 10 +-
drivers/net/ethernet/broadcom/tg3.c | 18 +++-
drivers/net/ethernet/ibm/ibmvnic.c | 2 +-
drivers/net/usb/smsc95xx.c | 7 ++
drivers/xen/Makefile | 3 -
include/linux/kbuild.h | 6 +-
include/linux/module.h | 4 +-
net/core/dev.c | 4 +
net/core/flow_dissector.c | 4 +-
net/ipv4/inet_fragment.c | 28 ++---
net/ipv4/ip_tunnel_core.c | 2 +-
net/ipv6/route.c | 7 +-
net/sctp/socket.c | 26 +----
scripts/Kbuild.include | 18 +++-
scripts/Makefile.build | 8 ++
scripts/Makefile.extrawarn | 1 -
scripts/Makefile.host | 6 --
scripts/Makefile.lib | 31 ++++++
scripts/mod/Makefile | 28 +----
63 files changed, 903 insertions(+), 298 deletions(-)
I'm announcing the release of the 4.14.83 kernel.
All users of the 4.14 kernel series must upgrade.
The updated 4.14.y git tree can be found at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-4.14.y
and can be browsed at the normal kernel.org git web browser:
http://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary
thanks,
greg k-h
------------
Makefile | 2
arch/arm/boot/dts/r8a7791.dtsi | 2
arch/arm/boot/dts/r8a7793.dtsi | 2
arch/x86/kernel/cpu/bugs.c | 57 ++----------------------
drivers/net/dsa/microchip/ksz_common.c | 10 ++--
drivers/net/ethernet/broadcom/bcmsysport.c | 15 ++----
drivers/net/ethernet/broadcom/tg3.c | 18 ++++++-
drivers/net/ethernet/ibm/ibmvnic.c | 2
drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 1
drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c | 6 +-
drivers/net/phy/mdio-gpio.c | 10 ++--
drivers/net/tun.c | 6 ++
drivers/net/usb/smsc95xx.c | 9 +++
include/uapi/linux/sctp.h | 2
kernel/cpu.c | 11 ----
net/core/dev.c | 4 +
net/core/flow_dissector.c | 4 -
net/ipv4/inet_fragment.c | 28 ++++++-----
net/ipv4/ip_tunnel_core.c | 2
net/ipv6/route.c | 7 ++
net/sctp/socket.c | 26 ++--------
net/sctp/stream.c | 1
22 files changed, 95 insertions(+), 130 deletions(-)
Chris Paterson (2):
ARM: dts: r8a7791: Correct critical CPU temperature
ARM: dts: r8a7793: Correct critical CPU temperature
David Ahern (1):
ipv6: Fix PMTU updates for UDP/raw sockets in presence of VRF
Eric Dumazet (2):
net-gro: reset skb->pkt_type in napi_reuse_skb()
inet: frags: better deal with smp races
Florian Fainelli (1):
net: systemport: Protect stop from timeout
Frieder Schrempf (1):
usbnet: smsc95xx: disable carrier check while suspending
Greg Kroah-Hartman (2):
Revert "x86/speculation: Enable cross-hyperthread spectre v2 STIBP mitigation"
Linux 4.14.83
Martin Schiller (1):
net: phy: mdio-gpio: Fix working over slow can_sleep GPIOs
Matthew Cover (1):
tuntap: fix multiqueue rx
Michał Mirosław (1):
ibmvnic: fix accelerated VLAN handling
Sabrina Dubroca (1):
ip_tunnel: don't force DF when MTU is locked
Shalom Toledo (1):
mlxsw: spectrum: Fix IP2ME CPU policer configuration
Siva Reddy Kallam (1):
tg3: Add PHY reset for 5717/5719/5720 in change ring and flow control paths
Stefan Wahren (1):
net: smsc95xx: Fix MTU range
Subash Abhinov Kasiviswanathan (1):
net: qualcomm: rmnet: Fix incorrect assignment of real_dev
Tristram Ha (1):
net: dsa: microchip: initialize mutex before use
Xin Long (3):
sctp: not allow to set asoc prsctp_enable by sockopt
sctp: fix strchange_flags name for Stream Change Event
sctp: not increase stream's incnt before sending addstrm_in request
배석진 (1):
flow_dissector: do not dissect l4 ports for fragments
From: Jerome Brunet <jbrunet(a)baylibre.com>
[ Upstream commit e39f9dd8206ad66992ac0e6218ef1ba746f2cce9 ]
If a bias is enabled on a pin of an Amlogic SoC, calling .pin_config_set()
with PIN_CONFIG_BIAS_DISABLE will not disable the bias. Instead it will
force a pull-down bias on the pin.
Instead of the pull type register bank, the driver should access the pull
enable register bank.
Fixes: 6ac730951104 ("pinctrl: add driver for Amlogic Meson SoCs")
Signed-off-by: Jerome Brunet <jbrunet(a)baylibre.com>
Acked-by: Neil Armstrong <narmstrong(a)baylibre.com>
Signed-off-by: Linus Walleij <linus.walleij(a)linaro.org>
Signed-off-by: Sasha Levin <sashal(a)kernel.org>
---
drivers/pinctrl/meson/pinctrl-meson.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/meson/pinctrl-meson.c b/drivers/pinctrl/meson/pinctrl-meson.c
index 9443c9d408c6..df61a71420b1 100644
--- a/drivers/pinctrl/meson/pinctrl-meson.c
+++ b/drivers/pinctrl/meson/pinctrl-meson.c
@@ -275,7 +275,7 @@ static int meson_pinconf_set(struct pinctrl_dev *pcdev, unsigned int pin,
dev_dbg(pc->dev, "pin %u: disable bias\n", pin);
meson_calc_reg_and_bit(bank, pin, REG_PULL, ®, &bit);
- ret = regmap_update_bits(pc->reg_pull, reg,
+ ret = regmap_update_bits(pc->reg_pullen, reg,
BIT(bit), 0);
if (ret)
return ret;
--
2.17.1
This is an automatic generated email to let you know that the following patch were queued:
Subject: media: gspca: fix frame overflow error
Author: Hans Verkuil <hverkuil(a)xs4all.nl>
Date: Tue Nov 20 05:13:04 2018 -0500
When converting gspca to vb2 I missed that fact that the buffer sizes
were rounded up to the next page size. As a result some gspca drivers
(spca561 being one of them) reported frame overflows.
Modify the code to align the buffer sizes to the next page size, just
as the original code did.
Fixes: 1f5965c4dfd7 ("media: gspca: convert to vb2")
Tested-off-by: Hans Verkuil <hans.verkuil(a)cisco.com>
Signed-off-by: Hans Verkuil <hans.verkuil(a)cisco.com>
Reported-by: softwarebugs <softwarebugs(a)protonmail.com>
Cc: <stable(a)vger.kernel.org> # for v4.18 and up
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung(a)kernel.org>
drivers/media/usb/gspca/gspca.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
---
diff --git a/drivers/media/usb/gspca/gspca.c b/drivers/media/usb/gspca/gspca.c
index fce9d6f4b7c9..3137f5d89d80 100644
--- a/drivers/media/usb/gspca/gspca.c
+++ b/drivers/media/usb/gspca/gspca.c
@@ -426,10 +426,10 @@ void gspca_frame_add(struct gspca_dev *gspca_dev,
/* append the packet to the frame buffer */
if (len > 0) {
- if (gspca_dev->image_len + len > gspca_dev->pixfmt.sizeimage) {
+ if (gspca_dev->image_len + len > PAGE_ALIGN(gspca_dev->pixfmt.sizeimage)) {
gspca_err(gspca_dev, "frame overflow %d > %d\n",
gspca_dev->image_len + len,
- gspca_dev->pixfmt.sizeimage);
+ PAGE_ALIGN(gspca_dev->pixfmt.sizeimage));
packet_type = DISCARD_PACKET;
} else {
/* !! image is NULL only when last pkt is LAST or DISCARD
@@ -1297,18 +1297,19 @@ static int gspca_queue_setup(struct vb2_queue *vq,
unsigned int sizes[], struct device *alloc_devs[])
{
struct gspca_dev *gspca_dev = vb2_get_drv_priv(vq);
+ unsigned int size = PAGE_ALIGN(gspca_dev->pixfmt.sizeimage);
if (*nplanes)
- return sizes[0] < gspca_dev->pixfmt.sizeimage ? -EINVAL : 0;
+ return sizes[0] < size ? -EINVAL : 0;
*nplanes = 1;
- sizes[0] = gspca_dev->pixfmt.sizeimage;
+ sizes[0] = size;
return 0;
}
static int gspca_buffer_prepare(struct vb2_buffer *vb)
{
struct gspca_dev *gspca_dev = vb2_get_drv_priv(vb->vb2_queue);
- unsigned long size = gspca_dev->pixfmt.sizeimage;
+ unsigned long size = PAGE_ALIGN(gspca_dev->pixfmt.sizeimage);
if (vb2_plane_size(vb, 0) < size) {
gspca_err(gspca_dev, "buffer too small (%lu < %lu)\n",
This is an automatic generated email to let you know that the following patch were queued:
Subject: media: gspca: fix frame overflow error
Author: Hans Verkuil <hverkuil(a)xs4all.nl>
Date: Tue Nov 20 05:13:04 2018 -0500
When converting gspca to vb2 I missed that fact that the buffer sizes
were rounded up to the next page size. As a result some gspca drivers
(spca561 being one of them) reported frame overflows.
Modify the code to align the buffer sizes to the next page size, just
as the original code did.
Fixes: 1f5965c4dfd7 ("media: gspca: convert to vb2")
Tested-off-by: Hans Verkuil <hans.verkuil(a)cisco.com>
Signed-off-by: Hans Verkuil <hans.verkuil(a)cisco.com>
Reported-by: softwarebugs <softwarebugs(a)protonmail.com>
Cc: <stable(a)vger.kernel.org> # for v4.18 and up
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung(a)kernel.org>
drivers/media/usb/gspca/gspca.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
---
diff --git a/drivers/media/usb/gspca/gspca.c b/drivers/media/usb/gspca/gspca.c
index fce9d6f4b7c9..3137f5d89d80 100644
--- a/drivers/media/usb/gspca/gspca.c
+++ b/drivers/media/usb/gspca/gspca.c
@@ -426,10 +426,10 @@ void gspca_frame_add(struct gspca_dev *gspca_dev,
/* append the packet to the frame buffer */
if (len > 0) {
- if (gspca_dev->image_len + len > gspca_dev->pixfmt.sizeimage) {
+ if (gspca_dev->image_len + len > PAGE_ALIGN(gspca_dev->pixfmt.sizeimage)) {
gspca_err(gspca_dev, "frame overflow %d > %d\n",
gspca_dev->image_len + len,
- gspca_dev->pixfmt.sizeimage);
+ PAGE_ALIGN(gspca_dev->pixfmt.sizeimage));
packet_type = DISCARD_PACKET;
} else {
/* !! image is NULL only when last pkt is LAST or DISCARD
@@ -1297,18 +1297,19 @@ static int gspca_queue_setup(struct vb2_queue *vq,
unsigned int sizes[], struct device *alloc_devs[])
{
struct gspca_dev *gspca_dev = vb2_get_drv_priv(vq);
+ unsigned int size = PAGE_ALIGN(gspca_dev->pixfmt.sizeimage);
if (*nplanes)
- return sizes[0] < gspca_dev->pixfmt.sizeimage ? -EINVAL : 0;
+ return sizes[0] < size ? -EINVAL : 0;
*nplanes = 1;
- sizes[0] = gspca_dev->pixfmt.sizeimage;
+ sizes[0] = size;
return 0;
}
static int gspca_buffer_prepare(struct vb2_buffer *vb)
{
struct gspca_dev *gspca_dev = vb2_get_drv_priv(vb->vb2_queue);
- unsigned long size = gspca_dev->pixfmt.sizeimage;
+ unsigned long size = PAGE_ALIGN(gspca_dev->pixfmt.sizeimage);
if (vb2_plane_size(vb, 0) < size) {
gspca_err(gspca_dev, "buffer too small (%lu < %lu)\n",
The Intel IOMMU driver opportunistically skips a few top level page
tables from the domain paging directory while programming the IOMMU
context entry. However there is an implicit assumption in the code that
domain's adjusted guest address width (agaw) would always be greater
than IOMMU's agaw.
The IOMMU capabilities in an upcoming platform cause the domain's agaw
to be lower than IOMMU's agaw. The issue is seen when the IOMMU supports
both 4-level and 5-level paging. The domain builds a 4-level page table
based on agaw of 2. However the IOMMU's agaw is set as 3 (5-level). In
this case the code incorrectly tries to skip page page table levels.
This causes the IOMMU driver to avoid programming the context entry. The
fix handles this case and programs the context entry accordingly.
Fixes: de24e55395698 ("iommu/vt-d: Simplify domain_context_mapping_one")
Cc: <stable(a)vger.kernel.org>
Cc: Ashok Raj <ashok.raj(a)intel.com>
Cc: Jacob Pan <jacob.jun.pan(a)linux.intel.com>
Cc: Lu Baolu <baolu.lu(a)linux.intel.com>
Reviewed-by: Lu Baolu <baolu.lu(a)linux.intel.com>
Reported-by: Ramos Falcon, Ernesto R <ernesto.r.ramos.falcon(a)intel.com>
Tested-by: Ricardo Neri <ricardo.neri-calderon(a)linux.intel.com>
Signed-off-by: Sohil Mehta <sohil.mehta(a)intel.com>
---
drivers/iommu/intel-iommu.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c
index f3ccf025108b..fdf79baf1d79 100644
--- a/drivers/iommu/intel-iommu.c
+++ b/drivers/iommu/intel-iommu.c
@@ -2044,7 +2044,7 @@ static int domain_context_mapping_one(struct dmar_domain *domain,
* than default. Unnecessary for PT mode.
*/
if (translation != CONTEXT_TT_PASS_THROUGH) {
- for (agaw = domain->agaw; agaw != iommu->agaw; agaw--) {
+ for (agaw = domain->agaw; agaw > iommu->agaw; agaw--) {
ret = -ENOMEM;
pgd = phys_to_virt(dma_pte_addr(pgd));
if (!dma_pte_present(pgd))
@@ -2058,7 +2058,7 @@ static int domain_context_mapping_one(struct dmar_domain *domain,
translation = CONTEXT_TT_MULTI_LEVEL;
context_set_address_root(context, virt_to_phys(pgd));
- context_set_address_width(context, iommu->agaw);
+ context_set_address_width(context, agaw);
} else {
/*
* In pass through mode, AW must be programmed to
--
2.19.0
>>> On 22.11.18 at 07:58, <sashal(a)kernel.org> wrote:
> [This is an automated email]
>
> This commit has been processed because it contains a "Fixes:" tag,
> fixing commit: 7f2590a110b8 x86/entry/64: Use a per-CPU trampoline stack for
> IDT entries.
>
> The bot has tested the following trees: v4.19.2, v4.18.19, v4.14.81.
>
> v4.19.2: Build OK!
> v4.18.19: Build OK!
> v4.14.81: Failed to apply! Possible dependencies:
> Unable to calculate
>
>
> How should we proceed with this patch?
Before evaluating backporting options, how about we first settle
on what's to go into the master branch?
Jan
This reverts commit 46431d9c28f6859f8e568ac7db92137f1da31100.
This commit fixes a bug in upstream commit a136f59c0a1f ("vb2: Move
buffer cache synchronisation to prepare from queue") which isn't
present in 4.4.
So as a result you get an UNBALANCED message in the kernel log if
this patch is applied:
vb2: counters for queue ffffffc0f3687478, buffer 3: UNBALANCED!
vb2: buf_init: 1 buf_cleanup: 1 buf_prepare: 805 buf_finish: 805
vb2: buf_queue: 806 buf_done: 806
vb2: alloc: 0 put: 0 prepare: 806 finish: 805 mmap: 0
vb2: get_userptr: 0 put_userptr: 0
vb2: attach_dmabuf: 1 detach_dmabuf: 1 map_dmabuf: 805 unmap_dmabuf: 805
vb2: get_dmabuf: 0 num_users: 1609 vaddr: 0 cookie: 805
Reverting this patch solves this regression.
Signed-off-by: Hans Verkuil <hans.verkuil(a)cisco.com>
---
Probably two reasons why this slipped through:
1) The patch was missing a Fixes: tag
2) I was probably CC-ed about this when it was about to be added to 4.9
but didn't realize that that was wrong.
---
drivers/media/v4l2-core/videobuf2-core.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/media/v4l2-core/videobuf2-core.c b/drivers/media/v4l2-core/videobuf2-core.c
index 1c37d5a..8ce9c63 100644
--- a/drivers/media/v4l2-core/videobuf2-core.c
+++ b/drivers/media/v4l2-core/videobuf2-core.c
@@ -870,12 +870,9 @@ void vb2_buffer_done(struct vb2_buffer *vb, enum vb2_buffer_state state)
dprintk(4, "done processing on buffer %d, state: %d\n",
vb->index, state);
- if (state != VB2_BUF_STATE_QUEUED &&
- state != VB2_BUF_STATE_REQUEUEING) {
- /* sync buffers */
- for (plane = 0; plane < vb->num_planes; ++plane)
- call_void_memop(vb, finish, vb->planes[plane].mem_priv);
- }
+ /* sync buffers */
+ for (plane = 0; plane < vb->num_planes; ++plane)
+ call_void_memop(vb, finish, vb->planes[plane].mem_priv);
spin_lock_irqsave(&q->done_lock, flags);
if (state == VB2_BUF_STATE_QUEUED ||
--
2.10.2
Salaam Aleikum,
The economy of Iraq has been devastated by the recent war, now that the war is winding down the emphasis in Iraq has turned to rebuilding a viable, vibrant economy, in this light the Iraq Reconstruction Management Office (IRMO) have been saddled with a renewed mandate from the Iraqi government to solicit, evaluate and recommend companies/individuals to work as partners in "THE RE-BUILD IRAQ PROJECT ". The launch of ongoing sourcing and bulk supply strategies has opened up new streams of public sector supply opportunities, as your company/individual has been shortlisted for this purpose and to participate " This project entails supplying various items for the Humanitarian Aid & Reconstruction Projects scheduled for all Provinces in the whole of Iraq.Please note given the current exigent circumstances in Iraq, the (IRMO) are currently accepting quotes to the port of Aquaba, Jordan from foreign contractors and Adhoc disbursement centers are now been utilized to expedite payments to contractors through our European payment centers..
Please kindly confirm your willingness to partake in this bulk supplies and contracting program under this new initiative "THE RE-BUILD IRAQ PROJECT ". Note confirmation should be strictly by our email as written below, in order to allow us send detailed procedures and the accompanying Iraq Reconstruction Management Office (IRMO) questionnaire will be sent promptly. Thank you for your co-operation.
Yours Faithfully,
Dr. Rahman Mahmoud
Email: drrahmanmahm(a)gmail.com
Commit-ID: 472de49fdc53365c880ab81ae2b5cfdd83db0b06
Gitweb: https://git.kernel.org/tip/472de49fdc53365c880ab81ae2b5cfdd83db0b06
Author: Jiri Olsa <jolsa(a)kernel.org>
AuthorDate: Wed, 21 Nov 2018 11:16:12 +0100
Committer: Ingo Molnar <mingo(a)kernel.org>
CommitDate: Thu, 22 Nov 2018 09:45:10 +0100
perf/x86/intel: Disallow precise_ip on BTS events
Vince reported a crash in the BTS flush code when touching the callchain
data, which was supposed to be initialized as an 'early' callchain,
but intel_pmu_drain_bts_buffer() does not do that:
BUG: unable to handle kernel NULL pointer dereference at 0000000000000000
...
Call Trace:
<IRQ>
intel_pmu_drain_bts_buffer+0x151/0x220
? intel_get_event_constraints+0x219/0x360
? perf_assign_events+0xe2/0x2a0
? select_idle_sibling+0x22/0x3a0
? __update_load_avg_se+0x1ec/0x270
? enqueue_task_fair+0x377/0xdd0
? cpumask_next_and+0x19/0x20
? load_balance+0x134/0x950
? check_preempt_curr+0x7a/0x90
? ttwu_do_wakeup+0x19/0x140
x86_pmu_stop+0x3b/0x90
x86_pmu_del+0x57/0x160
event_sched_out.isra.106+0x81/0x170
group_sched_out.part.108+0x51/0xc0
__perf_event_disable+0x7f/0x160
event_function+0x8c/0xd0
remote_function+0x3c/0x50
flush_smp_call_function_queue+0x35/0xe0
smp_call_function_single_interrupt+0x3a/0xd0
call_function_single_interrupt+0xf/0x20
</IRQ>
It was triggered by fuzzer but can be easily reproduced by:
# perf record -e cpu/branch-instructions/pu -g -c 1
Peter suggested not to allow branch tracing for precise events:
> Now arguably, this is really stupid behaviour. Who in his right mind
> wants callchain output on BTS entries. And even if they do, BTS +
> precise_ip is nonsensical.
>
> So in my mind disallowing precise_ip on BTS would be the simplest fix.
Suggested-by: Peter Zijlstra <peterz(a)infradead.org>
Reported-by: Vince Weaver <vincent.weaver(a)maine.edu>
Signed-off-by: Jiri Olsa <jolsa(a)kernel.org>
Acked-by: Peter Zijlstra <a.p.zijlstra(a)chello.nl>
Cc: <stable(a)vger.kernel.org>
Cc: Alexander Shishkin <alexander.shishkin(a)linux.intel.com>
Cc: Arnaldo Carvalho de Melo <acme(a)kernel.org>
Cc: Arnaldo Carvalho de Melo <acme(a)redhat.com>
Cc: Jiri Olsa <jolsa(a)redhat.com>
Cc: Linus Torvalds <torvalds(a)linux-foundation.org>
Cc: Stephane Eranian <eranian(a)google.com>
Cc: Thomas Gleixner <tglx(a)linutronix.de>
Fixes: 6cbc304f2f36 ("perf/x86/intel: Fix unwind errors from PEBS entries (mk-II)")
Link: http://lkml.kernel.org/r/20181121101612.16272-3-jolsa@kernel.org
Signed-off-by: Ingo Molnar <mingo(a)kernel.org>
---
arch/x86/events/intel/core.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/x86/events/intel/core.c b/arch/x86/events/intel/core.c
index a15a73788693..ecc3e34ca955 100644
--- a/arch/x86/events/intel/core.c
+++ b/arch/x86/events/intel/core.c
@@ -3106,6 +3106,10 @@ static int intel_pmu_bts_config(struct perf_event *event)
if (!attr->exclude_kernel)
return -EOPNOTSUPP;
+ /* BTS is not allowed for precise events. */
+ if (attr->precise_ip)
+ return -EOPNOTSUPP;
+
/* disallow bts if conflicting events are present */
if (x86_add_exclusive(x86_lbr_exclusive_lbr))
return -EBUSY;