Linux-stable-mirror

linux-stable-mirror@lists.linaro.org

286 participants
124115 discussions

[PATCH 4.20 0/1] Fix regression from arm spectre patch series

by David Long

From: "David A. Long" <dave.long(a)linaro.org> Backport upstream patch for regression introduced from spectre patch series. This was run through kernelci testing. Also the kernel was built with and without BIG_LITTLE and the symbol table was examined to verify the processor tables do not go into .rodata when BIG_LITTLE=n. Russell King (1): ARM: fix the cockup in the previous patch arch/arm/mm/proc-macros.S | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.17.1

6 years, 11 months

stable-rc/linux-4.4.y boot: 88 boots: 2 failed, 84 passed with 2 offline (v4.4.172)

by kernelci.org bot

stable-rc/linux-4.4.y boot: 88 boots: 2 failed, 84 passed with 2 offline (v4.4.172) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-4.4.y/kernel/v4.4.… Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-4.4.y/kernel/v4.4.172/ Tree: stable-rc Branch: linux-4.4.y Git Describe: v4.4.172 Git Commit: 626b008972db6e4977f6b3460400f6f4e6731081 Git URL: http://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Tested: 41 unique boards, 20 SoC families, 12 builds out of 187 Boot Failures Detected: arm64: defconfig qcom-qdf2400: 1 failed lab arm: multi_v7_defconfig stih410-b2120: 1 failed lab Offline Platforms: arm: multi_v7_defconfig: exynos5800-peach-pi: 1 offline lab exynos_defconfig: exynos5800-peach-pi: 1 offline lab --- For more info write to <info(a)kernelci.org>

6 years, 11 months

stable-rc/linux-4.14.y boot: 111 boots: 1 failed, 106 passed with 2 offline, 2 conflicts (v4.14.96)

by kernelci.org bot

stable-rc/linux-4.14.y boot: 111 boots: 1 failed, 106 passed with 2 offline, 2 conflicts (v4.14.96) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-4.14.y/kernel/v4.1… Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-4.14.y/kernel/v4.14.96/ Tree: stable-rc Branch: linux-4.14.y Git Describe: v4.14.96 Git Commit: e6608e1f2fbd5827df9fa0da9ab1ad64f68be8d7 Git URL: http://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Tested: 61 unique boards, 23 SoC families, 11 builds out of 197 Boot Regressions Detected: arm64: defconfig: meson-gxl-s905x-khadas-vim: lab-baylibre-seattle: failing since 1 day (last pass: v4.14.95 - first fail: v4.14.95-63-g1e16acf37196) Boot Failure Detected: arm64: defconfig rk3399-firefly: 1 failed lab Offline Platforms: arm: multi_v7_defconfig: exynos5800-peach-pi: 1 offline lab exynos_defconfig: exynos5800-peach-pi: 1 offline lab Conflicting Boot Failures Detected: (These likely are not failures as other labs are reporting PASS. Needs review.) arm64: defconfig: meson-gxl-s905x-khadas-vim: lab-baylibre: PASS lab-baylibre-seattle: FAIL meson-gxl-s905x-libretech-cc: lab-baylibre: PASS lab-baylibre-seattle: FAIL --- For more info write to <info(a)kernelci.org>

6 years, 11 months

[PATCH] HID: debug: fix the ring buffer implementation

by Vladis Dronov

Ring buffer implementation in hid_debug_event() and hid_debug_events_read() is strange allowing lost or corrupted data. After commit 717adfdaf147 ("HID: debug: check length before copy_to_user()") it is possible to enter an infinite loop in hid_debug_events_read() by providing 0 as count, this locks up a system. Fix this by rewriting the ring buffer implementation with kfifo and simplify the code. This fixes CVE-2019-3819. Link: https://bugzilla.redhat.com/show_bug.cgi?id=1669187 Cc: stable(a)vger.kernel.org # v4.16+ Fixes: cd667ce24796 ("HID: use debugfs for events/reports dumping") Fixes: 717adfdaf147 ("HID: debug: check length before copy_to_user()") Signed-off-by: Vladis Dronov <vdronov(a)redhat.com> --- drivers/hid/hid-debug.c | 116 ++++++++++++++------------------------ include/linux/hid-debug.h | 9 ++- 2 files changed, 47 insertions(+), 78 deletions(-) diff --git a/drivers/hid/hid-debug.c b/drivers/hid/hid-debug.c index c530476edba6..08870c909268 100644 --- a/drivers/hid/hid-debug.c +++ b/drivers/hid/hid-debug.c @@ -30,6 +30,7 @@ #include <linux/debugfs.h> #include <linux/seq_file.h> +#include <linux/kfifo.h> #include <linux/sched/signal.h> #include <linux/export.h> #include <linux/slab.h> @@ -661,17 +662,12 @@ EXPORT_SYMBOL_GPL(hid_dump_device); /* enqueue string to 'events' ring buffer */ void hid_debug_event(struct hid_device *hdev, char *buf) { - unsigned i; struct hid_debug_list *list; unsigned long flags; spin_lock_irqsave(&hdev->debug_list_lock, flags); - list_for_each_entry(list, &hdev->debug_list, node) { - for (i = 0; buf[i]; i++) - list->hid_debug_buf[(list->tail + i) % HID_DEBUG_BUFSIZE] = - buf[i]; - list->tail = (list->tail + i) % HID_DEBUG_BUFSIZE; - } + list_for_each_entry(list, &hdev->debug_list, node) + kfifo_in(&list->hid_debug_fifo, buf, strlen(buf)); spin_unlock_irqrestore(&hdev->debug_list_lock, flags); wake_up_interruptible(&hdev->debug_wait); @@ -722,8 +718,7 @@ void hid_dump_input(struct hid_device *hdev, struct hid_usage *usage, __s32 valu hid_debug_event(hdev, buf); kfree(buf); - wake_up_interruptible(&hdev->debug_wait); - + wake_up_interruptible(&hdev->debug_wait); } EXPORT_SYMBOL_GPL(hid_dump_input); @@ -1083,8 +1078,8 @@ static int hid_debug_events_open(struct inode *inode, struct file *file) goto out; } - if (!(list->hid_debug_buf = kzalloc(HID_DEBUG_BUFSIZE, GFP_KERNEL))) { - err = -ENOMEM; + err = kfifo_alloc(&list->hid_debug_fifo, HID_DEBUG_FIFOSIZE, GFP_KERNEL); + if (err) { kfree(list); goto out; } @@ -1104,77 +1099,55 @@ static ssize_t hid_debug_events_read(struct file *file, char __user *buffer, size_t count, loff_t *ppos) { struct hid_debug_list *list = file->private_data; - int ret = 0, len; + int ret = 0, copied; DECLARE_WAITQUEUE(wait, current); mutex_lock(&list->read_mutex); - while (ret == 0) { - if (list->head == list->tail) { - add_wait_queue(&list->hdev->debug_wait, &wait); - set_current_state(TASK_INTERRUPTIBLE); - - while (list->head == list->tail) { - if (file->f_flags & O_NONBLOCK) { - ret = -EAGAIN; - break; - } - if (signal_pending(current)) { - ret = -ERESTARTSYS; - break; - } - - if (!list->hdev || !list->hdev->debug) { - ret = -EIO; - set_current_state(TASK_RUNNING); - goto out; - } - - /* allow O_NONBLOCK from other threads */ - mutex_unlock(&list->read_mutex); - schedule(); - mutex_lock(&list->read_mutex); - set_current_state(TASK_INTERRUPTIBLE); - } - - set_current_state(TASK_RUNNING); - remove_wait_queue(&list->hdev->debug_wait, &wait); - } - - if (ret) - goto out; + if (kfifo_is_empty(&list->hid_debug_fifo)) { + add_wait_queue(&list->hdev->debug_wait, &wait); + set_current_state(TASK_INTERRUPTIBLE); + + while (kfifo_is_empty(&list->hid_debug_fifo)) { + if (file->f_flags & O_NONBLOCK) { + ret = -EAGAIN; + break; + } + + if (signal_pending(current)) { + ret = -ERESTARTSYS; + break; + } + + if (!list->hdev || !list->hdev->debug) { + ret = -EIO; + set_current_state(TASK_RUNNING); + goto out; + } + + /* allow O_NONBLOCK from other threads */ + mutex_unlock(&list->read_mutex); + schedule(); + mutex_lock(&list->read_mutex); + set_current_state(TASK_INTERRUPTIBLE); + } + + set_current_state(TASK_RUNNING); + remove_wait_queue(&list->hdev->debug_wait, &wait); + } + + if (ret) + goto out; + + if (kfifo_is_empty(&list->hid_debug_fifo)) + goto out; - /* pass the ringbuffer contents to userspace */ -copy_rest: - if (list->tail == list->head) - goto out; - if (list->tail > list->head) { - len = list->tail - list->head; - if (len > count) - len = count; - - if (copy_to_user(buffer + ret, &list->hid_debug_buf[list->head], len)) { - ret = -EFAULT; - goto out; - } - ret += len; - list->head += len; - } else { - len = HID_DEBUG_BUFSIZE - list->head; - if (len > count) - len = count; - - if (copy_to_user(buffer, &list->hid_debug_buf[list->head], len)) { - ret = -EFAULT; - goto out; - } - list->head = 0; - ret += len; - count -= len; - if (count > 0) - goto copy_rest; - } - - } + /* pass the fifo content to userspace, locking is not needed with only + * one concurrent reader and one concurrent writer + */ + ret = kfifo_to_user(&list->hid_debug_fifo, buffer, count, &copied); + if (ret) + goto out; + ret = copied; out: mutex_unlock(&list->read_mutex); return ret; @@ -1185,7 +1158,7 @@ static __poll_t hid_debug_events_poll(struct file *file, poll_table *wait) struct hid_debug_list *list = file->private_data; poll_wait(file, &list->hdev->debug_wait, wait); - if (list->head != list->tail) + if (!kfifo_is_empty(&list->hid_debug_fifo)) return EPOLLIN | EPOLLRDNORM; if (!list->hdev->debug) return EPOLLERR | EPOLLHUP; @@ -1200,7 +1173,7 @@ static int hid_debug_events_release(struct inode *inode, struct file *file) spin_lock_irqsave(&list->hdev->debug_list_lock, flags); list_del(&list->node); spin_unlock_irqrestore(&list->hdev->debug_list_lock, flags); - kfree(list->hid_debug_buf); + kfifo_free(&list->hid_debug_fifo); kfree(list); return 0; @@ -1246,4 +1219,3 @@ void hid_debug_exit(void) { debugfs_remove_recursive(hid_debug_root); } - diff --git a/include/linux/hid-debug.h b/include/linux/hid-debug.h index 8663f216c563..e7a7c92aaf09 100644 --- a/include/linux/hid-debug.h +++ b/include/linux/hid-debug.h @@ -24,7 +24,10 @@ #ifdef CONFIG_DEBUG_FS +#include <linux/kfifo.h> + #define HID_DEBUG_BUFSIZE 512 +#define HID_DEBUG_FIFOSIZE 512 void hid_dump_input(struct hid_device *, struct hid_usage *, __s32); void hid_dump_report(struct hid_device *, int , u8 *, int); @@ -38,10 +41,7 @@ void hid_debug_event(struct hid_device *, char *); void hid_debug_event(struct hid_device *, char *); - struct hid_debug_list { - char *hid_debug_buf; - int head; - int tail; + DECLARE_KFIFO_PTR(hid_debug_fifo, char); struct fasync_struct *fasync; struct hid_device *hdev; struct list_head node; @@ -64,4 +64,3 @@ struct hid_debug_list { #endif #endif -

6 years, 11 months

stable-rc/linux-4.19.y boot: 114 boots: 1 failed, 109 passed with 2 offline, 1 untried/unknown, 1 conflict (v4.19.18)

by kernelci.org bot

stable-rc/linux-4.19.y boot: 114 boots: 1 failed, 109 passed with 2 offline, 1 untried/unknown, 1 conflict (v4.19.18) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-4.19.y/kernel/v4.1… Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-4.19.y/kernel/v4.19.18/ Tree: stable-rc Branch: linux-4.19.y Git Describe: v4.19.18 Git Commit: 34ae657246154f095288059157e722ccf69f3b63 Git URL: http://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Tested: 63 unique boards, 23 SoC families, 12 builds out of 202 Boot Regressions Detected: arm: tegra_defconfig: tegra124-nyan-big: lab-collabora: new failure (last pass: v4.19.17-107-g3784655a0f02) arm64: defconfig: meson-gxl-s905x-khadas-vim: lab-baylibre-seattle: failing since 4 days (last pass: v4.19.16 - first fail: v4.19.16-100-ge43bc298813d) Boot Failure Detected: arm: tegra_defconfig tegra124-nyan-big: 1 failed lab Offline Platforms: arm: multi_v7_defconfig: exynos5800-peach-pi: 1 offline lab exynos_defconfig: exynos5800-peach-pi: 1 offline lab Conflicting Boot Failure Detected: (These likely are not failures as other labs are reporting PASS. Needs review.) arm64: defconfig: meson-gxl-s905x-khadas-vim: lab-baylibre: PASS lab-baylibre-seattle: FAIL --- For more info write to <info(a)kernelci.org>

6 years, 11 months

PASS: Test report for kernel 4.20.5.cki (linux-stable-rc)

by CKI

Hello, We ran automated tests on a recent commit from this kernel tree: Kernel repo: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Commit: 9f1a389a0b5b Linux 4.20.5 The results of these automated tests are provided below. Overall result: PASSED Patch merge: OK Compile: OK Kernel tests: OK Please reply to this email if you have any questions about the tests that we ran or if you have any suggestions on how to make future tests more effective. ,-. ,-. ( C ) ( K ) Continuous `-',-.`-' Kernel ( I ) Integration `-' ______________________________________________________________________________ Compile testing --------------- We compiled the kernel for 4 architectures: s390x: make options: make INSTALL_MOD_STRIP=1 -j64 targz-pkg -j64 configuration: https://artifacts.cki-project.org/builds/s390x/9f1a389a0b5b4004757759e26e2f… powerpc64le: make options: make INSTALL_MOD_STRIP=1 -j64 targz-pkg -j64 configuration: https://artifacts.cki-project.org/builds/ppc64le/9f1a389a0b5b4004757759e26e… aarch64: make options: make INSTALL_MOD_STRIP=1 -j64 targz-pkg -j64 configuration: https://artifacts.cki-project.org/builds/aarch64/9f1a389a0b5b4004757759e26e… x86_64: make options: make INSTALL_MOD_STRIP=1 -j64 targz-pkg -j64 configuration: https://artifacts.cki-project.org/builds/x86_64/9f1a389a0b5b4004757759e26e2… Hardware testing ---------------- We booted each kernel and ran the following tests: s390: Boot test - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… /distribution/command LTP lite - release 20180926 - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… Memory function: memfd_create - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#/memory/func… AMTU (Abstract Machine Test Utility) - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#misc/amtu Networking route: pmtu - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#/networking/… powerpc: Boot test - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… /distribution/command LTP lite - release 20180926 - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… xfstests: ext4 - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#/filesystems… xfstests: xfs - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#/filesystems… Memory function: memfd_create - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#/memory/func… AMTU (Abstract Machine Test Utility) - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#misc/amtu Networking route: pmtu - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#/networking/… Usex - version 1.9-29 - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#standards/us… arm64: Boot test - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… /distribution/command LTP lite - release 20180926 - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… xfstests: ext4 - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#/filesystems… xfstests: xfs - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#/filesystems… Memory function: memfd_create - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#/memory/func… AMTU (Abstract Machine Test Utility) - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#misc/amtu Networking route: pmtu - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#/networking/… Usex - version 1.9-29 - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#standards/us… x86_64: Boot test - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… /distribution/command LTP lite - release 20180926 - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#distribution… xfstests: ext4 - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#/filesystems… xfstests: xfs - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#/filesystems… Memory function: memfd_create - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#/memory/func… AMTU (Abstract Machine Test Utility) - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#misc/amtu Networking route: pmtu - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#/networking/… Usex - version 1.9-29 - URL: https://github.com/CKI-project/tests-beaker/archive/master.zip#standards/us…

6 years, 11 months

stable/linux-4.9.y boot: 98 boots: 0 failed, 96 passed with 2 offline (v4.9.153)

by kernelci.org bot

stable/linux-4.9.y boot: 98 boots: 0 failed, 96 passed with 2 offline (v4.9.153) Full Boot Summary: https://kernelci.org/boot/all/job/stable/branch/linux-4.9.y/kernel/v4.9.153/ Full Build Summary: https://kernelci.org/build/stable/branch/linux-4.9.y/kernel/v4.9.153/ Tree: stable Branch: linux-4.9.y Git Describe: v4.9.153 Git Commit: 189b75ad3fc2d4a0d40a818ca298526d254ccdc4 Git URL: http://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git Tested: 48 unique boards, 21 SoC families, 13 builds out of 192 Offline Platforms: arm: multi_v7_defconfig: exynos5800-peach-pi: 1 offline lab exynos_defconfig: exynos5800-peach-pi: 1 offline lab --- For more info write to <info(a)kernelci.org>

6 years, 11 months

stable-rc/linux-4.9.y boot: 98 boots: 0 failed, 96 passed with 2 offline (v4.9.153)

by kernelci.org bot

stable-rc/linux-4.9.y boot: 98 boots: 0 failed, 96 passed with 2 offline (v4.9.153) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-4.9.y/kernel/v4.9.… Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-4.9.y/kernel/v4.9.153/ Tree: stable-rc Branch: linux-4.9.y Git Describe: v4.9.153 Git Commit: 189b75ad3fc2d4a0d40a818ca298526d254ccdc4 Git URL: http://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Tested: 48 unique boards, 21 SoC families, 13 builds out of 193 Offline Platforms: arm: multi_v7_defconfig: exynos5800-peach-pi: 1 offline lab exynos_defconfig: exynos5800-peach-pi: 1 offline lab --- For more info write to <info(a)kernelci.org>

6 years, 11 months

stable-rc/linux-4.20.y boot: 116 boots: 1 failed, 112 passed with 2 offline, 1 conflict (v4.20.5)

by kernelci.org bot

stable-rc/linux-4.20.y boot: 116 boots: 1 failed, 112 passed with 2 offline, 1 conflict (v4.20.5) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-4.20.y/kernel/v4.2… Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-4.20.y/kernel/v4.20.5/ Tree: stable-rc Branch: linux-4.20.y Git Describe: v4.20.5 Git Commit: 9f1a389a0b5b4004757759e26e2ff459016515ac Git URL: http://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Tested: 65 unique boards, 23 SoC families, 13 builds out of 202 Boot Regressions Detected: arm64: defconfig: meson-gxl-s905x-khadas-vim: lab-baylibre-seattle: failing since 1 day (last pass: v4.20.4-128-g67963d8b5ca5 - first fail: v4.20.4-127-gc3515872cb7f) Boot Failure Detected: arm64: defconfig mt7622-rfb1: 1 failed lab Offline Platforms: arm: multi_v7_defconfig: exynos5800-peach-pi: 1 offline lab exynos_defconfig: exynos5800-peach-pi: 1 offline lab Conflicting Boot Failure Detected: (These likely are not failures as other labs are reporting PASS. Needs review.) arm64: defconfig: meson-gxl-s905x-khadas-vim: lab-baylibre: PASS lab-baylibre-seattle: FAIL --- For more info write to <info(a)kernelci.org>

6 years, 11 months

stable-rc/linux-3.18.y boot: 51 boots: 0 failed, 48 passed with 2 offline, 1 conflict (v3.18.133)

by kernelci.org bot

stable-rc/linux-3.18.y boot: 51 boots: 0 failed, 48 passed with 2 offline, 1 conflict (v3.18.133) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-3.18.y/kernel/v3.1… Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-3.18.y/kernel/v3.18.133/ Tree: stable-rc Branch: linux-3.18.y Git Describe: v3.18.133 Git Commit: 4c35624dcb3bce026bb08eb04085c187bafff863 Git URL: http://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Tested: 21 unique boards, 11 SoC families, 11 builds out of 185 Boot Regressions Detected: arm: tegra_defconfig: tegra124-jetson-tk1: lab-baylibre: new failure (last pass: v3.18.132-53-g8887b6a3fea6) Offline Platforms: arm: multi_v7_defconfig: exynos5800-peach-pi: 1 offline lab exynos_defconfig: exynos5800-peach-pi: 1 offline lab Conflicting Boot Failure Detected: (These likely are not failures as other labs are reporting PASS. Needs review.) arm: tegra_defconfig: tegra124-jetson-tk1: lab-baylibre: FAIL lab-baylibre-seattle: PASS lab-mhart: PASS lab-collabora: PASS --- For more info write to <info(a)kernelci.org>

6 years, 11 months

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror