Linux-stable-mirror

linux-stable-mirror@lists.linaro.org

54 participants
123755 discussions

FAILED: patch "[PATCH] usb: xhci: fix uninitialized completion when USB3 port got" failed to apply to 4.14-stable tree

by gregkh＠linuxfoundation.org

The patch below does not apply to the 4.14-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <stable(a)vger.kernel.org>. thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From 958c0bd86075d4ef1c936998deefe1947e539240 Mon Sep 17 00:00:00 2001 From: Aaron Ma <aaron.ma(a)canonical.com> Date: Fri, 9 Nov 2018 17:21:20 +0200 Subject: [PATCH] usb: xhci: fix uninitialized completion when USB3 port got wrong status Realtek USB3.0 Card Reader [0bda:0328] reports wrong port status on Cannon lake PCH USB3.1 xHCI [8086:a36d] after resume from S3, after clear port reset it works fine. Since this device is registered on USB3 roothub at boot, when port status reports not superspeed, xhci_get_port_status will call an uninitialized completion in bus_state[0]. Kernel will hang because of NULL pointer. Restrict the USB2 resume status check in USB2 roothub to fix hang issue. Cc: stable(a)vger.kernel.org Signed-off-by: Aaron Ma <aaron.ma(a)canonical.com> Signed-off-by: Mathias Nyman <mathias.nyman(a)linux.intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> diff --git a/drivers/usb/host/xhci-hub.c b/drivers/usb/host/xhci-hub.c index 12eea73d9f20..60e4ac7ae4f8 100644 --- a/drivers/usb/host/xhci-hub.c +++ b/drivers/usb/host/xhci-hub.c @@ -876,7 +876,7 @@ static u32 xhci_get_port_status(struct usb_hcd *hcd, status |= USB_PORT_STAT_SUSPEND; } if ((raw_port_status & PORT_PLS_MASK) == XDEV_RESUME && - !DEV_SUPERSPEED_ANY(raw_port_status)) { + !DEV_SUPERSPEED_ANY(raw_port_status) && hcd->speed < HCD_USB3) { if ((raw_port_status & PORT_RESET) || !(raw_port_status & PORT_PE)) return 0xffffffff; diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c index 730a6ecd85fc..250b758efe9f 100644 --- a/drivers/usb/host/xhci-ring.c +++ b/drivers/usb/host/xhci-ring.c @@ -1646,7 +1646,7 @@ static void handle_port_status(struct xhci_hcd *xhci, * RExit to a disconnect state). If so, let the the driver know it's * out of the RExit state. */ - if (!DEV_SUPERSPEED_ANY(portsc) && + if (!DEV_SUPERSPEED_ANY(portsc) && hcd->speed < HCD_USB3 && test_and_clear_bit(hcd_portnum, &bus_state->rexit_ports)) { complete(&bus_state->rexit_done[hcd_portnum]);

7 years, 1 month

4.14 patches for arm32 clang

by Nick Desaulniers

Greg, Please see the attached mbox of 5 patches. The first required a slight backport as noted in the commit message, but the others applied cleanly. Here's a build+boot of them in clang: https://travis-ci.com/ClangBuiltLinux/continuous-integration/builds/92778054 (obviously we need to backport warning cleanups, but this set gets it booting at least) -- Thanks, ~Nick Desaulniers

7 years, 1 month

[PATCH] efi/libstub: arm: support building with clang

by ndesaulniers＠google.com

From: Alistair Strachan <astrachan(a)google.com> (commit 41f1c48420709470c51ee0e54b6fb28b956bb4e0 upstream) When building with CONFIG_EFI and CONFIG_EFI_STUB on ARM, the libstub Makefile would use -mno-single-pic-base without checking it was supported by the compiler. As the ARM (32-bit) clang backend does not support this flag, the build would fail. This changes the Makefile to check the compiler's support for -mno-single-pic-base before using it, similar to c1c386681bd7 ("ARM: 8767/1: add support for building ARM kernel with clang"). Signed-off-by: Alistair Strachan <astrachan(a)google.com> Reviewed-by: Stefan Agner <stefan(a)agner.ch> Signed-off-by: Ard Biesheuvel <ard.biesheuvel(a)linaro.org> Signed-off-by: Nick Desaulniers <ndesaulniers(a)google.com> --- Please land in 4.19, 4.18. I'm preparing backports for 4.9 and 4.4 I will send today or tomorrow. This is for building the Linux kernel for arm32 with Clang. drivers/firmware/efi/libstub/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/firmware/efi/libstub/Makefile b/drivers/firmware/efi/libstub/Makefile index 14c40a7750d1..c51627660dbb 100644 --- a/drivers/firmware/efi/libstub/Makefile +++ b/drivers/firmware/efi/libstub/Makefile @@ -16,7 +16,8 @@ cflags-$(CONFIG_X86) += -m$(BITS) -D__KERNEL__ -O2 \ cflags-$(CONFIG_ARM64) := $(subst -pg,,$(KBUILD_CFLAGS)) -fpie \ $(DISABLE_STACKLEAK_PLUGIN) cflags-$(CONFIG_ARM) := $(subst -pg,,$(KBUILD_CFLAGS)) \ - -fno-builtin -fpic -mno-single-pic-base + -fno-builtin -fpic \ + $(call cc-option,-mno-single-pic-base) cflags-$(CONFIG_EFI_ARMSTUB) += -I$(srctree)/scripts/dtc/libfdt -- 2.20.0.rc0.387.gc7a69e6b6c-goog

7 years, 1 month

[RFC PATCH] btrfs: drop file privileges in btrfs_clone_files

by Lu Fengqi

The generic/513 tell that cloning into a file did not strip security privileges (suid, capabilities) like a regular write would. Signed-off-by: Lu Fengqi <lufq.fnst(a)cn.fujitsu.com> --- The xfs and ocfs2 call generic_remap_file_range_prep to drop file privileges, I'm not sure whether btrfs should do the same thing. Any suggestion? fs/btrfs/ioctl.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c index 410c7e007ba8..bc33c480603b 100644 --- a/fs/btrfs/ioctl.c +++ b/fs/btrfs/ioctl.c @@ -4312,6 +4312,10 @@ static noinline int btrfs_clone_files(struct file *file, struct file *file_src, goto out_unlock; } + ret = file_remove_privs(file); + if (ret) + goto out_unlock; + if (destoff > inode->i_size) { ret = btrfs_cont_expand(inode, inode->i_size, destoff); if (ret) -- 2.19.2

7 years, 1 month

stable-rc/linux-4.4.y boot: 89 boots: 1 failed, 87 passed with 1 offline (v4.4.165)

by kernelci.org bot

stable-rc/linux-4.4.y boot: 89 boots: 1 failed, 87 passed with 1 offline (v4.4.165) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-4.4.y/kernel/v4.4.… Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-4.4.y/kernel/v4.4.165/ Tree: stable-rc Branch: linux-4.4.y Git Describe: v4.4.165 Git Commit: 2757e11be64bcfcba65ff885e08a5b6067a8e394 Git URL: http://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Tested: 43 unique boards, 20 SoC families, 15 builds out of 187 Boot Failure Detected: arm64: defconfig qcom-qdf2400: 1 failed lab Offline Platforms: arm: multi_v7_defconfig: stih410-b2120: 1 offline lab --- For more info write to <info(a)kernelci.org>

7 years, 1 month

PASS: Test report for kernel 4.19.5.skt (linux-stable-rc)

by CKI

Hello, We ran automated tests on a recent commit from this kernel tree: Kernel repo: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Commit: b32d16ec9956 Linux 4.19.5 The results of these automated tests are provided below. Overall result: PASSED Patch merge: OK Compile: OK Kernel tests: OK Please reply to this email if you have any questions about the tests that we ran or if you have any suggestions on how to make future tests more effective. ,-. ,-. ( C ) ( K ) Continuous `-',-.`-' Kernel ( I ) Integration `-' ______________________________________________________________________________ Compile testing --------------- We compiled the kernel for 2 architectures: aarch64: make options: make INSTALL_MOD_STRIP=1 -j56 targz-pkg configuration: https://artifacts.cki-project.org/builds/aarch64/b32d16ec995683be888520d12d… x86_64: make options: make INSTALL_MOD_STRIP=1 -j56 targz-pkg configuration: https://artifacts.cki-project.org/builds/x86_64/b32d16ec995683be888520d12d8… Hardware testing ---------------- We booted each kernel and ran the following tests: arm64: /distribution/kpkginstall (boot test) LTP lite - release 20180515 xfstests: ext4 xfstests: xfs /kernel/misc/amtu x86_64: /distribution/kpkginstall (boot test) LTP lite - release 20180515 xfstests: ext4 xfstests: xfs /kernel/misc/amtu

7 years, 1 month

stable-rc/linux-4.14.y boot: 113 boots: 0 failed, 109 passed with 3 offline, 1 untried/unknown (v4.14.84)

by kernelci.org bot

stable-rc/linux-4.14.y boot: 113 boots: 0 failed, 109 passed with 3 offline, 1 untried/unknown (v4.14.84) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-4.14.y/kernel/v4.1… Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-4.14.y/kernel/v4.14.84/ Tree: stable-rc Branch: linux-4.14.y Git Describe: v4.14.84 Git Commit: 4201a586f1fa63de5a965a1ebc3b99e0e1a4912c Git URL: http://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Tested: 62 unique boards, 23 SoC families, 15 builds out of 197 Offline Platforms: arm: multi_v7_defconfig: stih410-b2120: 1 offline lab arm64: defconfig: meson-gxl-s905d-p230: 1 offline lab meson-gxl-s905x-p212: 1 offline lab --- For more info write to <info(a)kernelci.org>

7 years, 1 month

stable-rc/linux-4.19.y boot: 112 boots: 0 failed, 109 passed with 3 offline (v4.19.5)

by kernelci.org bot

stable-rc/linux-4.19.y boot: 112 boots: 0 failed, 109 passed with 3 offline (v4.19.5) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-4.19.y/kernel/v4.1… Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-4.19.y/kernel/v4.19.5/ Tree: stable-rc Branch: linux-4.19.y Git Describe: v4.19.5 Git Commit: b32d16ec995683be888520d12d8f2833efee5dae Git URL: http://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Tested: 63 unique boards, 23 SoC families, 15 builds out of 202 Offline Platforms: arm: multi_v7_defconfig: stih410-b2120: 1 offline lab arm64: defconfig: meson-gxl-s905d-p230: 1 offline lab meson-gxl-s905x-p212: 1 offline lab --- For more info write to <info(a)kernelci.org>

7 years, 1 month

stable-rc/linux-3.18.y boot: 52 boots: 4 failed, 48 passed (v3.18.127)

by kernelci.org bot

stable-rc/linux-3.18.y boot: 52 boots: 4 failed, 48 passed (v3.18.127) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-3.18.y/kernel/v3.1… Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-3.18.y/kernel/v3.18.127/ Tree: stable-rc Branch: linux-3.18.y Git Describe: v3.18.127 Git Commit: 376f405256923b1d1ab14cb2970a25e11b074198 Git URL: http://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Tested: 23 unique boards, 12 SoC families, 14 builds out of 185 Boot Failures Detected: x86: x86_64_defconfig qemu: 3 failed labs x86-atom330: 1 failed lab --- For more info write to <info(a)kernelci.org>

7 years, 1 month

stable-rc/linux-4.9.y boot: 98 boots: 0 failed, 97 passed with 1 offline (v4.9.141)

by kernelci.org bot

stable-rc/linux-4.9.y boot: 98 boots: 0 failed, 97 passed with 1 offline (v4.9.141) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-4.9.y/kernel/v4.9.… Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-4.9.y/kernel/v4.9.141/ Tree: stable-rc Branch: linux-4.9.y Git Describe: v4.9.141 Git Commit: bb2d990b6fefaf99b2832a7a588234e7986ebe15 Git URL: http://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Tested: 49 unique boards, 22 SoC families, 16 builds out of 193 Offline Platforms: arm: multi_v7_defconfig: stih410-b2120: 1 offline lab --- For more info write to <info(a)kernelci.org>

7 years, 1 month

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror