- Linux-stable-mirror - lists.linaro.org

[PATCH] drm/i915/dp: Send DPCD ON for MST before phy_up

by Lyude Paul

As it turns out, the aux block being off was not the real problem here, as transition from D3 to D0 is mandated by the DP spec to take a maximum of 1ms, whereas we're allowed a 100ms timeframe to respond to ESI irqs. The real problem here is a bit more subtle. When doing a modeset where the problem of the sink timing out to our sideband requests when transitioning from D3 to D0 occurs, the timeout is from the aux block not coming on. However, nothing else times out other than the initial phy_up message because the DPCD on call in intel_ddi_enable_dp() ends up waking up the AUX block on the hub, not the phy_up sideband message. This means that the real fix we need is to use the DPMS on before sending a phy_up to ensure that the hub is ready to accept sideband messages. Signed-off-by: Lyude Paul <lyude(a)redhat.com> Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan(a)intel.com> Cc: Ville Syrjälä <ville.syrjala(a)linux.intel.com> Cc: Laura Abbott <labbott(a)redhat.com> Cc: stable(a)vger.kernel.org Fixes: ad260ab32a4d9 ("drm/i915/dp: Write to SET_POWER dpcd to enable MST hub.") --- drivers/gpu/drm/i915/intel_ddi.c | 6 +++++- drivers/gpu/drm/i915/intel_dp_mst.c | 1 + 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c index a6672a9abd85..9bd675f73f7b 100644 --- a/drivers/gpu/drm/i915/intel_ddi.c +++ b/drivers/gpu/drm/i915/intel_ddi.c @@ -2324,7 +2324,11 @@ static void intel_ddi_pre_enable_dp(struct intel_encoder *encoder, intel_prepare_dp_ddi_buffers(encoder, crtc_state); intel_ddi_init_dp_buf_reg(encoder); - intel_dp_sink_dpms(intel_dp, DRM_MODE_DPMS_ON); + /* for MST, we do DPMS_ON outside of here so that DPMS_ON can happen + * before drm_dp_send_power_updown_phy() + */ + if (!intel_dp->is_mst) + intel_dp_sink_dpms(intel_dp, DRM_MODE_DPMS_ON); intel_dp_start_link_train(intel_dp); if (port != PORT_A || INTEL_GEN(dev_priv) >= 9) intel_dp_stop_link_train(intel_dp); diff --git a/drivers/gpu/drm/i915/intel_dp_mst.c b/drivers/gpu/drm/i915/intel_dp_mst.c index c3de0918ee13..eff9a4eae1f0 100644 --- a/drivers/gpu/drm/i915/intel_dp_mst.c +++ b/drivers/gpu/drm/i915/intel_dp_mst.c @@ -223,6 +223,7 @@ static void intel_mst_pre_enable_dp(struct intel_encoder *encoder, DRM_DEBUG_KMS("active links %d\n", intel_dp->active_mst_links); + intel_dp_sink_dpms(intel_dp, DRM_MODE_DPMS_ON); drm_dp_send_power_updown_phy(&intel_dp->mst_mgr, connector->port, true); if (intel_dp->active_mst_links == 0) intel_dig_port->base.pre_enable(&intel_dig_port->base, -- 2.14.3

7 years, 7 months

3
2
0 0

Re: [PATCH] Add Second Fan Support for Thinkpad P50

by Sasha Levin

Hi. [This is an automated email] This commit has been processed by the -stable helper bot and determined to be a high probability candidate for -stable trees. (score: 9.2381) The bot has tested the following trees: v4.15.15, v4.14.32, v4.9.92, v4.4.126, v4.15.15: Build OK! v4.14.32: Build OK! v4.9.92: Build OK! v4.4.126: Build OK! Please let us know if you'd like to have this patch included in a stable tree. -- Thanks. Sasha

7 years, 7 months

2
1
0 0

Re: [PATCH] usbip: vhci_hcd: Fix usb device and sockfd leaks

by Sasha Levin

Hi. [This is an automated email] This commit has been processed by the -stable helper bot and determined to be a high probability candidate for -stable trees. (score: 10.6103) The bot has tested the following trees: v4.15.15, v4.14.32, v4.9.92, v4.4.126, v4.15.15: Build OK! v4.14.32: Build OK! v4.9.92: Build OK! v4.4.126: Failed to apply! Possible dependencies: f0f1beb8f155 ("usbip: vhci_hcd: Fix usb device and sockfd leaks") Please let us know if you'd like to have this patch included in a stable tree. -- Thanks. Sasha

7 years, 7 months

2
1
0 0

Re: [PATCH 5/6] clocksource/drivers/imx-tpm: Correct some registers operation flow

by Sasha Levin

Hi. [This is an automated email] This commit has been processed by the -stable helper bot and determined to be a high probability candidate for -stable trees. (score: 11.8806) The bot has tested the following trees: v4.15.15, v4.14.32, v4.9.92, v4.4.126, v4.15.15: Build OK! v4.14.32: Build OK! v4.9.92: Failed to apply! Possible dependencies: 506a7be93ff7 ("clocksource/drivers/imx-tpm: Correct some registers operation flow") v4.4.126: Failed to apply! Possible dependencies: 506a7be93ff7 ("clocksource/drivers/imx-tpm: Correct some registers operation flow") Please let us know if you'd like to have this patch included in a stable tree. -- Thanks. Sasha

7 years, 7 months

1
0
0 0

Re: [PATCH 3/5] MIPS: perf: Fix perf with MT counting other threads

by Sasha Levin

Hi. [This is an automated email] This commit has been processed by the -stable helper bot and determined to be a high probability candidate for -stable trees. (score: 16.4885) The bot has tested the following trees: v4.15.15, v4.14.32, v4.9.92, v4.4.126, v4.15.15: Failed to apply! Possible dependencies: e2a7b77d89f6 ("MIPS: perf: Fix perf with MT counting other threads") v4.14.32: Failed to apply! Possible dependencies: e2a7b77d89f6 ("MIPS: perf: Fix perf with MT counting other threads") v4.9.92: Failed to apply! Possible dependencies: 4e099ca64578 ("MIPS: perf: Use correct VPE ID when setting up VPE tracing") e2a7b77d89f6 ("MIPS: perf: Fix perf with MT counting other threads") v4.4.126: Failed to apply! Possible dependencies: 4e099ca64578 ("MIPS: perf: Use correct VPE ID when setting up VPE tracing") e2a7b77d89f6 ("MIPS: perf: Fix perf with MT counting other threads") Please let us know if you'd like to have this patch included in a stable tree. -- Thanks. Sasha

7 years, 7 months

1
0
0 0

Re: [PATCH 1/5] MIPS: perf: More robustly probe for the presence of per-tc counters

by Sasha Levin

Hi. [This is an automated email] This commit has been processed by the -stable helper bot and determined to be a high probability candidate for -stable trees. (score: 7.7428) The bot has tested the following trees: v4.15.15, v4.14.32, v4.9.92, v4.4.126, v4.15.15: Build OK! v4.14.32: Build OK! v4.9.92: Build OK! v4.4.126: Failed to apply! Possible dependencies: dddf796db4e3 ("MIPS: perf: More robustly probe for the presence of per-tc counters") Please let us know if you'd like to have this patch included in a stable tree. -- Thanks. Sasha

7 years, 7 months

1
0
0 0

Re: [PATCH 2/2] usb: dwc2: gadget: Change default values

by Sasha Levin

Hi. [This is an automated email] This commit has been processed by the -stable helper bot and determined to be a high probability candidate for -stable trees. (score: 8.8219) The bot has tested the following trees: v4.15.15, v4.14.32, v4.9.92, v4.4.126, v4.15.15: Failed to apply! Possible dependencies: 808260f0b5d6 ("usb: dwc2: gadget: Change default values") v4.14.32: Failed to apply! Possible dependencies: 808260f0b5d6 ("usb: dwc2: gadget: Change default values") v4.9.92: Failed to apply! Possible dependencies: 6f80b6de0ecf ("usb: dwc2: Add core parameters for LPM support") 808260f0b5d6 ("usb: dwc2: gadget: Change default values") v4.4.126: Failed to apply! Possible dependencies: 6f80b6de0ecf ("usb: dwc2: Add core parameters for LPM support") 808260f0b5d6 ("usb: dwc2: gadget: Change default values") Please let us know if you'd like to have this patch included in a stable tree. -- Thanks. Sasha

7 years, 7 months

1
0
0 0

Re: [PATCH 0/2] usb: dwc2: gadget: Fixes for LPM

by Sasha Levin

Hi. [This is an automated email] This commit has been processed by the -stable helper bot and determined to be a high probability candidate for -stable trees. (score: 8.8219) The bot has tested the following trees: v4.15.15, v4.14.32, v4.9.92, v4.4.126, v4.15.15: Failed to apply! Possible dependencies: 9fca971e94df ("usb: dwc2: gadget: Change default values") v4.14.32: Failed to apply! Possible dependencies: 9fca971e94df ("usb: dwc2: gadget: Change default values") v4.9.92: Failed to apply! Possible dependencies: 6f80b6de0ecf ("usb: dwc2: Add core parameters for LPM support") 9fca971e94df ("usb: dwc2: gadget: Change default values") v4.4.126: Failed to apply! Possible dependencies: 6f80b6de0ecf ("usb: dwc2: Add core parameters for LPM support") 9fca971e94df ("usb: dwc2: gadget: Change default values") Please let us know if you'd like to have this patch included in a stable tree. -- Thanks. Sasha

7 years, 7 months

1
0
0 0

Re: [PATCH v1 5/7] soc: mediatek: add a fixed wait for SRAM stable

by Sasha Levin

Hi. [This is an automated email] This commit has been processed by the -stable helper bot and determined to be a high probability candidate for -stable trees. (score: 83.4612) The bot has tested the following trees: v4.15.15, v4.14.32, v4.9.92, v4.4.126, v4.15.15: Failed to apply! Possible dependencies: 40b3b88a117c ("soc: mediatek: reuse read[l,x]_poll_timeout helpers") v4.14.32: Failed to apply! Possible dependencies: 40b3b88a117c ("soc: mediatek: reuse read[l,x]_poll_timeout helpers") v4.9.92: Failed to apply! Possible dependencies: 40b3b88a117c ("soc: mediatek: reuse read[l,x]_poll_timeout helpers") 52510ee93488 ("soc: mediatek: add SCPSYS power domain driver for MediaTek MT7622 SoC") v4.4.126: Failed to apply! Possible dependencies: 40b3b88a117c ("soc: mediatek: reuse read[l,x]_poll_timeout helpers") 52510ee93488 ("soc: mediatek: add SCPSYS power domain driver for MediaTek MT7622 SoC") Please let us know if you'd like to have this patch included in a stable tree. -- Thanks. Sasha

7 years, 7 months

1
0
0 0

Re: [PATCH v1] mm: consider non-anonymous thp as unmovable page

by Sasha Levin

Hi. [This is an automated email] This commit has been processed because it contains a "Fixes:" tag, fixing commit: 72b39cfc4d75 ("mm, memory_hotplug: do not fail offlining too early"). The bot has also determined it's probably a bug fixing patch. (score: 77.7460) The bot has tested the following trees: v4.15.15 . v4.15.15: Build OK! -- Thanks. Sasha

7 years, 7 months

1
0
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror