- Linux-stable-mirror - lists.linaro.org

[stable-4.14 1/4] padata: set cpu_index of unused CPUs to -1

by Daniel Jordan

From: Mathias Krause <minipli(a)googlemail.com> [ Upstream commit 1bd845bcb41d5b7f83745e0cb99273eb376f2ec5 ] The parallel queue per-cpu data structure gets initialized only for CPUs in the 'pcpu' CPU mask set. This is not sufficient as the reorder timer may run on a different CPU and might wrongly decide it's the target CPU for the next reorder item as per-cpu memory gets memset(0) and we might be waiting for the first CPU in cpumask.pcpu, i.e. cpu_index 0. Make the '__this_cpu_read(pd->pqueue->cpu_index) == next_queue->cpu_index' compare in padata_get_next() fail in this case by initializing the cpu_index member of all per-cpu parallel queues. Use -1 for unused ones. Signed-off-by: Mathias Krause <minipli(a)googlemail.com> Signed-off-by: Herbert Xu <herbert(a)gondor.apana.org.au> Signed-off-by: Daniel Jordan <daniel.m.jordan(a)oracle.com> --- kernel/padata.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/kernel/padata.c b/kernel/padata.c index 40a0ebb8ea51..858e82179744 100644 --- a/kernel/padata.c +++ b/kernel/padata.c @@ -462,8 +462,14 @@ static void padata_init_pqueues(struct parallel_data *pd) struct padata_parallel_queue *pqueue; cpu_index = 0; - for_each_cpu(cpu, pd->cpumask.pcpu) { + for_each_possible_cpu(cpu) { pqueue = per_cpu_ptr(pd->pqueue, cpu); + + if (!cpumask_test_cpu(cpu, pd->cpumask.pcpu)) { + pqueue->cpu_index = -1; + continue; + } + pqueue->pd = pd; pqueue->cpu_index = cpu_index; cpu_index++; -- 2.26.2

5 years, 7 months

1
3
0 0

+ mm-ptdump-expand-type-of-val-in-note_page.patch added to -mm tree

by akpm＠linux-foundation.org

The patch titled Subject: mm: ptdump: expand type of 'val' in note_page() has been added to the -mm tree. Its filename is mm-ptdump-expand-type-of-val-in-note_page.patch This patch should soon appear at http://ozlabs.org/~akpm/mmots/broken-out/mm-ptdump-expand-type-of-val-in-no… and later at http://ozlabs.org/~akpm/mmotm/broken-out/mm-ptdump-expand-type-of-val-in-no… Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Steven Price <steven.price(a)arm.com> Subject: mm: ptdump: expand type of 'val' in note_page() The page table entry is passed in the 'val' argument to note_page(), however this was previously an "unsigned long" which is fine on 64-bit platforms. But for 32 bit x86 it is not always big enough to contain a page table entry which may be 64 bits. Change the type to u64 to ensure that it is always big enough. Link: http://lkml.kernel.org/r/20200521152308.33096-3-steven.price@arm.com Signed-off-by: Steven Price <steven.price(a)arm.com> Reported-by: Jan Beulich <jbeulich(a)suse.com> Cc: Andy Lutomirski <luto(a)kernel.org> Cc: Borislav Petkov <bp(a)alien8.de> Cc: Dave Hansen <dave.hansen(a)linux.intel.com> Cc: Ingo Molnar <mingo(a)redhat.com> Cc: Peter Zijlstra <peterz(a)infradead.org> Cc: Thomas Gleixner <tglx(a)linutronix.de> Cc: <stable(a)vger.kernel.org> Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> --- arch/arm64/mm/dump.c | 2 +- arch/x86/mm/dump_pagetables.c | 2 +- include/linux/ptdump.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) --- a/arch/arm64/mm/dump.c~mm-ptdump-expand-type-of-val-in-note_page +++ a/arch/arm64/mm/dump.c @@ -247,7 +247,7 @@ static void note_prot_wx(struct pg_state } static void note_page(struct ptdump_state *pt_st, unsigned long addr, int level, - unsigned long val) + u64 val) { struct pg_state *st = container_of(pt_st, struct pg_state, ptdump); static const char units[] = "KMGTPE"; --- a/arch/x86/mm/dump_pagetables.c~mm-ptdump-expand-type-of-val-in-note_page +++ a/arch/x86/mm/dump_pagetables.c @@ -273,7 +273,7 @@ static void effective_prot(struct ptdump * print what we collected so far. */ static void note_page(struct ptdump_state *pt_st, unsigned long addr, int level, - unsigned long val) + u64 val) { struct pg_state *st = container_of(pt_st, struct pg_state, ptdump); pgprotval_t new_prot, new_eff; --- a/include/linux/ptdump.h~mm-ptdump-expand-type-of-val-in-note_page +++ a/include/linux/ptdump.h @@ -13,7 +13,7 @@ struct ptdump_range { struct ptdump_state { /* level is 0:PGD to 4:PTE, or -1 if unknown */ void (*note_page)(struct ptdump_state *st, unsigned long addr, - int level, unsigned long val); + int level, u64 val); void (*effective_prot)(struct ptdump_state *st, int level, u64 val); const struct ptdump_range *range; }; _ Patches currently in -mm which might be from steven.price(a)arm.com are x86-mm-ptdump-calculate-effective-permissions-correctly.patch mm-ptdump-expand-type-of-val-in-note_page.patch

5 years, 7 months

1
0
0 0

+ x86-mm-ptdump-calculate-effective-permissions-correctly.patch added to -mm tree

by akpm＠linux-foundation.org

The patch titled Subject: x86: mm: ptdump: calculate effective permissions correctly has been added to the -mm tree. Its filename is x86-mm-ptdump-calculate-effective-permissions-correctly.patch This patch should soon appear at http://ozlabs.org/~akpm/mmots/broken-out/x86-mm-ptdump-calculate-effective-… and later at http://ozlabs.org/~akpm/mmotm/broken-out/x86-mm-ptdump-calculate-effective-… Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Steven Price <steven.price(a)arm.com> Subject: x86: mm: ptdump: calculate effective permissions correctly Patch series "Fix W+X debug feature on x86" Jan alerted me[1] that the W+X detection debug feature was broken in x86 by my change[2] to switch x86 to use the generic ptdump infrastructure. Fundamentally the approach of trying to move the calculation of effective permissions into note_page() was broken because note_page() is only called for 'leaf' entries and the effective permissions are passed down via the internal nodes of the page tree. The solution I've taken here is to create a new (optional) callback which is called for all nodes of the page tree and therefore can calculate the effective permissions. Secondly on some configurations (32 bit with PAE) "unsigned long" is not large enough to store the table entries. The fix here is simple - let's just use a u64. [1] https://lore.kernel.org/lkml/d573dc7e-e742-84de-473d-f971142fa319@suse.com/ [2] 2ae27137b2db ("x86: mm: convert dump_pagetables to use walk_page_range") This patch (of 2): By switching the x86 page table dump code to use the generic code the effective permissions are no longer calculated correctly because the note_page() function is only called for *leaf* entries. To calculate the actual effective permissions it is necessary to observe the full hierarchy of the page tree. Introduce a new callback for ptdump which is called for every entry and can therefore update the prot_levels array correctly. note_page() can then simply access the appropriate element in the array. Link: http://lkml.kernel.org/r/20200521152308.33096-1-steven.price@arm.com Link: http://lkml.kernel.org/r/20200521152308.33096-2-steven.price@arm.com Fixes: 2ae27137b2db ("x86: mm: convert dump_pagetables to use walk_page_range") Signed-off-by: Steven Price <steven.price(a)arm.com> Reported-by: Jan Beulich <jbeulich(a)suse.com> Cc: Andy Lutomirski <luto(a)kernel.org> Cc: Borislav Petkov <bp(a)alien8.de> Cc: Dave Hansen <dave.hansen(a)linux.intel.com> Cc: Ingo Molnar <mingo(a)redhat.com> Cc: Peter Zijlstra <peterz(a)infradead.org> Cc: Thomas Gleixner <tglx(a)linutronix.de> Cc: <stable(a)vger.kernel.org> Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> --- arch/x86/mm/dump_pagetables.c | 31 +++++++++++++++++++------------ include/linux/ptdump.h | 1 + mm/ptdump.c | 17 ++++++++++++++++- 3 files changed, 36 insertions(+), 13 deletions(-) --- a/arch/x86/mm/dump_pagetables.c~x86-mm-ptdump-calculate-effective-permissions-correctly +++ a/arch/x86/mm/dump_pagetables.c @@ -249,10 +249,22 @@ static void note_wx(struct pg_state *st, (void *)st->start_address); } -static inline pgprotval_t effective_prot(pgprotval_t prot1, pgprotval_t prot2) +static void effective_prot(struct ptdump_state *pt_st, int level, u64 val) { - return (prot1 & prot2 & (_PAGE_USER | _PAGE_RW)) | - ((prot1 | prot2) & _PAGE_NX); + struct pg_state *st = container_of(pt_st, struct pg_state, ptdump); + pgprotval_t prot = val & PTE_FLAGS_MASK; + pgprotval_t effective; + + if (level > 0) { + pgprotval_t higher_prot = st->prot_levels[level - 1]; + + effective = (higher_prot & prot & (_PAGE_USER | _PAGE_RW)) | + ((higher_prot | prot) & _PAGE_NX); + } else { + effective = prot; + } + + st->prot_levels[level] = effective; } /* @@ -270,16 +282,10 @@ static void note_page(struct ptdump_stat struct seq_file *m = st->seq; new_prot = val & PTE_FLAGS_MASK; + new_eff = st->prot_levels[level]; - if (level > 0) { - new_eff = effective_prot(st->prot_levels[level - 1], - new_prot); - } else { - new_eff = new_prot; - } - - if (level >= 0) - st->prot_levels[level] = new_eff; + if (!val) + new_eff = 0; /* * If we have a "break" in the series, we need to flush the state that @@ -374,6 +380,7 @@ static void ptdump_walk_pgd_level_core(s struct pg_state st = { .ptdump = { .note_page = note_page, + .effective_prot = effective_prot, .range = ptdump_ranges }, .level = -1, --- a/include/linux/ptdump.h~x86-mm-ptdump-calculate-effective-permissions-correctly +++ a/include/linux/ptdump.h @@ -14,6 +14,7 @@ struct ptdump_state { /* level is 0:PGD to 4:PTE, or -1 if unknown */ void (*note_page)(struct ptdump_state *st, unsigned long addr, int level, unsigned long val); + void (*effective_prot)(struct ptdump_state *st, int level, u64 val); const struct ptdump_range *range; }; --- a/mm/ptdump.c~x86-mm-ptdump-calculate-effective-permissions-correctly +++ a/mm/ptdump.c @@ -36,6 +36,9 @@ static int ptdump_pgd_entry(pgd_t *pgd, return note_kasan_page_table(walk, addr); #endif + if (st->effective_prot) + st->effective_prot(st, 0, pgd_val(val)); + if (pgd_leaf(val)) st->note_page(st, addr, 0, pgd_val(val)); @@ -53,6 +56,9 @@ static int ptdump_p4d_entry(p4d_t *p4d, return note_kasan_page_table(walk, addr); #endif + if (st->effective_prot) + st->effective_prot(st, 1, p4d_val(val)); + if (p4d_leaf(val)) st->note_page(st, addr, 1, p4d_val(val)); @@ -70,6 +76,9 @@ static int ptdump_pud_entry(pud_t *pud, return note_kasan_page_table(walk, addr); #endif + if (st->effective_prot) + st->effective_prot(st, 2, pud_val(val)); + if (pud_leaf(val)) st->note_page(st, addr, 2, pud_val(val)); @@ -87,6 +96,8 @@ static int ptdump_pmd_entry(pmd_t *pmd, return note_kasan_page_table(walk, addr); #endif + if (st->effective_prot) + st->effective_prot(st, 3, pmd_val(val)); if (pmd_leaf(val)) st->note_page(st, addr, 3, pmd_val(val)); @@ -97,8 +108,12 @@ static int ptdump_pte_entry(pte_t *pte, unsigned long next, struct mm_walk *walk) { struct ptdump_state *st = walk->private; + pte_t val = READ_ONCE(*pte); + + if (st->effective_prot) + st->effective_prot(st, 4, pte_val(val)); - st->note_page(st, addr, 4, pte_val(READ_ONCE(*pte))); + st->note_page(st, addr, 4, pte_val(val)); return 0; } _ Patches currently in -mm which might be from steven.price(a)arm.com are x86-mm-ptdump-calculate-effective-permissions-correctly.patch mm-ptdump-expand-type-of-val-in-note_page.patch

5 years, 7 months

1
0
0 0

Offer

by Mazer

I hope you are doing great? This is Felix from Toronto-Canada. I have a lucrative business offer that will benefit us both immensely within a very short period of time. However, I need your initial approval of interest prior to further and complete details regarding the deal. Thanks, Felix.

5 years, 7 months

1
0
0 0

[PATCH v2] x86/kvm: Disable KVM_ASYNC_PF_SEND_ALWAYS

by Andy Lutomirski

The ABI is broken and we cannot support it properly. Turn it off. If this causes a meaningful performance regression for someone, KVM can introduce an improved ABI that is supportable. Cc: stable(a)vger.kernel.org Signed-off-by: Andy Lutomirski <luto(a)kernel.org> --- arch/x86/kernel/kvm.c | 21 ++++++++++++++++++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c index 93ab0cbd304e..e6f2aefa298b 100644 --- a/arch/x86/kernel/kvm.c +++ b/arch/x86/kernel/kvm.c @@ -318,11 +318,26 @@ static void kvm_guest_cpu_init(void) pa = slow_virt_to_phys(this_cpu_ptr(&apf_reason)); -#ifdef CONFIG_PREEMPTION - pa |= KVM_ASYNC_PF_SEND_ALWAYS; -#endif pa |= KVM_ASYNC_PF_ENABLED; + /* + * We do not set KVM_ASYNC_PF_SEND_ALWAYS. With the current + * KVM paravirt ABI, the following scenario is possible: + * + * #PF: async page fault (KVM_PV_REASON_PAGE_NOT_PRESENT) + * NMI before CR2 or KVM_PF_REASON_PAGE_NOT_PRESENT + * NMI accesses user memory, e.g. due to perf + * #PF: normal page fault + * #PF reads CR2 and apf_reason -- apf_reason should be 0 + * + * outer #PF reads CR2 and apf_reason -- apf_reason should be + * KVM_PV_REASON_PAGE_NOT_PRESENT + * + * There is no possible way that both reads of CR2 and + * apf_reason get the correct values. Fixing this would + * require paravirt ABI changes. + */ + if (kvm_para_has_feature(KVM_FEATURE_ASYNC_PF_VMEXIT)) pa |= KVM_ASYNC_PF_DELIVERY_AS_PF_VMEXIT; -- 2.24.1

5 years, 7 months

9
54
0 0

[PATCH 4.9] arm64: fix the flush_icache_range arguments in machine_kexec

by Catalin Marinas

From: Christoph Hellwig <hch(a)lst.de> Commit d51c214541c5154dda3037289ee895ea3ded5ebd upstream. The second argument is the end "pointer", not the length. Fixes: d28f6df1305a ("arm64/kexec: Add core kexec support") Cc: <stable(a)vger.kernel.org> # 4.8.x- Signed-off-by: Christoph Hellwig <hch(a)lst.de> Signed-off-by: Catalin Marinas <catalin.marinas(a)arm.com> --- arch/arm64/kernel/machine_kexec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/arm64/kernel/machine_kexec.c b/arch/arm64/kernel/machine_kexec.c index bc96c8a7fc79..3e4b778f16a5 100644 --- a/arch/arm64/kernel/machine_kexec.c +++ b/arch/arm64/kernel/machine_kexec.c @@ -177,7 +177,8 @@ void machine_kexec(struct kimage *kimage) /* Flush the reboot_code_buffer in preparation for its execution. */ __flush_dcache_area(reboot_code_buffer, arm64_relocate_new_kernel_size); flush_icache_range((uintptr_t)reboot_code_buffer, - arm64_relocate_new_kernel_size); + (uintptr_t)reboot_code_buffer + + arm64_relocate_new_kernel_size); /* Flush the kimage list and its buffers. */ kexec_list_flush(kimage);

5 years, 7 months

1
0
0 0

Backporting "padata: Remove broken queue flushing"

by Ben Hutchings

I noticed that commit 07928d9bfc81 "padata: Remove broken queue flushing" has been backported to most stable branches, but commit 6fc4dbcf0276 "padata: Replace delayed timer with immediate workqueue in padata_reorder" has not. Is this correct? What prevents the parallel_data ref-count from dropping to 0 while the timer is scheduled? Ben. -- Ben Hutchings Larkinson's Law: All laws are basically false.

5 years, 7 months

3
4
0 0

patch "kobject: Make sure the parent does not get released before its" added to driver-core-linus

by gregkh＠linuxfoundation.org

This is a note to let you know that I've just added the patch titled kobject: Make sure the parent does not get released before its to my driver-core git tree which can be found at git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git in the driver-core-linus branch. The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.) The patch will hopefully also be merged in Linus's tree for the next -rc kernel release. If you have any questions about this process, please let me know. >From 4ef12f7198023c09ad6d25b652bd8748c965c7fa Mon Sep 17 00:00:00 2001 From: Heikki Krogerus <heikki.krogerus(a)linux.intel.com> Date: Wed, 13 May 2020 18:18:40 +0300 Subject: kobject: Make sure the parent does not get released before its children In the function kobject_cleanup(), kobject_del(kobj) is called before the kobj->release(). That makes it possible to release the parent of the kobject before the kobject itself. To fix that, adding function __kboject_del() that does everything that kobject_del() does except release the parent reference. kobject_cleanup() then calls __kobject_del() instead of kobject_del(), and separately decrements the reference count of the parent kobject after kobj->release() has been called. Reported-by: Naresh Kamboju <naresh.kamboju(a)linaro.org> Reported-by: kernel test robot <rong.a.chen(a)intel.com> Fixes: 7589238a8cf3 ("Revert "software node: Simplify software_node_release() function"") Suggested-by: "Rafael J. Wysocki" <rafael(a)kernel.org> Signed-off-by: Heikki Krogerus <heikki.krogerus(a)linux.intel.com> Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki(a)intel.com> Reviewed-by: Brendan Higgins <brendanhiggins(a)google.com> Tested-by: Brendan Higgins <brendanhiggins(a)google.com> Acked-by: Randy Dunlap <rdunlap(a)infradead.org> Link: https://lore.kernel.org/r/20200513151840.36400-1-heikki.krogerus@linux.inte… Cc: stable <stable(a)vger.kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> --- lib/kobject.c | 30 ++++++++++++++++++++---------- 1 file changed, 20 insertions(+), 10 deletions(-) diff --git a/lib/kobject.c b/lib/kobject.c index 83198cb37d8d..2bd631460e18 100644 --- a/lib/kobject.c +++ b/lib/kobject.c @@ -599,14 +599,7 @@ int kobject_move(struct kobject *kobj, struct kobject *new_parent) } EXPORT_SYMBOL_GPL(kobject_move); -/** - * kobject_del() - Unlink kobject from hierarchy. - * @kobj: object. - * - * This is the function that should be called to delete an object - * successfully added via kobject_add(). - */ -void kobject_del(struct kobject *kobj) +static void __kobject_del(struct kobject *kobj) { struct kernfs_node *sd; const struct kobj_type *ktype; @@ -625,9 +618,23 @@ void kobject_del(struct kobject *kobj) kobj->state_in_sysfs = 0; kobj_kset_leave(kobj); - kobject_put(kobj->parent); kobj->parent = NULL; } + +/** + * kobject_del() - Unlink kobject from hierarchy. + * @kobj: object. + * + * This is the function that should be called to delete an object + * successfully added via kobject_add(). + */ +void kobject_del(struct kobject *kobj) +{ + struct kobject *parent = kobj->parent; + + __kobject_del(kobj); + kobject_put(parent); +} EXPORT_SYMBOL(kobject_del); /** @@ -663,6 +670,7 @@ EXPORT_SYMBOL(kobject_get_unless_zero); */ static void kobject_cleanup(struct kobject *kobj) { + struct kobject *parent = kobj->parent; struct kobj_type *t = get_ktype(kobj); const char *name = kobj->name; @@ -684,7 +692,7 @@ static void kobject_cleanup(struct kobject *kobj) if (kobj->state_in_sysfs) { pr_debug("kobject: '%s' (%p): auto cleanup kobject_del\n", kobject_name(kobj), kobj); - kobject_del(kobj); + __kobject_del(kobj); } if (t && t->release) { @@ -698,6 +706,8 @@ static void kobject_cleanup(struct kobject *kobj) pr_debug("kobject: '%s': free name\n", name); kfree_const(name); } + + kobject_put(parent); } #ifdef CONFIG_DEBUG_KOBJECT_RELEASE -- 2.26.2

5 years, 7 months

1
0
0 0

patch "driver core: Fix handling of SYNC_STATE_ONLY + STATELESS device links" added to driver-core-linus

by gregkh＠linuxfoundation.org

This is a note to let you know that I've just added the patch titled driver core: Fix handling of SYNC_STATE_ONLY + STATELESS device links to my driver-core git tree which can be found at git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git in the driver-core-linus branch. The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.) The patch will hopefully also be merged in Linus's tree for the next -rc kernel release. If you have any questions about this process, please let me know. >From 44e960490ddf868fc9135151c4a658936e771dc2 Mon Sep 17 00:00:00 2001 From: Saravana Kannan <saravanak(a)google.com> Date: Tue, 19 May 2020 21:36:26 -0700 Subject: driver core: Fix handling of SYNC_STATE_ONLY + STATELESS device links Commit 21c27f06587d ("driver core: Fix SYNC_STATE_ONLY device link implementation") didn't completely fix STATELESS + SYNC_STATE_ONLY handling. What looks like an optimization in that commit is actually a bug that causes an if condition to always take the else path. This prevents reordering of devices in the dpm_list when a DL_FLAG_STATELESS device link is create on top of an existing DL_FLAG_SYNC_STATE_ONLY device link. Fixes: 21c27f06587d ("driver core: Fix SYNC_STATE_ONLY device link implementation") Signed-off-by: Saravana Kannan <saravanak(a)google.com> Cc: stable <stable(a)vger.kernel.org> Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki(a)intel.com> Link: https://lore.kernel.org/r/20200520043626.181820-1-saravanak@google.com Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> --- drivers/base/core.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/base/core.c b/drivers/base/core.c index 4e0e430315d9..0cad34f1eede 100644 --- a/drivers/base/core.c +++ b/drivers/base/core.c @@ -360,12 +360,14 @@ struct device_link *device_link_add(struct device *consumer, if (flags & DL_FLAG_STATELESS) { kref_get(&link->kref); - link->flags |= DL_FLAG_STATELESS; if (link->flags & DL_FLAG_SYNC_STATE_ONLY && - !(link->flags & DL_FLAG_STATELESS)) + !(link->flags & DL_FLAG_STATELESS)) { + link->flags |= DL_FLAG_STATELESS; goto reorder; - else + } else { + link->flags |= DL_FLAG_STATELESS; goto out; + } } /* -- 2.26.2

5 years, 7 months

1
0
0 0

[PATCH 4.4 00/86] 4.4.224-rc1 review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 4.4.224 release. There are 86 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Wed, 20 May 2020 17:32:42 +0000. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.4.224-rc… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.4.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 4.4.224-rc1 Sergei Trofimovich <slyfox(a)gentoo.org> Makefile: disallow data races on gcc-10 as well Jim Mattson <jmattson(a)google.com> KVM: x86: Fix off-by-one error in kvm_vcpu_ioctl_x86_setup_mce Geert Uytterhoeven <geert+renesas(a)glider.be> ARM: dts: r8a7740: Add missing extal2 to CPG node Kai-Heng Feng <kai.heng.feng(a)canonical.com> Revert "ALSA: hda/realtek: Fix pop noise on ALC225" Wei Yongjun <weiyongjun1(a)huawei.com> usb: gadget: legacy: fix error return code in cdc_bind() Wei Yongjun <weiyongjun1(a)huawei.com> usb: gadget: legacy: fix error return code in gncm_bind() Christophe JAILLET <christophe.jaillet(a)wanadoo.fr> usb: gadget: audio: Fix a missing error return value in audio_bind() Christophe JAILLET <christophe.jaillet(a)wanadoo.fr> usb: gadget: net2272: Fix a memory leak in an error handling path in 'net2272_plat_probe()' Eric W. Biederman <ebiederm(a)xmission.com> exec: Move would_dump into flush_old_exec Borislav Petkov <bp(a)suse.de> x86: Fix early boot crash on gcc-10, third try Fabio Estevam <festevam(a)gmail.com> ARM: dts: imx27-phytec-phycard-s-rdk: Fix the I2C1 pinctrl entries Kyungtae Kim <kt0755(a)gmail.com> USB: gadget: fix illegal array access in binding with UDC Takashi Iwai <tiwai(a)suse.de> ALSA: rawmidi: Initialize allocated buffers Takashi Iwai <tiwai(a)suse.de> ALSA: rawmidi: Fix racy buffer resize under concurrent accesses Takashi Iwai <tiwai(a)suse.de> ALSA: hda/realtek - Limit int mic boost for Thinkpad T530 Paolo Abeni <pabeni(a)redhat.com> netlabel: cope with NULL catmap Paolo Abeni <pabeni(a)redhat.com> net: ipv4: really enforce backoff for redirects Cong Wang <xiyou.wangcong(a)gmail.com> net: fix a potential recursive NETDEV_FEAT_CHANGE Linus Torvalds <torvalds(a)linux-foundation.org> gcc-10: avoid shadowing standard library 'free()' in crypto Boris Ostrovsky <boris.ostrovsky(a)oracle.com> x86/paravirt: Remove the unused irq_enable_sysexit pv op Keith Busch <keith.busch(a)intel.com> blk-mq: Allow blocking queue tag iter callbacks Jianchao Wang <jianchao.w.wang(a)oracle.com> blk-mq: sync the update nr_hw_queues with blk_mq_queue_tag_busy_iter Gabriel Krisman Bertazi <krisman(a)linux.vnet.ibm.com> blk-mq: Allow timeouts to run while queue is freezing Christoph Hellwig <hch(a)lst.de> block: defer timeouts to a workqueue Linus Torvalds <torvalds(a)linux-foundation.org> gcc-10: disable 'restrict' warning for now Linus Torvalds <torvalds(a)linux-foundation.org> gcc-10: disable 'stringop-overflow' warning for now Linus Torvalds <torvalds(a)linux-foundation.org> gcc-10: disable 'array-bounds' warning for now Linus Torvalds <torvalds(a)linux-foundation.org> gcc-10: disable 'zero-length-bounds' warning for now Linus Torvalds <torvalds(a)linux-foundation.org> Stop the ad-hoc games with -Wno-maybe-initialized Masahiro Yamada <yamada.masahiro(a)socionext.com> kbuild: compute false-positive -Wmaybe-uninitialized cases in Kconfig Linus Torvalds <torvalds(a)linux-foundation.org> gcc-10 warnings: fix low-hanging fruit Jason Gunthorpe <jgg(a)mellanox.com> pnp: Use list_for_each_entry() instead of open coding Jack Morgenstein <jackm(a)dev.mellanox.co.il> IB/mlx4: Test return value of calls to ib_get_cached_pkey Arnd Bergmann <arnd(a)arndb.de> netfilter: conntrack: avoid gcc-10 zero-length-bounds warning Gal Pressman <galp(a)mellanox.com> net/mlx5: Fix driver load error flow when firmware is stuck Anjali Singhai Jain <anjali.singhai(a)intel.com> i40e: avoid NVM acquire deadlock during NVM update Ben Hutchings <ben.hutchings(a)codethink.co.uk> scsi: qla2xxx: Avoid double completion of abort command zhong jiang <zhongjiang(a)huawei.com> mm/memory_hotplug.c: fix overflow in test_pages_in_a_zone() Jiri Benc <jbenc(a)redhat.com> gre: do not keep the GRE header around in collect medata mode John Hurley <john.hurley(a)netronome.com> net: openvswitch: fix csum updates for MPLS actions Vasily Averin <vvs(a)virtuozzo.com> ipc/util.c: sysvipc_find_ipc() incorrectly updates position index Vasily Averin <vvs(a)virtuozzo.com> drm/qxl: lost qxl_bo_kunmap_atomic_page in qxl_image_init_helper() Lubomir Rintel <lkundrak(a)v3.sk> dmaengine: mmp_tdma: Reset channel error on release Madhuparna Bhowmik <madhuparnabhowmik10(a)gmail.com> dmaengine: pch_dma.c: Avoid data race between probe and irq handler Ronnie Sahlberg <lsahlber(a)redhat.com> cifs: Fix a race condition with cifs_echo_request Samuel Cabrero <scabrero(a)suse.de> cifs: Check for timeout on Negotiate stage wuxu.wu <wuxu.wu(a)huawei.com> spi: spi-dw: Add lock protect dw_spi rx/tx to prevent concurrent calls Wu Bo <wubo40(a)huawei.com> scsi: sg: add sg_remove_request in sg_write Arnd Bergmann <arnd(a)arndb.de> drop_monitor: work around gcc-10 stringop-overflow warning Christophe JAILLET <christophe.jaillet(a)wanadoo.fr> net: moxa: Fix a potential double 'free_irq()' Christophe JAILLET <christophe.jaillet(a)wanadoo.fr> net/sonic: Fix a resource leak in an error handling path in 'jazz_sonic_probe()' David Ahern <dsa(a)cumulusnetworks.com> net: handle no dst on skb in icmp6_send Vladis Dronov <vdronov(a)redhat.com> ptp: free ptp device pin descriptors properly Vladis Dronov <vdronov(a)redhat.com> ptp: fix the race between the release of ptp_clock and cdev YueHaibing <yuehaibing(a)huawei.com> ptp: Fix pass zero to ERR_PTR() in ptp_clock_register Logan Gunthorpe <logang(a)deltatee.com> chardev: add helper function to register char devs with a struct device Dmitry Torokhov <dmitry.torokhov(a)gmail.com> ptp: create "pins" together with the rest of attributes Dmitry Torokhov <dmitry.torokhov(a)gmail.com> ptp: use is_visible method to hide unused attributes Dmitry Torokhov <dmitry.torokhov(a)gmail.com> ptp: do not explicitly set drvdata in ptp_clock_register() Cengiz Can <cengiz(a)kernel.wtf> blktrace: fix dereference after null check Jan Kara <jack(a)suse.cz> blktrace: Protect q->blk_trace with RCU Jens Axboe <axboe(a)kernel.dk> blktrace: fix trace mutex deadlock Jens Axboe <axboe(a)kernel.dk> blktrace: fix unlocked access to init/start-stop/teardown Waiman Long <longman(a)redhat.com> blktrace: Fix potential deadlock between delete & sysfs ops Sabrina Dubroca <sd(a)queasysnail.net> net: ipv6_stub: use ip6_dst_lookup_flow instead of ip6_dst_lookup Sabrina Dubroca <sd(a)queasysnail.net> net: ipv6: add net argument to ip6_dst_lookup_flow Shijie Luo <luoshijie1(a)huawei.com> ext4: add cond_resched() to ext4_protect_reserved_inode Kees Cook <keescook(a)chromium.org> binfmt_elf: Do not move brk for INTERP-less ET_EXEC Alexandre Belloni <alexandre.belloni(a)free-electrons.com> phy: micrel: Ensure interrupts are reenabled on resume Alexandre Belloni <alexandre.belloni(a)free-electrons.com> phy: micrel: Disable auto negotiation on startup Ivan Delalande <colona(a)arista.com> scripts/decodecode: fix trapping instruction formatting George Spelvin <lkml(a)sdf.org> batman-adv: fix batadv_nc_random_weight_tq Oliver Neukum <oneukum(a)suse.com> USB: serial: garmin_gps: add sanity checking for data length Oliver Neukum <oneukum(a)suse.com> USB: uas: add quirk for LaCie 2Big Quadra Alex Estrin <alex.estrin(a)intel.com> Revert "IB/ipoib: Update broadcast object if PKey value was changed in index 0" Ville Syrjälä <ville.syrjala(a)linux.intel.com> x86/apm: Don't access __preempt_count with zeroed fs Kees Cook <keescook(a)chromium.org> binfmt_elf: move brk out of mmap when doing direct loader exec Sabrina Dubroca <sd(a)queasysnail.net> ipv6: fix cleanup ordering for ip6_mr failure Govindarajulu Varadarajan <gvaradar(a)cisco.com> enic: do not overwrite error code Hans de Goede <hdegoede(a)redhat.com> Revert "ACPI / video: Add force_native quirk for HP Pavilion dv6" Eric Dumazet <edumazet(a)google.com> sch_choke: avoid potential panic in choke_reset() Eric Dumazet <edumazet(a)google.com> sch_sfq: validate silly quantum values Tariq Toukan <tariqt(a)mellanox.com> net/mlx4_core: Fix use of ENOSPC around mlx4_counter_alloc() Julia Lawall <Julia.Lawall(a)inria.fr> dp83640: reverse arguments to list_add_tail Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Revert "net: phy: Avoid polling PHY with PHY_IGNORE_INTERRUPTS" Matt Jolly <Kangie(a)footclan.ninja> USB: serial: qcserial: Add DW5816e support ------------- Diffstat: Makefile | 17 +- arch/arm/boot/dts/imx27-phytec-phycard-s-rdk.dts | 4 +- arch/arm/boot/dts/r8a7740.dtsi | 2 +- arch/x86/entry/entry_32.S | 8 +- arch/x86/include/asm/apm.h | 6 - arch/x86/include/asm/paravirt.h | 7 - arch/x86/include/asm/paravirt_types.h | 9 -- arch/x86/include/asm/stackprotector.h | 7 +- arch/x86/kernel/apm_32.c | 5 + arch/x86/kernel/asm-offsets.c | 3 - arch/x86/kernel/paravirt.c | 7 - arch/x86/kernel/paravirt_patch_32.c | 2 - arch/x86/kernel/paravirt_patch_64.c | 1 - arch/x86/kernel/smpboot.c | 8 + arch/x86/kvm/x86.c | 2 +- arch/x86/xen/enlighten.c | 3 - arch/x86/xen/smp.c | 1 + arch/x86/xen/xen-asm_32.S | 14 -- arch/x86/xen/xen-ops.h | 3 - block/blk-core.c | 3 + block/blk-mq-tag.c | 7 +- block/blk-mq.c | 17 ++ block/blk-timeout.c | 3 + crypto/lrw.c | 4 +- crypto/xts.c | 4 +- drivers/acpi/video_detect.c | 11 -- drivers/dma/mmp_tdma.c | 2 + drivers/dma/pch_dma.c | 2 +- drivers/gpu/drm/qxl/qxl_image.c | 3 +- drivers/infiniband/core/addr.c | 6 +- drivers/infiniband/hw/mlx4/qp.c | 14 +- drivers/infiniband/ulp/ipoib/ipoib_ib.c | 13 -- drivers/net/ethernet/cisco/enic/enic_main.c | 9 +- drivers/net/ethernet/intel/i40e/i40e_nvm.c | 98 +++++++----- drivers/net/ethernet/intel/i40e/i40e_prototype.h | 2 - drivers/net/ethernet/mellanox/mlx4/main.c | 4 +- drivers/net/ethernet/mellanox/mlx5/core/main.c | 2 +- drivers/net/ethernet/moxa/moxart_ether.c | 2 +- drivers/net/ethernet/natsemi/jazzsonic.c | 6 +- drivers/net/geneve.c | 4 +- drivers/net/phy/dp83640.c | 2 +- drivers/net/phy/micrel.c | 28 +++- drivers/net/phy/phy.c | 15 +- drivers/net/vxlan.c | 10 +- drivers/ptp/ptp_clock.c | 42 ++--- drivers/ptp/ptp_private.h | 9 +- drivers/ptp/ptp_sysfs.c | 162 ++++++++----------- drivers/scsi/qla2xxx/qla_init.c | 4 +- drivers/scsi/sg.c | 4 +- drivers/spi/spi-dw.c | 15 +- drivers/spi/spi-dw.h | 1 + drivers/usb/gadget/configfs.c | 3 + drivers/usb/gadget/legacy/audio.c | 4 +- drivers/usb/gadget/legacy/cdc2.c | 4 +- drivers/usb/gadget/legacy/ncm.c | 4 +- drivers/usb/gadget/udc/net2272.c | 2 + drivers/usb/serial/garmin_gps.c | 4 +- drivers/usb/serial/qcserial.c | 1 + drivers/usb/storage/unusual_uas.h | 7 + fs/binfmt_elf.c | 12 ++ fs/char_dev.c | 86 ++++++++++ fs/cifs/cifssmb.c | 12 ++ fs/cifs/connect.c | 11 +- fs/cifs/smb2pdu.c | 12 ++ fs/exec.c | 4 +- fs/ext4/block_validity.c | 1 + include/linux/blkdev.h | 3 +- include/linux/blktrace_api.h | 6 +- include/linux/cdev.h | 5 + include/linux/compiler.h | 7 + include/linux/fs.h | 2 +- include/linux/pnp.h | 29 ++-- include/linux/posix-clock.h | 19 ++- include/linux/tty.h | 2 +- include/net/addrconf.h | 6 +- include/net/ipv6.h | 2 +- include/net/netfilter/nf_conntrack.h | 2 +- include/sound/rawmidi.h | 1 + init/main.c | 2 + ipc/util.c | 12 +- kernel/time/posix-clock.c | 31 ++-- kernel/trace/blktrace.c | 191 +++++++++++++++++------ mm/memory_hotplug.c | 4 +- net/batman-adv/network-coding.c | 9 +- net/core/dev.c | 4 +- net/core/drop_monitor.c | 11 +- net/dccp/ipv6.c | 6 +- net/ipv4/cipso_ipv4.c | 6 +- net/ipv4/ip_gre.c | 7 +- net/ipv4/route.c | 2 +- net/ipv6/addrconf_core.c | 11 +- net/ipv6/af_inet6.c | 10 +- net/ipv6/datagram.c | 2 +- net/ipv6/icmp.c | 6 +- net/ipv6/inet6_connection_sock.c | 4 +- net/ipv6/ip6_output.c | 8 +- net/ipv6/raw.c | 2 +- net/ipv6/syncookies.c | 2 +- net/ipv6/tcp_ipv6.c | 4 +- net/l2tp/l2tp_ip6.c | 2 +- net/mpls/af_mpls.c | 7 +- net/netfilter/nf_conntrack_core.c | 4 +- net/netlabel/netlabel_kapi.c | 6 + net/openvswitch/actions.c | 6 +- net/sched/sch_choke.c | 3 +- net/sched/sch_sfq.c | 9 ++ net/sctp/ipv6.c | 4 +- net/tipc/udp_media.c | 9 +- scripts/decodecode | 2 +- sound/core/rawmidi.c | 35 ++++- sound/pci/hda/patch_realtek.c | 12 +- 111 files changed, 805 insertions(+), 496 deletions(-)

5 years, 7 months

5
94
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror