- Linux-stable-mirror - lists.linaro.org

[PATCH 1/1] usb: cdns3: gadget: prev_req->trb is NULL for ep0

by Peter Chen

And there are no multiple TRBs on EP0 and WA1 workaround, so it doesn't need to change TRB for EP0. It fixes below oops. configfs-gadget gadget: high-speed config #1: b android_work: sent uevent USB_STATE=CONFIGURED Unable to handle kernel read from unreadable memory at virtual address 0000000000000008 Mem abort info: android_work: sent uevent USB_STATE=DISCONNECTED ESR = 0x96000004 EC = 0x25: DABT (current EL), IL = 32 bits SET = 0, FnV = 0 EA = 0, S1PTW = 0 Data abort info: ISV = 0, ISS = 0x00000004 CM = 0, WnR = 0 user pgtable: 4k pages, 48-bit VAs, pgdp=00000008b5bb7000 [0000000000000008] pgd=0000000000000000 Internal error: Oops: 96000004 [#1] PREEMPT SMP Modules linked in: CPU: 2 PID: 430 Comm: HwBinder:401_1 Not tainted 5.4.24-06071-g6fa8921409c1-dirty #77 Hardware name: Freescale i.MX8QXP MEK (DT) pstate: 60400085 (nZCv daIf +PAN -UAO) pc : cdns3_gadget_ep_dequeue+0x1d4/0x270 lr : cdns3_gadget_ep_dequeue+0x48/0x270 sp : ffff800012763ba0 x29: ffff800012763ba0 x28: ffff00082c653c00 x27: 0000000000000000 x26: ffff000068fa7b00 x25: ffff0000699b2000 x24: ffff00082c6ac000 x23: ffff000834f0a480 x22: ffff000834e87b9c x21: 0000000000000000 x20: ffff000834e87800 x19: ffff000069eddc00 x18: 0000000000000000 x17: 0000000000000000 x16: 0000000000000000 x15: 0000000000000000 x14: 0000000000000000 x13: 0000000000000000 x12: 0000000000000001 x11: ffff80001180fbe8 x10: 0000000000000001 x9 : ffff800012101558 x8 : 0000000000000001 x7 : 0000000000000006 x6 : ffff000835d9c668 x5 : ffff000834f0a4c8 x4 : 0000000096000000 x3 : 0000000000001810 x2 : 0000000000000000 x1 : ffff800024bd001c x0 : 0000000000000001 Call trace: cdns3_gadget_ep_dequeue+0x1d4/0x270 usb_ep_dequeue+0x34/0xf8 composite_dev_cleanup+0x154/0x170 configfs_composite_unbind+0x6c/0xa8 usb_gadget_remove_driver+0x44/0x70 usb_gadget_unregister_driver+0x74/0xe0 unregister_gadget+0x28/0x58 gadget_dev_desc_UDC_store+0x80/0x110 configfs_write_file+0x1e0/0x2a0 __vfs_write+0x48/0x90 vfs_write+0xe4/0x1c8 ksys_write+0x78/0x100 __arm64_sys_write+0x24/0x30 el0_svc_common.constprop.0+0x74/0x168 el0_svc_handler+0x34/0xa0 el0_svc+0x8/0xc Code: 52830203 b9407660 f94042e4 11000400 (b9400841) ---[ end trace 1574516e4c1772ca ]--- Kernel panic - not syncing: Fatal exception SMP: stopping secondary CPUs Kernel Offset: disabled CPU features: 0x0002,20002008 Memory Limit: none Rebooting in 5 seconds.. Fixes: f616c3bda47e ("usb: cdns3: Fix dequeue implementation") Cc: stable <stable(a)vger.kernel.org> Signed-off-by: Peter Chen <peter.chen(a)nxp.com> --- drivers/usb/cdns3/gadget.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/cdns3/gadget.c b/drivers/usb/cdns3/gadget.c index 996699bd312f..c6908374232a 100644 --- a/drivers/usb/cdns3/gadget.c +++ b/drivers/usb/cdns3/gadget.c @@ -2552,7 +2552,7 @@ int cdns3_gadget_ep_dequeue(struct usb_ep *ep, link_trb = priv_req->trb; /* Update ring only if removed request is on pending_req_list list */ - if (req_on_hw_ring) { + if (req_on_hw_ring && link_trb) { link_trb->buffer = TRB_BUFFER(priv_ep->trb_pool_dma + ((priv_req->end_trb + 1) * TRB_SIZE)); link_trb->control = (link_trb->control & TRB_CYCLE) | -- 2.17.1

5 years, 8 months

1
0
0 0

Re: [PATCH] remoteproc: Fix wrong rvring index computation

by Doug Anderson

Hi, On Fri, 4 Oct 2019 Clement Leger <cleger(a)kalray.eu> wrote: > > Index of rvring is computed using pointer arithmetic. However, since > rvring->rvdev->vring is the base of the vring array, computation > of rvring idx should be reversed. It previously lead to writing at negative > indices in the resource table. > > Signed-off-by: Clement Leger <cleger(a)kalray.eu> > --- > drivers/remoteproc/remoteproc_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Randomly stumbled upon this in a list of patches. This patch landed in mainline as: 00a0eec59ddb remoteproc: Fix wrong rvring index computation Should it be queued up for stable? I'm guessing: Fixes: c0d631570ad5 ("remoteproc: set vring addresses in resource table") -Doug

5 years, 8 months

2
1
0 0

stable-rc/linux-5.4.y boot: 167 boots: 2 failed, 151 passed with 5 offline, 6 untried/unknown, 3 conflicts (v5.4.36)

by kernelci.org bot

stable-rc/linux-5.4.y boot: 167 boots: 2 failed, 151 passed with 5 offline, 6 untried/unknown, 3 conflicts (v5.4.36) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-5.4.y/kernel/v5.4.… Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-5.4.y/kernel/v5.4.36/ Tree: stable-rc Branch: linux-5.4.y Git Describe: v5.4.36 Git Commit: aa73bcc376865c23e61dcebd467697b527901be8 Git URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Tested: 100 unique boards, 26 SoC families, 22 builds out of 200 Boot Regressions Detected: arm: qcom_defconfig: gcc-8: qcom-apq8064-cm-qs600: lab-baylibre-seattle: failing since 81 days (last pass: v5.4.17-99-gbd0c6624a110 - first fail: v5.4.17-238-gbffcaa93483d) sama5_defconfig: gcc-8: at91-sama5d4_xplained: lab-baylibre: failing since 22 days (last pass: v5.4.30-37-g40da5db79b55 - first fail: v5.4.30-39-g23c04177b89f) sunxi_defconfig: gcc-8: sun8i-h2-plus-orangepi-r1: lab-baylibre: new failure (last pass: v5.4.35-169-g388ff47a1fba) versatile_defconfig: gcc-8: versatile-pb: lab-collabora: new failure (last pass: v5.4.35-169-g388ff47a1fba) arm64: defconfig: gcc-8: meson-gxl-s805x-libretech-ac: lab-baylibre: new failure (last pass: v5.4.35-169-g388ff47a1fba) Boot Failures Detected: arm64: defconfig: gcc-8: meson-gxl-s805x-libretech-ac: 1 failed lab arm: sama5_defconfig: gcc-8: at91-sama5d4_xplained: 1 failed lab Offline Platforms: arm: multi_v7_defconfig: gcc-8 exynos5800-peach-pi: 1 offline lab qcom-apq8064-cm-qs600: 1 offline lab stih410-b2120: 1 offline lab qcom_defconfig: gcc-8 qcom-apq8064-cm-qs600: 1 offline lab exynos_defconfig: gcc-8 exynos5800-peach-pi: 1 offline lab Conflicting Boot Failures Detected: (These likely are not failures as other labs are reporting PASS. Needs review.) i386: i386_defconfig: qemu_i386: lab-baylibre: PASS (gcc-8) lab-collabora: FAIL (gcc-8) x86_64: x86_64_defconfig: qemu_x86_64: lab-baylibre: PASS (gcc-8) lab-collabora: FAIL (gcc-8) arm: omap2plus_defconfig: omap4-panda: lab-baylibre: FAIL (gcc-8) lab-baylibre-seattle: PASS (gcc-8) lab-collabora: PASS (gcc-8) --- For more info write to <info(a)kernelci.org>

5 years, 8 months

1
0
0 0

[PATCH 5.6 000/167] 5.6.8-rc1 review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 5.6.8 release. There are 167 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Thu, 30 Apr 2020 18:20:42 +0000. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.6.8-rc1.… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.6.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 5.6.8-rc1 Christian Borntraeger <borntraeger(a)de.ibm.com> s390/mm: fix page table upgrade vs 2ndary address mode accesses Christophe Leroy <christophe.leroy(a)c-s.fr> powerpc/mm: Fix CONFIG_PPC_KUAP_DEBUG on PPC32 Michael Ellerman <mpe(a)ellerman.id.au> powerpc/kuap: PPC_KUAP_DEBUG should depend on PPC_KUAP Chris Wilson <chris(a)chris-wilson.co.uk> drm/i915/gt: Update PMINTRMSK holding fw Michal Simek <michal.simek(a)xilinx.com> Revert "serial: uartps: Register own uart console and driver structures" Michal Simek <michal.simek(a)xilinx.com> Revert "serial: uartps: Move Port ID to device data structure" Michal Simek <michal.simek(a)xilinx.com> Revert "serial: uartps: Change uart ID port allocation" Michal Simek <michal.simek(a)xilinx.com> Revert "serial: uartps: Do not allow use aliases >= MAX_UART_INSTANCES" Michal Simek <michal.simek(a)xilinx.com> Revert "serial: uartps: Fix error path when alloc failed" Michal Simek <michal.simek(a)xilinx.com> Revert "serial: uartps: Use the same dynamic major number for all ports" Michal Simek <michal.simek(a)xilinx.com> Revert "serial: uartps: Fix uartps_major handling" Kazuhiro Fujita <kazuhiro.fujita.jg(a)renesas.com> serial: sh-sci: Make sure status register SCxSR is read in correct sequence Mathias Nyman <mathias.nyman(a)linux.intel.com> xhci: Don't clear hub TT buffer on ep0 protocol stall Mathias Nyman <mathias.nyman(a)linux.intel.com> xhci: prevent bus suspend if a roothub port detected a over-current condition Mathias Nyman <mathias.nyman(a)linux.intel.com> xhci: Fix handling halted endpoint even if endpoint ring appears empty Naoki Kiryu <naonaokiryu2(a)gmail.com> usb: typec: altmode: Fix typec_altmode_get_partner sometimes returning an invalid pointer Badhri Jagan Sridharan <badhri(a)google.com> usb: typec: tcpm: Ignore CC and vbus changes in PORT_RESET change Udipto Goswami <ugoswami(a)codeaurora.org> usb: f_fs: Clear OS Extended descriptor counts to zero in ffs_data_reset() Thinh Nguyen <Thinh.Nguyen(a)synopsys.com> usb: dwc3: gadget: Fix request completion check Xu Yilun <yilun.xu(a)intel.com> fpga: dfl: pci: fix return value of cci_pci_sriov_configure Oliver Neukum <oneukum(a)suse.com> UAS: fix deadlock in error handling and PM flushing work Oliver Neukum <oneukum(a)suse.com> UAS: no use logging any details in case of ENODEV Oliver Neukum <oneukum(a)suse.com> cdc-acm: introduce a cool down Oliver Neukum <oneukum(a)suse.com> cdc-acm: close race betrween suspend() and acm_softint Benjamin Lee <ben(a)b1c1l1.com> mei: me: fix irq number stored in hw struct Malcolm Priestley <tvboxspy(a)gmail.com> staging: vt6656: Power save stop wake_up_count wrap around. Malcolm Priestley <tvboxspy(a)gmail.com> staging: vt6656: Fix pairwise key entry save. Malcolm Priestley <tvboxspy(a)gmail.com> staging: vt6656: Fix drivers TBTT timing counter. Malcolm Priestley <tvboxspy(a)gmail.com> staging: vt6656: Fix calling conditions of vnt_set_bss_mode Malcolm Priestley <tvboxspy(a)gmail.com> staging: vt6656: Don't set RCR_MULTICAST or RCR_BROADCAST by default. Nicolas Pitre <nico(a)fluxnic.net> vt: don't use kmalloc() for the unicode screen buffer Nicolas Pitre <nico(a)fluxnic.net> vt: don't hardcode the mem allocation upper bound Xiyu Yang <xiyuyang19(a)fudan.edu.cn> staging: comedi: Fix comedi_device refcnt leak in comedi_open Ian Abbott <abbotti(a)mev.co.uk> staging: comedi: dt2815: fix writing hi byte of analog output Chris Packham <chris.packham(a)alliedtelesis.co.nz> powerpc/setup_64: Set cache-line-size based on cache-block-size Christophe Leroy <christophe.leroy(a)c-s.fr> powerpc/8xx: Fix STRICT_KERNEL_RWX startup test failure Ahmad Fatoum <a.fatoum(a)pengutronix.de> ARM: imx: provide v7_cpu_resume() only on ARM_CPU_SUSPEND=y Paulo Alcantara <pc(a)cjr.nz> cifs: fix uninitialised lease_key in open_shroot() Luca Coelho <luciano.coelho(a)intel.com> iwlwifi: fix WGDS check when WRDS is disabled Johannes Berg <johannes.berg(a)intel.com> iwlwifi: mvm: fix inactive TID removal return value usage Ilan Peer <ilan.peer(a)intel.com> iwlwifi: mvm: Do not declare support for ACK Enabled Aggregation Johannes Berg <johannes.berg(a)intel.com> iwlwifi: mvm: limit maximum queue appropriately Johannes Berg <johannes.berg(a)intel.com> iwlwifi: pcie: indicate correct RB size to device Mordechay Goodstein <mordechay.goodstein(a)intel.com> iwlwifi: mvm: beacon statistics shouldn't go backwards Johannes Berg <johannes.berg(a)intel.com> iwlwifi: pcie: actually release queue memory in TVQM Chuck Lever <chuck.lever(a)oracle.com> SUNRPC: Fix backchannel RPC soft lockups Gyeongtaek Lee <gt82.lee(a)samsung.com> ASoC: dapm: fixup dapm kcontrol widget Paul Moore <paul(a)paul-moore.com> audit: check the length of userspace generated audit records Mikita Lipski <mikita.lipski(a)amd.com> drm/dp_mst: Zero assigned PBN when releasing VCPI slots Eric W. Biederman <ebiederm(a)xmission.com> signal: Avoid corrupting si_pid and si_uid in do_notify_parent Alan Stern <stern(a)rowland.harvard.edu> usb-storage: Add unusual_devs entry for JMicron JMS566 Jiri Slaby <jslaby(a)suse.cz> tty: rocket, avoid OOB access Andrew Melnychenko <andrew(a)daynix.com> tty: hvc: fix buffer overflow during hvc_alloc(). Uros Bizjak <ubizjak(a)gmail.com> KVM: VMX: Enable machine check support for 32bit targets Sean Christopherson <sean.j.christopherson(a)intel.com> KVM: Check validity of resolved slot when searching memslots Sean Christopherson <sean.j.christopherson(a)intel.com> KVM: s390: Return last valid slot if approx index is out-of-bounds George Wilson <gcwilson(a)linux.ibm.com> tpm: ibmvtpm: retry on H_CLOSED in tpm_ibmvtpm_send() Tianjia Zhang <tianjia.zhang(a)linux.alibaba.com> tpm: fix wrong return value in tpm_pcr_extend Jarkko Sakkinen <jarkko.sakkinen(a)linux.intel.com> tpm/tpm_tis: Free IRQ if probing fails Alexander Tsoy <alexander(a)tsoy.me> ALSA: usb-audio: Filter out unsupported sample rates on Focusrite devices Xiyu Yang <xiyuyang19(a)fudan.edu.cn> ALSA: usb-audio: Fix usb audio refcnt leak when getting spdif Takashi Iwai <tiwai(a)suse.de> ALSA: hda/hdmi: Add module option to disable audio component binding Kailang Yang <kailang(a)realtek.com> ALSA: hda/realtek - Add new codec supported for ALC245 Takashi Iwai <tiwai(a)suse.de> ALSA: hda/realtek - Fix unexpected init_amp override Takashi Iwai <tiwai(a)suse.de> ALSA: usx2y: Fix potential NULL dereference Lucas Stach <l.stach(a)pengutronix.de> tools/vm: fix cross-compile build Muchun Song <songmuchun(a)bytedance.com> mm/ksm: fix NULL pointer dereference when KSM zero page is enabled Longpeng <longpeng2(a)huawei.com> mm/hugetlb: fix a addressing exception caused by huge_pte_offset Sudip Mukherjee <sudipm.mukherjee(a)gmail.com> coredump: fix null pointer dereference on coredump Luis Mendes <luis.p.mendes(a)gmail.com> staging: gasket: Fix incongruency in handling of sysfs entries creation Jann Horn <jannh(a)google.com> vmalloc: fix remap_vmalloc_range() bounds checks Amit Singh Tomar <amittomer25(a)gmail.com> tty: serial: owl: add "much needed" clk_prepare_enable() Alan Stern <stern(a)rowland.harvard.edu> USB: hub: Revert commit bd0e6c9614b9 ("usb: hub: try old enumeration scheme first for high speed devices") Alan Stern <stern(a)rowland.harvard.edu> USB: hub: Fix handling of connect changes during sleep Alan Stern <stern(a)rowland.harvard.edu> USB: core: Fix free-while-in-use bug in the USB S-Glibrary Jann Horn <jannh(a)google.com> USB: early: Handle AMD's spec-compliant identifiers, too Jonathan Cox <jonathan(a)jdcox.net> USB: Add USB_QUIRK_DELAY_CTRL_MSG and USB_QUIRK_DELAY_INIT for Corsair K70 RGB RAPIDFIRE Changming Liu <liu.changm(a)northeastern.edu> USB: sisusbvga: Change port variable from signed to unsigned Lars-Peter Clausen <lars(a)metafoo.de> iio: xilinx-xadc: Make sure not exceed maximum samplerate Lars-Peter Clausen <lars(a)metafoo.de> iio: xilinx-xadc: Fix sequencer configuration for aux channels in simultaneous mode Lars-Peter Clausen <lars(a)metafoo.de> iio: xilinx-xadc: Fix clearing interrupt when enabling trigger Lars-Peter Clausen <lars(a)metafoo.de> iio: xilinx-xadc: Fix ADC-B powerdown Alexandre Belloni <alexandre.belloni(a)bootlin.com> iio: adc: ti-ads8344: properly byte swap value Olivier Moysan <olivier.moysan(a)st.com> iio: adc: stm32-adc: fix sleep in atomic context Lary Gibaud <yarl-baudig(a)mailoo.org> iio: st_sensors: rely on odr mask to know if odr can be set Lorenzo Bianconi <lorenzo(a)kernel.org> iio: imu: st_lsm6dsx: flush hw FIFO before resetting the device Lars Engebretsen <lars(a)engebretsen.ch> iio: core: remove extra semi-colon from devm_iio_device_register() macro David Ahern <dsahern(a)gmail.com> libbpf: Only check mode flags in get_xdp_id Johannes Berg <johannes.berg(a)intel.com> mac80211: populate debugfs only after cfg80211 init Takashi Iwai <tiwai(a)suse.de> ALSA: usb-audio: Add connector notifier delegation Takashi Iwai <tiwai(a)suse.de> ALSA: usb-audio: Add static mapping table for ALC1220-VB-based mobos Takashi Iwai <tiwai(a)suse.de> ALSA: hda: Remove ASUS ROG Zenith from the blacklist Waiman Long <longman(a)redhat.com> KEYS: Avoid false positive ENOMEM error on key read Tang Bin <tangbin(a)cmss.chinamobile.com> net: ethernet: ixp4xx: Add error handling in ixp4xx_eth_probe() David Ahern <dsahern(a)gmail.com> vrf: Check skb for XFRM_TRANSFORMED flag David Ahern <dsahern(a)gmail.com> xfrm: Always set XFRM_TRANSFORMED in xfrm{4,6}_output_finish Sabrina Dubroca <sd(a)queasysnail.net> geneve: use the correct nlattr array in NL_SET_ERR_MSG_ATTR Sabrina Dubroca <sd(a)queasysnail.net> vxlan: use the correct nlattr array in NL_SET_ERR_MSG_ATTR Florian Fainelli <f.fainelli(a)gmail.com> net: dsa: b53: b53_arl_rw_op() needs to select IVL or SVL Florian Fainelli <f.fainelli(a)gmail.com> net: dsa: b53: Rework ARL bin logic Florian Fainelli <f.fainelli(a)gmail.com> net: dsa: b53: Fix ARL register definitions Florian Fainelli <f.fainelli(a)gmail.com> net: dsa: b53: Fix valid setting for MDB entries Florian Fainelli <f.fainelli(a)gmail.com> net: dsa: b53: Lookup VID in ARL searches when VLAN is enabled David Ahern <dsahern(a)gmail.com> vrf: Fix IPv6 with qdisc and xfrm Xiyu Yang <xiyuyang19(a)fudan.edu.cn> tipc: Fix potential tipc_node refcnt leak in tipc_rcv Xiyu Yang <xiyuyang19(a)fudan.edu.cn> tipc: Fix potential tipc_aead refcnt leak in tipc_crypto_rcv Taehee Yoo <ap420073(a)gmail.com> team: fix hang in team_mode_get() Eric Dumazet <edumazet(a)google.com> tcp: cache line align MAX_TCP_HEADER David Ahern <dsahern(a)gmail.com> selftests: Fix suppress test in fib_tests.sh Eric Dumazet <edumazet(a)google.com> sched: etf: do not assume all sockets are full blown Xiyu Yang <xiyuyang19(a)fudan.edu.cn> net/x25: Fix x25_neigh refcnt leak when receiving frame Marc Zyngier <maz(a)kernel.org> net: stmmac: dwmac-meson8b: Add missing boundary to RGMII TX clock array Tonghao Zhang <xiangxia.m.yue(a)gmail.com> net: openvswitch: ovs_ct_exit to be done under ovs_lock Xiyu Yang <xiyuyang19(a)fudan.edu.cn> net: netrom: Fix potential nr_neigh refcnt leak in nr_add_node Eric Dumazet <edumazet(a)google.com> net/mlx4_en: avoid indirect call in TX completion Doug Berger <opendmb(a)gmail.com> net: bcmgenet: correct per TX/RX ring statistics Dan Carpenter <dan.carpenter(a)oracle.com> mlxsw: Fix some IS_ERR() vs NULL bugs Taehee Yoo <ap420073(a)gmail.com> macvlan: fix null dereference in macvlan_device_event() Taehee Yoo <ap420073(a)gmail.com> macsec: avoid to set wrong mtu John Haxby <john.haxby(a)oracle.com> ipv6: fix restrict IPV6_ADDRFORM operation David Ahern <dsahern(a)gmail.com> ipv4: Update fib_select_default to handle nexthop objects Rahul Lakkireddy <rahul.lakkireddy(a)chelsio.com> cxgb4: fix large delays in PTP synchronization Vishal Kulkarni <vishal(a)chelsio.com> cxgb4: fix adapter crash due to wrong MC size Christoph Hellwig <hch(a)lst.de> block: fix busy device checking in blk_drop_partitions again Mathias Nyman <mathias.nyman(a)linux.intel.com> xhci: Finetune host initiated USB3 rootport link suspend and resume Kai-Heng Feng <kai.heng.feng(a)canonical.com> xhci: Wait until link state trainsits to U0 after setting USB_SS_PORT_LS_U0 Kai-Heng Feng <kai.heng.feng(a)canonical.com> xhci: Ensure link state is U3 after setting USB_SS_PORT_LS_U3 František Kučera <franta-linux(a)frantovo.cz> ALSA: usb-audio: Add Pioneer DJ DJM-250MK2 quirk Hans de Goede <hdegoede(a)redhat.com> ASoC: Intel: bytcr_rt5640: Add quirk for MPMAN MPWIN895CL tablet Nicholas Kazlauskas <nicholas.kazlauskas(a)amd.com> drm/amd/display: Calculate scaling ratios on every medium/full update Jiri Olsa <jolsa(a)kernel.org> perf/core: Disable page faults when getting phys address James Smart <jsmart2021(a)gmail.com> scsi: lpfc: Fix lockdep error - register non-static key James Smart <jsmart2021(a)gmail.com> scsi: lpfc: Fix erroneous cpu limit of 128 on I/O statistics Florian Fainelli <f.fainelli(a)gmail.com> pwm: bcm2835: Dynamically allocate base Geert Uytterhoeven <geert+renesas(a)glider.be> pwm: renesas-tpu: Fix late Runtime PM enablement Nick Bowler <nbowler(a)draconx.ca> nvme: fix compat address handling in several ioctls Ganesh Goudar <ganeshgr(a)linux.ibm.com> powerpc/pseries: Fix MCE handling on pseries Nicholas Piggin <npiggin(a)gmail.com> Revert "powerpc/64: irq_work avoid interrupt when called with hardware irqs enabled" Evan Green <evgreen(a)chromium.org> loop: Better discard support for block devices Cornelia Huck <cohuck(a)redhat.com> s390/cio: avoid duplicated 'ADD' uevents Cornelia Huck <cohuck(a)redhat.com> s390/cio: generate delayed uevent for vfio-ccw subchannels Christoph Hellwig <hch(a)lst.de> block: fix busy device checking in blk_drop_partitions Masahiro Yamada <masahiroy(a)kernel.org> lib/raid6/test: fix build on distros whose /bin/sh is not bash Mauro Carvalho Chehab <mchehab+huawei(a)kernel.org> kconfig: qconf: Fix a few alignment issues Vasily Averin <vvs(a)virtuozzo.com> ipc/util.c: sysvipc_find_ipc() should increase position index Eric Biggers <ebiggers(a)google.com> selftests: kmod: fix handling test numbers above 9 Vasily Averin <vvs(a)virtuozzo.com> kernel/gcov/fs.c: gcov_seq_next() should increase position index Kishon Vijay Abraham I <kishon(a)ti.com> dma-direct: fix data truncation in dma_direct_get_required_mask() Isabel Zhang <isabel.zhang(a)amd.com> drm/amd/display: Update stream adjust in dc_stream_adjust_vmin_vmax Sagi Grimberg <sagi(a)grimberg.me> nvme: fix deadlock caused by ANA update wrong locking Hans de Goede <hdegoede(a)redhat.com> ASoC: Intel: atom: Take the drv->lock mutex before calling sst_send_slot_map() Santosh Sivaraj <santosh(a)fossix.org> tools/test/nvdimm: Fix out of tree build Wu Bo <wubo40(a)huawei.com> scsi: iscsi: Report unbind session event when the target has been removed Stephan Gerhold <stephan(a)gerhold.net> ASoC: qcom: q6asm-dai: Add SNDRV_PCM_INFO_BATCH flag Sagi Grimberg <sagi(a)grimberg.me> nvme-tcp: fix possible crash in write_zeroes processing Geert Uytterhoeven <geert+renesas(a)glider.be> pwm: rcar: Fix late Runtime PM enablement Uwe Kleine-König <u.kleine-koenig(a)pengutronix.de> pwm: imx27: Fix clock handling in pwm_imx27_apply() Yan, Zheng <zyan(a)redhat.com> ceph: don't skip updating wanted caps when cap is stale Qiujun Huang <hqjagain(a)gmail.com> ceph: return ceph_mdsc_do_request() errors from __get_parent() Javed Hasan <jhasan(a)marvell.com> scsi: libfc: If PRLI rejected, move rport to PLOGI state James Smart <jsmart2021(a)gmail.com> scsi: lpfc: Fix crash in target side cable pulls hitting WAIT_FOR_UNREG James Smart <jsmart2021(a)gmail.com> scsi: lpfc: Fix crash after handling a pci error Dave Chinner <dchinner(a)redhat.com> xfs: correctly acount for reclaimable slabs James Smart <jsmart2021(a)gmail.com> scsi: lpfc: Fix kasan slab-out-of-bounds error in lpfc_unreg_login Tero Kristo <t-kristo(a)ti.com> watchdog: reset last_hw_keepalive time at start Jan Kara <jack(a)suse.cz> tools/testing/nvdimm: Fix compilation failure without CONFIG_DEV_DAX_PMEM_COMPAT Linus Torvalds <torvalds(a)linux-foundation.org> mm: check that mm is still valid in madvise() ------------- Diffstat: Documentation/admin-guide/kernel-parameters.txt | 3 +- Makefile | 4 +- arch/arm/mach-imx/Makefile | 2 + arch/powerpc/kernel/entry_32.S | 2 +- arch/powerpc/kernel/setup_64.c | 2 + arch/powerpc/kernel/time.c | 44 ++--- arch/powerpc/mm/nohash/8xx.c | 3 + arch/powerpc/platforms/Kconfig.cputype | 2 +- arch/powerpc/platforms/pseries/ras.c | 11 ++ arch/s390/kvm/kvm-s390.c | 3 + arch/s390/lib/uaccess.c | 4 + arch/s390/mm/pgalloc.c | 16 +- arch/x86/kvm/vmx/vmx.c | 2 +- block/partition-generic.c | 2 +- drivers/block/loop.c | 42 ++-- drivers/char/tpm/tpm-interface.c | 2 +- drivers/char/tpm/tpm_ibmvtpm.c | 136 +++++++------ drivers/char/tpm/tpm_tis_core.c | 8 +- drivers/fpga/dfl-pci.c | 6 +- drivers/gpu/drm/amd/display/dc/core/dc.c | 15 +- drivers/gpu/drm/drm_dp_mst_topology.c | 1 + drivers/gpu/drm/i915/gt/intel_rps.c | 6 +- drivers/iio/adc/stm32-adc.c | 31 ++- drivers/iio/adc/ti-ads8344.c | 6 +- drivers/iio/adc/xilinx-xadc-core.c | 95 ++++++++-- drivers/iio/common/st_sensors/st_sensors_core.c | 2 +- drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 24 ++- drivers/misc/mei/pci-me.c | 3 +- drivers/net/dsa/b53/b53_common.c | 38 +++- drivers/net/dsa/b53/b53_regs.h | 8 +- drivers/net/ethernet/broadcom/genet/bcmgenet.c | 3 + drivers/net/ethernet/chelsio/cxgb4/cudbg_lib.c | 27 ++- drivers/net/ethernet/chelsio/cxgb4/cxgb4_ptp.c | 27 +-- drivers/net/ethernet/chelsio/cxgb4/t4_regs.h | 3 + drivers/net/ethernet/mellanox/mlx4/en_tx.c | 14 +- .../mellanox/mlxsw/core_acl_flex_actions.c | 4 +- .../ethernet/mellanox/mlxsw/spectrum2_acl_tcam.c | 4 +- drivers/net/ethernet/mellanox/mlxsw/spectrum_acl.c | 2 +- .../net/ethernet/mellanox/mlxsw/spectrum_mr_tcam.c | 4 +- .../net/ethernet/stmicro/stmmac/dwmac-meson8b.c | 1 + drivers/net/ethernet/xscale/ixp4xx_eth.c | 2 + drivers/net/geneve.c | 2 +- drivers/net/macsec.c | 12 +- drivers/net/macvlan.c | 2 +- drivers/net/team/team.c | 4 + drivers/net/vrf.c | 10 +- drivers/net/vxlan.c | 6 +- drivers/net/wireless/intel/iwlegacy/3945-rs.c | 2 +- drivers/net/wireless/intel/iwlegacy/4965-rs.c | 2 +- drivers/net/wireless/intel/iwlwifi/dvm/rs.c | 2 +- drivers/net/wireless/intel/iwlwifi/fw/acpi.c | 9 +- drivers/net/wireless/intel/iwlwifi/fw/api/txq.h | 6 +- drivers/net/wireless/intel/iwlwifi/iwl-nvm-parse.c | 6 +- drivers/net/wireless/intel/iwlwifi/mvm/fw.c | 25 ++- drivers/net/wireless/intel/iwlwifi/mvm/rs.c | 2 +- drivers/net/wireless/intel/iwlwifi/mvm/rx.c | 13 +- drivers/net/wireless/intel/iwlwifi/mvm/sta.c | 9 +- .../wireless/intel/iwlwifi/pcie/ctxt-info-gen3.c | 18 +- drivers/net/wireless/intel/iwlwifi/pcie/tx-gen2.c | 3 + drivers/net/wireless/realtek/rtlwifi/rc.c | 2 +- drivers/nvme/host/core.c | 27 ++- drivers/nvme/host/multipath.c | 4 +- drivers/nvme/host/tcp.c | 13 +- drivers/pwm/pwm-bcm2835.c | 1 + drivers/pwm/pwm-imx27.c | 2 +- drivers/pwm/pwm-rcar.c | 10 +- drivers/pwm/pwm-renesas-tpu.c | 9 +- drivers/s390/cio/device.c | 13 +- drivers/s390/cio/vfio_ccw_drv.c | 5 + drivers/scsi/libfc/fc_rport.c | 8 +- drivers/scsi/lpfc/lpfc.h | 9 +- drivers/scsi/lpfc/lpfc_debugfs.c | 204 ++++++++++++-------- drivers/scsi/lpfc/lpfc_debugfs.h | 1 - drivers/scsi/lpfc/lpfc_init.c | 33 +++- drivers/scsi/lpfc/lpfc_nvme.c | 59 +++--- drivers/scsi/lpfc/lpfc_nvmet.c | 55 +++--- drivers/scsi/lpfc/lpfc_scsi.c | 23 +-- drivers/scsi/lpfc/lpfc_sli.c | 13 +- drivers/scsi/lpfc/lpfc_sli4.h | 19 +- drivers/scsi/scsi_transport_iscsi.c | 4 +- drivers/staging/comedi/comedi_fops.c | 4 +- drivers/staging/comedi/drivers/dt2815.c | 3 + drivers/staging/gasket/gasket_sysfs.c | 3 +- drivers/staging/gasket/gasket_sysfs.h | 4 - drivers/staging/vt6656/int.c | 3 +- drivers/staging/vt6656/key.c | 14 +- drivers/staging/vt6656/main_usb.c | 31 +-- drivers/tty/hvc/hvc_console.c | 23 ++- drivers/tty/rocket.c | 25 +-- drivers/tty/serial/owl-uart.c | 7 + drivers/tty/serial/sh-sci.c | 13 +- drivers/tty/serial/xilinx_uartps.c | 211 +++++---------------- drivers/tty/vt/vt.c | 7 +- drivers/usb/class/cdc-acm.c | 36 +++- drivers/usb/class/cdc-acm.h | 5 +- drivers/usb/core/hub.c | 18 +- drivers/usb/core/message.c | 9 +- drivers/usb/core/quirks.c | 4 + drivers/usb/dwc3/gadget.c | 12 +- drivers/usb/early/xhci-dbc.c | 8 +- drivers/usb/early/xhci-dbc.h | 18 +- drivers/usb/gadget/function/f_fs.c | 4 + drivers/usb/host/xhci-hub.c | 70 ++++++- drivers/usb/host/xhci-mem.c | 1 + drivers/usb/host/xhci-ring.c | 47 ++++- drivers/usb/host/xhci.c | 14 +- drivers/usb/host/xhci.h | 6 +- drivers/usb/misc/sisusbvga/sisusb.c | 20 +- drivers/usb/misc/sisusbvga/sisusb_init.h | 14 +- drivers/usb/storage/uas.c | 46 ++++- drivers/usb/storage/unusual_devs.h | 7 + drivers/usb/typec/bus.c | 5 +- drivers/usb/typec/tcpm/tcpm.c | 26 +++ drivers/watchdog/watchdog_dev.c | 1 + fs/ceph/caps.c | 8 +- fs/ceph/export.c | 5 + fs/cifs/smb2ops.c | 5 + fs/coredump.c | 2 + fs/nfsd/nfs4callback.c | 4 +- fs/proc/vmcore.c | 5 +- fs/xfs/xfs_super.c | 3 +- include/linux/iio/iio.h | 2 +- include/linux/kvm_host.h | 2 +- include/linux/vmalloc.h | 2 +- include/net/mac80211.h | 4 +- include/net/tcp.h | 2 +- ipc/util.c | 2 +- kernel/audit.c | 3 + kernel/dma/direct.c | 3 +- kernel/events/core.c | 9 +- kernel/gcov/fs.c | 2 +- kernel/signal.c | 6 +- lib/raid6/test/Makefile | 6 +- mm/hugetlb.c | 14 +- mm/ksm.c | 12 +- mm/madvise.c | 18 ++ mm/vmalloc.c | 16 +- net/ipv4/fib_semantics.c | 6 +- net/ipv4/xfrm4_output.c | 2 - net/ipv6/ipv6_sockglue.c | 13 +- net/ipv6/xfrm6_output.c | 2 - net/mac80211/main.c | 5 +- net/mac80211/rate.c | 15 +- net/mac80211/rate.h | 23 +++ net/mac80211/rc80211_minstrel_ht.c | 19 +- net/netrom/nr_route.c | 1 + net/openvswitch/conntrack.c | 3 +- net/openvswitch/datapath.c | 4 +- net/sched/sch_etf.c | 7 +- net/sunrpc/svc_xprt.c | 2 + net/sunrpc/xprtrdma/svc_rdma_backchannel.c | 2 + net/sunrpc/xprtsock.c | 1 + net/tipc/crypto.c | 1 + net/tipc/node.c | 4 +- net/x25/x25_dev.c | 4 +- samples/vfio-mdev/mdpy.c | 2 +- scripts/kconfig/qconf.cc | 13 +- security/keys/internal.h | 12 ++ security/keys/keyctl.c | 58 ++++-- sound/pci/hda/hda_intel.c | 1 - sound/pci/hda/patch_hdmi.c | 9 + sound/pci/hda/patch_realtek.c | 11 +- sound/soc/intel/atom/sst-atom-controls.c | 2 + sound/soc/intel/boards/bytcr_rt5640.c | 11 ++ sound/soc/qcom/qdsp6/q6asm-dai.c | 4 +- sound/soc/soc-dapm.c | 20 +- sound/usb/format.c | 52 +++++ sound/usb/mixer.c | 37 +++- sound/usb/mixer.h | 10 + sound/usb/mixer_maps.c | 37 +++- sound/usb/mixer_quirks.c | 12 +- sound/usb/quirks-table.h | 56 ++++++ sound/usb/usx2y/usbusx2yaudio.c | 2 + tools/lib/bpf/netlink.c | 2 + tools/testing/nvdimm/Kbuild | 4 +- tools/testing/nvdimm/test/Kbuild | 4 +- tools/testing/nvdimm/test/nfit.c | 2 + tools/testing/selftests/kmod/kmod.sh | 13 +- tools/testing/selftests/net/fib_nexthops.sh | 23 +++ tools/testing/selftests/net/fib_tests.sh | 10 +- tools/vm/Makefile | 2 + 181 files changed, 1766 insertions(+), 872 deletions(-)

5 years, 8 months

5
175
0 0

stable-rc/linux-4.19.y boot: 149 boots: 1 failed, 133 passed with 6 offline, 7 untried/unknown, 2 conflicts (v4.19.119)

by kernelci.org bot

stable-rc/linux-4.19.y boot: 149 boots: 1 failed, 133 passed with 6 offline, 7 untried/unknown, 2 conflicts (v4.19.119) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-4.19.y/kernel/v4.1… Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-4.19.y/kernel/v4.19.119/ Tree: stable-rc Branch: linux-4.19.y Git Describe: v4.19.119 Git Commit: 765675379b6253b6901563e649a2f87d28ada3ff Git URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Tested: 86 unique boards, 22 SoC families, 20 builds out of 206 Boot Regressions Detected: arm: multi_v7_defconfig: gcc-8: sun8i-a83t-bananapi-m3: lab-clabbe: new failure (last pass: v4.19.118-132-g3fc812d65db6) qcom_defconfig: gcc-8: qcom-apq8064-cm-qs600: lab-baylibre-seattle: failing since 81 days (last pass: v4.19.101 - first fail: v4.19.102-96-g0632821fe218) sama5_defconfig: gcc-8: at91-sama5d4_xplained: lab-baylibre: failing since 47 days (last pass: v4.19.108-87-g624c124960e8 - first fail: v4.19.109) versatile_defconfig: gcc-8: versatile-pb: lab-collabora: new failure (last pass: v4.19.118-132-g3fc812d65db6) arm64: defconfig: gcc-8: meson-axg-s400: lab-baylibre-seattle: new failure (last pass: v4.19.118-132-g3fc812d65db6) sun50i-h5-nanopi-neo-plus2: lab-clabbe: new failure (last pass: v4.19.118-132-g3fc812d65db6) i386: i386_defconfig: gcc-8: qemu_i386: lab-collabora: new failure (last pass: v4.19.118-132-g3fc812d65db6) x86_64: x86_64_defconfig: gcc-8: qemu_x86_64: lab-collabora: new failure (last pass: v4.19.118-132-g3fc812d65db6) Boot Failure Detected: arm: sama5_defconfig: gcc-8: at91-sama5d4_xplained: 1 failed lab Offline Platforms: arm64: defconfig: gcc-8 meson-axg-s400: 1 offline lab arm: multi_v7_defconfig: gcc-8 exynos5800-peach-pi: 1 offline lab qcom-apq8064-cm-qs600: 1 offline lab stih410-b2120: 1 offline lab qcom_defconfig: gcc-8 qcom-apq8064-cm-qs600: 1 offline lab exynos_defconfig: gcc-8 exynos5800-peach-pi: 1 offline lab Conflicting Boot Failures Detected: (These likely are not failures as other labs are reporting PASS. Needs review.) i386: i386_defconfig: qemu_i386: lab-baylibre: PASS (gcc-8) lab-collabora: FAIL (gcc-8) x86_64: x86_64_defconfig: qemu_x86_64: lab-baylibre: PASS (gcc-8) lab-collabora: FAIL (gcc-8) --- For more info write to <info(a)kernelci.org>

5 years, 8 months

1
0
0 0

[PATCH crypto-stable] crypto: arch/lib - limit simd usage to PAGE_SIZE chunks

by Jason A. Donenfeld

The initial Zinc patchset, after some mailing list discussion, contained code to ensure that kernel_fpu_enable would not be kept on for more than a PAGE_SIZE chunk, since it disables preemption. The choice of PAGE_SIZE isn't totally scientific, but it's not a bad guess either, and it's what's used in both the x86 poly1305 and blake2s library code already. Unfortunately it appears to have been left out of the final patchset that actually added the glue code. So, this commit adds back the PAGE_SIZE chunking. Fixes: 84e03fa39fbe ("crypto: x86/chacha - expose SIMD ChaCha routine as library function") Fixes: b3aad5bad26a ("crypto: arm64/chacha - expose arm64 ChaCha routine as library function") Fixes: a44a3430d71b ("crypto: arm/chacha - expose ARM ChaCha routine as library function") Fixes: f569ca164751 ("crypto: arm64/poly1305 - incorporate OpenSSL/CRYPTOGAMS NEON implementation") Fixes: a6b803b3ddc7 ("crypto: arm/poly1305 - incorporate OpenSSL/CRYPTOGAMS NEON implementation") Cc: Eric Biggers <ebiggers(a)google.com> Cc: Ard Biesheuvel <ardb(a)kernel.org> Cc: stable(a)vger.kernel.org Signed-off-by: Jason A. Donenfeld <Jason(a)zx2c4.com> --- Eric, Ard - I'm wondering if this was in fact just an oversight in Ard's patches, or if there was actually some later discussion in which we concluded that the PAGE_SIZE chunking wasn't required, perhaps because of FPU changes. If that's the case, please do let me know, in which case I'll submit a _different_ patch that removes the chunking from x86 poly and blake. I can't find any emails that would indicate that, but I might be mistaken. arch/arm/crypto/chacha-glue.c | 16 +++++++++++++--- arch/arm/crypto/poly1305-glue.c | 17 +++++++++++++---- arch/arm64/crypto/chacha-neon-glue.c | 16 +++++++++++++--- arch/arm64/crypto/poly1305-glue.c | 17 +++++++++++++---- arch/x86/crypto/chacha_glue.c | 16 +++++++++++++--- 5 files changed, 65 insertions(+), 17 deletions(-) diff --git a/arch/arm/crypto/chacha-glue.c b/arch/arm/crypto/chacha-glue.c index 6fdb0ac62b3d..0e29ebac95fd 100644 --- a/arch/arm/crypto/chacha-glue.c +++ b/arch/arm/crypto/chacha-glue.c @@ -91,9 +91,19 @@ void chacha_crypt_arch(u32 *state, u8 *dst, const u8 *src, unsigned int bytes, return; } - kernel_neon_begin(); - chacha_doneon(state, dst, src, bytes, nrounds); - kernel_neon_end(); + for (;;) { + unsigned int todo = min_t(unsigned int, PAGE_SIZE, bytes); + + kernel_neon_begin(); + chacha_doneon(state, dst, src, todo, nrounds); + kernel_neon_end(); + + bytes -= todo; + if (!bytes) + break; + src += todo; + dst += todo; + } } EXPORT_SYMBOL(chacha_crypt_arch); diff --git a/arch/arm/crypto/poly1305-glue.c b/arch/arm/crypto/poly1305-glue.c index ceec04ec2f40..536a4a943ebe 100644 --- a/arch/arm/crypto/poly1305-glue.c +++ b/arch/arm/crypto/poly1305-glue.c @@ -160,13 +160,22 @@ void poly1305_update_arch(struct poly1305_desc_ctx *dctx, const u8 *src, unsigned int len = round_down(nbytes, POLY1305_BLOCK_SIZE); if (static_branch_likely(&have_neon) && do_neon) { - kernel_neon_begin(); - poly1305_blocks_neon(&dctx->h, src, len, 1); - kernel_neon_end(); + for (;;) { + unsigned int todo = min_t(unsigned int, PAGE_SIZE, len); + + kernel_neon_begin(); + poly1305_blocks_neon(&dctx->h, src, todo, 1); + kernel_neon_end(); + + len -= todo; + if (!len) + break; + src += todo; + } } else { poly1305_blocks_arm(&dctx->h, src, len, 1); + src += len; } - src += len; nbytes %= POLY1305_BLOCK_SIZE; } diff --git a/arch/arm64/crypto/chacha-neon-glue.c b/arch/arm64/crypto/chacha-neon-glue.c index 37ca3e889848..3eff767f4f77 100644 --- a/arch/arm64/crypto/chacha-neon-glue.c +++ b/arch/arm64/crypto/chacha-neon-glue.c @@ -87,9 +87,19 @@ void chacha_crypt_arch(u32 *state, u8 *dst, const u8 *src, unsigned int bytes, !crypto_simd_usable()) return chacha_crypt_generic(state, dst, src, bytes, nrounds); - kernel_neon_begin(); - chacha_doneon(state, dst, src, bytes, nrounds); - kernel_neon_end(); + for (;;) { + unsigned int todo = min_t(unsigned int, PAGE_SIZE, bytes); + + kernel_neon_begin(); + chacha_doneon(state, dst, src, todo, nrounds); + kernel_neon_end(); + + bytes -= todo; + if (!bytes) + break; + src += todo; + dst += todo; + } } EXPORT_SYMBOL(chacha_crypt_arch); diff --git a/arch/arm64/crypto/poly1305-glue.c b/arch/arm64/crypto/poly1305-glue.c index e97b092f56b8..616134bef02c 100644 --- a/arch/arm64/crypto/poly1305-glue.c +++ b/arch/arm64/crypto/poly1305-glue.c @@ -143,13 +143,22 @@ void poly1305_update_arch(struct poly1305_desc_ctx *dctx, const u8 *src, unsigned int len = round_down(nbytes, POLY1305_BLOCK_SIZE); if (static_branch_likely(&have_neon) && crypto_simd_usable()) { - kernel_neon_begin(); - poly1305_blocks_neon(&dctx->h, src, len, 1); - kernel_neon_end(); + for (;;) { + unsigned int todo = min_t(unsigned int, PAGE_SIZE, len); + + kernel_neon_begin(); + poly1305_blocks_neon(&dctx->h, src, todo, 1); + kernel_neon_end(); + + len -= todo; + if (!len) + break; + src += todo; + } } else { poly1305_blocks(&dctx->h, src, len, 1); + src += len; } - src += len; nbytes %= POLY1305_BLOCK_SIZE; } diff --git a/arch/x86/crypto/chacha_glue.c b/arch/x86/crypto/chacha_glue.c index b412c21ee06e..10733035b81c 100644 --- a/arch/x86/crypto/chacha_glue.c +++ b/arch/x86/crypto/chacha_glue.c @@ -153,9 +153,19 @@ void chacha_crypt_arch(u32 *state, u8 *dst, const u8 *src, unsigned int bytes, bytes <= CHACHA_BLOCK_SIZE) return chacha_crypt_generic(state, dst, src, bytes, nrounds); - kernel_fpu_begin(); - chacha_dosimd(state, dst, src, bytes, nrounds); - kernel_fpu_end(); + for (;;) { + unsigned int todo = min_t(unsigned int, PAGE_SIZE, bytes); + + kernel_fpu_begin(); + chacha_dosimd(state, dst, src, todo, nrounds); + kernel_fpu_end(); + + bytes -= todo; + if (!bytes) + break; + src += todo; + dst += todo; + } } EXPORT_SYMBOL(chacha_crypt_arch); -- 2.26.1

5 years, 8 months

5
16
0 0

[PATCH] padata: add separate cpuhp node for CPUHP_PADATA_DEAD

by Daniel Jordan

Removing the pcrypt module triggers this: general protection fault, probably for non-canonical address 0xdead000000000122 CPU: 5 PID: 264 Comm: modprobe Not tainted 5.6.0+ #2 Hardware name: QEMU Standard PC RIP: 0010:__cpuhp_state_remove_instance+0xcc/0x120 Call Trace: padata_sysfs_release+0x74/0xce kobject_put+0x81/0xd0 padata_free+0x12/0x20 pcrypt_exit+0x43/0x8ee [pcrypt] padata instances wrongly use the same hlist node for the online and dead states, so __padata_free()'s second cpuhp remove call chokes on the node that the first poisoned. cpuhp multi-instance callbacks only walk forward in cpuhp_step->list and the same node is linked in both the online and dead lists, so the list corruption that results from padata_alloc() adding the node to a second list without removing it from the first doesn't cause problems as long as no instances are freed. Avoid the issue by giving each state its own node. Fixes: 894c9ef9780c ("padata: validate cpumask without removed CPU during offline") Signed-off-by: Daniel Jordan <daniel.m.jordan(a)oracle.com> Cc: Herbert Xu <herbert(a)gondor.apana.org.au> Cc: Steffen Klassert <steffen.klassert(a)secunet.com> Cc: linux-crypto(a)vger.kernel.org Cc: linux-kernel(a)vger.kernel.org Cc: stable(a)vger.kernel.org # v5.4+ --- include/linux/padata.h | 6 ++++-- kernel/padata.c | 14 ++++++++------ 2 files changed, 12 insertions(+), 8 deletions(-) diff --git a/include/linux/padata.h b/include/linux/padata.h index a0d8b41850b2..693cae9bfe66 100644 --- a/include/linux/padata.h +++ b/include/linux/padata.h @@ -139,7 +139,8 @@ struct padata_shell { /** * struct padata_instance - The overall control structure. * - * @node: Used by CPU hotplug. + * @cpu_online_node: Linkage for CPU online callback. + * @cpu_dead_node: Linkage for CPU offline callback. * @parallel_wq: The workqueue used for parallel work. * @serial_wq: The workqueue used for serial work. * @pslist: List of padata_shell objects attached to this instance. @@ -150,7 +151,8 @@ struct padata_shell { * @flags: padata flags. */ struct padata_instance { - struct hlist_node node; + struct hlist_node cpu_online_node; + struct hlist_node cpu_dead_node; struct workqueue_struct *parallel_wq; struct workqueue_struct *serial_wq; struct list_head pslist; diff --git a/kernel/padata.c b/kernel/padata.c index a6afa12fb75e..aae789896616 100644 --- a/kernel/padata.c +++ b/kernel/padata.c @@ -703,7 +703,7 @@ static int padata_cpu_online(unsigned int cpu, struct hlist_node *node) struct padata_instance *pinst; int ret; - pinst = hlist_entry_safe(node, struct padata_instance, node); + pinst = hlist_entry_safe(node, struct padata_instance, cpu_online_node); if (!pinst_has_cpu(pinst, cpu)) return 0; @@ -718,7 +718,7 @@ static int padata_cpu_dead(unsigned int cpu, struct hlist_node *node) struct padata_instance *pinst; int ret; - pinst = hlist_entry_safe(node, struct padata_instance, node); + pinst = hlist_entry_safe(node, struct padata_instance, cpu_dead_node); if (!pinst_has_cpu(pinst, cpu)) return 0; @@ -734,8 +734,9 @@ static enum cpuhp_state hp_online; static void __padata_free(struct padata_instance *pinst) { #ifdef CONFIG_HOTPLUG_CPU - cpuhp_state_remove_instance_nocalls(CPUHP_PADATA_DEAD, &pinst->node); - cpuhp_state_remove_instance_nocalls(hp_online, &pinst->node); + cpuhp_state_remove_instance_nocalls(CPUHP_PADATA_DEAD, + &pinst->cpu_dead_node); + cpuhp_state_remove_instance_nocalls(hp_online, &pinst->cpu_online_node); #endif WARN_ON(!list_empty(&pinst->pslist)); @@ -939,9 +940,10 @@ static struct padata_instance *padata_alloc(const char *name, mutex_init(&pinst->lock); #ifdef CONFIG_HOTPLUG_CPU - cpuhp_state_add_instance_nocalls_cpuslocked(hp_online, &pinst->node); + cpuhp_state_add_instance_nocalls_cpuslocked(hp_online, + &pinst->cpu_online_node); cpuhp_state_add_instance_nocalls_cpuslocked(CPUHP_PADATA_DEAD, - &pinst->node); + &pinst->cpu_dead_node); #endif put_online_cpus(); base-commit: ae83d0b416db002fe95601e7f97f64b59514d936 -- 2.26.0

5 years, 8 months

3
3
0 0

stable-rc/linux-4.14.y boot: 133 boots: 3 failed, 118 passed with 6 offline, 5 untried/unknown, 1 conflict (v4.14.177)

by kernelci.org bot

stable-rc/linux-4.14.y boot: 133 boots: 3 failed, 118 passed with 6 offline, 5 untried/unknown, 1 conflict (v4.14.177) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-4.14.y/kernel/v4.1… Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-4.14.y/kernel/v4.14.177/ Tree: stable-rc Branch: linux-4.14.y Git Describe: v4.14.177 Git Commit: 050272a0423e68207fd2367831ae610680129062 Git URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Tested: 75 unique boards, 20 SoC families, 18 builds out of 201 Boot Regressions Detected: arm: davinci_all_defconfig: gcc-8: da850-evm: lab-baylibre-seattle: new failure (last pass: v4.14.176-199-ga7097ef0ff82) dm365evm,legacy: lab-baylibre-seattle: new failure (last pass: v4.14.176-199-ga7097ef0ff82) qcom_defconfig: gcc-8: qcom-apq8064-cm-qs600: lab-baylibre-seattle: failing since 77 days (last pass: v4.14.169-92-gb4137330c582 - first fail: v4.14.170-62-gd6856e4a2c23) sama5_defconfig: gcc-8: at91-sama5d4_xplained: lab-baylibre: failing since 65 days (last pass: v4.14.170-141-g00a0113414f7 - first fail: v4.14.171-29-g9cfe30e85240) Boot Failures Detected: arm64: defconfig: gcc-8: meson-gxbb-p200: 1 failed lab meson-gxm-q200: 1 failed lab arm: sama5_defconfig: gcc-8: at91-sama5d4_xplained: 1 failed lab Offline Platforms: arm: multi_v7_defconfig: gcc-8 exynos5800-peach-pi: 1 offline lab qcom-apq8064-cm-qs600: 1 offline lab qcom_defconfig: gcc-8 qcom-apq8064-cm-qs600: 1 offline lab davinci_all_defconfig: gcc-8 da850-evm: 1 offline lab dm365evm,legacy: 1 offline lab exynos_defconfig: gcc-8 exynos5800-peach-pi: 1 offline lab Conflicting Boot Failure Detected: (These likely are not failures as other labs are reporting PASS. Needs review.) x86_64: x86_64_defconfig: qemu_x86_64: lab-baylibre: PASS (gcc-8) lab-collabora: FAIL (gcc-8) --- For more info write to <info(a)kernelci.org>

5 years, 8 months

1
0
0 0

stable-rc/linux-4.9.y boot: 115 boots: 1 failed, 102 passed with 5 offline, 5 untried/unknown, 2 conflicts (v4.9.220)

by kernelci.org bot

stable-rc/linux-4.9.y boot: 115 boots: 1 failed, 102 passed with 5 offline, 5 untried/unknown, 2 conflicts (v4.9.220) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-4.9.y/kernel/v4.9.… Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-4.9.y/kernel/v4.9.220/ Tree: stable-rc Branch: linux-4.9.y Git Describe: v4.9.220 Git Commit: 0661b3d6cfd774e28a2e2ba90a3d87479e5c399b Git URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Tested: 61 unique boards, 20 SoC families, 19 builds out of 197 Boot Regressions Detected: arm: davinci_all_defconfig: gcc-8: da850-evm: lab-baylibre-seattle: new failure (last pass: v4.9.219-125-g01b8cf611034) dm365evm,legacy: lab-baylibre-seattle: new failure (last pass: v4.9.219-125-g01b8cf611034) qcom_defconfig: gcc-8: qcom-apq8064-cm-qs600: lab-baylibre-seattle: failing since 77 days (last pass: v4.9.213 - first fail: v4.9.213-37-g860ec95da9ad) sunxi_defconfig: gcc-8: sun4i-a10-olinuxino-lime: lab-baylibre: new failure (last pass: v4.9.219-84-gd7b7a33b0609) Boot Failure Detected: arm: sama5_defconfig: gcc-8: at91-sama5d4_xplained: 1 failed lab Offline Platforms: arm: multi_v7_defconfig: gcc-8 qcom-apq8064-cm-qs600: 1 offline lab qcom_defconfig: gcc-8 qcom-apq8064-cm-qs600: 1 offline lab davinci_all_defconfig: gcc-8 da850-evm: 1 offline lab dm365evm,legacy: 1 offline lab exynos_defconfig: gcc-8 exynos5800-peach-pi: 1 offline lab Conflicting Boot Failures Detected: (These likely are not failures as other labs are reporting PASS. Needs review.) i386: i386_defconfig: qemu_i386: lab-baylibre: FAIL (gcc-8) lab-collabora: PASS (gcc-8) x86_64: x86_64_defconfig: qemu_x86_64: lab-baylibre: FAIL (gcc-8) lab-collabora: PASS (gcc-8) --- For more info write to <info(a)kernelci.org>

5 years, 8 months

1
0
0 0

stable-rc/linux-4.4.y boot: 96 boots: 3 failed, 83 passed with 6 offline, 4 untried/unknown (v4.4.220)

by kernelci.org bot

stable-rc/linux-4.4.y boot: 96 boots: 3 failed, 83 passed with 6 offline, 4 untried/unknown (v4.4.220) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-4.4.y/kernel/v4.4.… Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-4.4.y/kernel/v4.4.220/ Tree: stable-rc Branch: linux-4.4.y Git Describe: v4.4.220 Git Commit: 5efe91c00c98c72cbe8475caa6e72c520199e32b Git URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Tested: 50 unique boards, 18 SoC families, 17 builds out of 190 Boot Regressions Detected: arm: davinci_all_defconfig: gcc-8: da850-evm: lab-baylibre-seattle: failing since 2 days (last pass: v4.4.219-83-g20fbd20eb91a - first fail: v4.4.219-101-gacb152478366) dm365evm,legacy: lab-baylibre-seattle: failing since 2 days (last pass: v4.4.219-83-g20fbd20eb91a - first fail: v4.4.219-101-gacb152478366) qcom_defconfig: gcc-8: qcom-apq8064-cm-qs600: lab-baylibre-seattle: failing since 77 days (last pass: v4.4.212-56-g758a39807529 - first fail: v4.4.213-28-ga3b43e6eae91) sama5_defconfig: gcc-8: at91-sama5d4_xplained: lab-baylibre: failing since 30 days (last pass: v4.4.216-127-g955137020949 - first fail: v4.4.217) x86_64: x86_64_defconfig: gcc-8: qemu_x86_64: lab-baylibre: new failure (last pass: v4.4.219-101-gacb152478366) Boot Failures Detected: arm: sama5_defconfig: gcc-8: at91-sama5d4_xplained: 1 failed lab multi_v5_defconfig: gcc-8: imx27-phytec-phycard-s-rdk: 1 failed lab imx_v4_v5_defconfig: gcc-8: imx27-phytec-phycard-s-rdk: 1 failed lab Offline Platforms: arm: multi_v7_defconfig: gcc-8 exynos5800-peach-pi: 1 offline lab qcom-apq8064-cm-qs600: 1 offline lab qcom_defconfig: gcc-8 qcom-apq8064-cm-qs600: 1 offline lab davinci_all_defconfig: gcc-8 da850-evm: 1 offline lab dm365evm,legacy: 1 offline lab exynos_defconfig: gcc-8 exynos5800-peach-pi: 1 offline lab --- For more info write to <info(a)kernelci.org>

5 years, 8 months

1
0
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror