- Linux-stable-mirror - lists.linaro.org

[PATCH for 4.4.y] xen-netfront: Fix mismatched rtnl_unlock

by Nobuhiro Iwamatsu

From: Ross Lagerwall <ross.lagerwall(a)citrix.com> commit cb257783c2927b73614b20f915a91ff78aa6f3e8 upstream. Fixes: f599c64fdf7d ("xen-netfront: Fix race between device setup and open") Reported-by: Ben Hutchings <ben.hutchings(a)codethink.co.uk> Signed-off-by: Ross Lagerwall <ross.lagerwall(a)citrix.com> Reviewed-by: Juergen Gross <jgross(a)suse.com> Signed-off-by: David S. Miller <davem(a)davemloft.net> Signed-off-by: Nobuhiro Iwamatsu (CIP) <nobuhiro1.iwamatsu(a)toshiba.co.jp> --- drivers/net/xen-netfront.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c index 89eec6fead753..744b111cff6a3 100644 --- a/drivers/net/xen-netfront.c +++ b/drivers/net/xen-netfront.c @@ -1835,7 +1835,7 @@ static int talk_to_netback(struct xenbus_device *dev, err = xen_net_read_mac(dev, info->netdev->dev_addr); if (err) { xenbus_dev_fatal(dev, err, "parsing %s/mac", dev->nodename); - goto out; + goto out_unlocked; } rtnl_lock(); @@ -1950,6 +1950,7 @@ abort_transaction_no_dev_fatal: xennet_destroy_queues(info); out: rtnl_unlock(); +out_unlocked: device_unregister(&dev->dev); return err; } -- 2.26.0

5 years, 8 months

1
0
0 0

+ ocfs2-no-need-try-to-truncate-file-beyond-i_size.patch added to -mm tree

by Andrew Morton

The patch titled Subject: ocfs2: no need try to truncate file beyond i_size has been added to the -mm tree. Its filename is ocfs2-no-need-try-to-truncate-file-beyond-i_size.patch This patch should soon appear at http://ozlabs.org/~akpm/mmots/broken-out/ocfs2-no-need-try-to-truncate-file… and later at http://ozlabs.org/~akpm/mmotm/broken-out/ocfs2-no-need-try-to-truncate-file… Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Changwei Ge <chge(a)linux.alibaba.com> Subject: ocfs2: no need try to truncate file beyond i_size Linux fallocate(2) with FALLOC_FL_PUNCH_HOLE mode set, its offset can exceed inode size. Ocfs2 now does't allow that offset beyond inode size. This restriction is not necessary and voilates fallocate(2) semantics. If fallocate(2) offset is beyond inode size, just return success and do nothing further. Otherwise, ocfs2 will crash the kernel. kernel BUG at fs/ocfs2//alloc.c:7264! ocfs2_truncate_inline+0x20f/0x360 [ocfs2] ? ocfs2_read_blocks+0x2f3/0x5f0 [ocfs2] ocfs2_remove_inode_range+0x23c/0xcb0 [ocfs2] ? ocfs2_read_inode_block+0x10/0x20 [ocfs2] ? ocfs2_allocate_extend_trans+0x1a0/0x1a0 [ocfs2] __ocfs2_change_file_space+0x4a5/0x650 [ocfs2] ocfs2_fallocate+0x83/0xa0 [ocfs2] ? __audit_syscall_entry+0xb8/0x100 ? __sb_start_write+0x3b/0x70 vfs_fallocate+0x148/0x230 SyS_fallocate+0x48/0x80 do_syscall_64+0x79/0x170 Link: http://lkml.kernel.org/r/20200407082754.17565-1-chge@linux.alibaba.com Signed-off-by: Changwei Ge <chge(a)linux.alibaba.com> Reviewed-by: Joseph Qi <joseph.qi(a)linux.alibaba.com> Cc: Mark Fasheh <mark(a)fasheh.com> Cc: Joel Becker <jlbec(a)evilplan.org> Cc: Junxiao Bi <junxiao.bi(a)oracle.com> Cc: Changwei Ge <gechangwei(a)live.cn> Cc: Gang He <ghe(a)suse.com> Cc: Jun Piao <piaojun(a)huawei.com> Cc: <stable(a)vger.kernel.org> Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> --- fs/ocfs2/alloc.c | 4 ++++ 1 file changed, 4 insertions(+) --- a/fs/ocfs2/alloc.c~ocfs2-no-need-try-to-truncate-file-beyond-i_size +++ a/fs/ocfs2/alloc.c @@ -7402,6 +7402,10 @@ int ocfs2_truncate_inline(struct inode * struct ocfs2_dinode *di = (struct ocfs2_dinode *)di_bh->b_data; struct ocfs2_inline_data *idata = &di->id2.i_data; + /* No need to punch hole beyond i_size. */ + if (start >= i_size_read(inode)) + return 0; + if (end > i_size_read(inode)) end = i_size_read(inode); _ Patches currently in -mm which might be from chge(a)linux.alibaba.com are ocfs2-no-need-try-to-truncate-file-beyond-i_size.patch

5 years, 8 months

1
0
0 0

[nacked] list-prevent-compiler-reloads-inside-safe-list-iteration.patch removed from -mm tree

by Andrew Morton

The patch titled Subject: lib/list: prevent compiler reloads inside 'safe' list iteration has been removed from the -mm tree. Its filename was list-prevent-compiler-reloads-inside-safe-list-iteration.patch This patch was dropped because it was nacked ------------------------------------------------------ From: Chris Wilson <chris(a)chris-wilson.co.uk> Subject: lib/list: prevent compiler reloads inside 'safe' list iteration Instruct the compiler to read the next element in the list iteration once, and that it is not allowed to reload the value from the stale element later. This is important as during the course of the safe iteration, the stale element may be poisoned (unbeknownst to the compiler). This helps prevent kcsan warnings over 'unsafe' conduct in releasing the list elements during list_for_each_entry_safe() and friends. Link: http://lkml.kernel.org/r/20200310092119.14965-1-chris@chris-wilson.co.uk Signed-off-by: Chris Wilson <chris(a)chris-wilson.co.uk> Reviewed-by: Paul E. McKenney <paulmck(a)kernel.org> Cc: Randy Dunlap <rdunlap(a)infradead.org> Cc: David Laight <David.Laight(a)ACULAB.COM> Cc: Mark Rutland <mark.rutland(a)arm.com> Cc: Marco Elver <elver(a)google.com> Cc: <stable(a)vger.kernel.org> Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> --- include/linux/list.h | 50 +++++++++++++++++++++++++++++------------ 1 file changed, 36 insertions(+), 14 deletions(-) --- a/include/linux/list.h~list-prevent-compiler-reloads-inside-safe-list-iteration +++ a/include/linux/list.h @@ -537,6 +537,17 @@ static inline void list_splice_tail_init list_entry((pos)->member.next, typeof(*(pos)), member) /** + * list_next_entry_safe - get the next element in list [once] + * @pos: the type * to cursor + * @member: the name of the list_head within the struct. + * + * Like list_next_entry() but prevents the compiler from reloading the + * next element. + */ +#define list_next_entry_safe(pos, member) \ + list_entry(READ_ONCE((pos)->member.next), typeof(*(pos)), member) + +/** * list_prev_entry - get the prev element in list * @pos: the type * to cursor * @member: the name of the list_head within the struct. @@ -545,6 +556,17 @@ static inline void list_splice_tail_init list_entry((pos)->member.prev, typeof(*(pos)), member) /** + * list_prev_entry_safe - get the prev element in list [once] + * @pos: the type * to cursor + * @member: the name of the list_head within the struct. + * + * Like list_prev_entry() but prevents the compiler from reloading the + * previous element. + */ +#define list_prev_entry_safe(pos, member) \ + list_entry(READ_ONCE((pos)->member.prev), typeof(*(pos)), member) + +/** * list_for_each - iterate over a list * @pos: the &struct list_head to use as a loop cursor. * @head: the head for your list. @@ -686,9 +708,9 @@ static inline void list_splice_tail_init */ #define list_for_each_entry_safe(pos, n, head, member) \ for (pos = list_first_entry(head, typeof(*pos), member), \ - n = list_next_entry(pos, member); \ + n = list_next_entry_safe(pos, member); \ &pos->member != (head); \ - pos = n, n = list_next_entry(n, member)) + pos = n, n = list_next_entry_safe(n, member)) /** * list_for_each_entry_safe_continue - continue list iteration safe against removal @@ -700,11 +722,11 @@ static inline void list_splice_tail_init * Iterate over list of given type, continuing after current point, * safe against removal of list entry. */ -#define list_for_each_entry_safe_continue(pos, n, head, member) \ - for (pos = list_next_entry(pos, member), \ - n = list_next_entry(pos, member); \ - &pos->member != (head); \ - pos = n, n = list_next_entry(n, member)) +#define list_for_each_entry_safe_continue(pos, n, head, member) \ + for (pos = list_next_entry(pos, member), \ + n = list_next_entry_safe(pos, member); \ + &pos->member != (head); \ + pos = n, n = list_next_entry_safe(n, member)) /** * list_for_each_entry_safe_from - iterate over list from current point safe against removal @@ -716,10 +738,10 @@ static inline void list_splice_tail_init * Iterate over list of given type from current point, safe against * removal of list entry. */ -#define list_for_each_entry_safe_from(pos, n, head, member) \ - for (n = list_next_entry(pos, member); \ - &pos->member != (head); \ - pos = n, n = list_next_entry(n, member)) +#define list_for_each_entry_safe_from(pos, n, head, member) \ + for (n = list_next_entry_safe(pos, member); \ + &pos->member != (head); \ + pos = n, n = list_next_entry_safe(n, member)) /** * list_for_each_entry_safe_reverse - iterate backwards over list safe against removal @@ -733,9 +755,9 @@ static inline void list_splice_tail_init */ #define list_for_each_entry_safe_reverse(pos, n, head, member) \ for (pos = list_last_entry(head, typeof(*pos), member), \ - n = list_prev_entry(pos, member); \ + n = list_prev_entry_safe(pos, member); \ &pos->member != (head); \ - pos = n, n = list_prev_entry(n, member)) + pos = n, n = list_prev_entry_safe(n, member)) /** * list_safe_reset_next - reset a stale list_for_each_entry_safe loop @@ -750,7 +772,7 @@ static inline void list_splice_tail_init * completing the current iteration of the loop body. */ #define list_safe_reset_next(pos, n, member) \ - n = list_next_entry(pos, member) + n = list_next_entry_safe(pos, member) /* * Double linked lists with a single pointer list head. _ Patches currently in -mm which might be from chris(a)chris-wilson.co.uk are

5 years, 8 months

1
0
0 0

[patch 125/166] lib/list: prevent compiler reloads inside 'safe' list iteration

by Andrew Morton

From: Chris Wilson <chris(a)chris-wilson.co.uk> Subject: lib/list: prevent compiler reloads inside 'safe' list iteration Instruct the compiler to read the next element in the list iteration once, and that it is not allowed to reload the value from the stale element later. This is important as during the course of the safe iteration, the stale element may be poisoned (unbeknownst to the compiler). This helps prevent kcsan warnings over 'unsafe' conduct in releasing the list elements during list_for_each_entry_safe() and friends. Link: http://lkml.kernel.org/r/20200310092119.14965-1-chris@chris-wilson.co.uk Signed-off-by: Chris Wilson <chris(a)chris-wilson.co.uk> Reviewed-by: Paul E. McKenney <paulmck(a)kernel.org> Cc: Randy Dunlap <rdunlap(a)infradead.org> Cc: David Laight <David.Laight(a)ACULAB.COM> Cc: Mark Rutland <mark.rutland(a)arm.com> Cc: Marco Elver <elver(a)google.com> Cc: <stable(a)vger.kernel.org> Signed-off-by: Andrew Morton <akpm(a)linux-foundation.org> --- include/linux/list.h | 50 +++++++++++++++++++++++++++++------------ 1 file changed, 36 insertions(+), 14 deletions(-) --- a/include/linux/list.h~list-prevent-compiler-reloads-inside-safe-list-iteration +++ a/include/linux/list.h @@ -537,6 +537,17 @@ static inline void list_splice_tail_init list_entry((pos)->member.next, typeof(*(pos)), member) /** + * list_next_entry_safe - get the next element in list [once] + * @pos: the type * to cursor + * @member: the name of the list_head within the struct. + * + * Like list_next_entry() but prevents the compiler from reloading the + * next element. + */ +#define list_next_entry_safe(pos, member) \ + list_entry(READ_ONCE((pos)->member.next), typeof(*(pos)), member) + +/** * list_prev_entry - get the prev element in list * @pos: the type * to cursor * @member: the name of the list_head within the struct. @@ -545,6 +556,17 @@ static inline void list_splice_tail_init list_entry((pos)->member.prev, typeof(*(pos)), member) /** + * list_prev_entry_safe - get the prev element in list [once] + * @pos: the type * to cursor + * @member: the name of the list_head within the struct. + * + * Like list_prev_entry() but prevents the compiler from reloading the + * previous element. + */ +#define list_prev_entry_safe(pos, member) \ + list_entry(READ_ONCE((pos)->member.prev), typeof(*(pos)), member) + +/** * list_for_each - iterate over a list * @pos: the &struct list_head to use as a loop cursor. * @head: the head for your list. @@ -686,9 +708,9 @@ static inline void list_splice_tail_init */ #define list_for_each_entry_safe(pos, n, head, member) \ for (pos = list_first_entry(head, typeof(*pos), member), \ - n = list_next_entry(pos, member); \ + n = list_next_entry_safe(pos, member); \ &pos->member != (head); \ - pos = n, n = list_next_entry(n, member)) + pos = n, n = list_next_entry_safe(n, member)) /** * list_for_each_entry_safe_continue - continue list iteration safe against removal @@ -700,11 +722,11 @@ static inline void list_splice_tail_init * Iterate over list of given type, continuing after current point, * safe against removal of list entry. */ -#define list_for_each_entry_safe_continue(pos, n, head, member) \ - for (pos = list_next_entry(pos, member), \ - n = list_next_entry(pos, member); \ - &pos->member != (head); \ - pos = n, n = list_next_entry(n, member)) +#define list_for_each_entry_safe_continue(pos, n, head, member) \ + for (pos = list_next_entry(pos, member), \ + n = list_next_entry_safe(pos, member); \ + &pos->member != (head); \ + pos = n, n = list_next_entry_safe(n, member)) /** * list_for_each_entry_safe_from - iterate over list from current point safe against removal @@ -716,10 +738,10 @@ static inline void list_splice_tail_init * Iterate over list of given type from current point, safe against * removal of list entry. */ -#define list_for_each_entry_safe_from(pos, n, head, member) \ - for (n = list_next_entry(pos, member); \ - &pos->member != (head); \ - pos = n, n = list_next_entry(n, member)) +#define list_for_each_entry_safe_from(pos, n, head, member) \ + for (n = list_next_entry_safe(pos, member); \ + &pos->member != (head); \ + pos = n, n = list_next_entry_safe(n, member)) /** * list_for_each_entry_safe_reverse - iterate backwards over list safe against removal @@ -733,9 +755,9 @@ static inline void list_splice_tail_init */ #define list_for_each_entry_safe_reverse(pos, n, head, member) \ for (pos = list_last_entry(head, typeof(*pos), member), \ - n = list_prev_entry(pos, member); \ + n = list_prev_entry_safe(pos, member); \ &pos->member != (head); \ - pos = n, n = list_prev_entry(n, member)) + pos = n, n = list_prev_entry_safe(n, member)) /** * list_safe_reset_next - reset a stale list_for_each_entry_safe loop @@ -750,7 +772,7 @@ static inline void list_splice_tail_init * completing the current iteration of the loop body. */ #define list_safe_reset_next(pos, n, member) \ - n = list_next_entry(pos, member) + n = list_next_entry_safe(pos, member) /* * Double linked lists with a single pointer list head. _

5 years, 8 months

5
13
0 0

[PATCH] smack: avoid unused 'sip' variable warning

by Arnd Bergmann

The mix of IS_ENABLED() and #ifdef checks has left a combination that causes a warning about an unused variable: security/smack/smack_lsm.c: In function 'smack_socket_connect': security/smack/smack_lsm.c:2838:24: error: unused variable 'sip' [-Werror=unused-variable] 2838 | struct sockaddr_in6 *sip = (struct sockaddr_in6 *)sap; Change the code to use C-style checks consistently so the compiler can handle it correctly. Fixes: 87fbfffcc89b ("broken ping to ipv6 linklocal addresses on debian buster") Signed-off-by: Arnd Bergmann <arnd(a)arndb.de> --- There are lots of ways of addressing this, if you prefer a different way, please just treat this patch as a bug report and apply the replacement patch directly. --- security/smack/smack.h | 6 ------ security/smack/smack_lsm.c | 25 ++++++++----------------- 2 files changed, 8 insertions(+), 23 deletions(-) diff --git a/security/smack/smack.h b/security/smack/smack.h index 62529f382942..335d2411abe4 100644 --- a/security/smack/smack.h +++ b/security/smack/smack.h @@ -148,7 +148,6 @@ struct smk_net4addr { struct smack_known *smk_label; /* label */ }; -#if IS_ENABLED(CONFIG_IPV6) /* * An entry in the table identifying IPv6 hosts. */ @@ -159,9 +158,7 @@ struct smk_net6addr { int smk_masks; /* mask size */ struct smack_known *smk_label; /* label */ }; -#endif /* CONFIG_IPV6 */ -#ifdef SMACK_IPV6_PORT_LABELING /* * An entry in the table identifying ports. */ @@ -174,7 +171,6 @@ struct smk_port_label { short smk_sock_type; /* Socket type */ short smk_can_reuse; }; -#endif /* SMACK_IPV6_PORT_LABELING */ struct smack_known_list_elem { struct list_head list; @@ -335,9 +331,7 @@ extern struct smack_known smack_known_web; extern struct mutex smack_known_lock; extern struct list_head smack_known_list; extern struct list_head smk_net4addr_list; -#if IS_ENABLED(CONFIG_IPV6) extern struct list_head smk_net6addr_list; -#endif /* CONFIG_IPV6 */ extern struct mutex smack_onlycap_lock; extern struct list_head smack_onlycap_list; diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c index 8c61d175e195..e193b0db0271 100644 --- a/security/smack/smack_lsm.c +++ b/security/smack/smack_lsm.c @@ -50,10 +50,8 @@ #define SMK_RECEIVING 1 #define SMK_SENDING 2 -#ifdef SMACK_IPV6_PORT_LABELING -DEFINE_MUTEX(smack_ipv6_lock); +static DEFINE_MUTEX(smack_ipv6_lock); static LIST_HEAD(smk_ipv6_port_list); -#endif static struct kmem_cache *smack_inode_cache; struct kmem_cache *smack_rule_cache; int smack_enabled; @@ -2320,7 +2318,6 @@ static struct smack_known *smack_ipv4host_label(struct sockaddr_in *sip) return NULL; } -#if IS_ENABLED(CONFIG_IPV6) /* * smk_ipv6_localhost - Check for local ipv6 host address * @sip: the address @@ -2388,7 +2385,6 @@ static struct smack_known *smack_ipv6host_label(struct sockaddr_in6 *sip) return NULL; } -#endif /* CONFIG_IPV6 */ /** * smack_netlabel - Set the secattr on a socket @@ -2477,7 +2473,6 @@ static int smack_netlabel_send(struct sock *sk, struct sockaddr_in *sap) return smack_netlabel(sk, sk_lbl); } -#if IS_ENABLED(CONFIG_IPV6) /** * smk_ipv6_check - check Smack access * @subject: subject Smack label @@ -2510,7 +2505,6 @@ static int smk_ipv6_check(struct smack_known *subject, rc = smk_bu_note("IPv6 check", subject, object, MAY_WRITE, rc); return rc; } -#endif /* CONFIG_IPV6 */ #ifdef SMACK_IPV6_PORT_LABELING /** @@ -2599,6 +2593,7 @@ static void smk_ipv6_port_label(struct socket *sock, struct sockaddr *address) mutex_unlock(&smack_ipv6_lock); return; } +#endif /** * smk_ipv6_port_check - check Smack port access @@ -2661,7 +2656,6 @@ static int smk_ipv6_port_check(struct sock *sk, struct sockaddr_in6 *address, return smk_ipv6_check(skp, object, address, act); } -#endif /* SMACK_IPV6_PORT_LABELING */ /** * smack_inode_setsecurity - set smack xattrs @@ -2836,24 +2830,21 @@ static int smack_socket_connect(struct socket *sock, struct sockaddr *sap, return 0; if (IS_ENABLED(CONFIG_IPV6) && sap->sa_family == AF_INET6) { struct sockaddr_in6 *sip = (struct sockaddr_in6 *)sap; -#ifdef SMACK_IPV6_SECMARK_LABELING - struct smack_known *rsp; -#endif + struct smack_known *rsp = NULL; if (addrlen < SIN6_LEN_RFC2133) return 0; -#ifdef SMACK_IPV6_SECMARK_LABELING - rsp = smack_ipv6host_label(sip); + if (__is_defined(SMACK_IPV6_SECMARK_LABELING)) + rsp = smack_ipv6host_label(sip); if (rsp != NULL) { struct socket_smack *ssp = sock->sk->sk_security; rc = smk_ipv6_check(ssp->smk_out, rsp, sip, SMK_CONNECTING); } -#endif -#ifdef SMACK_IPV6_PORT_LABELING - rc = smk_ipv6_port_check(sock->sk, sip, SMK_CONNECTING); -#endif + if (__is_defined(SMACK_IPV6_PORT_LABELING)) + rc = smk_ipv6_port_check(sock->sk, sip, SMK_CONNECTING); + return rc; } if (sap->sa_family != AF_INET || addrlen < sizeof(struct sockaddr_in)) -- 2.26.0

5 years, 8 months

2
1
0 0

[PATCH] drm: avoid spurious EBUSY due to nonblocking atomic modesets

by Daniel Vetter

When doing an atomic modeset with ALLOW_MODESET drivers are allowed to pull in arbitrary other resources, including CRTCs (e.g. when reconfiguring global resources). But in nonblocking mode userspace has then no idea this happened, which can lead to spurious EBUSY calls, both: - when that other CRTC is currently busy doing a page_flip the ALLOW_MODESET commit can fail with an EBUSY - on the other CRTC a normal atomic flip can fail with EBUSY because of the additional commit inserted by the kernel without userspace's knowledge For blocking commits this isn't a problem, because everyone else will just block until all the CRTC are reconfigured. Only thing userspace can notice is the dropped frames without any reason for why frames got dropped. Consensus is that we need new uapi to handle this properly, but no one has any idea what exactly the new uapi should look like. As a stop-gap plug this problem by demoting nonblocking commits which might cause issues by including CRTCs not in the original request to blocking commits. v2: Add comments and a WARN_ON to enforce this only when allowed - we don't want to silently convert page flips into blocking plane updates just because the driver is buggy. v3: Fix inverted WARN_ON (Pekka). References: https://lists.freedesktop.org/archives/dri-devel/2018-July/182281.html Bugzilla: https://gitlab.freedesktop.org/wayland/weston/issues/24#note_9568 Cc: Daniel Stone <daniel(a)fooishbar.org> Cc: Pekka Paalanen <pekka.paalanen(a)collabora.co.uk> Cc: stable(a)vger.kernel.org Reviewed-by: Daniel Stone <daniels(a)collabora.com> Signed-off-by: Daniel Vetter <daniel.vetter(a)intel.com> --- drivers/gpu/drm/drm_atomic.c | 34 +++++++++++++++++++++++++++++++--- 1 file changed, 31 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c index 9ccfbf213d72..4c035abf98b8 100644 --- a/drivers/gpu/drm/drm_atomic.c +++ b/drivers/gpu/drm/drm_atomic.c @@ -1362,15 +1362,43 @@ EXPORT_SYMBOL(drm_atomic_commit); int drm_atomic_nonblocking_commit(struct drm_atomic_state *state) { struct drm_mode_config *config = &state->dev->mode_config; - int ret; + unsigned requested_crtc = 0; + unsigned affected_crtc = 0; + struct drm_crtc *crtc; + struct drm_crtc_state *crtc_state; + bool nonblocking = true; + int ret, i; + + /* + * For commits that allow modesets drivers can add other CRTCs to the + * atomic commit, e.g. when they need to reallocate global resources. + * + * But when userspace also requests a nonblocking commit then userspace + * cannot know that the commit affects other CRTCs, which can result in + * spurious EBUSY failures. Until we have better uapi plug this by + * demoting such commits to blocking mode. + */ + for_each_new_crtc_in_state(state, crtc, crtc_state, i) + requested_crtc |= drm_crtc_mask(crtc); ret = drm_atomic_check_only(state); if (ret) return ret; - DRM_DEBUG_ATOMIC("committing %p nonblocking\n", state); + for_each_new_crtc_in_state(state, crtc, crtc_state, i) + affected_crtc |= drm_crtc_mask(crtc); + + if (affected_crtc != requested_crtc) { + /* adding other CRTC is only allowed for modeset commits */ + WARN_ON(!state->allow_modeset); + + DRM_DEBUG_ATOMIC("demoting %p to blocking mode to avoid EBUSY\n", state); + nonblocking = false; + } else { + DRM_DEBUG_ATOMIC("committing %p nonblocking\n", state); + } - return config->funcs->atomic_commit(state->dev, state, true); + return config->funcs->atomic_commit(state->dev, state, nonblocking); } EXPORT_SYMBOL(drm_atomic_nonblocking_commit); -- 2.24.1

5 years, 8 months

2
5
0 0

Linux 5.6.3

by Greg KH

I'm announcing the release of the 5.6.3 kernel. All users of the 5.6 kernel series must upgrade. The updated 5.6.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-5.6.y and can be browsed at the normal kernel.org git web browser: https://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary thanks, greg k-h ------------ Makefile | 2 drivers/extcon/extcon-axp288.c | 32 ++++++++ drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 4 - drivers/gpu/drm/i915/display/intel_display.c | 4 - drivers/md/dm.c | 5 - drivers/misc/cardreader/rts5227.c | 1 drivers/misc/mei/hw-me-regs.h | 2 drivers/misc/mei/pci-me.c | 2 drivers/misc/pci_endpoint_test.c | 14 ++- drivers/net/dsa/microchip/Kconfig | 1 drivers/net/ethernet/cadence/macb_main.c | 3 drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 2 drivers/nvmem/core.c | 1 drivers/nvmem/nvmem-sysfs.c | 6 + drivers/nvmem/sprd-efuse.c | 2 drivers/pci/pci-sysfs.c | 6 + drivers/power/supply/axp288_charger.c | 57 +++++++++++++++- drivers/soc/mediatek/mtk-cmdq-helper.c | 1 include/uapi/linux/coresight-stm.h | 6 + include/uapi/sound/asoc.h | 1 kernel/padata.c | 2 lib/test_xarray.c | 18 +++++ lib/xarray.c | 3 mm/mempolicy.c | 6 + net/core/skbuff.c | 1 net/ipv4/fib_trie.c | 3 net/ipv4/ip_tunnel.c | 6 - net/ipv4/udp_offload.c | 1 net/sctp/ipv6.c | 20 +++-- net/sctp/protocol.c | 28 +++++-- net/sctp/socket.c | 31 ++++++-- sound/pci/hda/patch_ca0132.c | 1 tools/perf/util/setup.py | 2 33 files changed, 225 insertions(+), 49 deletions(-) Alexander Usyskin (1): mei: me: add cedar fork device ids Arnaldo Carvalho de Melo (1): perf python: Fix clang detection to strip out options passed in $CC Bibby Hsieh (1): soc: mediatek: knows_txdone needs to be set in Mediatek CMDQ helper Codrin Ciubotariu (2): net: dsa: ksz: Select KSZ protocol tag net: macb: Fix handling of fixed-link node Daniel Jordan (1): padata: fix uninitialized return value in padata_replace() Eugene Syromiatnikov (1): coresight: do not use the BIT() macro in the UAPI header Florian Westphal (1): net: fix fraglist segmentation reference count leak Freeman Liu (1): nvmem: sprd: Fix the block lock operation Geoffrey Allott (1): ALSA: hda/ca0132 - Add Recon3Di quirk to handle integrated sound on EVGA X99 Classified motherboard Greg Kroah-Hartman (1): Linux 5.6.3 Guenter Roeck (1): brcmfmac: abort and release host after error Hans de Goede (2): extcon: axp288: Add wakeup support power: supply: axp288_charger: Add special handling for HP Pavilion x2 10 Kelsey Skunberg (1): PCI: sysfs: Revert "rescan" file renames Khouloud Touil (1): nvmem: release the write-protect pin Kishon Vijay Abraham I (2): misc: pci_endpoint_test: Fix to support > 10 pci-endpoint-test devices misc: pci_endpoint_test: Avoid using module parameter to determine irqtype Marcelo Ricardo Leitner (1): sctp: fix possibly using a bad saddr with a given dst Matthew Wilcox (Oracle) (1): XArray: Fix xa_find_next for large multi-index entries Mike Snitzer (1): Revert "dm: always call blk_queue_split() in dm_process_bio()" Nicholas Johnson (1): nvmem: check for NULL reg_read and reg_write before dereferencing Qian Cai (1): ipv4: fix a RCU-list lock in fib_triestat_seq_show Qiujun Huang (1): sctp: fix refcount bug in sctp_wfree Randy Dunlap (1): mm: mempolicy: require at least one nodeid for MPOL_PREFERRED Takashi Iwai (1): Revert "ALSA: uapi: Drop asound.h inclusion from asoc.h" Torsten Duwe (1): drm/bridge: analogix-anx6345: Avoid duplicate -supply suffix Uma Shankar (1): drm/i915/display: Fix mode private_flags comparison at atomic_check William Dauchy (1): net, ip_tunnel: fix interface lookup with no key Xin Long (1): udp: initialize is_flist with 0 in udp_gro_receive YueHaibing (1): misc: rtsx: set correct pcr_ops for rts522A

5 years, 8 months

1
1
0 0

Linux 5.5.16

by Greg KH

I'm announcing the release of the 5.5.16 kernel. All users of the 5.5 kernel series must upgrade. The updated 5.5.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-5.5.y and can be browsed at the normal kernel.org git web browser: https://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary thanks, greg k-h ------------ Makefile | 2 drivers/extcon/extcon-axp288.c | 32 +++++++ drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 2 drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 11 ++ drivers/gpu/drm/bochs/bochs_hw.c | 6 - drivers/i2c/busses/i2c-i801.c | 45 ++------- drivers/infiniband/hw/hfi1/user_sdma.c | 25 ++++- drivers/md/dm.c | 5 - drivers/misc/cardreader/rts5227.c | 1 drivers/misc/mei/hw-me-regs.h | 2 drivers/misc/mei/pci-me.c | 2 drivers/misc/pci_endpoint_test.c | 14 ++- drivers/net/dsa/microchip/Kconfig | 1 drivers/net/ethernet/cadence/macb_main.c | 3 drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls.h | 4 drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 2 drivers/net/wireless/intel/iwlwifi/fw/dbg.c | 25 +---- drivers/net/wireless/intel/iwlwifi/fw/dbg.h | 6 - drivers/net/wireless/intel/iwlwifi/mvm/rs-fw.c | 6 + drivers/nvme/host/rdma.c | 8 + drivers/nvmem/nvmem-sysfs.c | 6 + drivers/nvmem/sprd-efuse.c | 2 drivers/pci/pci-sysfs.c | 6 - drivers/power/supply/axp288_charger.c | 57 ++++++++++++ drivers/soc/mediatek/mtk-cmdq-helper.c | 1 drivers/staging/wfx/hif_tx.c | 1 drivers/watchdog/iTCO_vendor.h | 2 drivers/watchdog/iTCO_vendor_support.c | 16 +-- drivers/watchdog/iTCO_wdt.c | 28 +++--- include/uapi/linux/coresight-stm.h | 6 - kernel/padata.c | 6 - lib/test_xarray.c | 18 +++ lib/xarray.c | 3 mm/mempolicy.c | 6 + net/core/dev.c | 2 net/ipv4/fib_trie.c | 3 net/ipv4/ip_tunnel.c | 6 - net/ipv4/tcp_input.c | 6 + net/netlink/genetlink.c | 5 - net/rxrpc/sendmsg.c | 4 net/sched/act_api.c | 1 net/sctp/ipv6.c | 20 +++- net/sctp/protocol.c | 28 ++++-- net/sctp/socket.c | 31 +++++- net/smc/af_smc.c | 25 +++-- net/smc/smc_core.c | 12 ++ net/smc/smc_core.h | 2 sound/pci/hda/patch_ca0132.c | 1 tools/power/x86/turbostat/Makefile | 2 tools/power/x86/turbostat/turbostat.c | 73 ++++++++++------ usr/Kconfig | 22 ++-- 52 files changed, 420 insertions(+), 187 deletions(-) Alexander Usyskin (1): mei: me: add cedar fork device ids Amritha Nambiar (1): net: Fix Tx hash bound checking Bibby Hsieh (1): soc: mediatek: knows_txdone needs to be set in Mediatek CMDQ helper Codrin Ciubotariu (2): net: dsa: ksz: Select KSZ protocol tag net: macb: Fix handling of fixed-link node Daniel Jordan (2): padata: fix uninitialized return value in padata_replace() padata: always acquire cpu_hotplug_lock before pinst->lock David Howells (1): rxrpc: Fix sendmsg(MSG_WAITALL) handling Eugene Syromiatnikov (1): coresight: do not use the BIT() macro in the UAPI header Eugeniy Paltsev (1): initramfs: restore default compression behavior Evan Quan (1): drm/amdgpu: add fbdev suspend/resume on gpu reset Freeman Liu (1): nvmem: sprd: Fix the block lock operation Geoffrey Allott (1): ALSA: hda/ca0132 - Add Recon3Di quirk to handle integrated sound on EVGA X99 Classified motherboard Gerd Hoffmann (1): drm/bochs: downgrade pci_request_region failure from error to warning Greg Kroah-Hartman (1): Linux 5.5.16 Guenter Roeck (1): brcmfmac: abort and release host after error Hans de Goede (2): extcon: axp288: Add wakeup support power: supply: axp288_charger: Add special handling for HP Pavilion x2 10 James Zhu (1): drm/amdgpu: fix typo for vcn1 idle check Jiri Pirko (1): sched: act: count in the size of action flags bitfield Jérôme Pouiller (1): staging: wfx: fix warning about freeing in-use mutex during device unregister Kelsey Skunberg (1): PCI: sysfs: Revert "rescan" file renames Kishon Vijay Abraham I (2): misc: pci_endpoint_test: Fix to support > 10 pci-endpoint-test devices misc: pci_endpoint_test: Avoid using module parameter to determine irqtype Len Brown (3): tools/power turbostat: Fix gcc build warnings tools/power turbostat: Fix missing SYS_LPI counter on some Chromebooks tools/power turbostat: Fix 32-bit capabilities warning Luca Coelho (1): iwlwifi: dbg: don't abort if sending DBGC_SUSPEND_RESUME fails Marcelo Ricardo Leitner (1): sctp: fix possibly using a bad saddr with a given dst Mario Kleiner (1): drm/amd/display: Add link_rate quirk for Apple 15" MBP 2017 Matthew Wilcox (Oracle) (1): XArray: Fix xa_find_next for large multi-index entries Mika Westerberg (3): watchdog: iTCO_wdt: Export vendorsupport watchdog: iTCO_wdt: Make ICH_RES_IO_SMI optional i2c: i801: Do not add ICH_RES_IO_SMI for the iTCO_wdt device Mike Marciniszyn (1): IB/hfi1: Ensure pq is not left on waitlist Mike Snitzer (1): Revert "dm: always call blk_queue_split() in dm_process_bio()" Mordechay Goodstein (2): iwlwifi: consider HE capability when setting LDPC iwlwifi: yoyo: don't add TLV offset when reading FIFOs Neal Cardwell (1): tcp: fix TFO SYNACK undo to avoid double-timestamp-undo Nicholas Johnson (1): nvmem: check for NULL reg_read and reg_write before dereferencing Paolo Abeni (1): net: genetlink: return the error code when attribute parsing fails. Prabhath Sajeepa (1): nvme-rdma: Avoid double freeing of async event data Qian Cai (1): ipv4: fix a RCU-list lock in fib_triestat_seq_show Qiujun Huang (1): sctp: fix refcount bug in sctp_wfree Randy Dunlap (1): mm: mempolicy: require at least one nodeid for MPOL_PREFERRED Tariq Toukan (1): net/mlx5e: kTLS, Fix wrong value in record tracker enum Ursula Braun (1): net/smc: fix cleanup for linkgroup setup failures William Dauchy (1): net, ip_tunnel: fix interface lookup with no key YueHaibing (1): misc: rtsx: set correct pcr_ops for rts522A

5 years, 8 months

1
1
0 0

Linux 5.4.31

by Greg KH

I'm announcing the release of the 5.4.31 kernel. All users of the 5.4 kernel series must upgrade. The updated 5.4.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-5.4.y and can be browsed at the normal kernel.org git web browser: https://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary thanks, greg k-h ------------ Makefile | 2 drivers/extcon/extcon-axp288.c | 32 +++++ drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 2 drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 11 + drivers/gpu/drm/bochs/bochs_hw.c | 6 - drivers/i2c/busses/i2c-i801.c | 45 ++------ drivers/infiniband/hw/hfi1/user_sdma.c | 25 +++- drivers/md/dm.c | 5 drivers/misc/cardreader/rts5227.c | 1 drivers/misc/mei/hw-me-regs.h | 2 drivers/misc/mei/pci-me.c | 2 drivers/misc/pci_endpoint_test.c | 14 +- drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls.h | 4 drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_tx.c | 2 drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 2 drivers/net/wireless/intel/iwlwifi/fw/dbg.c | 25 +--- drivers/net/wireless/intel/iwlwifi/fw/dbg.h | 6 - drivers/net/wireless/intel/iwlwifi/mvm/rs-fw.c | 6 - drivers/nvme/host/rdma.c | 8 - drivers/nvmem/nvmem-sysfs.c | 6 + drivers/pci/pci-sysfs.c | 6 - drivers/power/supply/axp288_charger.c | 57 +++++++++- drivers/soc/mediatek/mtk-cmdq-helper.c | 1 drivers/watchdog/iTCO_vendor.h | 2 drivers/watchdog/iTCO_vendor_support.c | 16 +- drivers/watchdog/iTCO_wdt.c | 28 ++-- include/uapi/linux/coresight-stm.h | 6 - kernel/padata.c | 6 - lib/test_xarray.c | 18 +++ lib/xarray.c | 3 mm/mempolicy.c | 6 - net/core/dev.c | 2 net/ipv4/tcp_input.c | 6 - net/rxrpc/sendmsg.c | 4 scripts/Kconfig.include | 7 + sound/pci/hda/patch_ca0132.c | 1 tools/power/x86/turbostat/Makefile | 2 tools/power/x86/turbostat/turbostat.c | 73 ++++++++----- usr/Kconfig | 22 +-- 39 files changed, 326 insertions(+), 146 deletions(-) Alexander Usyskin (1): mei: me: add cedar fork device ids Amritha Nambiar (1): net: Fix Tx hash bound checking Bibby Hsieh (1): soc: mediatek: knows_txdone needs to be set in Mediatek CMDQ helper Daniel Jordan (2): padata: fix uninitialized return value in padata_replace() padata: always acquire cpu_hotplug_lock before pinst->lock David Howells (1): rxrpc: Fix sendmsg(MSG_WAITALL) handling Eugene Syromiatnikov (1): coresight: do not use the BIT() macro in the UAPI header Eugeniy Paltsev (1): initramfs: restore default compression behavior Geoffrey Allott (1): ALSA: hda/ca0132 - Add Recon3Di quirk to handle integrated sound on EVGA X99 Classified motherboard Gerd Hoffmann (1): drm/bochs: downgrade pci_request_region failure from error to warning Greg Kroah-Hartman (1): Linux 5.4.31 Guenter Roeck (1): brcmfmac: abort and release host after error Hans de Goede (2): extcon: axp288: Add wakeup support power: supply: axp288_charger: Add special handling for HP Pavilion x2 10 James Zhu (1): drm/amdgpu: fix typo for vcn1 idle check Kelsey Skunberg (1): PCI: sysfs: Revert "rescan" file renames Kishon Vijay Abraham I (2): misc: pci_endpoint_test: Fix to support > 10 pci-endpoint-test devices misc: pci_endpoint_test: Avoid using module parameter to determine irqtype Len Brown (3): tools/power turbostat: Fix gcc build warnings tools/power turbostat: Fix missing SYS_LPI counter on some Chromebooks tools/power turbostat: Fix 32-bit capabilities warning Luca Coelho (1): iwlwifi: dbg: don't abort if sending DBGC_SUSPEND_RESUME fails Mario Kleiner (1): drm/amd/display: Add link_rate quirk for Apple 15" MBP 2017 Masahiro Yamada (1): kconfig: introduce m32-flag and m64-flag Matthew Wilcox (Oracle) (1): XArray: Fix xa_find_next for large multi-index entries Mika Westerberg (3): watchdog: iTCO_wdt: Export vendorsupport watchdog: iTCO_wdt: Make ICH_RES_IO_SMI optional i2c: i801: Do not add ICH_RES_IO_SMI for the iTCO_wdt device Mike Marciniszyn (1): IB/hfi1: Ensure pq is not left on waitlist Mike Snitzer (1): Revert "dm: always call blk_queue_split() in dm_process_bio()" Mordechay Goodstein (2): iwlwifi: consider HE capability when setting LDPC iwlwifi: yoyo: don't add TLV offset when reading FIFOs Neal Cardwell (1): tcp: fix TFO SYNACK undo to avoid double-timestamp-undo Nicholas Johnson (1): nvmem: check for NULL reg_read and reg_write before dereferencing Prabhath Sajeepa (1): nvme-rdma: Avoid double freeing of async event data Randy Dunlap (1): mm: mempolicy: require at least one nodeid for MPOL_PREFERRED Tariq Toukan (2): net/mlx5e: kTLS, Fix TCP seq off-by-1 issue in TX resync flow net/mlx5e: kTLS, Fix wrong value in record tracker enum YueHaibing (1): misc: rtsx: set correct pcr_ops for rts522A

5 years, 8 months

1
1
0 0

stable/linux-5.6.y boot: 74 boots: 1 failed, 70 passed with 3 untried/unknown (v5.6.3)

by kernelci.org bot

stable/linux-5.6.y boot: 74 boots: 1 failed, 70 passed with 3 untried/unknown (v5.6.3) Full Boot Summary: https://kernelci.org/boot/all/job/stable/branch/linux-5.6.y/kernel/v5.6.3/ Full Build Summary: https://kernelci.org/build/stable/branch/linux-5.6.y/kernel/v5.6.3/ Tree: stable Branch: linux-5.6.y Git Describe: v5.6.3 Git Commit: f9fb85751506e75ecffaa498896efbb0c886adda Git URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git Tested: 55 unique boards, 14 SoC families, 16 builds out of 200 Boot Regressions Detected: arm: multi_v7_defconfig: gcc-8: am335x-boneblack: lab-baylibre: new failure (last pass: v5.6.2) Boot Failure Detected: arm: sama5_defconfig: gcc-8: at91-sama5d4_xplained: 1 failed lab --- For more info write to <info(a)kernelci.org>

5 years, 8 months

1
0
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror