- Linux-stable-mirror - lists.linaro.org

WTF: patch "[PATCH] net: wireless: ti: wl1251 use new SDIO_VENDOR_ID_TI_WL1251" was seriously submitted to be applied to the 5.4-stable tree?

by gregkh＠linuxfoundation.org

The patch below was submitted to be applied to the 5.4-stable tree. I fail to see how this patch meets the stable kernel rules as found at Documentation/process/stable-kernel-rules.rst. I could be totally wrong, and if so, please respond to <stable(a)vger.kernel.org> and let me know why this patch should be applied. Otherwise, it is now dropped from my patch queues, never to be seen again. thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From d8620bbc32541a30f84154007defad917f5179f0 Mon Sep 17 00:00:00 2001 From: "H. Nikolaus Schaller" <hns(a)goldelico.com> Date: Thu, 7 Nov 2019 11:30:44 +0100 Subject: [PATCH] net: wireless: ti: wl1251 use new SDIO_VENDOR_ID_TI_WL1251 definition SDIO_VENDOR_ID_TI_WL1251 is now defined in mmc/sdio_ids.h separately from SDIO_VENDOR_ID_TI for wl1271. Fixes: 884f38607897 ("mmc: core: move some sdio IDs out of quirks file") Signed-off-by: H. Nikolaus Schaller <hns(a)goldelico.com> Acked-by: Kalle Valo <kvalo(a)codeaurora.org> Cc: <stable(a)vger.kernel.org> # v4.11+ Signed-off-by: Ulf Hansson <ulf.hansson(a)linaro.org> diff --git a/drivers/net/wireless/ti/wl1251/sdio.c b/drivers/net/wireless/ti/wl1251/sdio.c index f1224b948f83..ac677309dab6 100644 --- a/drivers/net/wireless/ti/wl1251/sdio.c +++ b/drivers/net/wireless/ti/wl1251/sdio.c @@ -52,7 +52,7 @@ static void wl1251_sdio_interrupt(struct sdio_func *func) } static const struct sdio_device_id wl1251_devices[] = { - { SDIO_DEVICE(SDIO_VENDOR_ID_TI, SDIO_DEVICE_ID_TI_WL1251) }, + { SDIO_DEVICE(SDIO_VENDOR_ID_TI_WL1251, SDIO_DEVICE_ID_TI_WL1251) }, {} }; MODULE_DEVICE_TABLE(sdio, wl1251_devices);

5 years, 11 months

1
0
0 0

WTF: patch "[PATCH] Documentation: dt: wireless: update wl1251 for sdio" was seriously submitted to be applied to the 5.4-stable tree?

by gregkh＠linuxfoundation.org

The patch below was submitted to be applied to the 5.4-stable tree. I fail to see how this patch meets the stable kernel rules as found at Documentation/process/stable-kernel-rules.rst. I could be totally wrong, and if so, please respond to <stable(a)vger.kernel.org> and let me know why this patch should be applied. Otherwise, it is now dropped from my patch queues, never to be seen again. thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From 69167ae5a511560e6ae4181364da274b535a743f Mon Sep 17 00:00:00 2001 From: "H. Nikolaus Schaller" <hns(a)goldelico.com> Date: Thu, 7 Nov 2019 11:30:34 +0100 Subject: [PATCH] Documentation: dt: wireless: update wl1251 for sdio The standard method for sdio devices connected to an sdio interface is to define them as a child node like we can see with wlcore. Signed-off-by: H. Nikolaus Schaller <hns(a)goldelico.com> Acked-by: Kalle Valo <kvalo(a)codeaurora.org> Reviewed-by: Rob Herring <robh(a)kernel.org> Cc: <stable(a)vger.kernel.org> # v4.7+ Signed-off-by: Ulf Hansson <ulf.hansson(a)linaro.org> diff --git a/Documentation/devicetree/bindings/net/wireless/ti,wl1251.txt b/Documentation/devicetree/bindings/net/wireless/ti,wl1251.txt index bb2fcde6f7ff..f38950560982 100644 --- a/Documentation/devicetree/bindings/net/wireless/ti,wl1251.txt +++ b/Documentation/devicetree/bindings/net/wireless/ti,wl1251.txt @@ -35,3 +35,29 @@ Examples: ti,power-gpio = <&gpio3 23 GPIO_ACTIVE_HIGH>; /* 87 */ }; }; + +&mmc3 { + vmmc-supply = <&wlan_en>; + + bus-width = <4>; + non-removable; + ti,non-removable; + cap-power-off-card; + + pinctrl-names = "default"; + pinctrl-0 = <&mmc3_pins>; + + #address-cells = <1>; + #size-cells = <0>; + + wlan: wifi@1 { + compatible = "ti,wl1251"; + + reg = <1>; + + interrupt-parent = <&gpio1>; + interrupts = <21 IRQ_TYPE_LEVEL_HIGH>; /* GPIO_21 */ + + ti,wl1251-has-eeprom; + }; +};

5 years, 11 months

1
0
0 0

[PATCH v6 2/2] can: tcan4x5x: put the device out of standby before register access

by Sean Nyekjaer

The m_can tries to detect if Non ISO Operation is available while in standby, this function results in the following error: tcan4x5x spi2.0 (unnamed net_device) (uninitialized): Failed to init module tcan4x5x spi2.0: m_can device registered (irq=84, version=32) tcan4x5x spi2.0 can2: TCAN4X5X successfully initialized. When the tcan device comes out of reset it comes out in standby mode. The m_can driver tries to access the control register but fails due to the device is in standby mode. So this patch will put the tcan device in normal mode before the m_can driver does the initialization. Fixes: 5443c226ba91 ("can: tcan4x5x: Add tcan4x5x driver to the kernel") Cc: stable(a)vger.kernel.org Signed-off-by: Sean Nyekjaer <sean(a)geanix.com> Signed-off-by: Marc Kleine-Budde <mkl(a)pengutronix.de> --- Changes since v3: - Fixed fixes tag Changes since v4: - None Changes since v5: - None Sorry for the mess :) drivers/net/can/m_can/tcan4x5x.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/can/m_can/tcan4x5x.c b/drivers/net/can/m_can/tcan4x5x.c index dcfa85edc787..8ed2813f227e 100644 --- a/drivers/net/can/m_can/tcan4x5x.c +++ b/drivers/net/can/m_can/tcan4x5x.c @@ -482,6 +482,10 @@ static int tcan4x5x_can_probe(struct spi_device *spi) tcan4x5x_power_enable(priv->power, 1); + ret = tcan4x5x_init(mcan_class); + if (ret) + goto out_power; + ret = m_can_class_register(mcan_class); if (ret) goto out_power; -- 2.24.0

5 years, 11 months

1
0
0 0

[PATCH v6 1/2] can: tcan4x5x: put the device out of standby before register access

by Sean Nyekjaer

The m_can tries to detect if Non ISO Operation is available while in standby, this function results in the following error: tcan4x5x spi2.0 (unnamed net_device) (uninitialized): Failed to init module tcan4x5x spi2.0: m_can device registered (irq=84, version=32) tcan4x5x spi2.0 can2: TCAN4X5X successfully initialized. When the tcan device comes out of reset it comes out in standby mode. The m_can driver tries to access the control register but fails due to the device is in standby mode. So this patch will put the tcan device in normal mode before the m_can driver does the initialization. Fixes: 5443c226ba91 ("can: tcan4x5x: Add tcan4x5x driver to the kernel") Cc: stable(a)vger.kernel.org Signed-off-by: Sean Nyekjaer <sean(a)geanix.com> Signed-off-by: Marc Kleine-Budde <mkl(a)pengutronix.de> --- Changes since v3: - added reset if the reset_gpio is not avaliable Changes since v4: - added error handling for the SPI I/O Changes since v5: - Removed braces for single statement if's drivers/net/can/m_can/tcan4x5x.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/can/m_can/tcan4x5x.c b/drivers/net/can/m_can/tcan4x5x.c index c1b83dc26c3a..295dbb73c69e 100644 --- a/drivers/net/can/m_can/tcan4x5x.c +++ b/drivers/net/can/m_can/tcan4x5x.c @@ -484,6 +484,10 @@ static int tcan4x5x_can_probe(struct spi_device *spi) if (ret) goto out_power; + ret = tcan4x5x_init(mcan_class); + if (ret) + goto out_power; + ret = m_can_class_register(mcan_class); if (ret) goto out_power; -- 2.24.0

5 years, 11 months

1
1
0 0

stable RC build breakages (4.14.y, 4.19.y)

by Guenter Roeck

v4.14.y: arm64:defconfig: arch/arm64/boot/dts/nvidia/tegra186-p2771-0000.dts:5:10: fatal error: dt-bindings/input/gpio-keys.h: No such file or directory i386:allyesconfig: drivers/crypto/geode-aes.c:174:2: error: implicit declaration of function 'crypto_sync_skcipher_clear_flags and several similar errors. --- v4.19.y: arm64:defconfig: arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts:82.1-7 Label or path codec not found arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts:86.1-14 Label or path codec_analog not found arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts:91.1-5 Label or path dai not found arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts:297.1-7 Label or path sound not found i386:allyesconfig: Same as v4.14.y. Guenter

5 years, 11 months

4
3
0 0

Linux 4.19.89-rc1 5944fcdd errors

by Chris Paterson

Hello Greg, all, I've seen a few errors with 4.19.89-rc1 (5944fcdd). 1) Config: arm64 defconfig Link: https://gitlab.com/cip-playground/linux-stable-rc-ci/-/jobs/373484093#L267 Probable culprit: 227b635dcae6 ("bpf, arm64: fix getting subprog addr from aux for calls") Issue log: 267 arch/arm64/net/bpf_jit_comp.c: In function 'build_insn': 268 arch/arm64/net/bpf_jit_comp.c:633:9: error: implicit declaration of function 'bpf_jit_get_func_addr'; did you mean 'bpf_jit_binary_hdr'? [-Werror=implicit-function-declaration] 269 ret = bpf_jit_get_func_addr(ctx->prog, insn, extra_pass, 270 ^~~~~~~~~~~~~~~~~~~~~ 271 bpf_jit_binary_hdr 2) Config: arm multi_v7_defconfig Link: https://gitlab.com/cip-playground/linux-stable-rc-ci/-/jobs/373484091#L2147 Probable culprit: 192929fd944d ("dmaengine: xilinx_dma: Fix 64-bit simple CDMA transfer") Issue log: 2147 drivers/dma/xilinx/xilinx_dma.c: In function 'xilinx_cdma_start_transfer': 2148 drivers/dma/xilinx/xilinx_dma.c:1252:9: error: implicit declaration of function 'xilinx_prep_dma_addr_t'; did you mean 'xilinx_dma_start'? [-Werror=implicit-function-declaration] 2149 xilinx_prep_dma_addr_t(hw->src_addr)); 2150 ^~~~~~~~~~~~~~~~~~~~~~ 2151 xilinx_dma_start 3) Config: arm shmobile_defconfig Link: https://gitlab.com/cip-playground/linux-stable-rc-ci/-/jobs/373484089#L2249 Probable culprit: 984d7a8bff57 ("pinctrl: sh-pfc: r8a7792: Fix VIN versioned groups") Issue log: 2249 drivers/pinctrl/sh-pfc/pfc-r8a7792.c:1750:38: error: macro "VIN_DATA_PIN_GROUP" passed 3 arguments, but takes just 2 2250 VIN_DATA_PIN_GROUP(vin1_data, 24, _b), 2251 ^ 2252 drivers/pinctrl/sh-pfc/pfc-r8a7792.c:1750:2: error: 'VIN_DATA_PIN_GROUP' undeclared here (not in a function); did you mean 'PIN_MAP_TYPE_MUX_GROUP'? 2253 VIN_DATA_PIN_GROUP(vin1_data, 24, _b), 2254 ^~~~~~~~~~~~~~~~~~ 2255 PIN_MAP_TYPE_MUX_GROUP 2256 drivers/pinctrl/sh-pfc/pfc-r8a7792.c:1751:38: error: macro "VIN_DATA_PIN_GROUP" passed 3 arguments, but takes just 2 2257 VIN_DATA_PIN_GROUP(vin1_data, 20, _b), 2258 ^ 2259 drivers/pinctrl/sh-pfc/pfc-r8a7792.c:1753:38: error: macro "VIN_DATA_PIN_GROUP" passed 3 arguments, but takes just 2 2260 VIN_DATA_PIN_GROUP(vin1_data, 16, _b), 2261 ^ Kind regards, Chris

5 years, 11 months

4
14
0 0

[PATCH rh7.3 06/11] usb: iowarrior: fix deadlock on disconnect

by Mao Wenan

From: Oliver Neukum <oneukum(a)suse.com> mainline inclusion from mainline-5.3 commit c468a8aa790e0dfe0a7f8a39db282d39c2c00b46 category: bugfix bugzilla: NA DTS: NA CVE: CVE-2019-19528 ------------------------------------------------- We have to drop the mutex before we close() upon disconnect() as close() needs the lock. This is safe to do by dropping the mutex as intfdata is already set to NULL, so open() will fail. Fixes: 03f36e885fc26 ("USB: open disconnect race in iowarrior") Reported-by: syzbot+a64a382964bf6c71a9c0(a)syzkaller.appspotmail.com Cc: stable <stable(a)vger.kernel.org> Signed-off-by: Oliver Neukum <oneukum(a)suse.com> Link: https://lore.kernel.org/r/20190808092728.23417-1-oneukum@suse.com Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Signed-off-by: Mao Wenan <maowenan(a)huawei.com> --- drivers/usb/misc/iowarrior.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/usb/misc/iowarrior.c b/drivers/usb/misc/iowarrior.c index 1950e87b4219..eb8c08a54a77 100644 --- a/drivers/usb/misc/iowarrior.c +++ b/drivers/usb/misc/iowarrior.c @@ -889,19 +889,20 @@ static void iowarrior_disconnect(struct usb_interface *interface) dev = usb_get_intfdata(interface); mutex_lock(&iowarrior_open_disc_lock); usb_set_intfdata(interface, NULL); + /* prevent device read, write and ioctl */ + dev->present = 0; minor = dev->minor; + mutex_unlock(&iowarrior_open_disc_lock); + /* give back our minor - this will call close() locks need to be dropped at this point*/ - /* give back our minor */ usb_deregister_dev(interface, &iowarrior_class); mutex_lock(&dev->mutex); /* prevent device read, write and ioctl */ - dev->present = 0; mutex_unlock(&dev->mutex); - mutex_unlock(&iowarrior_open_disc_lock); if (dev->opened) { /* There is a process that holds a filedescriptor to the device , -- 2.20.1

5 years, 11 months

2
1
0 0

[PATCH v5 2/2] can: tcan4x5x: put the device out of standby before register access

by Sean Nyekjaer

The m_can tries to detect if Non ISO Operation is available while in standby, this function results in the following error: tcan4x5x spi2.0 (unnamed net_device) (uninitialized): Failed to init module tcan4x5x spi2.0: m_can device registered (irq=84, version=32) tcan4x5x spi2.0 can2: TCAN4X5X successfully initialized. When the tcan device comes out of reset it comes out in standby mode. The m_can driver tries to access the control register but fails due to the device is in standby mode. So this patch will put the tcan device in normal mode before the m_can driver does the initialization. Fixes: 5443c226ba91 ("can: tcan4x5x: Add tcan4x5x driver to the kernel") Cc: stable(a)vger.kernel.org Signed-off-by: Sean Nyekjaer <sean(a)geanix.com> Signed-off-by: Marc Kleine-Budde <mkl(a)pengutronix.de> --- Changes since v3: - Fixed fixes tag Changes since v4: - None drivers/net/can/m_can/tcan4x5x.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/can/m_can/tcan4x5x.c b/drivers/net/can/m_can/tcan4x5x.c index 032d110e0870..3a3359ad3723 100644 --- a/drivers/net/can/m_can/tcan4x5x.c +++ b/drivers/net/can/m_can/tcan4x5x.c @@ -485,6 +485,10 @@ static int tcan4x5x_can_probe(struct spi_device *spi) if (ret) goto out_power; + ret = tcan4x5x_init(mcan_class); + if (ret) + goto out_power; + ret = m_can_class_register(mcan_class); if (ret) goto out_power; -- 2.24.0

5 years, 11 months

1
0
0 0

[PATCH v4 2/2] can: tcan4x5x: put the device out of standby before register access

by Sean Nyekjaer

The m_can tries to detect if Non ISO Operation is available while in standby, this function results in the following error: tcan4x5x spi2.0 (unnamed net_device) (uninitialized): Failed to init module tcan4x5x spi2.0: m_can device registered (irq=84, version=32) tcan4x5x spi2.0 can2: TCAN4X5X successfully initialized. When the tcan device comes out of reset it comes out in standby mode. The m_can driver tries to access the control register but fails due to the device is in standby mode. So this patch will put the tcan device in normal mode before the m_can driver does the initialization. Fixes: 5443c226ba91 ("can: tcan4x5x: Add tcan4x5x driver to the kernel") Cc: stable(a)vger.kernel.org Signed-off-by: Sean Nyekjaer <sean(a)geanix.com> Signed-off-by: Marc Kleine-Budde <mkl(a)pengutronix.de> --- Changes since v3: - Fixed fixes tag drivers/net/can/m_can/tcan4x5x.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/can/m_can/tcan4x5x.c b/drivers/net/can/m_can/tcan4x5x.c index 960a16aca7ca..32c16be5a9d8 100644 --- a/drivers/net/can/m_can/tcan4x5x.c +++ b/drivers/net/can/m_can/tcan4x5x.c @@ -475,6 +475,10 @@ static int tcan4x5x_can_probe(struct spi_device *spi) if (ret) goto out_power; + ret = tcan4x5x_init(mcan_class); + if (ret) + goto out_power; + ret = m_can_class_register(mcan_class); if (ret) goto out_power; -- 2.24.0

5 years, 11 months

1
0
0 0

[PATCH v3 1/2] can: m_can: tcan4x5x: put the device out of standby before register access

by Sean Nyekjaer

The m_can tries to detect if Non ISO Operation is available while in standby, this function results in the following error: tcan4x5x spi2.0 (unnamed net_device) (uninitialized): Failed to init module tcan4x5x spi2.0: m_can device registered (irq=84, version=32) tcan4x5x spi2.0 can2: TCAN4X5X successfully initialized. When the tcan device comes out of reset it comes out in standby mode. The m_can driver tries to access the control register but fails due to the device is in standby mode. So this patch will put the tcan device in normal mode before the m_can driver does the initialization. Fixes: a229abeed7f7 ("can: tcan4x5x: Turn on the power before parsing the config") Cc: stable(a)vger.kernel.org Signed-off-by: Sean Nyekjaer <sean(a)geanix.com> --- Changes since v2: - added error handling for tcan4x5x_init call drivers/net/can/m_can/tcan4x5x.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/can/m_can/tcan4x5x.c b/drivers/net/can/m_can/tcan4x5x.c index b6b2feca9e8f..1f04fec7723d 100644 --- a/drivers/net/can/m_can/tcan4x5x.c +++ b/drivers/net/can/m_can/tcan4x5x.c @@ -460,6 +460,10 @@ static int tcan4x5x_can_probe(struct spi_device *spi) if (ret) goto out_power; + ret = tcan4x5x_init(mcan_class); + if (ret) + goto out_power; + ret = m_can_class_register(mcan_class); if (ret) goto out_power; -- 2.24.0

5 years, 11 months

2
7
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror