- Linux-stable-mirror - lists.linaro.org

PROBLEM: objtool: __x64_sys_exit_group()+0x14: unreachable instruction

by Jeffrin Jose

hello all, i found a warning during kernel build (5.3.11-rc1+). -----------------x----------x----------------- kernel/exit.o: warning: objtool: __x64_sys_exit_group()+0x14: unreachable instruction -------------------x---------------x----------- Related details: --------------- $uname -a Linux debian 5.3.11-rc1+ #6 SMP Tue Nov 12 01:23:06 IST 2019 x86_64 GNU/Linux $ $gcc --version gcc (Debian 9.2.1-14) 9.2.1 20191025 ------x---has-been-cut-here--x------ (gdb) l __x64_sys_exit_group 987 /* 988 * this kills every thread in the thread group. Note that any externally 989 * wait4()-ing process will get the correct exit code - even if this 990 * thread is not the thread group leader. 991 */ 992 SYSCALL_DEFINE1(exit_group, int, error_code) 993 { 994 do_group_exit((error_code & 0xff) << 8); 995 /* NOTREACHED */ 996 return 0; (gdb) (gdb) l *__x64_sys_exit_group+0x14 0xffffffff81085404 is in __x64_sys_exit_group (kernel/exit.c:996). 991 */ 992 SYSCALL_DEFINE1(exit_group, int, error_code) 993 { 994 do_group_exit((error_code & 0xff) << 8); 995 /* NOTREACHED */ 996 return 0; 997 } 998 999 struct waitid_info { 1000 pid_t pid; (gdb) (gdb) l *__x64_sys_exit_group 0xffffffff810853f0 is in __x64_sys_exit_group (kernel/exit.c:992). 987 /* 988 * this kills every thread in the thread group. Note that any externally 989 * wait4()-ing process will get the correct exit code - even if this 990 * thread is not the thread group leader. 991 */ 992 SYSCALL_DEFINE1(exit_group, int, error_code) 993 { 994 do_group_exit((error_code & 0xff) << 8); 995 /* NOTREACHED */ 996 return 0; (gdb) --------------------x-------------x----------------------------- objdump -r -S -l --disassemble kernel/exit.o output is attached -- software engineer rajagiri school of engineering and technology

5 years, 12 months

3
3
0 0

Investment opportunity

by Peter Wong

Greetings, Find attached email very confidential. reply for more details Thanks. Peter Wong ---------------------------------------------------- This email was sent by the shareware version of Postman Professional.

5 years, 12 months

1
0
0 0

[PATCH 4.4 00/20] 4.4.202-stable review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 4.4.202 release. There are 20 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Sun, 17 Nov 2019 06:18:31 +0000. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.4.202-rc… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.4.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 4.4.202-rc1 Vineela Tummalapalli <vineela.tummalapalli(a)intel.com> x86/bugs: Add ITLB_MULTIHIT bug infrastructure Josh Poimboeuf <jpoimboe(a)redhat.com> x86/speculation/taa: Fix printing of TAA_MSG_SMT on IBRS_ALL CPUs Michal Hocko <mhocko(a)suse.com> x86/tsx: Add config options to set tsx=on|off|auto Pawan Gupta <pawan.kumar.gupta(a)linux.intel.com> x86/speculation/taa: Add documentation for TSX Async Abort Pawan Gupta <pawan.kumar.gupta(a)linux.intel.com> x86/tsx: Add "auto" option to the tsx= cmdline parameter Pawan Gupta <pawan.kumar.gupta(a)linux.intel.com> kvm/x86: Export MDS_NO=0 to guests when TSX is enabled Pawan Gupta <pawan.kumar.gupta(a)linux.intel.com> x86/speculation/taa: Add sysfs reporting for TSX Async Abort Pawan Gupta <pawan.kumar.gupta(a)linux.intel.com> x86/speculation/taa: Add mitigation for TSX Async Abort Pawan Gupta <pawan.kumar.gupta(a)linux.intel.com> x86/cpu: Add a "tsx=" cmdline option with TSX disabled by default Pawan Gupta <pawan.kumar.gupta(a)linux.intel.com> x86/cpu: Add a helper function x86_read_arch_cap_msr() Pawan Gupta <pawan.kumar.gupta(a)linux.intel.com> x86/msr: Add the IA32_TSX_CTRL MSR Paolo Bonzini <pbonzini(a)redhat.com> KVM: x86: use Intel speculation bugs and features as derived in generic x86 code Jim Mattson <jmattson(a)google.com> kvm: x86: IA32_ARCH_CAPABILITIES is always supported Sean Christopherson <sean.j.christopherson(a)intel.com> KVM: x86: Emulate MSR_IA32_ARCH_CAPABILITIES on AMD hosts Ben Hutchings <ben(a)decadent.org.uk> KVM: Introduce kvm_get_arch_capabilities() Nicholas Piggin <npiggin(a)gmail.com> powerpc/boot: Request no dynamic linker for boot wrapper Nicholas Piggin <npiggin(a)gmail.com> powerpc: Fix compiling a BE kernel with a powerpc64le toolchain Michael Ellerman <mpe(a)ellerman.id.au> powerpc/Makefile: Use cflags-y/aflags-y for setting endian options Jonas Gorski <jonas.gorski(a)gmail.com> MIPS: BCM63XX: fix switch core reset on BCM6368 Junaid Shahid <junaids(a)google.com> kvm: mmu: Don't read PDPTEs when paging is not enabled ------------- Diffstat: Documentation/ABI/testing/sysfs-devices-system-cpu | 2 + Documentation/hw-vuln/tsx_async_abort.rst | 268 +++++++++++++++++++++ Documentation/kernel-parameters.txt | 62 +++++ Documentation/x86/tsx_async_abort.rst | 117 +++++++++ Makefile | 4 +- arch/mips/bcm63xx/reset.c | 2 +- arch/powerpc/Makefile | 31 ++- arch/powerpc/boot/wrapper | 24 +- arch/x86/Kconfig | 45 ++++ arch/x86/include/asm/cpufeatures.h | 2 + arch/x86/include/asm/kvm_host.h | 2 + arch/x86/include/asm/msr-index.h | 16 ++ arch/x86/include/asm/nospec-branch.h | 4 +- arch/x86/include/asm/processor.h | 7 + arch/x86/kernel/cpu/Makefile | 2 +- arch/x86/kernel/cpu/bugs.c | 143 ++++++++++- arch/x86/kernel/cpu/common.c | 93 ++++--- arch/x86/kernel/cpu/cpu.h | 18 ++ arch/x86/kernel/cpu/intel.c | 5 + arch/x86/kernel/cpu/tsx.c | 140 +++++++++++ arch/x86/kvm/cpuid.c | 12 + arch/x86/kvm/vmx.c | 15 -- arch/x86/kvm/x86.c | 53 +++- drivers/base/cpu.c | 17 ++ include/linux/cpu.h | 5 + 25 files changed, 1019 insertions(+), 70 deletions(-)

5 years, 12 months

5
24
0 0

[PATCH v2] ASoC: rt5645: Fixed typo for buddy jack support.

by Jacob Rasmussen

Had a typo in e7cfd867fd98 that resulted in buddy jack support not being fixed. Fixes: e7cfd867fd98 ("ASoC: rt5645: Fixed buddy jack support.") Signed-off-by: Jacob Rasmussen <jacobraz(a)google.com> Reviewed-by: Ross Zwisler <zwisler(a)google.com> Cc: <jacobraz(a)google.com> CC: stable(a)vger.kernel.org --- sound/soc/codecs/rt5645.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/rt5645.c b/sound/soc/codecs/rt5645.c index 902ac98a3fbe..19662ee330d6 100644 --- a/sound/soc/codecs/rt5645.c +++ b/sound/soc/codecs/rt5645.c @@ -3271,7 +3271,7 @@ static void rt5645_jack_detect_work(struct work_struct *work) report, SND_JACK_MICROPHONE); return; case 4: - val = snd_soc_component_read32(rt5645->component, RT5645_A_JD_CTRL1) & 0x002; + val = snd_soc_component_read32(rt5645->component, RT5645_A_JD_CTRL1) & 0x0020; break; default: /* read rt5645 jd1_1 status */ val = snd_soc_component_read32(rt5645->component, RT5645_INT_IRQ_ST) & 0x1000; -- 2.21.0

5 years, 12 months

2
1
0 0

stable-rc/linux-4.4.y boot: 80 boots: 1 failed, 75 passed with 3 offline, 1 conflict (v4.4.201-21-gb0074e36d782)

by kernelci.org bot

stable-rc/linux-4.4.y boot: 80 boots: 1 failed, 75 passed with 3 offline, 1 conflict (v4.4.201-21-gb0074e36d782) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-4.4.y/kernel/v4.4.… Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-4.4.y/kernel/v4.4.201-21-… Tree: stable-rc Branch: linux-4.4.y Git Describe: v4.4.201-21-gb0074e36d782 Git Commit: b0074e36d782e84e6a2e08910103642762949d2b Git URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Tested: 41 unique boards, 17 SoC families, 13 builds out of 190 Boot Regressions Detected: arm: exynos_defconfig: gcc-8: exynos5422-odroidxu3: lab-collabora: new failure (last pass: v4.4.201) Boot Failure Detected: arm: exynos_defconfig: gcc-8: exynos5422-odroidxu3: 1 failed lab Offline Platforms: arm: sunxi_defconfig: gcc-8 sun7i-a20-bananapi: 1 offline lab multi_v7_defconfig: gcc-8 bcm4708-smartrg-sr400ac: 1 offline lab sun7i-a20-bananapi: 1 offline lab Conflicting Boot Failure Detected: (These likely are not failures as other labs are reporting PASS. Needs review.) i386: i386_defconfig: qemu_i386: lab-baylibre: FAIL (gcc-8) lab-collabora: PASS (gcc-8) --- For more info write to <info(a)kernelci.org>

5 years, 12 months

1
0
0 0

stable-rc/linux-4.9.y boot: 93 boots: 0 failed, 89 passed with 3 offline, 1 conflict (v4.9.201-32-gd7f83e4f45e8)

by kernelci.org bot

stable-rc/linux-4.9.y boot: 93 boots: 0 failed, 89 passed with 3 offline, 1 conflict (v4.9.201-32-gd7f83e4f45e8) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-4.9.y/kernel/v4.9.… Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-4.9.y/kernel/v4.9.201-32-… Tree: stable-rc Branch: linux-4.9.y Git Describe: v4.9.201-32-gd7f83e4f45e8 Git Commit: d7f83e4f45e886d919bc985bd225b8355ddd9284 Git URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Tested: 49 unique boards, 19 SoC families, 14 builds out of 197 Offline Platforms: arm: sunxi_defconfig: gcc-8 sun7i-a20-bananapi: 1 offline lab multi_v7_defconfig: gcc-8 bcm4708-smartrg-sr400ac: 1 offline lab sun7i-a20-bananapi: 1 offline lab Conflicting Boot Failure Detected: (These likely are not failures as other labs are reporting PASS. Needs review.) x86_64: x86_64_defconfig: qemu_x86_64: lab-collabora: FAIL (gcc-8) lab-baylibre: PASS (gcc-8) --- For more info write to <info(a)kernelci.org>

5 years, 12 months

1
0
0 0

Re: [PATCH 4.19] memfd: Fix locking when tagging pins

by Matthew Wilcox

On Wed, Nov 13, 2019 at 12:00:22PM +0800, zhong jiang wrote: > Hi, Matthew > > When appling the following patch, I hit the an warning. > > *WARNING: suspicious RCU usage in memfd_wait_for_pins* > > It is because we remove the rcu_read_lock/read_read_unlock. but We still use > radix_tree_deref_slot checking rcu_read_lock_held(). Ooh. We should be using radix_tree_deref_slot_protected() instead. Can I trouble you to send that patch? > A simple fix as follows without test. > > diff --git a/mm/memfd.c b/mm/memfd.c > index 5859705dafe1..af244c9c8b6f 100644 > --- a/mm/memfd.c > +++ b/mm/memfd.c > @@ -40,6 +40,7 @@ static void memfd_tag_pins(struct address_space *mapping) > start = 0; > > xa_lock_irq(&mapping->i_pages); > + rcu_read_lock(); > radix_tree_for_each_slot(slot, &mapping->i_pages, &iter, start) { > page = radix_tree_deref_slot(slot); > if (!page || radix_tree_exception(page)) { > @@ -60,6 +61,7 @@ static void memfd_tag_pins(struct address_space *mapping) > cond_resched(); > xa_lock_irq(&mapping->i_pages); > } > + rcu_read_unlock(); > xa_unlock_irq(&mapping->i_pages); > } > > Thanks, > zhong jiang > > On 2019/10/26 0:58, Matthew Wilcox wrote: > > From: "Matthew Wilcox (Oracle)" <willy(a)infradead.org> > > > > The RCU lock is insufficient to protect the radix tree iteration as > > a deletion from the tree can occur before we take the spinlock to > > tag the entry. In 4.19, this has manifested as a bug with the following > > trace: > > > > kernel BUG at lib/radix-tree.c:1429! > > invalid opcode: 0000 [#1] SMP KASAN PTI > > CPU: 7 PID: 6935 Comm: syz-executor.2 Not tainted 4.19.36 #25 > > Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.10.2-1ubuntu1 04/01/2014 > > RIP: 0010:radix_tree_tag_set+0x200/0x2f0 lib/radix-tree.c:1429 > > Code: 00 00 5b 5d 41 5c 41 5d 41 5e 41 5f c3 48 89 44 24 10 e8 a3 29 7e fe 48 8b 44 24 10 48 0f ab 03 e9 d2 fe ff ff e8 90 29 7e fe <0f> 0b 48 c7 c7 e0 5a 87 84 e8 f0 e7 08 ff 4c 89 ef e8 4a ff ac fe > > RSP: 0018:ffff88837b13fb60 EFLAGS: 00010016 > > RAX: 0000000000040000 RBX: ffff8883c5515d58 RCX: ffffffff82cb2ef0 > > RDX: 0000000000000b72 RSI: ffffc90004cf2000 RDI: ffff8883c5515d98 > > RBP: ffff88837b13fb98 R08: ffffed106f627f7e R09: ffffed106f627f7e > > R10: 0000000000000001 R11: ffffed106f627f7d R12: 0000000000000004 > > R13: ffffea000d7fea80 R14: 1ffff1106f627f6f R15: 0000000000000002 > > FS: 00007fa1b8df2700(0000) GS:ffff8883e2fc0000(0000) knlGS:0000000000000000 > > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > > CR2: 00007fa1b8df1db8 CR3: 000000037d4d2001 CR4: 0000000000160ee0 > > Call Trace: > > memfd_tag_pins mm/memfd.c:51 [inline] > > memfd_wait_for_pins+0x2c5/0x12d0 mm/memfd.c:81 > > memfd_add_seals mm/memfd.c:215 [inline] > > memfd_fcntl+0x33d/0x4a0 mm/memfd.c:247 > > do_fcntl+0x589/0xeb0 fs/fcntl.c:421 > > __do_sys_fcntl fs/fcntl.c:463 [inline] > > __se_sys_fcntl fs/fcntl.c:448 [inline] > > __x64_sys_fcntl+0x12d/0x180 fs/fcntl.c:448 > > do_syscall_64+0xc8/0x580 arch/x86/entry/common.c:293 > > > > The problem does not occur in mainline due to the XArray rewrite which > > changed the locking to exclude modification of the tree during iteration. > > At the time, nobody realised this was a bugfix. Backport the locking > > changes to stable. > > > > Cc: stable(a)vger.kernel.org > > Reported-by: zhong jiang <zhongjiang(a)huawei.com> > > Signed-off-by: Matthew Wilcox (Oracle) <willy(a)infradead.org> > > --- > > mm/memfd.c | 18 ++++++++++-------- > > 1 file changed, 10 insertions(+), 8 deletions(-) > > > > diff --git a/mm/memfd.c b/mm/memfd.c > > index 2bb5e257080e..5859705dafe1 100644 > > --- a/mm/memfd.c > > +++ b/mm/memfd.c > > @@ -34,11 +34,12 @@ static void memfd_tag_pins(struct address_space *mapping) > > void __rcu **slot; > > pgoff_t start; > > struct page *page; > > + unsigned int tagged = 0; > > > > lru_add_drain(); > > start = 0; > > - rcu_read_lock(); > > > > + xa_lock_irq(&mapping->i_pages); > > radix_tree_for_each_slot(slot, &mapping->i_pages, &iter, start) { > > page = radix_tree_deref_slot(slot); > > if (!page || radix_tree_exception(page)) { > > @@ -47,18 +48,19 @@ static void memfd_tag_pins(struct address_space *mapping) > > continue; > > } > > } else if (page_count(page) - page_mapcount(page) > 1) { > > - xa_lock_irq(&mapping->i_pages); > > radix_tree_tag_set(&mapping->i_pages, iter.index, > > MEMFD_TAG_PINNED); > > - xa_unlock_irq(&mapping->i_pages); > > } > > > > - if (need_resched()) { > > - slot = radix_tree_iter_resume(slot, &iter); > > - cond_resched_rcu(); > > - } > > + if (++tagged % 1024) > > + continue; > > + > > + slot = radix_tree_iter_resume(slot, &iter); > > + xa_unlock_irq(&mapping->i_pages); > > + cond_resched(); > > + xa_lock_irq(&mapping->i_pages); > > } > > - rcu_read_unlock(); > > + xa_unlock_irq(&mapping->i_pages); > > } > > > > /* >

5 years, 12 months

2
1
0 0

patch "USB: serial: ftdi_sio: add device IDs for U-Blox C099-F9P" added to usb-next

by gregkh＠linuxfoundation.org

This is a note to let you know that I've just added the patch titled USB: serial: ftdi_sio: add device IDs for U-Blox C099-F9P to my usb git tree which can be found at git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git in the usb-next branch. The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.) The patch will also be merged in the next major kernel release during the merge window. If you have any questions about this process, please let me know. >From c1a1f273d0825774c80896b8deb1c9ea1d0b91e3 Mon Sep 17 00:00:00 2001 From: Fabio D'Urso <fabiodurso(a)hotmail.it> Date: Thu, 14 Nov 2019 01:30:53 +0000 Subject: USB: serial: ftdi_sio: add device IDs for U-Blox C099-F9P This device presents itself as a USB hub with three attached devices: - An ACM serial port connected to the GPS module (not affected by this commit) - An FTDI serial port connected to the GPS module (1546:0502) - Another FTDI serial port connected to the ODIN-W2 radio module (1546:0503) This commit registers U-Blox's VID and the PIDs of the second and third devices. Datasheet: https://www.u-blox.com/sites/default/files/C099-F9P-AppBoard-Mbed-OS3-FW_Us… Signed-off-by: Fabio D'Urso <fabiodurso(a)hotmail.it> Cc: stable <stable(a)vger.kernel.org> Signed-off-by: Johan Hovold <johan(a)kernel.org> --- drivers/usb/serial/ftdi_sio.c | 3 +++ drivers/usb/serial/ftdi_sio_ids.h | 7 +++++++ 2 files changed, 10 insertions(+) diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c index 25e81faf4c24..9ad44a96dfe3 100644 --- a/drivers/usb/serial/ftdi_sio.c +++ b/drivers/usb/serial/ftdi_sio.c @@ -1033,6 +1033,9 @@ static const struct usb_device_id id_table_combined[] = { /* Sienna devices */ { USB_DEVICE(FTDI_VID, FTDI_SIENNA_PID) }, { USB_DEVICE(ECHELON_VID, ECHELON_U20_PID) }, + /* U-Blox devices */ + { USB_DEVICE(UBLOX_VID, UBLOX_C099F9P_ZED_PID) }, + { USB_DEVICE(UBLOX_VID, UBLOX_C099F9P_ODIN_PID) }, { } /* Terminating entry */ }; diff --git a/drivers/usb/serial/ftdi_sio_ids.h b/drivers/usb/serial/ftdi_sio_ids.h index 22d66217cb41..e8373528264c 100644 --- a/drivers/usb/serial/ftdi_sio_ids.h +++ b/drivers/usb/serial/ftdi_sio_ids.h @@ -1558,3 +1558,10 @@ */ #define UNJO_VID 0x22B7 #define UNJO_ISODEBUG_V1_PID 0x150D + +/* + * U-Blox products (http://www.u-blox.com). + */ +#define UBLOX_VID 0x1546 +#define UBLOX_C099F9P_ZED_PID 0x0502 +#define UBLOX_C099F9P_ODIN_PID 0x0503 -- 2.24.0

5 years, 12 months

1
0
0 0

patch "USB: serial: option: add support for Foxconn T77W968 LTE modules" added to usb-next

by gregkh＠linuxfoundation.org

This is a note to let you know that I've just added the patch titled USB: serial: option: add support for Foxconn T77W968 LTE modules to my usb git tree which can be found at git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git in the usb-next branch. The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.) The patch will also be merged in the next major kernel release during the merge window. If you have any questions about this process, please let me know. >From f0797095423e6ea3b4be61134ee353c7f504d440 Mon Sep 17 00:00:00 2001 From: Aleksander Morgado <aleksander(a)aleksander.es> Date: Wed, 13 Nov 2019 11:14:05 +0100 Subject: USB: serial: option: add support for Foxconn T77W968 LTE modules These are the Foxconn-branded variants of the Dell DW5821e modules, same USB layout as those. The device exposes AT, NMEA and DIAG ports in both USB configurations. P: Vendor=0489 ProdID=e0b4 Rev=03.18 S: Manufacturer=FII S: Product=T77W968 LTE S: SerialNumber=0123456789ABCDEF C: #Ifs= 6 Cfg#= 1 Atr=a0 MxPwr=500mA I: If#=0x0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=ff Driver=qmi_wwan I: If#=0x1 Alt= 0 #EPs= 1 Cls=03(HID ) Sub=00 Prot=00 Driver=usbhid I: If#=0x2 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option I: If#=0x3 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option I: If#=0x4 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option I: If#=0x5 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=option P: Vendor=0489 ProdID=e0b4 Rev=03.18 S: Manufacturer=FII S: Product=T77W968 LTE S: SerialNumber=0123456789ABCDEF C: #Ifs= 7 Cfg#= 2 Atr=a0 MxPwr=500mA I: If#=0x0 Alt= 0 #EPs= 1 Cls=02(commc) Sub=0e Prot=00 Driver=cdc_mbim I: If#=0x1 Alt= 1 #EPs= 2 Cls=0a(data ) Sub=00 Prot=02 Driver=cdc_mbim I: If#=0x2 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option I: If#=0x3 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option I: If#=0x4 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option I: If#=0x5 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=option I: If#=0x6 Alt= 0 #EPs= 1 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none) Signed-off-by: Aleksander Morgado <aleksander(a)aleksander.es> [ johan: drop id defines ] Cc: stable <stable(a)vger.kernel.org> Signed-off-by: Johan Hovold <johan(a)kernel.org> --- drivers/usb/serial/option.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c index 2023f1f4edaf..e9491d400a24 100644 --- a/drivers/usb/serial/option.c +++ b/drivers/usb/serial/option.c @@ -1993,6 +1993,10 @@ static const struct usb_device_id option_ids[] = { { USB_DEVICE_AND_INTERFACE_INFO(0x03f0, 0xa31d, 0xff, 0x06, 0x13) }, { USB_DEVICE_AND_INTERFACE_INFO(0x03f0, 0xa31d, 0xff, 0x06, 0x14) }, { USB_DEVICE_AND_INTERFACE_INFO(0x03f0, 0xa31d, 0xff, 0x06, 0x1b) }, + { USB_DEVICE(0x0489, 0xe0b4), /* Foxconn T77W968 */ + .driver_info = RSVD(0) | RSVD(1) | RSVD(6) }, + { USB_DEVICE(0x0489, 0xe0b5), /* Foxconn T77W968 ESIM */ + .driver_info = RSVD(0) | RSVD(1) | RSVD(6) }, { USB_DEVICE(0x1508, 0x1001), /* Fibocom NL668 */ .driver_info = RSVD(4) | RSVD(5) | RSVD(6) }, { USB_DEVICE(0x2cb7, 0x0104), /* Fibocom NL678 series */ -- 2.24.0

5 years, 12 months

1
0
0 0

patch "USB: serial: mos7720: fix remote wakeup" added to usb-next

by gregkh＠linuxfoundation.org

This is a note to let you know that I've just added the patch titled USB: serial: mos7720: fix remote wakeup to my usb git tree which can be found at git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git in the usb-next branch. The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.) The patch will also be merged in the next major kernel release during the merge window. If you have any questions about this process, please let me know. >From ea422312a462696093b5db59d294439796cba4ad Mon Sep 17 00:00:00 2001 From: Johan Hovold <johan(a)kernel.org> Date: Thu, 7 Nov 2019 14:21:18 +0100 Subject: USB: serial: mos7720: fix remote wakeup The driver was setting the device remote-wakeup feature during probe in violation of the USB specification (which says it should only be set just prior to suspending the device). This could potentially waste power during suspend as well as lead to spurious wakeups. Note that USB core would clear the remote-wakeup feature at first resume. Fixes: 0f64478cbc7a ("USB: add USB serial mos7720 driver") Cc: stable <stable(a)vger.kernel.org> # 2.6.19 Reviewed-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Signed-off-by: Johan Hovold <johan(a)kernel.org> --- drivers/usb/serial/mos7720.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/usb/serial/mos7720.c b/drivers/usb/serial/mos7720.c index 18110225d506..2ec4eeacebc7 100644 --- a/drivers/usb/serial/mos7720.c +++ b/drivers/usb/serial/mos7720.c @@ -1833,10 +1833,6 @@ static int mos7720_startup(struct usb_serial *serial) product = le16_to_cpu(serial->dev->descriptor.idProduct); dev = serial->dev; - /* setting configuration feature to one */ - usb_control_msg(serial->dev, usb_sndctrlpipe(serial->dev, 0), - (__u8)0x03, 0x00, 0x01, 0x00, NULL, 0x00, 5000); - if (product == MOSCHIP_DEVICE_ID_7715) { struct urb *urb = serial->port[0]->interrupt_in_urb; -- 2.24.0

5 years, 12 months

1
0
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror