- Linux-stable-mirror - lists.linaro.org

[PATCH v4 2/7] zram: fix double free backing device

by Minchan Kim

If blkdev_get fails, we shouldn't do blkdev_put. Otherwise, kernel emits below log. This patch fixes it. [ 31.073006] WARNING: CPU: 0 PID: 1893 at fs/block_dev.c:1828 blkdev_put+0x105/0x120 [ 31.075104] Modules linked in: [ 31.075898] CPU: 0 PID: 1893 Comm: swapoff Not tainted 4.19.0+ #453 [ 31.077484] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.10.2-1 04/01/2014 [ 31.079589] RIP: 0010:blkdev_put+0x105/0x120 [ 31.080606] Code: 48 c7 80 a0 00 00 00 00 00 00 00 48 c7 c7 40 e7 40 96 e8 6e 47 73 00 48 8b bb e0 00 00 00 e9 2c ff ff ff 0f 0b e9 75 ff ff ff <0f> 0b e9 5a ff ff ff 48 c7 80 a0 00 00 00 00 00 00 00 eb 87 0f 1f [ 31.085080] RSP: 0018:ffffb409005c7ed0 EFLAGS: 00010297 [ 31.086383] RAX: ffff9779fe5a8040 RBX: ffff9779fbc17300 RCX: 00000000b9fc37a4 [ 31.088105] RDX: 0000000000000001 RSI: 0000000000000000 RDI: ffffffff9640e740 [ 31.089850] RBP: ffff9779fbc17318 R08: ffffffff95499a89 R09: 0000000000000004 [ 31.091201] R10: ffffb409005c7e50 R11: 7a9ef6088ff4d4a1 R12: 0000000000000083 [ 31.092276] R13: ffff9779fe607b98 R14: 0000000000000000 R15: ffff9779fe607a38 [ 31.093355] FS: 00007fc118d9b840(0000) GS:ffff9779fc600000(0000) knlGS:0000000000000000 [ 31.094582] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 31.095541] CR2: 00007fc11894b8dc CR3: 00000000339f6001 CR4: 0000000000160ef0 [ 31.096781] Call Trace: [ 31.097212] __x64_sys_swapoff+0x46d/0x490 [ 31.097914] do_syscall_64+0x5a/0x190 [ 31.098550] entry_SYSCALL_64_after_hwframe+0x49/0xbe [ 31.099402] RIP: 0033:0x7fc11843ec27 [ 31.100013] Code: 73 01 c3 48 8b 0d 71 62 2c 00 f7 d8 64 89 01 48 83 c8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 b8 a8 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 41 62 2c 00 f7 d8 64 89 01 48 [ 31.103149] RSP: 002b:00007ffdf69be648 EFLAGS: 00000206 ORIG_RAX: 00000000000000a8 [ 31.104425] RAX: ffffffffffffffda RBX: 00000000011d98c0 RCX: 00007fc11843ec27 [ 31.105627] RDX: 0000000000000001 RSI: 0000000000000001 RDI: 00000000011d98c0 [ 31.106847] RBP: 0000000000000001 R08: 00007ffdf69be690 R09: 0000000000000001 [ 31.108038] R10: 00000000000002b1 R11: 0000000000000206 R12: 0000000000000001 [ 31.109231] R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000 [ 31.110433] irq event stamp: 4466 [ 31.111001] hardirqs last enabled at (4465): [<ffffffff953ebd43>] __free_pages_ok+0x1e3/0x490 [ 31.112437] hardirqs last disabled at (4466): [<ffffffff95201b7a>] trace_hardirqs_off_thunk+0x1a/0x1c [ 31.113973] softirqs last enabled at (3420): [<ffffffff95e00333>] __do_softirq+0x333/0x446 [ 31.115364] softirqs last disabled at (3407): [<ffffffff9527aee1>] irq_exit+0xd1/0xe0 Cc: stable(a)vger.kernel.org # 4.14+ Reviewed-by: Joey Pabalinas <joeypabalinas(a)gmail.com> Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky(a)gmail.com> Signed-off-by: Minchan Kim <minchan(a)kernel.org> --- drivers/block/zram/zram_drv.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c index 21a7046958a3..d1459cc1159f 100644 --- a/drivers/block/zram/zram_drv.c +++ b/drivers/block/zram/zram_drv.c @@ -387,8 +387,10 @@ static ssize_t backing_dev_store(struct device *dev, bdev = bdgrab(I_BDEV(inode)); err = blkdev_get(bdev, FMODE_READ | FMODE_WRITE | FMODE_EXCL, zram); - if (err < 0) + if (err < 0) { + bdev = NULL; goto out; + } nr_pages = i_size_read(inode) >> PAGE_SHIFT; bitmap_sz = BITS_TO_LONGS(nr_pages) * sizeof(long); -- 2.20.0.rc1.387.gf8505762e3-goog

6 years, 9 months

1
0
0 0

[PATCH 3.18 00/83] 3.18.128-stable review

by Greg Kroah-Hartman

This is the start of the stable review cycle for the 3.18.128 release. There are 83 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Sat Dec 1 14:01:23 UTC 2018. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v3.x/stable-review/patch-3.18.128-r… or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-3.18.y and the diffstat can be found below. thanks, greg k-h ------------- Pseudo-Shortlog of commits: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Linux 3.18.128-rc1 Thomas Zimmermann <tzimmermann(a)suse.de> drm/ast: Remove existing framebuffers before loading driver WANG Cong <xiyou.wangcong(a)gmail.com> af_unix: move unix_mknod() out of bindlock Greg Kroah-Hartman <greg(a)kroah.com> tty: wipe buffer if not echoing data Linus Torvalds <torvalds(a)linux-foundation.org> tty: wipe buffer. Mauricio Faria de Oliveira <mauricfo(a)linux.vnet.ibm.com> scsi: qla2xxx: do not queue commands when unloading Subhash Jadavani <subhashj(a)codeaurora.org> scsi: ufs: fix race between clock gating and devfreq scaling work Venkat Gopalakrishnan <venkatg(a)codeaurora.org> scsi: ufshcd: Fix race between clk scaling and ungate work Yaniv Gardi <ygardi(a)codeaurora.org> scsi: ufs: fix bugs related to null pointer access and array size Johannes Thumshirn <jthumshirn(a)suse.de> cw1200: Don't leak memory if krealloc failes Ramses Ramírez <ramzeto(a)gmail.com> Input: xpad - add support for Xbox1 PDP Camo series gamepad Enno Boland <gottox(a)voidlinux.eu> Input: xpad - fix GPD Win 2 controller name Ethan Lee <flibitijibibo(a)gmail.com> Input: xpad - add GPD Win 2 Controller USB IDs Marcus Folkesson <marcus.folkesson(a)gmail.com> Input: xpad - avoid using __set_bit() for capabilities Leo Sperling <leosperling97(a)gmail.com> Input: xpad - fix some coding style issues Francis Therien <frtherien(a)gmail.com> Input: xpad - add PDP device id 0x02a4 Mark Furneaux <mark(a)furneaux.ca> Input: xpad - add support for PDP Xbox One controllers Cameron Gutman <aicommander(a)gmail.com> Input: xpad - validate USB endpoint type during probe Cameron Gutman <aicommander(a)gmail.com> Input: xpad - fix PowerA init quirk for some gamepad models Arvind Yadav <arvind.yadav.cs(a)gmail.com> Input: xpad - constify usb_device_id Benjamin Valentin <benpicco(a)googlemail.com> Input: xpad - sync supported devices with XBCD Benjamin Valentin <benpicco(a)googlemail.com> Input: xpad - sync supported devices with 360Controller Benjamin Valentin <benpicco(a)googlemail.com> Input: xpad - add USB IDs for Mad Catz Brawlstick and Razer Sabertooth Benjamin Valentin <benpicco(a)googlemail.com> Input: xpad - sync supported devices with xboxdrv Benjamin Valentin <benpicco(a)googlemail.com> Input: xpad - sort supported devices by USB ID Cameron Gutman <aicommander(a)gmail.com> Input: xpad - support some quirky Xbox One pads Cameron Gutman <aicommander(a)gmail.com> Input: xpad - restore LED state after device resume Cameron Gutman <aicommander(a)gmail.com> Input: xpad - fix stuck mode button on Xbox One S pad Cameron Gutman <aicommander(a)gmail.com> Input: xpad - don't depend on endpoint order Pavel Rojtberg <rojtberg(a)gmail.com> Input: xpad - simplify error condition in init_output Daniel Tobias <dan.g.tob(a)gmail.com> Input: xpad - move reporting xbox one home button to common function Daniel Tobias <dan.g.tob(a)gmail.com> Input: xpad - correctly sort vendor id's Pavel Rojtberg <rojtberg(a)gmail.com> Input: xpad - use correct product id for x360w controllers Cameron Gutman <aicommander(a)gmail.com> Input: xpad - fix Xbox One rumble stopping after 2.5 secs Cameron Gutman <aicommander(a)gmail.com> Input: xpad - add product ID for Xbox One S pad Cameron Gutman <aicommander(a)gmail.com> Input: xpad - power off wireless 360 controllers on suspend Cameron Gutman <aicommander(a)gmail.com> Input: xpad - fix oops when attaching an unknown Xbox One gamepad Cameron Gutman <aicommander(a)gmail.com> Input: xpad - fix rumble on Xbox One controllers with 2015 firmware Pavel Rojtberg <rojtberg(a)gmail.com> Input: xpad - xbox one elite controller support Pavel Rojtberg <rojtberg(a)gmail.com> Input: xpad - add more third-party controllers Cameron Gutman <aicommander(a)gmail.com> Input: xpad - prevent spurious input from wired Xbox 360 controllers Pavel Rojtberg <rojtberg(a)gmail.com> Input: xpad - move pending clear to the correct location Silvan Jegen <s.jegen(a)gmail.com> Input: xpad - add Mad Catz FightStick TE 2 VID/PID Arnd Bergmann <arnd(a)arndb.de> Input: xpad - remove unused function Pavel Rojtberg <rojtberg(a)gmail.com> Input: xpad - correct xbox one pad device name Dmitry Torokhov <dmitry.torokhov(a)gmail.com> Input: xpad - use LED API when identifying wireless controllers Pavel Rojtberg <rojtberg(a)gmail.com> Input: xpad - workaround dead irq_out after suspend/ resume Pierre-Loup A. Griffais <githubpublic(a)plagman.net> Input: xpad - update Xbox One Force Feedback Support Pavel Rojtberg <rojtberg(a)gmail.com> Input: xpad - correctly handle concurrent LED and FF requests Pierre-Loup A. Griffais <pgriffais(a)valvesoftware.com> Input: xpad - handle "present" and "gone" correctly Clement Calmels <clement.calmels(a)free.fr> Input: xpad - remove spurious events of wireless xpad 360 controller Pavel Rojtberg <rojtberg(a)gmail.com> Input: xpad - fix clash of presence handling with LED setting Pavel Rojtberg <rojtberg(a)gmail.com> Input: xpad - query wireless controller state at init Pierre-Loup A. Griffais <pgriffais(a)valvesoftware.com> Input: xpad - move the input device creation to a new function Pavel Rojtberg <rojtberg(a)gmail.com> Input: xpad - x360w: report dpad as buttons and axes Pavel Rojtberg <rojtberg(a)gmail.com> Input: xpad - factor out URB submission in xpad_play_effect Pavel Rojtberg <rojtberg(a)gmail.com> Input: xpad - remove needless bulk out URB used for LED setup Pavel Rojtberg <rojtberg(a)gmail.com> Input: xpad - use ida() for finding the pad_nr Pavel Rojtberg <rojtberg(a)gmail.com> Input: xpad - clarify LED enumeration Dario Scarpa <dario.scarpa(a)duskzone.it> Input: xpad - fix Razer Atrox Arcade Stick button mapping Erik Lundgren <eriklundgren93(a)gmail.com> Input: xpad - add Covert Forces edition of the Xbox One controller Pavel Rojtberg <rojtberg(a)gmail.com> Input: xpad - re-send LED command on present event Pierre-Loup A. Griffais <pgriffais(a)valvesoftware.com> Input: xpad - set the LEDs properly on XBox Wireless controllers Ming-ting Yao Wei <mwei(a)lxde.org> Input: xpad - add rumble support for Xbox One controller Aniroop Mathur <aniroop.mathur(a)gmail.com> Input: initialize device counter variables with -1 Greg Hackmann <ghackmann(a)android.com> arm64: remove no-op -p linker flag Yufen Yu <yuyufen(a)huawei.com> tmpfs: make lseek(SEEK_DATA/SEK_HOLE) return ENXIO with a negative offset Satheesh Rajendran <sathnaga(a)linux.vnet.ibm.com> powerpc/numa: Suppress "VPHN is not supported" messages Prarit Bhargava <prarit(a)redhat.com> kdb: Use strscpy with destination buffer size Trond Myklebust <trond.myklebust(a)hammerspace.com> SUNRPC: Fix a bogus get/put in generic_key_to_expire() Russell King <rmk+kernel(a)armlinux.org.uk> ARM: make lookup_processor_type() non-__init Anson Huang <anson.huang(a)nxp.com> cpufreq: imx6q: add return value check for voltage scale Marc Kleine-Budde <mkl(a)pengutronix.de> can: dev: __can_get_echo_skb(): print error message, if trying to echo non existing skb Marc Kleine-Budde <mkl(a)pengutronix.de> can: dev: __can_get_echo_skb(): Don't crash the kernel if can_priv::echo_skb is accessed out of bounds Marc Kleine-Budde <mkl(a)pengutronix.de> can: dev: __can_get_echo_skb(): replace struct can_frame by canfd_frame to access frame length Marc Kleine-Budde <mkl(a)pengutronix.de> can: dev: can_get_echo_skb(): factor out non sending code to __can_get_echo_skb() Y.C. Chen <yc_chen(a)aspeedtech.com> drm/ast: change resolution may cause screen blurred Y.C. Chen <yc_chen(a)aspeedtech.com> drm/ast: fixed cursor may disappear sometimes Eric Dumazet <edumazet(a)google.com> llc: do not use sk_eat_skb() Andrew Price <anprice(a)redhat.com> gfs2: Don't leave s_fs_info pointing to freed memory in init_sbd Xin Long <lucien.xin(a)gmail.com> sctp: clear the transport of some out_chunk_list chunks in sctp_assoc_rm_peer Tetsuo Handa <penguin-kernel(a)I-love.SAKURA.ne.jp> bfs: add sanity check at bfs_fill_super() Dominique Martinet <dominique.martinet(a)cea.fr> v9fs_dir_readdir: fix double-free on p9stat_read error Dennis Wassenberg <dennis.wassenberg(a)secunet.com> usb: core: Fix hub port connection events lost ------------- Diffstat: Makefile | 4 +- arch/arm/kernel/head-common.S | 6 +- arch/arm64/Makefile | 2 +- arch/powerpc/mm/numa.c | 2 +- drivers/cpufreq/imx6q-cpufreq.c | 7 +- drivers/gpu/drm/ast/ast_drv.c | 21 + drivers/gpu/drm/ast/ast_mode.c | 3 +- drivers/input/gameport/gameport.c | 4 +- drivers/input/joystick/xpad.c | 1422 +++++++++++++++++++++++++++---------- drivers/input/misc/ims-pcu.c | 4 +- drivers/input/serio/serio.c | 4 +- drivers/input/serio/serio_raw.c | 4 +- drivers/net/can/dev.c | 48 +- drivers/net/wireless/cw1200/wsm.c | 16 +- drivers/scsi/qla2xxx/qla_os.c | 5 + drivers/scsi/ufs/ufs.h | 3 +- drivers/scsi/ufs/ufshcd.c | 72 +- drivers/tty/n_tty.c | 19 +- drivers/tty/tty_buffer.c | 2 + drivers/usb/core/hub.c | 4 +- fs/9p/vfs_dir.c | 11 - fs/bfs/inode.c | 9 +- fs/gfs2/ops_fstype.c | 2 +- include/linux/can/dev.h | 1 + kernel/debug/kdb/kdb_io.c | 15 +- kernel/debug/kdb/kdb_private.h | 2 +- kernel/debug/kdb/kdb_support.c | 10 +- mm/shmem.c | 4 +- net/llc/af_llc.c | 11 +- net/sctp/associola.c | 10 +- net/sunrpc/auth_generic.c | 8 +- net/unix/af_unix.c | 27 +- 32 files changed, 1293 insertions(+), 469 deletions(-)

6 years, 9 months

7
96
0 0

Security fixes for 4.14

by Ben Hutchings

I've backported a number of fixes for security issues affecting 4.14- stable. All of these are already fixed in 4.19-stable. Most of the issues involve filesystem validation, and I tested with the reproducers where available. For the BPF fix, I verified that the self-tests didn't regress and temporarily added logging to check that the mitigation is applied when needed. Ben. -- Ben Hutchings, Software Developer Codethink Ltd https://www.codethink.co.uk/ Dale House, 35 Dale Street Manchester, M1 2HF, United Kingdom

6 years, 9 months

2
1
0 0

request for 4.14-stable: 25677478474a ("ubi: Initialize Fastmap checkmapping correctly")

by Sudip Mukherjee

Hi Greg, This was not marked for stable but the commit which it fixes has been added to v4.14.85. -- Regards Sudip

6 years, 9 months

2
1
0 0

media: em28xx: Fix use-after-free when disconnecting

by Steve Muckle

Hello, Please pick the following commit from Linus' tree: commit 910b0797fa9e8af09c44a3fa36cb310ba7a7218d Author: Matthias Schwarzott <zzam(a)gentoo.org> Date: Mon Oct 30 06:07:29 2017 -0400 media: em28xx: Fix use-after-free when disconnecting into stable for 4.14, 4.9, and 4.4. I have verified it applies on 4.14.84, 4.9.141, and 4.4.165. thanks, Steve

6 years, 9 months

2
1
0 0

stable-rc/linux-4.14.y boot: 64 boots: 0 failed, 63 passed with 1 untried/unknown (v4.14.85)

by kernelci.org bot

stable-rc/linux-4.14.y boot: 64 boots: 0 failed, 63 passed with 1 untried/unknown (v4.14.85) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-4.14.y/kernel/v4.1… Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-4.14.y/kernel/v4.14.85/ Tree: stable-rc Branch: linux-4.14.y Git Describe: v4.14.85 Git Commit: 5ff1ad556aad473952c1caca6092aac4517ac1ae Git URL: http://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Tested: 28 unique boards, 13 SoC families, 9 builds out of 197 --- For more info write to <info(a)kernelci.org>

6 years, 9 months

1
0
0 0

stable-rc/linux-4.4.y boot: 51 boots: 1 failed, 50 passed (v4.4.166)

by kernelci.org bot

stable-rc/linux-4.4.y boot: 51 boots: 1 failed, 50 passed (v4.4.166) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-4.4.y/kernel/v4.4.… Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-4.4.y/kernel/v4.4.166/ Tree: stable-rc Branch: linux-4.4.y Git Describe: v4.4.166 Git Commit: 56ccc3f7a7ee1f0ab64453794ebbc7d9a4c8ddf7 Git URL: http://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Tested: 19 unique boards, 9 SoC families, 8 builds out of 187 Boot Failure Detected: arm64: defconfig qcom-qdf2400: 1 failed lab --- For more info write to <info(a)kernelci.org>

6 years, 9 months

1
0
0 0

stable-rc/linux-4.19.y boot: 64 boots: 0 failed, 63 passed with 1 untried/unknown (v4.19.6)

by kernelci.org bot

stable-rc/linux-4.19.y boot: 64 boots: 0 failed, 63 passed with 1 untried/unknown (v4.19.6) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-4.19.y/kernel/v4.1… Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-4.19.y/kernel/v4.19.6/ Tree: stable-rc Branch: linux-4.19.y Git Describe: v4.19.6 Git Commit: 96db90800c06d3fe3fa08eb6222fe201286bb778 Git URL: http://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Tested: 30 unique boards, 14 SoC families, 10 builds out of 202 --- For more info write to <info(a)kernelci.org>

6 years, 9 months

1
0
0 0

stable-rc/linux-4.9.y boot: 54 boots: 0 failed, 54 passed (v4.9.142)

by kernelci.org bot

stable-rc/linux-4.9.y boot: 54 boots: 0 failed, 54 passed (v4.9.142) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-4.9.y/kernel/v4.9.… Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-4.9.y/kernel/v4.9.142/ Tree: stable-rc Branch: linux-4.9.y Git Describe: v4.9.142 Git Commit: 68ae960f6d2aac4289d8872cbc4e1d79d4934e70 Git URL: http://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Tested: 20 unique boards, 10 SoC families, 9 builds out of 193 --- For more info write to <info(a)kernelci.org>

6 years, 9 months

1
0
0 0

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

by Hans de Goede

Hi, On 01-11-18 07:55, Mogens Jensen wrote: > ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ > On Wednesday, October 31, 2018 9:29 AM, Hans de Goede <hdegoede(a)redhat.com> wrote: > >> Hi, >> >> On 31-10-18 07:02, Mogens Jensen wrote: >> >>> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ >>> On Tuesday, October 30, 2018 7:10 PM, Hans de Goede hdegoede(a)redhat.com wrote: >>> >>>> Hi, >>>> On 30-10-18 19:56, Mogens Jensen wrote: >>>> >>>>> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ >>>>> On Tuesday, October 30, 2018 4:04 PM, Hans de Goede hdegoede(a)redhat.com wrote: >>>>> >>>>>> Hi, >>>>>> On 30-10-18 16:46, Hans de Goede wrote: >>>>>> >>>>>>> Hi, >>>>>>> On 30-10-18 16:04, Pierre-Louis Bossart wrote: >>>>>>> >>>>>>>> In addition I am not aware of any baytrail device using plt_clk_0, so moving a common machine driver such a cht_bsw_max98090_ti to use plt_clk0 only would break other devices (e.g. Rambi/Orco). Asking for both clocks to be on might work though, >>>>>>> >>>>>>> Ok, so we need to have a DMI based quirk for the Swanky and maybe also >>>>>>> the clapper to use plt_clk_0 there. Asking for 2 clks if we only need >>>>>>> one does not seem like a good plan. >>>>>> >>>>>> Dean, Mogens, >>>>>> To write a proper patch for this I'm going to need DMI strings >>>>>> from your devices. >>>>>> Can you please run (as normal user): >>>>>> grep . /sys/class/dmi/id/* 2> /dev/null >>>>>> And reply with the output of this command? >>>>>> I have attached the output from a coreboot seabios based clapper. >>>> >>>> Thank you. >>>> >>>>> Should I still test 0001-ASoC-intel-cht_bsw_max98090_ti-Use-pmc_plt_clk_0-ins.patch with SND_SOC_INTEL_CHT_BSW_MAX98090_TI_MACH and asoundrc from Dean? There seems to have been some development in the case since that request was made. >>>> >>>> Yes please test that, I expect that to also fix things for the >>>> Clapper, but I need to have that confirmed before submitting a >>>> patch upstream adding a quirk for the Clapper to use pmc_plt_clk_0 >>>> instead of pmc_plt_clk_3. >>>> Regards, >>>> Hans >>> >>> Unfortunately I only have access to longterm kernel 4.14 for building/running on this system, and 0001-ASoC-intel-cht_bsw_max98090_ti-Use-pmc_plt_clk_0-ins.patch does not patch against 4.14.78. Can a test patch for 4.14 be created? >> >> Can you run (as root): >> >> for i in /sys/kernel/debug/clk/pmc_plt_clk_?; do echo -n "$i: "; cat $i/clk_flags; echo; done >> >> When running a kernel with working audio? >> >> Then I can confirm that the Clapper is also using pmc_plt_clk_0, so that I can >> fix this for the clapper for 4.18+ >> >> I've just checked the 4.14 sources and in 4.14 the SND_SOC_INTEL_CHT_BSW_MAX98090_TI_MACH >> driver does not support mclk control yet, so for the 4.14 kernel the only way to >> fix this is to revert the 648e921888ad ("clk: x86: Stop marking clocks as CLK_IS_CRITICAL") >> commit. >> >> Regards, >> >> Hans >> > Here is the output from the Clapper with 4.14.78 and working sound: > > /sys/kernel/debug/clk/pmc_plt_clk_0: 0x00000800 > /sys/kernel/debug/clk/pmc_plt_clk_1: 0x00000000 > /sys/kernel/debug/clk/pmc_plt_clk_2: 0x00000000 > /sys/kernel/debug/clk/pmc_plt_clk_3: 0x00000000 > /sys/kernel/debug/clk/pmc_plt_clk_4: 0x00000000 > /sys/kernel/debug/clk/pmc_plt_clk_5: 0x00000000 Ok, so your Clapper model indeed is also using clk 0 and not clk 3 as expected. I've just submitted a patch upstream adding a quirk for this. As for what the plan is with 4.14, I don't know. I believe that reverting the commit causing the issue there is fine. Regards, Hans

6 years, 9 months

1
0
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-stable-mirror