On Fri, Nov 08, 2024 at 10:42:56AM +0100, Andrea della Porta wrote:
When populating "ranges" property for a PCI bridge or endpoint, of_pci_prop_ranges() incorrectly use the CPU bus address of the resource. In such PCI nodes, the window should instead be in PCI address space. Call pci_bus_address() on the resource in order to obtain the PCI bus address.
Fixes: 407d1a51921e ("PCI: Create device tree node for bridge") Cc: stable@vger.kernel.org Signed-off-by: Andrea della Porta andrea.porta@suse.com Acked-by: Bjorn Helgaas bhelgaas@google.com Tested-by: Herve Codina herve.codina@bootlin.com
I picked this up on pci/of for v6.13, thanks! Rob, let me know if you'd prefer to take it or ack/review it.
This patch, originally preparatory for a bigger patchset (see [1]), has been splitted in a standalone one for better management and because it contains a bugfix which is probably of interest to stable branch.
drivers/pci/of_property.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/of_property.c b/drivers/pci/of_property.c index 5a0b98e69795..886c236e5de6 100644 --- a/drivers/pci/of_property.c +++ b/drivers/pci/of_property.c @@ -126,7 +126,7 @@ static int of_pci_prop_ranges(struct pci_dev *pdev, struct of_changeset *ocs, if (of_pci_get_addr_flags(&res[j], &flags)) continue;
val64 = res[j].start;
val64 = pci_bus_address(pdev, &res[j] - pdev->resource);-- 2.35.3