Re: [PATCH] platform/chrome: cros_ec_debugfs: fix wrong EC message version

On Tue, Jun 11, 2024 at 4:31 AM Tzung-Bi Shih tzungbi@kernel.org wrote:

ec_read_version_supported() uses ec_params_get_cmd_versions_v1 but it wrongly uses message version 0.

Fix it.

Cc: stable@vger.kernel.org Fixes: e86264595225 ("mfd: cros_ec: add debugfs, console log file") Signed-off-by: Tzung-Bi Shih tzungbi@kernel.org

Reviewed-by: Guenter Roeck groeck@chromium.org

---

drivers/platform/chrome/cros_ec_debugfs.c | 1 + 1 file changed, 1 insertion(+)

diff --git a/drivers/platform/chrome/cros_ec_debugfs.c b/drivers/platform/chrome/cros_ec_debugfs.c index f0e9efb543df..4525ad1b59f4 100644 --- a/drivers/platform/chrome/cros_ec_debugfs.c +++ b/drivers/platform/chrome/cros_ec_debugfs.c @@ -334,6 +334,7 @@ static int ec_read_version_supported(struct cros_ec_dev *ec) if (!msg) return 0;

•   msg->version = 1;
    msg->command = EC_CMD_GET_CMD_VERSIONS + ec->cmd_offset;
    msg->outsize = sizeof(*params);
    msg->insize = sizeof(*response);
  

-- 2.45.2.505.gda0bf45e8d-goog