3.16.63-rc1 review patch. If anyone has any objections, please let me know.
------------------
From: Dan Carpenter dan.carpenter@oracle.com
commit 2043e1fd09c1896bb03a6e25b64baa84a30879c9 upstream.
We should be returning an error code here instead of success. Either -ENODEV or -ENOMEM would work. There is also a failure message in printk().
Signed-off-by: Dan Carpenter dan.carpenter@oracle.com Acked-by: Chad Dupuis chad.dupuis@qlogic.com Signed-off-by: Christoph Hellwig hch@lst.de Signed-off-by: Ben Hutchings ben@decadent.org.uk --- drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 1 + 1 file changed, 1 insertion(+)
--- a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c +++ b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c @@ -2201,6 +2201,7 @@ static int _bnx2fc_create(struct net_dev interface = bnx2fc_interface_create(hba, netdev, fip_mode); if (!interface) { printk(KERN_ERR PFX "bnx2fc_interface_create failed\n"); + rc = -ENOMEM; goto ifput_err; }