6.17-stable review patch. If anyone has any objections, please let me know.
------------------
From: Li Chen me@linux.beauty
commit 98b7bf54338b797e3a11e8178ce0e806060d8fa3 upstream.
loop_change_fd() and loop_configure() call loop_check_backing_file() to validate the new backing file. If validation fails, the reference acquired by fget() was not dropped, leaking a file reference.
Fix this by calling fput(file) before returning the error.
Cc: stable@vger.kernel.org Cc: Markus Elfring Markus.Elfring@web.de CC: Yang Erkun yangerkun@huawei.com Cc: Ming Lei ming.lei@redhat.com Cc: Yu Kuai yukuai1@huaweicloud.com Fixes: f5c84eff634b ("loop: Add sanity check for read/write_iter") Signed-off-by: Li Chen chenl311@chinatelecom.cn Reviewed-by: Ming Lei ming.lei@redhat.com Reviewed-by: Yang Erkun yangerkun@huawei.com Signed-off-by: Jens Axboe axboe@kernel.dk Signed-off-by: Greg Kroah-Hartman gregkh@linuxfoundation.org --- drivers/block/loop.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
--- a/drivers/block/loop.c +++ b/drivers/block/loop.c @@ -551,8 +551,10 @@ static int loop_change_fd(struct loop_de return -EBADF;
error = loop_check_backing_file(file); - if (error) + if (error) { + fput(file); return error; + }
/* suppress uevents while reconfiguring the device */ dev_set_uevent_suppress(disk_to_dev(lo->lo_disk), 1); @@ -993,8 +995,10 @@ static int loop_configure(struct loop_de return -EBADF;
error = loop_check_backing_file(file); - if (error) + if (error) { + fput(file); return error; + }
is_loop = is_loop_device(file);