Re: [PATCH v2 2/2] scsi: core: remove command size deduction from scsi_setup_scsi_cmnd

On 11/3/21 10:06 AM, Tadeusz Struk wrote:

diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c index 572673873ddf..e026da7549be 100644 --- a/drivers/scsi/scsi_lib.c +++ b/drivers/scsi/scsi_lib.c @@ -1174,8 +1174,6 @@ static blk_status_t scsi_setup_scsi_cmnd(struct scsi_device *sdev, } cmd->cmd_len = scsi_req(req)->cmd_len;

• if (cmd->cmd_len == 0)

• cmd->cmd_len = scsi_command_size(cmd->cmnd);
  

  cmd->cmnd = scsi_req(req)->cmd; cmd->transfersize = blk_rq_bytes(req); cmd->allowed = scsi_req(req)->retries;

Reviewed-by: Bart Van Assche bvanassche@acm.org