26 Sep
2023
26 Sep
'23
9:39 p.m.
Hi Ilpo,
On 9/15/2023 8:44 AM, Ilpo Järvinen wrote:
Currently, _GNU_SOURCE is defined in resctrl.h. Defining _GNU_SOURCE
nitpick: If you do submit a new version, could you please drop the "Currently".
has a large impact on what gets defined when including headers either before or after it. This can result in compile failures if .c file decides to include a standard header file before resctrl.h.
It is safer to define _GNU_SOURCE in Makefile so it is always defined regardless of in which order includes are done.
Signed-off-by: Ilpo Järvinen ilpo.jarvinen@linux.intel.com Cc: stable@vger.kernel.org
Thank you.
Reviewed-by: Reinette Chatre reinette.chatre@intel.com
Reinette