On Tue, Jan 09, 2024 at 10:51:15AM +0300, Dan Carpenter wrote:
On Tue, Jan 09, 2024 at 01:14:59PM +0900, Hidenori Kobayashi wrote:
The imgu driver fails to probe because it does not set the pad's flags before calling media_entity_pads_init(). Fix the initialization order so that the driver probe succeeds. The ops initialization is also moved together for readability.
Wait, I was really hoping you would include these lines in the commit message:
the imgu driver fails to probe with the following message:
[ 14.596315] ipu3-imgu 0000:00:05.0: failed initialize subdev media entity (-22) [ 14.596322] ipu3-imgu 0000:00:05.0: failed to register subdev0 ret (-22) [ 14.596327] ipu3-imgu 0000:00:05.0: failed to register pipes (-22) [ 14.596331] ipu3-imgu 0000:00:05.0: failed to create V4L2 devices (-22)
That's what people will search for when they run intio the problem. Could you please resend a v3? Normally, editing a commit message is pretty easy, right?
regards, dan carpenter
Ah, I misunderstood then, sorry. I will add the error lines to the commit messages and send a v3.
Hidenori