Re: [PATCH v2] fix missing sb_min_blocksize() return value checks in some filesystems

Yongpeng Yang yangyongpeng.storage@gmail.com writes:

diff --git a/fs/fat/inode.c b/fs/fat/inode.c index 9648ed097816..d22eec4f17b2 100644 --- a/fs/fat/inode.c +++ b/fs/fat/inode.c @@ -1535,7 +1535,7 @@ int fat_fill_super(struct super_block *sb, struct fs_context *fc, void (*setup)(struct super_block *)) { struct fat_mount_options *opts = fc->fs_private;

• int silent = fc->sb_flags & SB_SILENT;

• int silent = fc->sb_flags & SB_SILENT, blocksize; struct inode *root_inode = NULL, *fat_inode = NULL; struct inode *fsinfo_inode = NULL; struct buffer_head *bh;

@@ -1595,8 +1595,13 @@ int fat_fill_super(struct super_block *sb, struct fs_context *fc, setup(sb); /* flavour-specific stuff that needs options */

• error = -EINVAL;
• blocksize = sb_min_blocksize(sb, 512);
• if (!blocksize) {

if (!sb_min_blocksize(sb, 512)) {

Looks like this one is enough?

• fat_msg(sb, KERN_ERR, "unable to set blocksize");
  

• goto out_fail;
  

• }