Hi, This set adds and enforces 1 second minimum value for bridge multicast query and startup query intervals in order to avoid rearming the timers too often which could lock and crash the host. I doubt anyone is using such low values or anything lower than 1 second, so it seems like a good minimum. In order to be compatible if the value is lower then it is overwritten and a log message is emitted, since we can't return an error at this point.
Eric, I looked for the syzbot reports in its dashboard but couldn't find them so I've added you as the reporter. If you point me to the reports I can respin to give syzbot the credit.
I've prepared a global bridge igmp rate limiting patch but wasn't sure if it's ok for -net. It adds a static limit of 32k packets per second, I plan to send it for net-next with added drop counters for each bridge so it can be easily debugged.
Original report can be seen at: https://lore.kernel.org/netdev/e8b9ce41-57b9-b6e2-a46a-ff9c791cf0ba@gmail.co...
Thanks, Nik
Nikolay Aleksandrov (2): net: bridge: mcast: add and enforce query interval minimum net: bridge: mcast: add and enforce startup query interval minimum
net/bridge/br_multicast.c | 32 ++++++++++++++++++++++++++++++++ net/bridge/br_netlink.c | 4 ++-- net/bridge/br_private.h | 6 ++++++ net/bridge/br_sysfs_br.c | 4 ++-- net/bridge/br_vlan_options.c | 4 ++-- 5 files changed, 44 insertions(+), 6 deletions(-)