From: Adam Queler queler@gmail.com
[ Upstream commit 949ddec3728f3a793a13c1c9003028b9b159aefc ]
This model requires an additional detection quirk to enable the internal microphone.
Signed-off-by: Adam Queler queler+k@gmail.com Link: https://patch.msgid.link/20250715031434.222062-1-queler+k@gmail.com Signed-off-by: Mark Brown broonie@kernel.org Signed-off-by: Sasha Levin sashal@kernel.org ---
LLM Generated explanations, may be completely bogus:
**YES**
This commit should be backported to stable kernel trees. Here's my extensive analysis:
## Nature of the Change
This commit adds a simple DMI (Desktop Management Interface) quirk entry for the HP Victus Gaming Laptop 15-fb1xxx model to enable internal microphone support. The change is: - Adding a new entry to the `yc_acp_quirk_table[]` array - The entry matches DMI_BOARD_VENDOR "HP" and DMI_PRODUCT_NAME "Victus by HP Gaming Laptop 15-fb1xxx" - Associates the match with `&acp6x_card` driver data
## Comparison with Similar Commits
All 5 similar commits with "Backport Status: YES" follow the exact same pattern: 1. They add DMI entries for HP laptops (HP OMEN, HP Victus) or other brands 2. They enable internal microphone functionality for specific hardware models 3. They are minimal, self-contained changes adding only DMI match entries 4. They fix hardware enablement issues that affect users
## Backport Suitability Analysis
**Reasons this qualifies for stable backporting:**
1. **Bug Fix**: This fixes a hardware functionality issue where the internal microphone doesn't work on HP Victus 15-fb1xxx laptops without this quirk
2. **User Impact**: Without this patch, users of this specific laptop model cannot use their internal microphone, which is a significant functionality regression
3. **Minimal Risk**: The change is: - Extremely localized (only adds one DMI entry) - Cannot affect other hardware (DMI matching is specific to this model) - Uses the same pattern as dozens of other entries in the same table - No algorithmic changes or new features
4. **Self-Contained**: The patch is completely self-contained with no dependencies on other changes
5. **Hardware Enablement**: This falls under the stable tree criteria for "hardware that is broken by design and needs a quirk"
6. **Precedent**: The git history shows numerous similar DMI quirk additions for this driver have been backported to stable
## Code Safety Analysis
The code change is safe because: - It only adds a static data structure entry - The DMI matching system is well-established and reliable - The `acp6x_card` driver data is already used by many other entries - No memory allocations, no new logic paths, no behavioral changes for existing hardware
This is a textbook example of a stable-appropriate patch: it fixes a real user-facing bug with minimal risk and follows established patterns.
sound/soc/amd/yc/acp6x-mach.c | 7 +++++++ 1 file changed, 7 insertions(+)
diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c index 1f4c43bf817e4..fce918a089e37 100644 --- a/sound/soc/amd/yc/acp6x-mach.c +++ b/sound/soc/amd/yc/acp6x-mach.c @@ -458,6 +458,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = { DMI_MATCH(DMI_PRODUCT_NAME, "OMEN by HP Gaming Laptop 16z-n000"), } }, + { + .driver_data = &acp6x_card, + .matches = { + DMI_MATCH(DMI_BOARD_VENDOR, "HP"), + DMI_MATCH(DMI_PRODUCT_NAME, "Victus by HP Gaming Laptop 15-fb1xxx"), + } + }, { .driver_data = &acp6x_card, .matches = {