On Wed, Jun 09, 2021 at 08:25:47PM -0400, Pascal Giard wrote:
On Sat, Jun 5, 2021 at 2:44 AM Greg KH gregkh@linuxfoundation.org wrote:
On Fri, Jun 04, 2021 at 12:10:23PM -0400, Pascal Giard wrote:
This commit fixes a freeze on insertion of a Guitar Hero Live PS3/WiiU USB dongle. Indeed, with the current implementation, inserting one of those USB dongles will lead to a hard freeze. I apologize for not catching this earlier, it didn't occur on my old laptop.
While the issue was isolated to memory alloc/free, I could not figure out why it causes a freeze. So this patch fixes this issue by simplifying memory allocation and usage.
We remind that for the dongle to work properly, a control URB needs to be sent periodically. We used to alloc/free the URB each time this URB needed to be sent.
With this patch, the memory for the URB is allocated on the probe, reused for as long as the dongle is plugged in, and freed once the dongle is unplugged.
Signed-off-by: Pascal Giard pascal.giard@etsmtl.ca
drivers/hid/hid-sony.c | 98 +++++++++++++++++++++--------------------- 1 file changed, 49 insertions(+), 49 deletions(-)
<formletter>
This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly.
</formletter>
Dear Greg,
I apologize for failing to follow the procedure. I had already read these guidelines, and I actually thought I was following Option 1 :-/
Is this commit already in Linus's tree? If so then we just need a git commit id and we can queue it up.
I thought that I had to get my patch merged into next first (patch against dtor's git) and that by adding stable@ as CC, it would automatically get considered for inclusion into stable once merged into Linus' tree. Based on your email, I got that wrong...
It will, but you need to add that to the signed-off-by: area, as the document says.
thanks,
greg k-h