Hello Diederik,
On Wed, Oct 15, 2025 at 03:21:48PM +0200, Diederik de Haas wrote:
On Wed Oct 15, 2025 at 2:31 PM CEST, Niklas Cassel wrote:
The L1 substates support requires additional steps to work, see e.g. section '11.6.6.4 L1 Substate' in the RK3588 TRM V1.0.
I visually compared '18.6.6 PCIe Power Management' of Part 2 V1.1 (20210301) of the RK3568 TRM with '11.6.6 PCIe Power Management' of Part 2 V1.0 (20220309) of the RK3588 TRM. AFAICT they are word for word the same ... until I got to 'Table 18-14 PCIe Interrupt Table' (RK3568) and 'Table 11-22 ...' (RK3588) where there are differences. I don't understand enough of this material so I would appreciate if you could take a look to see if that difference is or could be relevant.
What you should compare is "18.6.6.4 L1 Substate" of RK3658 TRM Part2 V1.1, vs "11.6.6.4 L1 Substate" of RK3588 TRM Part2 V1.0.
But I have just done that, and I can tell you that they are identical.
Shawn also replied here: https://lore.kernel.org/linux-pci/7df0bf91-8ab1-4e76-83fa-841a4059c634@rock-...
that there is indeed a lot of things missing for L1 substates to work, including proper pinmuxing.
Kind regards, Niklas