11 Oct
2023
11 Oct
'23
9:54 p.m.
On 10/11/23 2:20 PM, Jens Axboe wrote:
On 10/11/23 2:12 PM, Sarthak Kukreti wrote:
Only call truncate_bdev_range() if the fallocate mode is supported. This fixes a bug where data in the pagecache could be invalidated if the fallocate() was called on the block device with an invalid mode.
Fix looks fine, but would be nicer if we didn't have to duplicate the truncate_bdev_range() in each switch clause. Can we check this upfront instead?
Don't see a good way to do it on my end, so let's just go with what is there now. I applied it with the commit message reformatted.
--
Jens Axboe