Re: [PATCH] x86/xen: disable Firmware First mode for correctable memory errors

On 25.09.2020 15:45, boris.ostrovsky@oracle.com wrote:

On 9/25/20 6:11 AM, Juergen Gross wrote:

...

@@ -1296,6 +1296,14 @@ asmlinkage __visible void __init xen_start_kernel(void) xen_smp_init(); +#ifdef CONFIG_ACPI

• /*

• * Disable selecting "Firmware First mode" for correctable memory
  

• * errors, as this is the duty of the hypervisor to decide.
  

• */
  

• acpi_disable_cmcff = 1;

+#endif

Not that it matters greatly but should this go under if (xen_initial_domain()) clause a bit further down?

Yes - DomU-s are supposed to be in charge of their (virtual) firmware, no matter that right now APEI for guests is completely out of sight as far as I'm aware.

Jan