Re: [PATCH] slimbus: ngd: Fix reference count leak in qcom_slim_ngd_notify_slaves

On Mon, Oct 27, 2025 at 02:06:01PM +0800, Miaoqian Lin wrote:

The function qcom_slim_ngd_notify_slaves() calls of_slim_get_device() which internally uses device_find_child() to obtain a device reference. According to the device_find_child() documentation, the caller must drop the reference with put_device() after use.

Found via static analysis and this is similar to commit 4e65bda8273c ("ASoC: wcd934x: fix error handling in wcd934x_codec_parse_data()")

Fixes: 917809e2280b ("slimbus: ngd: Add qcom SLIMBus NGD driver") Cc: stable@vger.kernel.org Signed-off-by: Miaoqian Lin linmq006@gmail.com

---

drivers/slimbus/qcom-ngd-ctrl.c | 1 + 1 file changed, 1 insertion(+)

Reviewed-by: Dmitry Baryshkov dmitry.baryshkov@oss.qualcomm.com