Re: [PATCH] drbd: correctly submit flush bio on barrier

On Wed, 03 May 2023 14:19:37 +0200, Christoph Böhmwalder wrote:

When we receive a flush command (or "barrier" in DRBD), we currently use a REQ_OP_FLUSH with the REQ_PREFLUSH flag set.

The correct way to submit a flush bio is by using a REQ_OP_WRITE without any data, and set the REQ_PREFLUSH flag.

Since commit b4a6bb3a67aa ("block: add a sanity check for non-write flush/fua bios"), this triggers a warning in the block layer, but this has been broken for quite some time before that.

[...]

Applied, thanks!

[1/1] drbd: correctly submit flush bio on barrier commit: 3899d94e3831ee07ea6821c032dc297aec80586a

Best regards,