Re: [PATCH 3/3] vfs: return -EOVERFLOW in generic_remap_checks() when overflow check fails

On Fri, Sep 20, 2024 at 08:30:22PM +0800, Julian Sun wrote:

Keep it consistent with the handling of the same check within generic_copy_file_checks(). Also, returning -EOVERFLOW in this case is more appropriate.

Maybe:

Keep the errno value consistent with the equivalent check in generic_copy_file_checks() that returns -EOVERFLOW, which feels like the more appropriate value to return compared to the overly generic -EINVAL.

Otherwise looks good:

Reviewed-by: Christoph Hellwig hch@lst.de