From: Raven Black ravenblack@gmail.com
[ Upstream commit 13b86ea92ebf0fa587fbadfb8a60ca2e9993203f ]
Make the internal microphone work on HP Victus laptops.
Signed-off-by: Raven Black ravenblack@gmail.com Link: https://patch.msgid.link/20250613-support-hp-victus-microphone-v1-1-bebc4c3a... Signed-off-by: Mark Brown broonie@kernel.org Signed-off-by: Sasha Levin sashal@kernel.org ---
**YES**
This commit should be backported to stable kernel trees. Here's my extensive analysis:
## Analysis of the Commit
### 1. **Nature of the Change** The commit adds a simple DMI (Desktop Management Interface) quirk entry to enable the internal microphone on HP Victus Gaming Laptop 15-fb2xxx. The change consists of adding just 7 lines to the `yc_acp_quirk_table[]` array:
```c + { + .driver_data = &acp6x_card, + .matches = { + DMI_MATCH(DMI_BOARD_VENDOR, "HP"), + DMI_MATCH(DMI_PRODUCT_NAME, "Victus by HP Gaming Laptop 15-fb2xxx"), + } + }, ```
### 2. **Comparison with Similar Commits** All 5 historical similar commits provided were marked as "Backport Status: YES" and share identical characteristics: - Same file modified (sound/soc/amd/yc/acp6x-mach.c) - Same type of change (adding DMI quirk entries) - Same purpose (enabling internal microphone on specific laptop models) - Similar commit messages mentioning microphone support - All are HP laptop models (except one MECHREVO)
### 3. **Meets Stable Backport Criteria**
**✓ Fixes a real bug affecting users**: Without this quirk, the internal microphone on HP Victus Gaming Laptop 15-fb2xxx doesn't work, which is a functional regression for users of this hardware.
**✓ Small and contained change**: The patch is minimal - only 7 lines adding a DMI match entry to an existing quirk table. No logic changes, no new features.
**✓ No architectural changes**: This is a simple hardware enablement quirk, not modifying any kernel architecture.
**✓ Minimal risk of regression**: - The change only affects systems that match the specific DMI strings - Cannot affect other hardware configurations - Uses the same `acp6x_card` driver data as other entries - Pattern is well-established in the codebase
**✓ Hardware enablement**: This is pure hardware enablement for audio functionality, which is a common reason for stable backports.
### 4. **Technical Safety** The code change: - Adds to an existing array without modifying existing entries - Uses standard DMI matching infrastructure - Follows the exact same pattern as dozens of other entries in the same table - The `acp6x_card` structure is already defined and used by many other entries
### 5. **User Impact** Users of HP Victus Gaming Laptop 15-fb2xxx running stable kernels would benefit from having their internal microphone work correctly without waiting for the next major kernel release.
This commit is an ideal candidate for stable backporting as it's a minimal, safe hardware enablement fix that follows well-established patterns in the codebase.
sound/soc/amd/yc/acp6x-mach.c | 7 +++++++ 1 file changed, 7 insertions(+)
diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c index 9ce4339680e35..dce17f0bfab9e 100644 --- a/sound/soc/amd/yc/acp6x-mach.c +++ b/sound/soc/amd/yc/acp6x-mach.c @@ -507,6 +507,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = { DMI_MATCH(DMI_PRODUCT_NAME, "OMEN by HP Gaming Laptop 16z-n000"), } }, + { + .driver_data = &acp6x_card, + .matches = { + DMI_MATCH(DMI_BOARD_VENDOR, "HP"), + DMI_MATCH(DMI_PRODUCT_NAME, "Victus by HP Gaming Laptop 15-fb2xxx"), + } + }, { .driver_data = &acp6x_card, .matches = {