On Tue, Jan 28, 2020 at 12:28:15PM +0200, Jouni Högander wrote:
Hello Greg,
jouni.hogander@unikie.com (Jouni Högander) writes:
Greg Kroah-Hartman gregkh@linuxfoundation.org writes:
Now queued up, I'll push out -rc2 versions with this fix.
greg k-h
We have also been informed about another regression these two commits are causing:
https://lore.kernel.org/lkml/ace19af4-7cae-babd-bac5-cd3505dcd874@I-love.SAK...
I suggest to drop these two patches from this queue, and give us a week to shake out the regressions of the change, and once ready, we can include the complete set of fixes to stable (probably in a week or two).
Ok, thanks for the information, I've now dropped them from all of the queues that had them in them.
greg k-h
I have now run more extensive Syzkaller testing on following patches:
cb626bf566eb net-sysfs: Fix reference count leak ddd9b5e3e765 net-sysfs: Call dev_hold always in rx_queue_add_kobject e0b60903b434 net-sysfs: Call dev_hold always in netdev_queue_add_kobje 48a322b6f996 net-sysfs: fix netdev_queue_add_kobject() breakage b8eb718348b8 net-sysfs: Fix reference count leak in rx|netdev_queue_add_kobject
These patches are fixing couple of memory leaks including this one found by Syzbot: https://syzkaller.appspot.com/bug?extid=ad8ca40ecd77896d51e2
I can reproduce these memory leaks in following stable branches: 4.14, 4.19, and 5.4.
These are all now merged into net/master tree and based on my testing they are ready to be taken into stable branches as well.
Best Regards,
Jouni Högander
These four patches are still missing from 4.14 and 4.19 branches:
ddd9b5e3e765 net-sysfs: Call dev_hold always in rx_queue_add_kobject e0b60903b434 net-sysfs: Call dev_hold always in netdev_queue_add_kobje 48a322b6f996 net-sysfs: fix netdev_queue_add_kobject() breakage b8eb718348b8 net-sysfs: Fix reference count leak in rx|netdev_queue_add_kobject
Could you please consider taking them in or let me know if you want some further activities from my side?
Thanks for the list, I have now queued these all up.
greg k-h