Re: [PATCH v2] arm64: vdso: remove commas between macro name and arguments

On Fri, 16 Apr 2021 at 22:35, Jian Cai jiancai@google.com wrote:

LLVM's integrated assembler does not support using commas separating the name and arguments in .macro. However, only spaces are used in the manual page. This replaces commas between macro names and the subsequent arguments with space in calls to clock_gettime_return to make it compatible with IAS.

Link: https://sourceware.org/binutils/docs/as/Macro.html#Macro https://github.com/ClangBuiltLinux/linux/issues/1349

Suggested-by: Ard Biesheuvel ardb@kernel.org

Please remove this tag - the only thing I suggested was to drop part of the original patch.

Signed-off-by: Jian Cai jiancai@google.com

Changes v1 -> v2: Keep the comma in the macro definition to be consistent with other definitions.

arch/arm64/kernel/vdso/gettimeofday.S | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/kernel/vdso/gettimeofday.S b/arch/arm64/kernel/vdso/gettimeofday.S index 856fee6d3512..b6faf8b5d1fe 100644 --- a/arch/arm64/kernel/vdso/gettimeofday.S +++ b/arch/arm64/kernel/vdso/gettimeofday.S @@ -227,7 +227,7 @@ realtime: seqcnt_check fail=realtime get_ts_realtime res_sec=x10, res_nsec=x11, \ clock_nsec=x15, xtime_sec=x13, xtime_nsec=x14, nsec_to_sec=x9

•   clock_gettime_return, shift=1
  

•   clock_gettime_return shift=1
  
    ALIGN
  

monotonic: @@ -250,7 +250,7 @@ monotonic: clock_nsec=x15, xtime_sec=x13, xtime_nsec=x14, nsec_to_sec=x9

    add_ts sec=x10, nsec=x11, ts_sec=x3, ts_nsec=x4, nsec_to_sec=x9

•   clock_gettime_return, shift=1
  

•   clock_gettime_return shift=1
  
    ALIGN
  

monotonic_raw: @@ -271,7 +271,7 @@ monotonic_raw: clock_nsec=x15, nsec_to_sec=x9

    add_ts sec=x10, nsec=x11, ts_sec=x13, ts_nsec=x14, nsec_to_sec=x9

•   clock_gettime_return, shift=1
  

•   clock_gettime_return shift=1
  
    ALIGN
  

realtime_coarse:

2.31.1.368.gbe11c130af-goog