5.10-stable review patch. If anyone has any objections, please let me know.
------------------
From: David Lechner dlechner@baylibre.com
[ Upstream commit 0cf81c73e4c6a4861128a8f27861176ec312af4e ]
The TI eQEP clock is both a functional and interface clock. Since it is required for the device to function, we should be enabling it at probe.
Up to now, we've just been lucky that the clock was enabled by something else on the system already.
Fixes: f213729f6796 ("counter: new TI eQEP driver") Reviewed-by: Judith Mendez jm@ti.com Signed-off-by: David Lechner dlechner@baylibre.com Link: https://lore.kernel.org/r/20240621-ti-eqep-enable-clock-v2-1-edd3421b54d4@ba... Signed-off-by: William Breathitt Gray wbg@kernel.org Signed-off-by: Sasha Levin sashal@kernel.org --- drivers/counter/ti-eqep.c | 6 ++++++ 1 file changed, 6 insertions(+)
diff --git a/drivers/counter/ti-eqep.c b/drivers/counter/ti-eqep.c index 65df9ef5b5bc0..6343998819296 100644 --- a/drivers/counter/ti-eqep.c +++ b/drivers/counter/ti-eqep.c @@ -6,6 +6,7 @@ */
#include <linux/bitops.h> +#include <linux/clk.h> #include <linux/counter.h> #include <linux/kernel.h> #include <linux/mod_devicetable.h> @@ -349,6 +350,7 @@ static int ti_eqep_probe(struct platform_device *pdev) struct device *dev = &pdev->dev; struct ti_eqep_cnt *priv; void __iomem *base; + struct clk *clk; int err;
priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); @@ -388,6 +390,10 @@ static int ti_eqep_probe(struct platform_device *pdev) pm_runtime_enable(dev); pm_runtime_get_sync(dev);
+ clk = devm_clk_get_enabled(dev, NULL); + if (IS_ERR(clk)) + return dev_err_probe(dev, PTR_ERR(clk), "failed to enable clock\n"); + err = counter_register(&priv->counter); if (err < 0) { pm_runtime_put_sync(dev);