Hello,
Schrempf Frieder frieder.schrempf@kontron.de wrote on Tue, 25 Jun 2019 07:04:06 +0000:
Hi liaoweixiong,
On 25.06.19 05:08, Greg KH wrote:
On Tue, Jun 25, 2019 at 09:02:29AM +0800, liaoweixiong wrote:
In case of the last page containing bitflips (ret > 0), spinand_mtd_read() will return that number of bitflips for the last page. But to me it looks like it should instead return max_bitflips like it does when the last page read returns with 0.
Signed-off-by: liaoweixiong liaoweixiong@allwinnertech.com
Please write your entire official first/last name(s)
Reviewed-by: Boris Brezillon boris.brezillon@collabora.com Reviewed-by: Frieder Schrempf frieder.schrempf@kontron.de
I am waiting your next version with Acked-by instead of Rewieved-by tags and Greg's comment addressed.
Fixes: 7529df465248 ("mtd: nand: Add core infrastructure to support SPI NANDs")
Finally, when we ask you to resend a patch, it means sending a new version of the patch. So in the subject, you should not use the [RESEND] keyword (which means you are sending something again exactly as it was before, you just got ignored, for example) but instead you should increment the version number (v3) and also write a nice changelog after the three dashes '---' (will be ignored by Git when applying).
I would like to queue this for the next release so if you can do it ASAP, that would be great.
Thank you, Miquèl