On Wed, Apr 30, 2025 at 09:46:00AM +0200, Niklas Schnelle wrote:
On Wed, 2025-04-30 at 09:41 +0200, Jiri Slaby wrote:
On 29. 04. 25, 18:37, Greg Kroah-Hartman wrote:
6.14-stable review patch. If anyone has any objections, please let me know.
From: Niklas Schnelle schnelle@linux.ibm.com
[ Upstream commit aa9f168d55dc47c0de564f7dfe0e90467c9fee71 ]
...
+static void zpci_ism_bar_no_mmap(struct pci_dev *pdev) +{
- /*
* ISM's BAR is special. Drivers written for ISM know* how to handle this but others need to be aware of their* special nature e.g. to prevent attempts to mmap() it.*/- pdev->non_mappable_bars = 1;
I see: arch/s390/pci/pci_fixup.c: In function 'zpci_ism_bar_no_mmap': arch/s390/pci/pci_fixup.c:19:13: error: 'struct pci_dev' has no member named 'non_mappable_bars' 19 | pdev->non_mappable_bars = 1; | ^~
The above needs at least: commit 888bd8322dfc325dc5ad99184baba4e1fd91082d Author: Niklas Schnelle schnelle@linux.ibm.com Date: Wed Feb 26 13:07:46 2025 +0100
s390/pci: Introduce pdev->non_mappable_bars and replace VFIO_PCI_MMAPthanks,
Yes, as this didn't originally have a Cc stable / Fixes tag this prerequisite doesn't seem to have been pulled in correctly. Besides the cited commit 888bd8322dfc ("s390/pci: Introduce pdev->non_mappable_bars and replace VFIO_PCI_MMAP") this also needs commit 41a0926e82f4 ("s390/pci: Fix s390_mmio_read/write syscall page fault handling") for correct operation.
I'll just drop this from all queues for now and if it is something that really needs to be in the stable trees, I'll wait for someone to submit a working set of backported patches.
thanks,
greg k-h