Re: [PATCH] NFSD: Fix destination buffer size in nfsd4_ssc_setup_dul()

From: Chuck Lever chuck.lever@oracle.com

On Tue, 05 Aug 2025 19:53:02 +0200, Thorsten Blum wrote:

Commit 5304877936c0 ("NFSD: Fix strncpy() fortify warning") replaced strncpy(,, sizeof(..)) with strlcpy(,, sizeof(..) - 1), but strlcpy() already guaranteed NUL-termination of the destination buffer and subtracting one byte potentially truncated the source string.

The incorrect size was then carried over in commit 72f78ae00a8e ("NFSD: move from strlcpy with unused retval to strscpy") when switching from strlcpy() to strscpy().

[...]

Applied to nfsd-testing, thanks!

[1/1] NFSD: Fix destination buffer size in nfsd4_ssc_setup_dul() commit: 5486ae619bff16a8c885afab7f40b10c69030344

-- Chuck Lever