Re: [PATCH] iommu/omap: Fix error handling in omap_iommu_probe_device

omap_iommu_probe_device() calls of_find_device_by_node() which increments the reference count of the platform device, but fails to decrement the reference count in both success and error paths. This could lead to resource leakage and prevent proper device cleanup when the IOMMU is unbound or the device is removed.

1. See also once more: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Docu...

2. May the statement “ret = -EINVAL;” be moved behind an additional label?

3. Would it be helpful to append parentheses to the function name in the summary phrase?

Regards, Markus