Re: [PATCH 5.15.y 4/4] phy: qcom-qmp-combo: fix runtime suspend

Quoting Johan Hovold (2023-01-13 00:09:35)

On Thu, Jan 12, 2023 at 04:54:05PM -0800, Stephen Boyd wrote:

...

diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c index 9fda6d283f20..d928afe2ebba 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c @@ -4985,15 +4985,11 @@ static void qcom_qmp_phy_disable_autonomous_mode(struct qmp_phy *qphy) static int __maybe_unused qcom_qmp_phy_runtime_suspend(struct device *dev) { struct qcom_qmp *qmp = dev_get_drvdata(dev);

• struct qmp_phy *qphy = qmp->phys[0];
  

• struct qmp_phy *qphy = qmp->usb_phy;
  const struct qmp_phy_cfg *cfg = qphy->cfg;
  
  dev_vdbg(dev, "Suspending QMP phy, mode:%d\n", qphy->mode);
  

So this doesn't work currently either as the usb_phy pointer is not set for PCIe and UFS PHYs.

Cool, setting usb_phy for pcie and ufs fixes this.