Re: [PATCH v2] mm: page_alloc: move mlocked flag clearance into free_pages_prepare()

On Mon, 21 Oct 2024, Matthew Wilcox wrote:

On Mon, Oct 21, 2024 at 05:34:55PM +0000, Roman Gushchin wrote:

...

Fix it by moving the mlocked flag clearance down to free_page_prepare().

Urgh, I don't like this new reference to folio in free_pages_prepare(). It feels like a layering violation. I'll think about where else we could put this.

I'm glad to see that I guessed correctly when preparing my similar patch: I expected you to feel that way. The alternative seems to be to bring back PageMlocked etc, but I thought you'd find that more distasteful.

Hugh