Re: [PATCH] perf session: Fix undeclared 'oe'

On Wed, Apr 11, 2018 at 03:41:35PM -0300, Murilo Opsfelder Araujo wrote:

Using linux-3.18.y branch, perf build fails with the following:

$ make -s -j16 -C tools/perf V=1 WERROR=0 NO_LIBUNWIND=1 HAVE_CPLUS_DEMANGLE=1 NO_GTK2=1 NO_LIBNUMA=1 NO_STRLCPY=1 NO_BIONIC=1 prefix=/usr DESTDIR=/tmp/builddir/build all
[...]
util/session.c: In function ‘__perf_session__process_pipe_events’:
util/session.c:1093:36: error: ‘oe’ undeclared (first use in this function)
  ordered_events__set_copy_on_queue(oe, true);
                                    ^
util/session.c:1093:36: note: each undeclared identifier is reported only once for each function it appears in

This patch fixes it for linux-3.18.y branch.

Why is this failing now? Has it always been broken? Is there an upstream patch that fixed this instead?

Fixes: 95b33b99cdd6 ("perf inject: Copy events when reordering events in pipe mode")

Was this just a bad backport?

thanks,

greg k-h