From: aprilgrimoire aprilgrimoire@proton.me
[ Upstream commit 8822e8be86d40410ddd2ac8ff44f3050c9ecf9c6 ]
The firmware of Mechrevo Yilong15Pro emits a spurious keyboard interrupt on events including closing the lid. When a user closes the lid on an already suspended system this causes the system to wake up. Add Mechrevo Yilong15Pro Series (GM5HG7A) to the list of quirk spurious_8042 to work around this issue.
Link: https://lore.kernel.org/linux-pm/6ww4uu6Gl4F5n6VY5dl1ufASfKzs4DhMxAN8BuqUpCo... Signed-off-by: April Grimoire aprilgrimoire@proton.me Reviewed-by: Mario Limonciello (AMD) superm1@kernel.org Link: https://patch.msgid.link/IvSc_IN5Pa0wRXElTk_fEl-cTpMZxg6TCQk_7aRUkTd9vJUp_Ze... Reviewed-by: Ilpo Järvinen ilpo.jarvinen@linux.intel.com Signed-off-by: Ilpo Järvinen ilpo.jarvinen@linux.intel.com Signed-off-by: Sasha Levin sashal@kernel.org ---
LLM Generated explanations, may be completely bogus:
Based on my extensive analysis of the commit and comprehensive research of the kernel subsystem, stable backporting practices, and similar commits:
**Backport Status: YES**
## Detailed Justification:
### This commit is suitable for stable backporting because:
1. **Fixes a real user bug**: The commit fixes spurious system wakeups when closing the lid on an already suspended MECHREVO Yilong15Pro laptop - a frustrating issue that affects real users.
2. **Minimal and contained change**: The patch adds exactly 8 lines to a DMI quirk table - one of the safest types of kernel changes with virtually zero regression risk.
3. **Strong precedent for backporting**: My research found that similar spurious_8042 quirk additions have been regularly backported: - `0dd4a4cc9afdd`: TUXEDO IB Pro Gen10 (explicitly marked "Cc: stable@vger.kernel.org") - `0887817e49538`: MECHREVO Wujie 14XA (has Fixes: tag, auto-selected for stable) - Multiple other platform quirks routinely backported
4. **Meets stable kernel criteria**: Per Documentation/process/stable- kernel-rules.rst: - ✅ Fixes a real bug that bothers people - ✅ Falls under explicitly allowed "hardware quirks" category - ✅ "Just add a device ID" type change - ✅ Already merged in mainline with proper maintainer review
5. **Zero impact on other systems**: DMI quirks only affect systems with exact DMI string matches - no risk to other hardware.
6. **Well-understood mechanism**: The spurious_8042 quirk has been in the kernel since January 2023, is well-tested, and addresses a documented AMD platform firmware bug affecting multiple laptop models.
### Technical specifics from the code: ```c + { + .ident = "MECHREVO Yilong15Pro Series GM5HG7A", + .driver_data = &quirk_spurious_8042, + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "MECHREVO"), + DMI_MATCH(DMI_PRODUCT_NAME, "Yilong15Pro Series GM5HG7A"), + } + }, ```
This simply adds the laptop to the `fwbug_list[]` array in `drivers/platform/x86/amd/pmc/pmc-quirks.c`, applying the existing `quirk_spurious_8042` workaround that disables IRQ1 wakeup to prevent spurious keyboard interrupts during suspend.
The commit has been properly reviewed by both Mario Limonciello (AMD maintainer) and Ilpo Järvinen (platform/x86 maintainer), ensuring quality and correctness.
**Recommendation**: This commit should be marked with "Cc: stable@vger.kernel.org" for backporting to stable kernels where the spurious_8042 quirk mechanism exists (6.2+).
drivers/platform/x86/amd/pmc/pmc-quirks.c | 8 ++++++++ 1 file changed, 8 insertions(+)
diff --git a/drivers/platform/x86/amd/pmc/pmc-quirks.c b/drivers/platform/x86/amd/pmc/pmc-quirks.c index 18fb44139de25..4d0a38e06f083 100644 --- a/drivers/platform/x86/amd/pmc/pmc-quirks.c +++ b/drivers/platform/x86/amd/pmc/pmc-quirks.c @@ -239,6 +239,14 @@ static const struct dmi_system_id fwbug_list[] = { DMI_MATCH(DMI_BOARD_NAME, "WUJIE14-GX4HRXL"), } }, + { + .ident = "MECHREVO Yilong15Pro Series GM5HG7A", + .driver_data = &quirk_spurious_8042, + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "MECHREVO"), + DMI_MATCH(DMI_PRODUCT_NAME, "Yilong15Pro Series GM5HG7A"), + } + }, /* https://bugzilla.kernel.org/show_bug.cgi?id=220116 */ { .ident = "PCSpecialist Lafite Pro V 14M",