On 13. 02. 25, 14:38, Stuart Hayhurst wrote:
corsair_void_process_receiver can be called from an interrupt context, locking battery_mutex in it was causing a kernel panic. Fix it by moving the critical section into its own work, sharing this work with battery_add_work and battery_remove_work to remove the need for any locking
Closes: https://bugzilla.suse.com/show_bug.cgi?id=1236843 Fixes: 6ea2a6fd3872 ("HID: corsair-void: Add Corsair Void headset family driver") Cc: stable@vger.kernel.org Signed-off-by: Stuart Hayhurst stuart.a.hayhurst@gmail.com
v2 -> v3:
- Use an enum instead of a define for battery flag values
- Use an integer instead of BIT() for the bit index
- Drop unhelpful comments
- Simplify corsair_void_battery_work_handler logic
- Remove extra newline in commit message
v1 -> v2:
- Actually remove the mutex
drivers/hid/hid-corsair-void.c | 83 ++++++++++++++++++---------------- 1 file changed, 43 insertions(+), 40 deletions(-)
diff --git a/drivers/hid/hid-corsair-void.c b/drivers/hid/hid-corsair-void.c index 56e858066c3c..afbd67aa9719 100644 --- a/drivers/hid/hid-corsair-void.c +++ b/drivers/hid/hid-corsair-void.c @@ -71,11 +71,9 @@ #include <linux/bitfield.h> #include <linux/bitops.h> -#include <linux/cleanup.h> #include <linux/device.h> #include <linux/hid.h> #include <linux/module.h> -#include <linux/mutex.h> #include <linux/power_supply.h> #include <linux/usb.h> #include <linux/workqueue.h> @@ -120,6 +118,12 @@ enum { CORSAIR_VOID_BATTERY_CHARGING = 5, }; +enum {
- CORSAIR_VOID_ADD_BATTERY = 0,
- CORSAIR_VOID_REMOVE_BATTERY = 1,
- CORSAIR_VOID_UPDATE_BATTERY = 2,
BTW numbering these explicitly is superfluous.