Re: [PATCH net] wifi: brcmfmac: release 'root' node in all execution paths

Javier Carrasco javier.carrasco.cruz@gmail.com wrote:

The fixed patch introduced an additional condition to enter the scope where the 'root' device_node is released (!settings->board_type, currently 'err'), which avoid decrementing the refcount with a call to of_node_put() if that second condition is not satisfied.

Move the call to of_node_put() to the point where 'root' is no longer required to avoid leaking the resource if err is not zero.

Cc: stable@vger.kernel.org Fixes: 7682de8b3351 ("wifi: brcmfmac: of: Fetch Apple properties") Signed-off-by: Javier Carrasco javier.carrasco.cruz@gmail.com

Wireless patches go to wireless trees, not net. But no need to resend because of this. And I think wireless-next is approriate for this fix.