On Tue, Feb 19, 2019 at 5:57 PM Jeff Moyer jmoyer@redhat.com wrote:
Dan Williams dan.j.williams@intel.com writes:
Commit 11189c1089da "acpi/nfit: Fix command-supported detection" broke ND_CMD_CALL for bus-level commands. The "func = cmd" assumption is only valid for:
ND_CMD_ARS_CAP ND_CMD_ARS_START ND_CMD_ARS_STATUS ND_CMD_CLEAR_ERRORThe function number otherwise needs to be pulled from the command payload for:
NFIT_CMD_TRANSLATE_SPA NFIT_CMD_ARS_INJECT_SET NFIT_CMD_ARS_INJECT_CLEAR NFIT_CMD_ARS_INJECT_GETUpdate cmd_to_func() for the bus case and call it in the common path.
Fixes: 11189c1089da ("acpi/nfit: Fix command-supported detection") Cc: stable@vger.kernel.org Cc: Vishal Verma vishal.verma@intel.com Reported-by: Grzegorz Burzynski grzegorz.burzynski@intel.com Signed-off-by: Dan Williams dan.j.williams@intel.com
Tricky code path, eh?
ioctl path, number one source of bugs / thrash in this subsystem. 2nd place, ARS.
Tested-by: Jeff Moyer jmoyer@redhat.com
Thanks.