4 Jun
2023
4 Jun
'23
11:57 a.m.
On Sun, Jun 4, 2023 at 10:47 AM Greg KH gregkh@linuxfoundation.org wrote:
On Fri, Jun 02, 2023 at 11:26:21AM -0400, Hugo Villeneuve wrote:
...
+static u8 sc16is7xx_setup_mctrl_ports(struct device *dev)
This returns what, mctrl? If so, please document that, it doesn't look obvious.
Good suggestion. Because I also stumbled over the returned type.
And as the kernel test robot reported, you do nothing with the return value so why compute it?
It seems that the entire function and respective call has to be moved under #ifdef CONFIG_GPIOLIB.
And you have a real port here, no need to pass in a "raw" struct device, right?
--
With Best Regards,
Andy Shevchenko