Re: [PATCH] genirq/msi: Take the per-device MSI lock before validating the control structure

On Mon, Feb 20, 2023 at 07:01:01PM +0000, Marc Zyngier wrote:

Calling msi_ctrl_valid() ultimately results in calling msi_get_device_domain(), which requires holding the device MSI lock.

However, we take that lock right after having called msi_ctrl_valid(), which is just a tad too late. Taking the lock earlier solves the issue.

Fixes: 40742716f294 ("genirq/msi: Make msi_add_simple_msi_descs() device domain aware") Reported-by: "Russell King (Oracle)" linux@armlinux.org.uk

Tested-by: Russell King (Oracle) rmk+kernel@armlinux.org.uk

Thanks!