On Thu, 7 Dec 2023 10:45:48 +0900 Greg KH gregkh@linuxfoundation.org wrote:
On Thu, Nov 30, 2023 at 02:10:43PM -0500, Hugo Villeneuve wrote:
From: Hugo Villeneuve hvilleneuve@dimonoff.com
Change snprint format specifier from %d to %u since port_id is unsigned.
Fixes: 3837a0379533 ("serial: sc16is7xx: improve regmap debugfs by using one regmap per port") Cc: stable@vger.kernel.org # 6.1.x: 3837a03 serial: sc16is7xx: improve regmap debugfs by using one regmap per port Suggested-by: Andy Shevchenko andy.shevchenko@gmail.com Signed-off-by: Hugo Villeneuve hvilleneuve@dimonoff.com
I did not originally add a "Cc: stable" tag for commit 3837a0379533 ("serial: sc16is7xx: improve regmap debugfs by using one regmap per port") as it was intended only to improve debugging using debugfs. But since then, I have been able to confirm that it also fixes a long standing bug in our system where the Tx interrupt are no longer enabled at some point when transmitting large RS-485 paquets (> 64 bytes, which is the size of the FIFO). I have been investigating why, but so far I haven't found the exact cause, altough I suspect it has something to do with regmap caching. Therefore, I have added it as a prerequisite for this patch so that it is automatically added to the stable kernels.
As you are splitting fixes from non-fixes in this series, please resend this as 2 different series, one that I can apply now to my tty-linus branch to get merged for 6.7-final, and one that can go into tty-next for 6.8-rc1. Mixing them up here just ensures that they all would get applied to tty-next.
Ok, makes sense. Will do after I fix the 0-day issue.
Thank you, Hugo.